overlayfs: fs on './file0' does not support file handles, falling back to index=off.
======================================================
WARNING: possible circular locking dependency detected
4.14.299-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.2/11639 is trying to acquire lock:
 (&ovl_i_mutex_dir_key[depth]){++++}, at: [<ffffffff81892da9>] inode_lock_shared include/linux/fs.h:729 [inline]
 (&ovl_i_mutex_dir_key[depth]){++++}, at: [<ffffffff81892da9>] lookup_slow+0x129/0x400 fs/namei.c:1674

but task is already holding lock:
 (&oi->lock){+.+.}, at: [<ffffffff823180bf>] ovl_nlink_start+0x22f/0x460 fs/overlayfs/util.c:523

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&oi->lock){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
       ovl_copy_up_start+0x40/0xe0 fs/overlayfs/util.c:318
       ovl_copy_up_one+0x21f/0x910 fs/overlayfs/copy_up.c:631
       ovl_copy_up_flags+0xd5/0x120 fs/overlayfs/copy_up.c:686
       ovl_rename+0x164/0xe50 fs/overlayfs/dir.c:939
       vfs_rename+0x560/0x1820 fs/namei.c:4498
       SYSC_renameat2 fs/namei.c:4646 [inline]
       SyS_renameat2+0x95b/0xad0 fs/namei.c:4535
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3
audit: type=1804 audit(1669237993.876:241): pid=11655 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.5" name="/root/syzkaller-testdir1896740244/syzkaller.syukmS/59/bus" dev="sda1" ino=14176 res=1

-> #1 (sb_writers#3){.+.+}:
       percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline]
       percpu_down_read include/linux/percpu-rwsem.h:59 [inline]
       __sb_start_write+0x64/0x260 fs/super.c:1342
       sb_start_write include/linux/fs.h:1551 [inline]
       mnt_want_write+0x3a/0xb0 fs/namespace.c:386
       ovl_do_remove+0x67/0xb90 fs/overlayfs/dir.c:759
       vfs_rmdir.part.0+0x144/0x390 fs/namei.c:3910
       vfs_rmdir fs/namei.c:3895 [inline]
       do_rmdir+0x334/0x3c0 fs/namei.c:3970
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

-> #0 (&ovl_i_mutex_dir_key[depth]){++++}:
audit: type=1800 audit(1669237993.876:242): pid=11655 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.5" name="bus" dev="sda1" ino=14176 res=0
       lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
       down_read+0x36/0x80 kernel/locking/rwsem.c:24
       inode_lock_shared include/linux/fs.h:729 [inline]
       lookup_slow+0x129/0x400 fs/namei.c:1674
       lookup_one_len_unlocked+0x3a0/0x410 fs/namei.c:2595
       ovl_lower_positive+0x184/0x350 fs/overlayfs/namei.c:783
       ovl_rename+0x47c/0xe50 fs/overlayfs/dir.c:968
       vfs_rename+0x560/0x1820 fs/namei.c:4498
       SYSC_renameat2 fs/namei.c:4646 [inline]
       SyS_renameat2+0x95b/0xad0 fs/namei.c:4535
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

other info that might help us debug this:

Chain exists of:
  &ovl_i_mutex_dir_key[depth] --> sb_writers#3 --> &oi->lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->lock);
                               lock(sb_writers#3);
                               lock(&oi->lock);
  lock(&ovl_i_mutex_dir_key[depth]);

 *** DEADLOCK ***

8 locks held by syz-executor.2/11639:
 #0:  (sb_writers#13){.+.+}, at: [<ffffffff818e1bca>] sb_start_write include/linux/fs.h:1551 [inline]
 #0:  (sb_writers#13){.+.+}, at: [<ffffffff818e1bca>] mnt_want_write+0x3a/0xb0 fs/namespace.c:386
 #1:  (&type->s_vfs_rename_key#2){+.+.}, at: [<ffffffff818930d4>] lock_rename+0x54/0x280 fs/namei.c:2889
 #2:  (&ovl_i_mutex_dir_key[depth]#2/1){+.+.}, at: [<ffffffff81893120>] inode_lock_nested include/linux/fs.h:754 [inline]
 #2:  (&ovl_i_mutex_dir_key[depth]#2/1){+.+.}, at: [<ffffffff81893120>] lock_rename+0xa0/0x280 fs/namei.c:2893
 #3:  (&ovl_i_mutex_dir_key[depth]#2/2){+.+.}, at: [<ffffffff81893154>] inode_lock_nested include/linux/fs.h:754 [inline]
 #3:  (&ovl_i_mutex_dir_key[depth]#2/2){+.+.}, at: [<ffffffff81893154>] lock_rename+0xd4/0x280 fs/namei.c:2894
 #4:  (&ovl_i_mutex_key[depth]){+.+.}, at: [<ffffffff818cc8da>] inode_lock include/linux/fs.h:719 [inline]
 #4:  (&ovl_i_mutex_key[depth]){+.+.}, at: [<ffffffff818cc8da>] lock_two_nondirectories+0xca/0xf0 fs/inode.c:989
 #5:  (&ovl_i_mutex_key[depth]/4){+.+.}, at: [<ffffffff818cc8c2>] inode_lock_nested include/linux/fs.h:754 [inline]
 #5:  (&ovl_i_mutex_key[depth]/4){+.+.}, at: [<ffffffff818cc8c2>] lock_two_nondirectories+0xb2/0xf0 fs/inode.c:991
 #6:  (sb_writers#3){.+.+}, at: [<ffffffff818e1bca>] sb_start_write include/linux/fs.h:1551 [inline]
 #6:  (sb_writers#3){.+.+}, at: [<ffffffff818e1bca>] mnt_want_write+0x3a/0xb0 fs/namespace.c:386
 #7:  (&oi->lock){+.+.}, at: [<ffffffff823180bf>] ovl_nlink_start+0x22f/0x460 fs/overlayfs/util.c:523

stack backtrace:
CPU: 1 PID: 11639 Comm: syz-executor.2 Not tainted 4.14.299-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x1b2/0x281 lib/dump_stack.c:58
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
 check_prev_add kernel/locking/lockdep.c:1905 [inline]
 check_prevs_add kernel/locking/lockdep.c:2022 [inline]
 validate_chain kernel/locking/lockdep.c:2464 [inline]
 __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
 down_read+0x36/0x80 kernel/locking/rwsem.c:24
 inode_lock_shared include/linux/fs.h:729 [inline]
 lookup_slow+0x129/0x400 fs/namei.c:1674
 lookup_one_len_unlocked+0x3a0/0x410 fs/namei.c:2595
 ovl_lower_positive+0x184/0x350 fs/overlayfs/namei.c:783
 ovl_rename+0x47c/0xe50 fs/overlayfs/dir.c:968
 vfs_rename+0x560/0x1820 fs/namei.c:4498
 SYSC_renameat2 fs/namei.c:4646 [inline]
 SyS_renameat2+0x95b/0xad0 fs/namei.c:4535
 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
 entry_SYSCALL_64_after_hwframe+0x5e/0xd3
print_req_error: I/O error, dev loop3, sector 0
Buffer I/O error on dev loop3, logical block 0, async page read
print_req_error: I/O error, dev loop3, sector 4
Buffer I/O error on dev loop3, logical block 2, async page read
print_req_error: I/O error, dev loop3, sector 6
Buffer I/O error on dev loop3, logical block 3, async page read
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
audit: type=1800 audit(1669237994.606:243): pid=11680 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.3" name="bus" dev="sda1" ino=14241 res=0
audit: type=1804 audit(1669237994.626:244): pid=11680 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.3" name="/root/syzkaller-testdir2744373134/syzkaller.Kk3kmv/59/bus" dev="sda1" ino=14241 res=1
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
audit: type=1800 audit(1669237994.626:245): pid=11680 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.3" name="bus" dev="sda1" ino=14241 res=0
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
audit: type=1804 audit(1669237994.776:246): pid=11693 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.5" name="/root/syzkaller-testdir1896740244/syzkaller.syukmS/60/bus" dev="sda1" ino=14225 res=1
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
befs: (nullb0): No write support. Marking filesystem read-only
befs: (nullb0): invalid magic header
syz-executor.2 (11744) used greatest stack depth: 25160 bytes left
kauditd_printk_skb: 12 callbacks suppressed
audit: type=1800 audit(1669237996.316:259): pid=11767 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.1" name="bus" dev="sda1" ino=14182 res=0
audit: type=1800 audit(1669237996.336:260): pid=11772 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.4" name="bus" dev="sda1" ino=14246 res=0
audit: type=1800 audit(1669237996.366:261): pid=11771 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.2" name="bus" dev="sda1" ino=14267 res=0
audit: type=1804 audit(1669237996.376:262): pid=11771 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.2" name="/root/syzkaller-testdir1649317056/syzkaller.jIAoRf/59/bus" dev="sda1" ino=14267 res=1
audit: type=1800 audit(1669237996.656:263): pid=11800 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.1" name="bus" dev="sda1" ino=14205 res=0
EXT4-fs (loop3): couldn't mount RDWR because of unsupported optional features (8000)
audit: type=1800 audit(1669237997.286:264): pid=11824 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.1" name="bus" dev="loop1" ino=18 res=0
NILFS (loop1): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
audit: type=1804 audit(1669237997.316:265): pid=11834 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.4" name="/root/syzkaller-testdir1298724081/syzkaller.2do1e6/79/bus" dev="sda1" ino=14289 res=1
audit: type=1800 audit(1669237997.446:266): pid=11844 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.3" name="bus" dev="sda1" ino=14291 res=0
audit: type=1800 audit(1669237997.476:267): pid=11837 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.2" name="bus" dev="sda1" ino=14292 res=0
NILFS (loop1): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
audit: type=1804 audit(1669237997.486:268): pid=11837 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.2" name="/root/syzkaller-testdir1649317056/syzkaller.jIAoRf/60/bus" dev="sda1" ino=14292 res=1
Bluetooth: hci0 command 0x0409 tx timeout
Bluetooth: hci0 command 0x041b tx timeout