====================================================== WARNING: possible circular locking dependency detected 6.13.0-rc3-next-20241220-syzkaller #0 Not tainted ------------------------------------------------------ syz.6.367/7912 is trying to acquire lock: ffff88805641d1c8 (&ni->ni_lock#2/5){+.+.}-{4:4}, at: ni_lock fs/ntfs3/ntfs_fs.h:1110 [inline] ffff88805641d1c8 (&ni->ni_lock#2/5){+.+.}-{4:4}, at: ntfs_fallocate+0x5c7/0x1270 fs/ntfs3/file.c:611 but task is already holding lock: ffff88805641d600 (mapping.invalidate_lock#11){++++}-{4:4}, at: filemap_invalidate_lock include/linux/fs.h:908 [inline] ffff88805641d600 (mapping.invalidate_lock#11){++++}-{4:4}, at: ntfs_fallocate+0x3c4/0x1270 fs/ntfs3/file.c:596 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (mapping.invalidate_lock#11){++++}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524 filemap_invalidate_lock_shared include/linux/fs.h:918 [inline] filemap_fault+0x7f8/0x16c0 mm/filemap.c:3368 __do_fault+0x135/0x390 mm/memory.c:4978 do_read_fault mm/memory.c:5393 [inline] do_fault mm/memory.c:5527 [inline] do_pte_missing mm/memory.c:4048 [inline] handle_pte_fault+0x39eb/0x5ee0 mm/memory.c:5890 __handle_mm_fault mm/memory.c:6033 [inline] handle_mm_fault+0x11f5/0x1d50 mm/memory.c:6202 do_user_addr_fault arch/x86/mm/fault.c:1389 [inline] handle_page_fault arch/x86/mm/fault.c:1481 [inline] exc_page_fault+0x2b9/0x8b0 arch/x86/mm/fault.c:1539 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623 strncpy_from_user+0xc8/0x270 lib/strncpy_from_user.c:130 getname_flags+0xf1/0x540 fs/namei.c:150 getname fs/namei.c:223 [inline] __do_sys_rename fs/namei.c:5272 [inline] __se_sys_rename fs/namei.c:5269 [inline] __x64_sys_rename+0x6a/0x90 fs/namei.c:5269 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&mm->mmap_lock){++++}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __might_fault+0xc6/0x120 mm/memory.c:6841 _inline_copy_to_user include/linux/uaccess.h:192 [inline] _copy_to_user+0x2c/0xb0 lib/usercopy.c:26 copy_to_user include/linux/uaccess.h:225 [inline] fiemap_fill_next_extent+0x235/0x410 fs/ioctl.c:145 ni_fiemap+0xfca/0x1220 fs/ntfs3/frecord.c:1948 ntfs_fiemap+0x132/0x180 fs/ntfs3/file.c:1360 ioctl_fiemap fs/ioctl.c:220 [inline] do_vfs_ioctl+0x1c01/0x2e40 fs/ioctl.c:840 __do_sys_ioctl fs/ioctl.c:904 [inline] __se_sys_ioctl+0x80/0x170 fs/ioctl.c:892 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ni->ni_lock#2/5){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735 ni_lock fs/ntfs3/ntfs_fs.h:1110 [inline] ntfs_fallocate+0x5c7/0x1270 fs/ntfs3/file.c:611 vfs_fallocate+0x623/0x7a0 fs/open.c:338 ksys_fallocate fs/open.c:362 [inline] __do_sys_fallocate fs/open.c:367 [inline] __se_sys_fallocate fs/open.c:365 [inline] __x64_sys_fallocate+0xbc/0x110 fs/open.c:365 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ni->ni_lock#2/5 --> &mm->mmap_lock --> mapping.invalidate_lock#11 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(mapping.invalidate_lock#11); lock(&mm->mmap_lock); lock(mapping.invalidate_lock#11); lock(&ni->ni_lock#2/5); *** DEADLOCK *** 3 locks held by syz.6.367/7912: #0: ffff88805e54a420 (sb_writers#22){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:3012 [inline] #0: ffff88805e54a420 (sb_writers#22){.+.+}-{0:0}, at: vfs_fallocate+0x59d/0x7a0 fs/open.c:337 #1: ffff88805641d460 (&sb->s_type->i_mutex_key#30){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:863 [inline] #1: ffff88805641d460 (&sb->s_type->i_mutex_key#30){+.+.}-{4:4}, at: ntfs_fallocate+0x2dd/0x1270 fs/ntfs3/file.c:582 #2: ffff88805641d600 (mapping.invalidate_lock#11){++++}-{4:4}, at: filemap_invalidate_lock include/linux/fs.h:908 [inline] #2: ffff88805641d600 (mapping.invalidate_lock#11){++++}-{4:4}, at: ntfs_fallocate+0x3c4/0x1270 fs/ntfs3/file.c:596 stack backtrace: CPU: 1 UID: 0 PID: 7912 Comm: syz.6.367 Not tainted 6.13.0-rc3-next-20241220-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735 ni_lock fs/ntfs3/ntfs_fs.h:1110 [inline] ntfs_fallocate+0x5c7/0x1270 fs/ntfs3/file.c:611 vfs_fallocate+0x623/0x7a0 fs/open.c:338 ksys_fallocate fs/open.c:362 [inline] __do_sys_fallocate fs/open.c:367 [inline] __se_sys_fallocate fs/open.c:365 [inline] __x64_sys_fallocate+0xbc/0x110 fs/open.c:365 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f7997b85d29 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f7998941038 EFLAGS: 00000246 ORIG_RAX: 000000000000011d RAX: ffffffffffffffda RBX: 00007f7997d75fa0 RCX: 00007f7997b85d29 RDX: 0000000000001000 RSI: 0000000000000003 RDI: 0000000000000006 RBP: 00007f7997c01b08 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000010003 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f7997d75fa0 R15: 00007fffa04bb378