====================================================== WARNING: possible circular locking dependency detected 6.1.128-syzkaller #0 Not tainted ------------------------------------------------------ syz.5.847/7913 is trying to acquire lock: ffff0000cfe630f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_free+0xcc/0x4b0 fs/hfsplus/bitmap.c:182 but task is already holding lock: ffff0000d875cb48 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x24c/0xa18 fs/hfsplus/extents.c:577 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 hfsplus_get_block+0x2c4/0x1168 fs/hfsplus/extents.c:260 block_read_full_folio+0x2f4/0x98c fs/buffer.c:2271 hfsplus_read_folio+0x28/0x38 fs/hfsplus/inode.c:28 filemap_read_folio+0x14c/0x39c mm/filemap.c:2489 do_read_cache_folio+0x24c/0x544 mm/filemap.c:3626 do_read_cache_page mm/filemap.c:3668 [inline] read_cache_page+0x6c/0x180 mm/filemap.c:3677 read_mapping_page include/linux/pagemap.h:791 [inline] hfsplus_block_allocate+0xe0/0x818 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0x770/0x14cc fs/hfsplus/extents.c:469 hfsplus_get_block+0x398/0x1168 fs/hfsplus/extents.c:245 get_more_blocks fs/direct-io.c:665 [inline] do_direct_IO fs/direct-io.c:953 [inline] __blockdev_direct_IO+0x14cc/0x3ef4 fs/direct-io.c:1266 blockdev_direct_IO include/linux/fs.h:3342 [inline] hfsplus_direct_IO+0xf4/0x1e0 fs/hfsplus/inode.c:135 generic_file_direct_write+0x234/0x538 mm/filemap.c:3769 __generic_file_write_iter+0x1bc/0x388 mm/filemap.c:3929 generic_file_write_iter+0xb8/0x2b4 mm/filemap.c:4005 do_iter_write+0x534/0x964 fs/read_write.c:861 vfs_writev fs/read_write.c:934 [inline] do_pwritev+0x1ec/0x334 fs/read_write.c:1031 __do_sys_pwritev2 fs/read_write.c:1090 [inline] __se_sys_pwritev2 fs/read_write.c:1081 [inline] __arm64_sys_pwritev2+0xd4/0x108 fs/read_write.c:1081 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 hfsplus_block_free+0xcc/0x4b0 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x3a4/0x8d4 fs/hfsplus/extents.c:374 hfsplus_file_truncate+0x674/0xa18 fs/hfsplus/extents.c:592 hfsplus_setattr+0x18c/0x25c fs/hfsplus/inode.c:269 notify_change+0xb58/0xe1c fs/attr.c:499 do_truncate+0x1c0/0x28c fs/open.c:65 vfs_truncate+0x2c4/0x36c fs/open.c:111 do_sys_truncate+0xec/0x1b4 fs/open.c:134 __do_sys_truncate fs/open.c:146 [inline] __se_sys_truncate fs/open.c:144 [inline] __arm64_sys_truncate+0x5c/0x70 fs/open.c:144 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 3 locks held by syz.5.847/7913: #0: ffff0000d2388460 (sb_writers#22){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:393 #1: ffff0000d875cd40 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff0000d875cd40 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: do_truncate+0x1ac/0x28c fs/open.c:63 #2: ffff0000d875cb48 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x24c/0xa18 fs/hfsplus/extents.c:577 stack backtrace: CPU: 0 PID: 7913 Comm: syz.5.847 Not tainted 6.1.128-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 hfsplus_block_free+0xcc/0x4b0 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x3a4/0x8d4 fs/hfsplus/extents.c:374 hfsplus_file_truncate+0x674/0xa18 fs/hfsplus/extents.c:592 hfsplus_setattr+0x18c/0x25c fs/hfsplus/inode.c:269 notify_change+0xb58/0xe1c fs/attr.c:499 do_truncate+0x1c0/0x28c fs/open.c:65 vfs_truncate+0x2c4/0x36c fs/open.c:111 do_sys_truncate+0xec/0x1b4 fs/open.c:134 __do_sys_truncate fs/open.c:146 [inline] __se_sys_truncate fs/open.c:144 [inline] __arm64_sys_truncate+0x5c/0x70 fs/open.c:144 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 hfsplus: unable to mark blocks free: error -5 hfsplus: can't free extent