====================================================== WARNING: possible circular locking dependency detected 6.1.119-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor/4250 is trying to acquire lock: ffff88805b4de6d8 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x379/0x1cb0 fs/ext4/inode.c:603 but task is already holding lock: ffff888054554208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:357 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:335 dquot_acquire+0x188/0x680 fs/quota/dquot.c:463 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6797 dqget+0x762/0xe90 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515 ext4_create+0xb1/0x550 fs/ext4/namei.c:2876 lookup_open fs/namei.c:3482 [inline] open_last_lookups fs/namei.c:3550 [inline] path_openat+0x12f1/0x2e60 fs/namei.c:3780 do_filp_open+0x230/0x480 fs/namei.c:3810 do_sys_openat2+0x13b/0x4f0 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_open fs/open.c:1342 [inline] __se_sys_open fs/open.c:1338 [inline] __x64_sys_open+0x221/0x270 fs/open.c:1338 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #1 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6777 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_alloc_space+0xb68/0x10e0 fs/quota/dquot.c:1750 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0x1302/0x4b80 fs/ext4/mballoc.c:5727 ext4_ext_map_blocks+0x1c1c/0x7ab0 fs/ext4/extents.c:4339 ext4_map_blocks+0xa2b/0x1cb0 fs/ext4/inode.c:678 ext4_alloc_file_blocks+0x3db/0xce0 fs/ext4/extents.c:4523 ext4_fallocate+0xd2b/0x2190 fs/ext4/extents.c:4810 vfs_fallocate+0x547/0x6b0 fs/open.c:323 ksys_fallocate fs/open.c:346 [inline] __do_sys_fallocate fs/open.c:354 [inline] __se_sys_fallocate fs/open.c:352 [inline] __x64_sys_fallocate+0xb9/0x100 fs/open.c:352 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x379/0x1cb0 fs/ext4/inode.c:603 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:889 ext4_bread+0x2a/0x170 fs/ext4/inode.c:945 ext4_quota_write+0x21e/0x570 fs/ext4/super.c:7171 write_blk fs/quota/quota_tree.c:70 [inline] get_free_dqblk+0x340/0x6c0 fs/quota/quota_tree.c:136 do_insert_tree+0x298/0x1440 fs/quota/quota_tree.c:347 do_insert_tree+0xb94/0x1440 fs/quota/quota_tree.c:402 dq_insert_tree fs/quota/quota_tree.c:432 [inline] qtree_write_dquot+0x483/0x5a0 fs/quota/quota_tree.c:451 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:361 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6797 dqget+0x762/0xe90 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515 ext4_unlink+0x14b/0x670 fs/ext4/namei.c:3363 vfs_unlink+0x359/0x5f0 fs/namei.c:4322 do_unlinkat+0x4a5/0x820 fs/namei.c:4390 __do_sys_unlink fs/namei.c:4438 [inline] __se_sys_unlink fs/namei.c:4436 [inline] __x64_sys_unlink+0x45/0x50 fs/namei.c:4436 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 5 locks held by syz-executor/4250: #0: ffff888054554460 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393 #1: ffff88805b4da218 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] #1: ffff88805b4da218 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: do_unlinkat+0x266/0x820 fs/namei.c:4373 #2: ffff888074231810 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #2: ffff888074231810 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: vfs_unlink+0xe0/0x5f0 fs/namei.c:4311 #3: ffff88805b75eb28 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x64/0x680 fs/quota/dquot.c:460 #4: ffff888054554208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:357 stack backtrace: CPU: 1 PID: 4250 Comm: syz-executor Not tainted 6.1.119-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x379/0x1cb0 fs/ext4/inode.c:603 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:889 ext4_bread+0x2a/0x170 fs/ext4/inode.c:945 ext4_quota_write+0x21e/0x570 fs/ext4/super.c:7171 write_blk fs/quota/quota_tree.c:70 [inline] get_free_dqblk+0x340/0x6c0 fs/quota/quota_tree.c:136 do_insert_tree+0x298/0x1440 fs/quota/quota_tree.c:347 do_insert_tree+0xb94/0x1440 fs/quota/quota_tree.c:402 dq_insert_tree fs/quota/quota_tree.c:432 [inline] qtree_write_dquot+0x483/0x5a0 fs/quota/quota_tree.c:451 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:361 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6797 dqget+0x762/0xe90 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515 ext4_unlink+0x14b/0x670 fs/ext4/namei.c:3363 vfs_unlink+0x359/0x5f0 fs/namei.c:4322 do_unlinkat+0x4a5/0x820 fs/namei.c:4390 __do_sys_unlink fs/namei.c:4438 [inline] __se_sys_unlink fs/namei.c:4436 [inline] __x64_sys_unlink+0x45/0x50 fs/namei.c:4436 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7f68ab57ddc7 Code: 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 57 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffd30293bf8 EFLAGS: 00000206 ORIG_RAX: 0000000000000057 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f68ab57ddc7 RDX: 00007ffd30293c20 RSI: 00007ffd30293cb0 RDI: 00007ffd30293cb0 RBP: 00007ffd30293cb0 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000100 R11: 0000000000000206 R12: 00007ffd30294da0 R13: 00007f68ab5f15fc R14: 0000000000037b32 R15: 00007ffd30296f50 EXT4-fs (loop0): unmounting filesystem.