hfs: request for non-existent node 16777216 in B*Tree hfs: request for non-existent node 16777216 in B*Tree ====================================================== WARNING: possible circular locking dependency detected 5.15.160-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.1/10742 is trying to acquire lock: ffff8880153b60b0 (&tree->tree_lock#2/1){+.+.}-{3:3}, at: hfs_find_init+0x16a/0x1e0 but task is already holding lock: ffff88807eb7a178 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xfb/0x1440 fs/hfs/extent.c:397 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfs_extend_file+0xfb/0x1440 fs/hfs/extent.c:397 hfs_bmap_reserve+0xd5/0x3f0 fs/hfs/btree.c:231 __hfs_ext_write_extent+0x22e/0x4f0 fs/hfs/extent.c:121 __hfs_ext_cache_extent+0x6a/0x990 fs/hfs/extent.c:174 hfs_ext_read_extent fs/hfs/extent.c:202 [inline] hfs_extend_file+0x340/0x1440 fs/hfs/extent.c:401 hfs_get_block+0x3e0/0xb60 fs/hfs/extent.c:353 __block_write_begin_int+0x60b/0x1650 fs/buffer.c:2012 __block_write_begin fs/buffer.c:2062 [inline] block_write_begin fs/buffer.c:2122 [inline] cont_write_begin+0x5d6/0x840 fs/buffer.c:2471 hfs_write_begin+0x92/0xd0 fs/hfs/inode.c:59 generic_perform_write+0x2bf/0x5b0 mm/filemap.c:3785 __generic_file_write_iter+0x243/0x4f0 mm/filemap.c:3912 generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3944 call_write_iter include/linux/fs.h:2172 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0xacf/0xe50 fs/read_write.c:594 ksys_write+0x1a2/0x2c0 fs/read_write.c:647 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&tree->tree_lock#2/1){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfs_find_init+0x16a/0x1e0 hfs_ext_read_extent fs/hfs/extent.c:200 [inline] hfs_extend_file+0x317/0x1440 fs/hfs/extent.c:401 hfs_bmap_reserve+0xd5/0x3f0 fs/hfs/btree.c:231 hfs_cat_move+0x1b7/0x1050 fs/hfs/catalog.c:310 hfs_rename+0x242/0x320 fs/hfs/dir.c:299 vfs_rename+0xd32/0x10f0 fs/namei.c:4832 do_renameat2+0xe0f/0x1700 fs/namei.c:4985 __do_sys_renameat2 fs/namei.c:5018 [inline] __se_sys_renameat2 fs/namei.c:5015 [inline] __x64_sys_renameat2+0xce/0xe0 fs/namei.c:5015 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFS_I(tree->inode)->extents_lock); lock(&tree->tree_lock#2/1); lock(&HFS_I(tree->inode)->extents_lock); lock(&tree->tree_lock#2/1); *** DEADLOCK *** 8 locks held by syz-executor.1/10742: #0: ffff8880609ac460 (sb_writers#20){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377 #1: ffff8880609ac748 (&type->s_vfs_rename_key#6){+.+.}-{3:3}, at: lock_rename fs/namei.c:3016 [inline] #1: ffff8880609ac748 (&type->s_vfs_rename_key#6){+.+.}-{3:3}, at: do_renameat2+0x5b7/0x1700 fs/namei.c:4924 #2: ffff88807eb7b6a8 (&type->i_mutex_dir_key#12/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3017 [inline] #2: ffff88807eb7b6a8 (&type->i_mutex_dir_key#12/1){+.+.}-{3:3}, at: do_renameat2+0x644/0x1700 fs/namei.c:4924 #3: ffff88807eb7b028 (&type->i_mutex_dir_key#12/5){+.+.}-{3:3}, at: do_renameat2+0x67e/0x1700 fs/namei.c:4924 #4: ffff88807eb782a8 (&sb->s_type->i_mutex_key#27){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #4: ffff88807eb782a8 (&sb->s_type->i_mutex_key#27){+.+.}-{3:3}, at: lock_two_nondirectories+0xde/0x130 fs/inode.c:1083 #5: ffff88807eb78928 (&sb->s_type->i_mutex_key#27/4){+.+.}-{3:3}, at: vfs_rename+0x7e4/0x10f0 fs/namei.c:4803 #6: ffff8880153b80b0 (&tree->tree_lock#2){+.+.}-{3:3}, at: hfs_find_init+0x16a/0x1e0 #7: ffff88807eb7a178 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xfb/0x1440 fs/hfs/extent.c:397 stack backtrace: CPU: 0 PID: 10742 Comm: syz-executor.1 Not tainted 5.15.160-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfs_find_init+0x16a/0x1e0 hfs_ext_read_extent fs/hfs/extent.c:200 [inline] hfs_extend_file+0x317/0x1440 fs/hfs/extent.c:401 hfs_bmap_reserve+0xd5/0x3f0 fs/hfs/btree.c:231 hfs_cat_move+0x1b7/0x1050 fs/hfs/catalog.c:310 hfs_rename+0x242/0x320 fs/hfs/dir.c:299 vfs_rename+0xd32/0x10f0 fs/namei.c:4832 do_renameat2+0xe0f/0x1700 fs/namei.c:4985 __do_sys_renameat2 fs/namei.c:5018 [inline] __se_sys_renameat2 fs/namei.c:5015 [inline] __x64_sys_renameat2+0xce/0xe0 fs/namei.c:5015 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7f95e8b8ff69 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f95e77090c8 EFLAGS: 00000246 ORIG_RAX: 000000000000013c RAX: ffffffffffffffda RBX: 00007f95e8cc6f80 RCX: 00007f95e8b8ff69 RDX: 0000000000000004 RSI: 0000000020000080 RDI: ffffffffffffff9c RBP: 00007f95e8bed6fe R08: 0000000000000000 R09: 0000000000000000 R10: 0000000020000980 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f95e8cc6f80 R15: 00007ffd4da9df28 hfs: request for non-existent node 16777216 in B*Tree hfs: request for non-existent node 16777216 in B*Tree