ocfs2: Mounting device (7,3) on (node local, slot 0) with ordered data mode. ====================================================== WARNING: possible circular locking dependency detected 6.1.124-syzkaller #0 Not tainted ------------------------------------------------------ syz.3.801/9000 is trying to acquire lock: ffff0000f442c2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] ffff0000f442c2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 but task is already holding lock: ffff0001002360a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x270/0xb1c fs/ocfs2/quota_global.c:806 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 dquot_commit+0x54/0x240 fs/quota/dquot.c:507 ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6770 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6830 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412 __dquot_alloc_space+0xb28/0xf50 fs/quota/dquot.c:1752 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0xe8c/0x4680 fs/ext4/mballoc.c:5727 ext4_ext_map_blocks+0x15a8/0x6638 fs/ext4/extents.c:4339 ext4_map_blocks+0x810/0x1810 fs/ext4/inode.c:678 _ext4_get_block+0x1c0/0x5a0 fs/ext4/inode.c:821 ext4_get_block+0x4c/0x60 fs/ext4/inode.c:838 ext4_block_write_begin+0x500/0x1130 fs/ext4/inode.c:1123 ext4_write_begin+0x620/0x138c ext4_da_write_begin+0x38c/0xa68 fs/ext4/inode.c:2999 generic_perform_write+0x278/0x55c mm/filemap.c:3845 ext4_buffered_write_iter+0x2e0/0x538 fs/ext4/file.c:285 ext4_file_write_iter+0x18c/0x1654 do_iter_write+0x534/0x964 fs/read_write.c:861 vfs_writev fs/read_write.c:934 [inline] do_pwritev+0x1ec/0x334 fs/read_write.c:1031 __do_sys_pwritev2 fs/read_write.c:1090 [inline] __se_sys_pwritev2 fs/read_write.c:1081 [inline] __arm64_sys_pwritev2+0xd4/0x108 fs/read_write.c:1081 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #5 (&ei->i_data_sem){++++}-{3:3}: down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 ext4_map_blocks+0x77c/0x1810 fs/ext4/inode.c:671 mpage_map_one_extent fs/ext4/inode.c:2433 [inline] mpage_map_and_submit_extent fs/ext4/inode.c:2486 [inline] ext4_writepages+0x1050/0x32b4 fs/ext4/inode.c:2854 do_writepages+0x2e8/0x56c mm/page-writeback.c:2491 __writeback_single_inode+0x16c/0x1770 fs/fs-writeback.c:1612 writeback_sb_inodes+0x978/0x1718 fs/fs-writeback.c:1903 __writeback_inodes_wb+0x110/0x39c fs/fs-writeback.c:1974 wb_writeback+0x428/0x1130 fs/fs-writeback.c:2079 wb_check_background_flush fs/fs-writeback.c:2145 [inline] wb_do_writeback fs/fs-writeback.c:2233 [inline] wb_workfn+0xc98/0x1034 fs/fs-writeback.c:2260 process_one_work+0x7ac/0x1404 kernel/workqueue.c:2292 worker_thread+0x8e4/0xfec kernel/workqueue.c:2439 kthread+0x250/0x2d8 kernel/kthread.c:376 ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:864 -> #4 (jbd2_handle){++++}-{0:0}: start_this_handle+0x1140/0x13ac fs/jbd2/transaction.c:463 jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:520 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559 ocfs2_start_trans+0x3e8/0x73c fs/ocfs2/journal.c:354 ocfs2_modify_bh+0xe4/0x484 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x1220/0x15bc fs/ocfs2/quota_local.c:768 dquot_load_quota_sb+0x6f0/0xb1c fs/quota/dquot.c:2470 dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2507 ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:926 ocfs2_fill_super+0x3aa4/0x48c4 fs/ocfs2/super.c:1139 mount_bdev+0x274/0x370 fs/super.c:1443 ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1186 legacy_get_tree+0xd4/0x16c fs/fs_context.c:632 vfs_get_tree+0x90/0x274 fs/super.c:1573 do_new_mount+0x278/0x8fc fs/namespace.c:3056 path_mount+0x590/0xe5c fs/namespace.c:3386 do_mount fs/namespace.c:3399 [inline] __do_sys_mount fs/namespace.c:3607 [inline] __se_sys_mount fs/namespace.c:3584 [inline] __arm64_sys_mount+0x45c/0x594 fs/namespace.c:3584 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #3 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0x64/0x308 kernel/locking/rwsem.c:1520 ocfs2_start_trans+0x3dc/0x73c fs/ocfs2/journal.c:352 ocfs2_modify_bh+0xe4/0x484 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x1220/0x15bc fs/ocfs2/quota_local.c:768 dquot_load_quota_sb+0x6f0/0xb1c fs/quota/dquot.c:2470 dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2507 ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:926 ocfs2_fill_super+0x3aa4/0x48c4 fs/ocfs2/super.c:1139 mount_bdev+0x274/0x370 fs/super.c:1443 ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1186 legacy_get_tree+0xd4/0x16c fs/fs_context.c:632 vfs_get_tree+0x90/0x274 fs/super.c:1573 do_new_mount+0x278/0x8fc fs/namespace.c:3056 path_mount+0x590/0xe5c fs/namespace.c:3386 do_mount fs/namespace.c:3399 [inline] __do_sys_mount fs/namespace.c:3607 [inline] __se_sys_mount fs/namespace.c:3584 [inline] __arm64_sys_mount+0x45c/0x594 fs/namespace.c:3584 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #2 (sb_internal#4){.+.+}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1891 [inline] sb_start_intwrite include/linux/fs.h:2013 [inline] ocfs2_start_trans+0x260/0x73c fs/ocfs2/journal.c:350 ocfs2_write_info+0x114/0x354 fs/ocfs2/quota_global.c:977 dquot_set_dqinfo+0x398/0x5f4 fs/quota/dquot.c:2911 quota_setinfo+0x3b0/0x4fc fs/quota/quota.c:174 do_quotactl+0x4c0/0x698 fs/quota/quota.c:796 __do_sys_quotactl fs/quota/quota.c:960 [inline] __se_sys_quotactl fs/quota/quota.c:916 [inline] __arm64_sys_quotactl+0x2d8/0x7a0 fs/quota/quota.c:916 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #1 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 ocfs2_write_info+0xdc/0x354 fs/ocfs2/quota_global.c:974 dquot_set_dqinfo+0x398/0x5f4 fs/quota/dquot.c:2911 quota_setinfo+0x3b0/0x4fc fs/quota/quota.c:174 do_quotactl+0x4c0/0x698 fs/quota/quota.c:796 __do_sys_quotactl fs/quota/quota.c:960 [inline] __se_sys_quotactl fs/quota/quota.c:916 [inline] __arm64_sys_quotactl+0x2d8/0x7a0 fs/quota/quota.c:916 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:811 dqget+0x660/0xcec fs/quota/dquot.c:988 dquot_set_dqblk+0x40/0xea8 fs/quota/dquot.c:2833 quota_setquota+0x5bc/0x6f0 fs/quota/quota.c:310 do_quotactl+0x508/0x698 fs/quota/quota.c:802 __do_sys_quotactl fs/quota/quota.c:960 [inline] __se_sys_quotactl fs/quota/quota.c:916 [inline] __arm64_sys_quotactl+0x2d8/0x7a0 fs/quota/quota.c:916 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2 --> &ei->i_data_sem --> &dquot->dq_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&dquot->dq_lock); lock(&ei->i_data_sem); lock(&dquot->dq_lock); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2); *** DEADLOCK *** 2 locks held by syz.3.801/9000: #0: ffff0000d883e0e0 (&type->s_umount_key#86){++++}-{3:3}, at: user_get_super+0x11c/0x240 fs/super.c:889 #1: ffff0001002360a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x270/0xb1c fs/ocfs2/quota_global.c:806 stack backtrace: CPU: 0 PID: 9000 Comm: syz.3.801 Not tainted 6.1.124-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x5c lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 down_write+0x5c/0x88 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:811 dqget+0x660/0xcec fs/quota/dquot.c:988 dquot_set_dqblk+0x40/0xea8 fs/quota/dquot.c:2833 quota_setquota+0x5bc/0x6f0 fs/quota/quota.c:310 do_quotactl+0x508/0x698 fs/quota/quota.c:802 __do_sys_quotactl fs/quota/quota.c:960 [inline] __se_sys_quotactl fs/quota/quota.c:916 [inline] __arm64_sys_quotactl+0x2d8/0x7a0 fs/quota/quota.c:916 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585