======================================================
WARNING: possible circular locking dependency detected
4.19.211-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.3/10323 is trying to acquire lock:
0000000058a1c3d8 ((wq_completion)"dio/%s"sb->s_id){+.+.}, at: flush_workqueue+0xe8/0x13e0 kernel/workqueue.c:2658

but task is already holding lock:
00000000cdeebc7c (&sb->s_type->i_mutex_key#23){+.+.}, at: inode_lock include/linux/fs.h:748 [inline]
00000000cdeebc7c (&sb->s_type->i_mutex_key#23){+.+.}, at: generic_file_write_iter+0x99/0x730 mm/filemap.c:3320

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&sb->s_type->i_mutex_key#23){+.+.}:
       inode_lock include/linux/fs.h:748 [inline]
       __generic_file_fsync+0xb0/0x1f0 fs/libfs.c:989
       fat_file_fsync+0x73/0x200 fs/fat/file.c:198
       vfs_fsync_range+0x13a/0x220 fs/sync.c:197
       generic_write_sync include/linux/fs.h:2750 [inline]
       dio_complete+0x763/0xac0 fs/direct-io.c:329
       process_one_work+0x864/0x1570 kernel/workqueue.c:2153
       worker_thread+0x64c/0x1130 kernel/workqueue.c:2296
       kthread+0x33f/0x460 kernel/kthread.c:259
       ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:415

-> #1 ((work_completion)(&dio->complete_work)){+.+.}:
       worker_thread+0x64c/0x1130 kernel/workqueue.c:2296
       kthread+0x33f/0x460 kernel/kthread.c:259
       ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:415

-> #0 ((wq_completion)"dio/%s"sb->s_id){+.+.}:
       flush_workqueue+0x117/0x13e0 kernel/workqueue.c:2661
       drain_workqueue+0x1a5/0x460 kernel/workqueue.c:2826
       destroy_workqueue+0x75/0x790 kernel/workqueue.c:4183
       __alloc_workqueue_key+0xb76/0xed0 kernel/workqueue.c:4160
       sb_init_dio_done_wq+0x34/0x90 fs/direct-io.c:623
       do_blockdev_direct_IO fs/direct-io.c:1285 [inline]
       __blockdev_direct_IO+0x5f55/0xef40 fs/direct-io.c:1419
       blockdev_direct_IO include/linux/fs.h:3059 [inline]
       fat_direct_IO+0x1d1/0x370 fs/fat/inode.c:282
       generic_file_direct_write+0x208/0x4a0 mm/filemap.c:3073
       __generic_file_write_iter+0x2d0/0x610 mm/filemap.c:3252
       generic_file_write_iter+0x3f8/0x730 mm/filemap.c:3323
       call_write_iter include/linux/fs.h:1821 [inline]
       aio_write+0x37f/0x5c0 fs/aio.c:1574
       __io_submit_one fs/aio.c:1858 [inline]
       io_submit_one+0xecd/0x20c0 fs/aio.c:1909
       __do_sys_io_submit fs/aio.c:1953 [inline]
       __se_sys_io_submit+0x11b/0x4a0 fs/aio.c:1924
       do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

other info that might help us debug this:

Chain exists of:
  (wq_completion)"dio/%s"sb->s_id --> (work_completion)(&dio->complete_work) --> &sb->s_type->i_mutex_key#23

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sb->s_type->i_mutex_key#23);
                               lock((work_completion)(&dio->complete_work));
                               lock(&sb->s_type->i_mutex_key#23);
  lock((wq_completion)"dio/%s"sb->s_id);

 *** DEADLOCK ***

1 lock held by syz-executor.3/10323:
 #0: 00000000cdeebc7c (&sb->s_type->i_mutex_key#23){+.+.}, at: inode_lock include/linux/fs.h:748 [inline]
 #0: 00000000cdeebc7c (&sb->s_type->i_mutex_key#23){+.+.}, at: generic_file_write_iter+0x99/0x730 mm/filemap.c:3320

stack backtrace:
CPU: 1 PID: 10323 Comm: syz-executor.3 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/26/2022
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222
 check_prev_add kernel/locking/lockdep.c:1866 [inline]
 check_prevs_add kernel/locking/lockdep.c:1979 [inline]
 validate_chain kernel/locking/lockdep.c:2420 [inline]
 __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416
 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908
 flush_workqueue+0x117/0x13e0 kernel/workqueue.c:2661
 drain_workqueue+0x1a5/0x460 kernel/workqueue.c:2826
 destroy_workqueue+0x75/0x790 kernel/workqueue.c:4183
 __alloc_workqueue_key+0xb76/0xed0 kernel/workqueue.c:4160
 sb_init_dio_done_wq+0x34/0x90 fs/direct-io.c:623
 do_blockdev_direct_IO fs/direct-io.c:1285 [inline]
 __blockdev_direct_IO+0x5f55/0xef40 fs/direct-io.c:1419
 blockdev_direct_IO include/linux/fs.h:3059 [inline]
 fat_direct_IO+0x1d1/0x370 fs/fat/inode.c:282
 generic_file_direct_write+0x208/0x4a0 mm/filemap.c:3073
 __generic_file_write_iter+0x2d0/0x610 mm/filemap.c:3252
 generic_file_write_iter+0x3f8/0x730 mm/filemap.c:3323
 call_write_iter include/linux/fs.h:1821 [inline]
 aio_write+0x37f/0x5c0 fs/aio.c:1574
 __io_submit_one fs/aio.c:1858 [inline]
 io_submit_one+0xecd/0x20c0 fs/aio.c:1909
 __do_sys_io_submit fs/aio.c:1953 [inline]
 __se_sys_io_submit+0x11b/0x4a0 fs/aio.c:1924
 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f8b59659409
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8b57fad168 EFLAGS: 00000246 ORIG_RAX: 00000000000000d1
RAX: ffffffffffffffda RBX: 00007f8b5976c050 RCX: 00007f8b59659409
RDX: 0000000020000540 RSI: 0000000000001801 RDI: 00007f8b59747000
RBP: 00007f8b596b4367 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffd8cad65bf R14: 00007f8b57fad300 R15: 0000000000022000
IPVS: ftp: loaded support on port[0] = 21
IPVS: ftp: loaded support on port[0] = 21
IPVS: ftp: loaded support on port[0] = 21
MINIX-fs: mounting unchecked file system, running fsck is recommended
overlayfs: failed to resolve './file0ÿÿ': -2
MINIX-fs: mounting unchecked file system, running fsck is recommended
attempt to access beyond end of device
loop2: rw=0, want=22, limit=20
Buffer I/O error on dev loop2, logical block 10, async page read
attempt to access beyond end of device
loop2: rw=0, want=22, limit=20
Buffer I/O error on dev loop2, logical block 10, async page read
overlayfs: failed to resolve './file0ÿÿ': -2
kauditd_printk_skb: 60 callbacks suppressed
audit: type=1800 audit(1663263096.997:72): pid=10551 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed comm="syz-executor.2" name="file1" dev="loop2" ino=5 res=0
MINIX-fs: mounting unchecked file system, running fsck is recommended
attempt to access beyond end of device
loop2: rw=0, want=22, limit=20
overlayfs: failed to resolve './file0ÿÿ': -2
Buffer I/O error on dev loop2, logical block 10, async page read
attempt to access beyond end of device
loop2: rw=0, want=22, limit=20
Buffer I/O error on dev loop2, logical block 10, async page read
audit: type=1800 audit(1663263097.287:73): pid=10589 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed comm="syz-executor.2" name="file1" dev="loop2" ino=5 res=0
IPVS: ftp: loaded support on port[0] = 21
MINIX-fs: mounting unchecked file system, running fsck is recommended
MINIX-fs: mounting unchecked file system, running fsck is recommended
attempt to access beyond end of device
attempt to access beyond end of device
loop2: rw=0, want=22, limit=20
loop0: rw=0, want=22, limit=20
QAT: failed to copy from user.
Buffer I/O error on dev loop2, logical block 10, async page read
overlayfs: failed to resolve './file0ÿÿ': -2
Buffer I/O error on dev loop0, logical block 10, async page read
overlayfs: failed to resolve './file0ÿÿ': -2
attempt to access beyond end of device
loop0: rw=0, want=22, limit=20
Buffer I/O error on dev loop0, logical block 10, async page read
attempt to access beyond end of device
audit: type=1800 audit(1663263097.987:74): pid=10645 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed comm="syz-executor.0" name="file1" dev="loop0" ino=5 res=0
loop2: rw=0, want=22, limit=20
Buffer I/O error on dev loop2, logical block 10, async page read
QAT: failed to copy from user.
audit: type=1800 audit(1663263098.047:75): pid=10641 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed comm="syz-executor.2" name="file1" dev="loop2" ino=5 res=0
QAT: failed to copy from user.
QAT: failed to copy from user.
QAT: failed to copy from user.
ieee80211 ©,í…×: Selected rate control algorithm 'minstrel_ht'
QAT: failed to copy from user.
F2FS-fs (loop4): Magic Mismatch, valid(0xf2f52010) - read(0x0)
F2FS-fs (loop4): Can't find valid F2FS filesystem in 1th superblock
F2FS-fs (loop4): Magic Mismatch, valid(0xf2f52010) - read(0x0)
F2FS-fs (loop4): Can't find valid F2FS filesystem in 2th superblock
F2FS-fs (loop4): Magic Mismatch, valid(0xf2f52010) - read(0x0)
F2FS-fs (loop4): Can't find valid F2FS filesystem in 1th superblock
F2FS-fs (loop4): Magic Mismatch, valid(0xf2f52010) - read(0x0)
F2FS-fs (loop4): Can't find valid F2FS filesystem in 2th superblock
ieee80211 ©,í…×: Selected rate control algorithm 'minstrel_ht'
F2FS-fs (loop4): Magic Mismatch, valid(0xf2f52010) - read(0x0)
F2FS-fs (loop4): Can't find valid F2FS filesystem in 1th superblock
ieee80211 ©,í…×: Selected rate control algorithm 'minstrel_ht'
ieee80211 ©,í…×: Selected rate control algorithm 'minstrel_ht'
ieee80211 phy18: Selected rate control algorithm 'minstrel_ht'
ieee80211 ©,í…×: Selected rate control algorithm 'minstrel_ht'
ieee80211 ©,í…×: Selected rate control algorithm 'minstrel_ht'
FAULT_INJECTION: forcing a failure.
name fail_page_alloc, interval 1, probability 0, space 0, times 1
CPU: 0 PID: 11273 Comm: syz-executor.0 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/26/2022
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
 fail_dump lib/fault-inject.c:51 [inline]
 should_fail.cold+0xa/0xf lib/fault-inject.c:149
ieee80211 ©,í…×: Selected rate control algorithm 'minstrel_ht'
 should_fail_alloc_page mm/page_alloc.c:3088 [inline]
 prepare_alloc_pages mm/page_alloc.c:4346 [inline]
 __alloc_pages_nodemask+0x239/0x2890 mm/page_alloc.c:4393
 alloc_pages_current+0x193/0x2a0 mm/mempolicy.c:2197
 alloc_pages include/linux/gfp.h:532 [inline]
 skb_page_frag_refill+0x258/0x550 net/core/sock.c:2238
 tun_build_skb+0x25e/0x1960 drivers/net/tun.c:1617
 tun_get_user+0x83f/0x5100 drivers/net/tun.c:1790
 tun_chr_write_iter+0xdb/0x1d0 drivers/net/tun.c:2007
 call_write_iter include/linux/fs.h:1821 [inline]
 new_sync_write fs/read_write.c:474 [inline]
 __vfs_write+0x51b/0x770 fs/read_write.c:487
 vfs_write+0x1f3/0x540 fs/read_write.c:549
 ksys_write+0x12b/0x2a0 fs/read_write.c:599
 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f6914dd3f1f
Code: 89 54 24 18 48 89 74 24 10 89 7c 24 08 e8 99 fd ff ff 48 8b 54 24 18 48 8b 74 24 10 41 89 c0 8b 7c 24 08 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 31 44 89 c7 48 89 44 24 08 e8 cc fd ff ff 48
RSP: 002b:00007f6913796130 EFLAGS: 00000293 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f6914f33f80 RCX: 00007f6914dd3f1f
RDX: 0000000000000080 RSI: 0000000020000080 RDI: 00000000000000c8
RBP: 00007f69137961d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000080 R11: 0000000000000293 R12: 0000000000000001
R13: 00007fffbfa6c89f R14: 00007f6913796300 R15: 0000000000022000
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 1
CPU: 1 PID: 11343 Comm: syz-executor.0 Not tainted 4.19.211-syzkaller #0
ieee80211 ©,í…×: Selected rate control algorithm 'minstrel_ht'
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/26/2022
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
 fail_dump lib/fault-inject.c:51 [inline]
 should_fail.cold+0xa/0xf lib/fault-inject.c:149
 __should_failslab+0x115/0x180 mm/failslab.c:32
 should_failslab+0x5/0x10 mm/slab_common.c:1590
 slab_pre_alloc_hook mm/slab.h:424 [inline]
 slab_alloc mm/slab.c:3383 [inline]
 kmem_cache_alloc+0x3f/0x370 mm/slab.c:3557
 __build_skb+0x39/0x300 net/core/skbuff.c:281
 build_skb+0x1c/0x190 net/core/skbuff.c:312
 tun_build_skb+0x51b/0x1960 drivers/net/tun.c:1686
 tun_get_user+0x83f/0x5100 drivers/net/tun.c:1790
 tun_chr_write_iter+0xdb/0x1d0 drivers/net/tun.c:2007
 call_write_iter include/linux/fs.h:1821 [inline]
 new_sync_write fs/read_write.c:474 [inline]
 __vfs_write+0x51b/0x770 fs/read_write.c:487
 vfs_write+0x1f3/0x540 fs/read_write.c:549
 ksys_write+0x12b/0x2a0 fs/read_write.c:599
 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f6914dd3f1f
Code: 89 54 24 18 48 89 74 24 10 89 7c 24 08 e8 99 fd ff ff 48 8b 54 24 18 48 8b 74 24 10 41 89 c0 8b 7c 24 08 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 31 44 89 c7 48 89 44 24 08 e8 cc fd ff ff 48
RSP: 002b:00007f6913796130 EFLAGS: 00000293 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f6914f33f80 RCX: 00007f6914dd3f1f
RDX: 0000000000000080 RSI: 0000000020000080 RDI: 00000000000000c8
RBP: 00007f69137961d0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000080 R11: 0000000000000293 R12: 0000000000000001
R13: 00007fffbfa6c89f R14: 00007f6913796300 R15: 0000000000022000
ieee80211 ©,í…×: Selected rate control algorithm 'minstrel_ht'
ieee80211 ©,í…×: Selected rate control algorithm 'minstrel_ht'
ieee80211 ©,í…×: Selected rate control algorithm 'minstrel_ht'
ieee80211 ©,í…×: Selected rate control algorithm 'minstrel_ht'
ieee80211 ©,í…×: Selected rate control algorithm 'minstrel_ht'
ieee80211 ©,í…×: Selected rate control algorithm 'minstrel_ht'
ieee80211 phy29: Selected rate control algorithm 'minstrel_ht'
ieee80211 phy30: Selected rate control algorithm 'minstrel_ht'