====================================================== WARNING: possible circular locking dependency detected 6.13.0-rc2-syzkaller-g2e7aff49b5da #0 Not tainted ------------------------------------------------------ syz.3.271/8246 is trying to acquire lock: ffff0000f84e5100 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline] ffff0000f84e5100 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}, at: ocfs2_xattr_set+0xb60/0x1448 fs/ocfs2/xattr.c:3622 but task is already holding lock: ffff0000dd1cbff8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x4e0/0x1448 fs/ocfs2/xattr.c:3583 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&oi->ip_xattr_sem){++++}-{4:4}: down_read+0x58/0x2fc kernel/locking/rwsem.c:1524 ocfs2_init_acl+0x2c8/0x764 fs/ocfs2/acl.c:366 ocfs2_mknod+0x1388/0x2438 fs/ocfs2/namei.c:410 ocfs2_mkdir+0x194/0x4d4 fs/ocfs2/namei.c:657 vfs_mkdir+0x27c/0x410 fs/namei.c:4311 do_mkdirat+0x248/0x574 fs/namei.c:4334 __do_sys_mkdirat fs/namei.c:4349 [inline] __se_sys_mkdirat fs/namei.c:4347 [inline] __arm64_sys_mkdirat+0x8c/0xa4 fs/namei.c:4347 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #1 (jbd2_handle){++++}-{0:0}: jbd2_journal_lock_updates+0xbc/0x324 fs/jbd2/transaction.c:865 __ocfs2_flush_truncate_log+0x29c/0x1140 fs/ocfs2/alloc.c:6029 ocfs2_flush_truncate_log+0x50/0x70 fs/ocfs2/alloc.c:6076 ocfs2_sync_fs+0x110/0x31c fs/ocfs2/super.c:402 sync_filesystem+0x1a0/0x218 fs/sync.c:66 generic_shutdown_super+0x70/0x2bc fs/super.c:621 kill_block_super+0x44/0x90 fs/super.c:1710 deactivate_locked_super+0xc4/0x12c fs/super.c:473 deactivate_super+0xe0/0x100 fs/super.c:506 cleanup_mnt+0x34c/0x3dc fs/namespace.c:1373 __cleanup_mnt+0x20/0x30 fs/namespace.c:1380 task_work_run+0x230/0x2e0 kernel/task_work.c:239 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] do_notify_resume+0x178/0x1f4 arch/arm64/kernel/entry-common.c:151 exit_to_user_mode_prepare arch/arm64/kernel/entry-common.c:169 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:178 [inline] el0_svc+0xac/0x168 arch/arm64/kernel/entry-common.c:745 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5226 lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5849 down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:818 [inline] ocfs2_xattr_set+0xb60/0x1448 fs/ocfs2/xattr.c:3622 ocfs2_set_acl+0x410/0x4b4 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x230/0x374 fs/ocfs2/acl.c:286 set_posix_acl fs/posix_acl.c:954 [inline] vfs_set_acl+0x7a0/0xa24 fs/posix_acl.c:1133 do_set_acl+0xe4/0x1ac fs/posix_acl.c:1278 do_setxattr fs/xattr.c:633 [inline] filename_setxattr+0x2e8/0x404 fs/xattr.c:665 path_setxattrat+0x370/0x41c fs/xattr.c:713 __do_sys_setxattr fs/xattr.c:747 [inline] __se_sys_setxattr fs/xattr.c:743 [inline] __arm64_sys_setxattr+0xc0/0xdc fs/xattr.c:743 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6 --> jbd2_handle --> &oi->ip_xattr_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_xattr_sem); lock(jbd2_handle); lock(&oi->ip_xattr_sem); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6); *** DEADLOCK *** 3 locks held by syz.3.271/8246: #0: ffff0000ed1b4420 (sb_writers#18){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:515 #1: ffff0000dd1cc2c0 (&type->i_mutex_dir_key#11){++++}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline] #1: ffff0000dd1cc2c0 (&type->i_mutex_dir_key#11){++++}-{4:4}, at: vfs_set_acl+0x374/0xa24 fs/posix_acl.c:1114 #2: ffff0000dd1cbff8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x4e0/0x1448 fs/ocfs2/xattr.c:3583 stack backtrace: CPU: 0 UID: 0 PID: 8246 Comm: syz.3.271 Not tainted 6.13.0-rc2-syzkaller-g2e7aff49b5da #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call trace: show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:484 (C) __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:120 dump_stack+0x1c/0x28 lib/dump_stack.c:129 print_circular_bug+0x154/0x1c0 kernel/locking/lockdep.c:2074 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5226 lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5849 down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:818 [inline] ocfs2_xattr_set+0xb60/0x1448 fs/ocfs2/xattr.c:3622 ocfs2_set_acl+0x410/0x4b4 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x230/0x374 fs/ocfs2/acl.c:286 set_posix_acl fs/posix_acl.c:954 [inline] vfs_set_acl+0x7a0/0xa24 fs/posix_acl.c:1133 do_set_acl+0xe4/0x1ac fs/posix_acl.c:1278 do_setxattr fs/xattr.c:633 [inline] filename_setxattr+0x2e8/0x404 fs/xattr.c:665 path_setxattrat+0x370/0x41c fs/xattr.c:713 __do_sys_setxattr fs/xattr.c:747 [inline] __se_sys_setxattr fs/xattr.c:743 [inline] __arm64_sys_setxattr+0xc0/0xdc fs/xattr.c:743 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600