overlayfs: upper fs does not support tmpfile.
overlayfs: upper fs does not support RENAME_WHITEOUT.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.35/4594 is trying to acquire lock:
ffff0000e216d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
ffff0000e216d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x12c/0x3cd4 fs/ocfs2/suballoc.c:782

but task is already holding lock:
ffff0000e2141538 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x32c/0xe98 fs/ocfs2/xattr.c:3587

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0x64/0x304 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x258/0x5f0 fs/ocfs2/acl.c:365
       ocfs2_mknod+0x1168/0x1f18 fs/ocfs2/namei.c:410
       ocfs2_create+0x19c/0x4f0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0x112c/0x2680 fs/namei.c:3788
       do_filp_open+0x174/0x344 fs/namei.c:3818
       do_sys_openat2+0x128/0x3d8 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __arm64_sys_openat+0x120/0x154 fs/open.c:1345
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #4 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0xfe0/0x122c fs/jbd2/transaction.c:463
       jbd2__journal_start+0x288/0x51c fs/jbd2/transaction.c:520
       jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x380/0x6c4 fs/ocfs2/journal.c:376
       ocfs2_mknod+0xc7c/0x1f18 fs/ocfs2/namei.c:361
       ocfs2_create+0x19c/0x4f0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0x112c/0x2680 fs/namei.c:3788
       do_filp_open+0x174/0x344 fs/namei.c:3818
       do_sys_openat2+0x128/0x3d8 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __arm64_sys_openat+0x120/0x154 fs/open.c:1345
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #3 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x64/0x304 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x374/0x6c4 fs/ocfs2/journal.c:374
       ocfs2_mknod+0xc7c/0x1f18 fs/ocfs2/namei.c:361
       ocfs2_create+0x19c/0x4f0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0x112c/0x2680 fs/namei.c:3788
       do_filp_open+0x174/0x344 fs/namei.c:3818
       do_sys_openat2+0x128/0x3d8 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __arm64_sys_openat+0x120/0x154 fs/open.c:1345
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #2 (sb_internal#2){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x20c/0x6c4 fs/ocfs2/journal.c:372
       ocfs2_mknod+0xc7c/0x1f18 fs/ocfs2/namei.c:361
       ocfs2_create+0x19c/0x4f0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0x112c/0x2680 fs/namei.c:3788
       do_filp_open+0x174/0x344 fs/namei.c:3818
       do_sys_openat2+0x128/0x3d8 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __arm64_sys_openat+0x120/0x154 fs/open.c:1345
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}:
       down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_reserve_local_alloc_bits+0xf8/0x278c fs/ocfs2/localalloc.c:635
       ocfs2_reserve_clusters_with_limit+0x198/0x9e0 fs/ocfs2/suballoc.c:1162
       ocfs2_reserve_clusters+0x3c/0x50 fs/ocfs2/suballoc.c:1223
       ocfs2_mknod+0xc2c/0x1f18 fs/ocfs2/namei.c:354
       ocfs2_create+0x19c/0x4f0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0x112c/0x2680 fs/namei.c:3788
       do_filp_open+0x174/0x344 fs/namei.c:3818
       do_sys_openat2+0x128/0x3d8 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __arm64_sys_openat+0x120/0x154 fs/open.c:1345
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x293c/0x6544 kernel/locking/lockdep.c:5049
       lock_acquire+0x20c/0x644 kernel/locking/lockdep.c:5662
       down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_reserve_suballoc_bits+0x12c/0x3cd4 fs/ocfs2/suballoc.c:782
       ocfs2_reserve_new_metadata_blocks+0x368/0x810 fs/ocfs2/suballoc.c:978
       ocfs2_init_xattr_set_ctxt+0x300/0x7bc fs/ocfs2/xattr.c:3281
       ocfs2_xattr_set+0x91c/0xe98 fs/ocfs2/xattr.c:3638
       ocfs2_xattr_trusted_set+0x4c/0x64 fs/ocfs2/xattr.c:7349
       __vfs_setxattr+0x388/0x3a4 fs/xattr.c:182
       __vfs_setxattr_noperm+0x120/0x564 fs/xattr.c:216
       __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277
       vfs_setxattr+0x158/0x2ac fs/xattr.c:309
       ovl_do_setxattr fs/overlayfs/overlayfs.h:252 [inline]
       ovl_setxattr fs/overlayfs/overlayfs.h:264 [inline]
       ovl_make_workdir fs/overlayfs/super.c:1435 [inline]
       ovl_get_workdir+0x950/0x1068 fs/overlayfs/super.c:1539
       ovl_fill_super+0x139c/0x2294 fs/overlayfs/super.c:2095
       mount_nodev+0x68/0x104 fs/super.c:1489
       ovl_mount+0x3c/0x50 fs/overlayfs/super.c:2186
       legacy_get_tree+0xd4/0x16c fs/fs_context.c:632
       vfs_get_tree+0x90/0x274 fs/super.c:1573
       do_new_mount+0x228/0x810 fs/namespace.c:3078
       path_mount+0x5b4/0xe78 fs/namespace.c:3408
       do_mount fs/namespace.c:3421 [inline]
       __do_sys_mount fs/namespace.c:3629 [inline]
       __se_sys_mount fs/namespace.c:3606 [inline]
       __arm64_sys_mount+0x49c/0x584 fs/namespace.c:3606
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3 --> jbd2_handle --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3);

 *** DEADLOCK ***

4 locks held by syz.0.35/4594:
 #0: ffff0000d4c700e0 (&type->s_umount_key#49/1){+.+.}-{3:3}, at: alloc_super+0x1a4/0x804 fs/super.c:228
 #1: ffff0000db450460 (sb_writers#12){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:402
 #2: ffff0000e2141808 (&sb->s_type->i_mutex_key#27){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff0000e2141808 (&sb->s_type->i_mutex_key#27){+.+.}-{3:3}, at: vfs_setxattr+0x138/0x2ac fs/xattr.c:308
 #3: ffff0000e2141538 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x32c/0xe98 fs/ocfs2/xattr.c:3587

stack backtrace:
CPU: 0 PID: 4594 Comm: syz.0.35 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/03/2025
Call trace:
 dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
 __dump_stack+0x30/0x40 lib/dump_stack.c:88
 dump_stack_lvl+0xf8/0x160 lib/dump_stack.c:106
 dump_stack+0x1c/0x5c lib/dump_stack.c:113
 print_circular_bug+0x148/0x1b0 kernel/locking/lockdep.c:2048
 check_noncircular+0x240/0x2d4 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x293c/0x6544 kernel/locking/lockdep.c:5049
 lock_acquire+0x20c/0x644 kernel/locking/lockdep.c:5662
 down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:758 [inline]
 ocfs2_reserve_suballoc_bits+0x12c/0x3cd4 fs/ocfs2/suballoc.c:782
 ocfs2_reserve_new_metadata_blocks+0x368/0x810 fs/ocfs2/suballoc.c:978
 ocfs2_init_xattr_set_ctxt+0x300/0x7bc fs/ocfs2/xattr.c:3281
 ocfs2_xattr_set+0x91c/0xe98 fs/ocfs2/xattr.c:3638
 ocfs2_xattr_trusted_set+0x4c/0x64 fs/ocfs2/xattr.c:7349
 __vfs_setxattr+0x388/0x3a4 fs/xattr.c:182
 __vfs_setxattr_noperm+0x120/0x564 fs/xattr.c:216
 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277
 vfs_setxattr+0x158/0x2ac fs/xattr.c:309
 ovl_do_setxattr fs/overlayfs/overlayfs.h:252 [inline]
 ovl_setxattr fs/overlayfs/overlayfs.h:264 [inline]
 ovl_make_workdir fs/overlayfs/super.c:1435 [inline]
 ovl_get_workdir+0x950/0x1068 fs/overlayfs/super.c:1539
 ovl_fill_super+0x139c/0x2294 fs/overlayfs/super.c:2095
 mount_nodev+0x68/0x104 fs/super.c:1489
 ovl_mount+0x3c/0x50 fs/overlayfs/super.c:2186
 legacy_get_tree+0xd4/0x16c fs/fs_context.c:632
 vfs_get_tree+0x90/0x274 fs/super.c:1573
 do_new_mount+0x228/0x810 fs/namespace.c:3078
 path_mount+0x5b4/0xe78 fs/namespace.c:3408
 do_mount fs/namespace.c:3421 [inline]
 __do_sys_mount fs/namespace.c:3629 [inline]
 __se_sys_mount fs/namespace.c:3606 [inline]
 __arm64_sys_mount+0x49c/0x584 fs/namespace.c:3606
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
 el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637
 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
(syz.0.35,4594,1):ocfs2_read_blocks:239 ERROR: status = -12
(syz.0.35,4594,0):ocfs2_search_chain:1761 ERROR: status = -12
(syz.0.35,4594,1):ocfs2_search_chain:1871 ERROR: status = -12
(syz.0.35,4594,0):ocfs2_claim_suballoc_bits:1940 ERROR: status = -12
(syz.0.35,4594,1):ocfs2_claim_suballoc_bits:1983 ERROR: status = -12
(syz.0.35,4594,0):__ocfs2_claim_clusters:2355 ERROR: status = -12
(syz.0.35,4594,1):__ocfs2_claim_clusters:2363 ERROR: status = -12
(syz.0.35,4594,0):ocfs2_block_group_alloc_contig:433 ERROR: status = -12
(syz.0.35,4594,1):ocfs2_block_group_alloc:705 ERROR: status = -12
(syz.0.35,4594,0):ocfs2_block_group_alloc:758 ERROR: status = -12
(syz.0.35,4594,1):ocfs2_reserve_suballoc_bits:833 ERROR: status = -12
(syz.0.35,4594,0):ocfs2_reserve_suballoc_bits:850 ERROR: status = -12
(syz.0.35,4594,1):ocfs2_reserve_new_metadata_blocks:990 ERROR: status = -12
(syz.0.35,4594,0):ocfs2_reserve_new_metadata_blocks:1013 ERROR: status = -12
(syz.0.35,4594,1):ocfs2_init_xattr_set_ctxt:3284 ERROR: status = -12
(syz.0.35,4594,0):ocfs2_xattr_set:3641 ERROR: status = -12
overlayfs: failed to set xattr on upper
overlayfs: ...falling back to index=off,metacopy=off.
overlayfs: upper fs missing required features.