====================================================== WARNING: possible circular locking dependency detected 4.19.211-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.4/13604 is trying to acquire lock: 00000000ef053d98 (&fs_info->qgroup_ioctl_lock){+.+.}, at: btrfs_remove_qgroup+0xae/0x770 fs/btrfs/qgroup.c:1415 but task is already holding lock: 000000004b4bce45 (sb_internal#3){.+.+}, at: sb_start_intwrite include/linux/fs.h:1626 [inline] 000000004b4bce45 (sb_internal#3){.+.+}, at: start_transaction+0xa37/0xf90 fs/btrfs/transaction.c:528 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (sb_internal#3){.+.+}: sb_start_intwrite include/linux/fs.h:1626 [inline] start_transaction+0xa37/0xf90 fs/btrfs/transaction.c:528 btrfs_quota_enable+0x169/0x10b0 fs/btrfs/qgroup.c:905 btrfs_ioctl_quota_ctl fs/btrfs/ioctl.c:5233 [inline] btrfs_ioctl+0x622c/0x76d0 fs/btrfs/ioctl.c:6021 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:501 [inline] do_vfs_ioctl+0xcdb/0x12e0 fs/ioctl.c:688 ksys_ioctl+0x9b/0xc0 fs/ioctl.c:705 __do_sys_ioctl fs/ioctl.c:712 [inline] __se_sys_ioctl fs/ioctl.c:710 [inline] __x64_sys_ioctl+0x6f/0xb0 fs/ioctl.c:710 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #0 (&fs_info->qgroup_ioctl_lock){+.+.}: __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 btrfs_remove_qgroup+0xae/0x770 fs/btrfs/qgroup.c:1415 btrfs_ioctl_qgroup_create fs/btrfs/ioctl.c:5337 [inline] btrfs_ioctl+0x661c/0x76d0 fs/btrfs/ioctl.c:6025 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:501 [inline] do_vfs_ioctl+0xcdb/0x12e0 fs/ioctl.c:688 ksys_ioctl+0x9b/0xc0 fs/ioctl.c:705 __do_sys_ioctl fs/ioctl.c:712 [inline] __se_sys_ioctl fs/ioctl.c:710 [inline] __x64_sys_ioctl+0x6f/0xb0 fs/ioctl.c:710 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(sb_internal#3); lock(&fs_info->qgroup_ioctl_lock); lock(sb_internal#3); lock(&fs_info->qgroup_ioctl_lock); *** DEADLOCK *** 2 locks held by syz-executor.4/13604: #0: 00000000e8add1a7 (sb_writers#23){.+.+}, at: sb_start_write include/linux/fs.h:1579 [inline] #0: 00000000e8add1a7 (sb_writers#23){.+.+}, at: mnt_want_write_file+0x63/0x1d0 fs/namespace.c:418 #1: 000000004b4bce45 (sb_internal#3){.+.+}, at: sb_start_intwrite include/linux/fs.h:1626 [inline] #1: 000000004b4bce45 (sb_internal#3){.+.+}, at: start_transaction+0xa37/0xf90 fs/btrfs/transaction.c:528 stack backtrace: CPU: 1 PID: 13604 Comm: syz-executor.4 Not tainted 4.19.211-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1fc/0x2ef lib/dump_stack.c:118 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222 check_prev_add kernel/locking/lockdep.c:1866 [inline] check_prevs_add kernel/locking/lockdep.c:1979 [inline] validate_chain kernel/locking/lockdep.c:2420 [inline] __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908 __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 btrfs_remove_qgroup+0xae/0x770 fs/btrfs/qgroup.c:1415 btrfs_ioctl_qgroup_create fs/btrfs/ioctl.c:5337 [inline] btrfs_ioctl+0x661c/0x76d0 fs/btrfs/ioctl.c:6025 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:501 [inline] do_vfs_ioctl+0xcdb/0x12e0 fs/ioctl.c:688 ksys_ioctl+0x9b/0xc0 fs/ioctl.c:705 __do_sys_ioctl fs/ioctl.c:712 [inline] __se_sys_ioctl fs/ioctl.c:710 [inline] __x64_sys_ioctl+0x6f/0xb0 fs/ioctl.c:710 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7f50834040c9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f5081976168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f5083523f80 RCX: 00007f50834040c9 RDX: 00000000200011c0 RSI: 000000004010942a RDI: 0000000000000004 RBP: 00007f508345fae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007fff851af82f R14: 00007f5081976300 R15: 0000000000022000 BTRFS error (device loop4): fail to start transaction for status update: -28 MINIX-fs: deleted inode referenced: 1 MINIX-fs: get root inode failed BTRFS info (device loop4): using free space tree BTRFS info (device loop4): has skinny extents BTRFS warning (device ): duplicate device /dev/loop1 devid 1 generation 8 scanned by syz-executor.1 (13705) BTRFS warning (device ): duplicate device /dev/loop1 devid 1 generation 8 scanned by systemd-udevd (13731) BTRFS error (device loop4): fail to start transaction for status update: -28 MINIX-fs: deleted inode referenced: 1 MINIX-fs: get root inode failed IPVS: ftp: loaded support on port[0] = 21 MINIX-fs: deleted inode referenced: 1 MINIX-fs: get root inode failed MINIX-fs: deleted inode referenced: 1 IPVS: ftp: loaded support on port[0] = 21 MINIX-fs: get root inode failed BTRFS info (device loop4): using free space tree BTRFS warning (device ): duplicate device /dev/loop1 devid 1 generation 8 scanned by syz-executor.1 (13778) BTRFS info (device loop4): has skinny extents IPVS: ftp: loaded support on port[0] = 21 BTRFS error (device loop4): fail to start transaction for status update: -28 IPVS: ftp: loaded support on port[0] = 21 BTRFS info (device loop1): using free space tree BTRFS info (device loop1): has skinny extents BTRFS warning (device ): duplicate device /dev/loop4 devid 1 generation 8 scanned by syz-executor.4 (13948) BTRFS error (device loop1): fail to start transaction for status update: -28 snd_aloop snd_aloop.0: control 0:0:0:syz1:0 is already present snd_aloop snd_aloop.0: control 0:0:0:syz1:0 is already present snd_aloop snd_aloop.0: control 0:0:0:syz1:0 is already present snd_aloop snd_aloop.0: control 0:0:0:syz1:0 is already present snd_aloop snd_aloop.0: control 0:0:0:syz1:0 is already present snd_aloop snd_aloop.0: control 0:0:0:syz1:0 is already present snd_aloop snd_aloop.0: control 0:0:0:syz1:0 is already present snd_aloop snd_aloop.0: control 0:0:0:syz1:0 is already present snd_aloop snd_aloop.0: control 0:0:0:syz1:0 is already present snd_aloop snd_aloop.0: control 0:0:0:syz1:0 is already present netlink: 36 bytes leftover after parsing attributes in process `syz-executor.1'. snd_aloop snd_aloop.0: control 0:0:0:syz1:0 is already present netlink: 36 bytes leftover after parsing attributes in process `syz-executor.1'. netlink: 36 bytes leftover after parsing attributes in process `syz-executor.1'. IPv6: ADDRCONF(NETDEV_UP): bridge1: link is not ready snd_aloop snd_aloop.0: control 0:0:0:syz1:0 is already present netlink: 36 bytes leftover after parsing attributes in process `syz-executor.1'. IPv6: ADDRCONF(NETDEV_UP): bridge2: link is not ready IPv6: ADDRCONF(NETDEV_UP): bridge3: link is not ready audit: type=1804 audit(1673625574.725:75): pid=14191 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.0" name="/root/syzkaller-testdir1084772202/syzkaller.Rl1pwa/118/bus" dev="sda1" ino=14149 res=1 IPv6: ADDRCONF(NETDEV_UP): bridge4: link is not ready