====================================================== WARNING: possible circular locking dependency detected 6.1.16-syzkaller #0 Not tainted ------------------------------------------------------ syz-fuzzer/3662 is trying to acquire lock: ffff88801f66e490 (&q->queue_lock){..-.}-{2:2}, at: spin_lock_irq include/linux/spinlock.h:375 [inline] ffff88801f66e490 (&q->queue_lock){..-.}-{2:2}, at: throtl_pending_timer_fn+0x10d/0x1be0 block/blk-throttle.c:1193 but task is already holding lock: ffffc900001e0bc0 ((&sq->pending_timer)){+.-.}-{0:0}, at: lockdep_copy_map include/linux/lockdep.h:41 [inline] ffffc900001e0bc0 ((&sq->pending_timer)){+.-.}-{0:0}, at: call_timer_fn+0xbd/0x840 kernel/time/timer.c:1464 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 ((&sq->pending_timer)){+.-.}-{0:0}: lock_acquire+0x23a/0x630 kernel/locking/lockdep.c:5669 del_timer_sync+0x111/0x2e0 kernel/time/timer.c:1417 throtl_pd_free+0x15/0x40 block/blk-throttle.c:493 blkcg_deactivate_policy+0x32d/0x550 block/blk-cgroup.c:1499 blk_throtl_exit+0xa6/0x140 block/blk-throttle.c:2406 disk_release+0x1dd/0x380 block/genhd.c:1171 device_release+0x91/0x1c0 kobject_cleanup lib/kobject.c:681 [inline] kobject_release lib/kobject.c:712 [inline] kref_put include/linux/kref.h:65 [inline] kobject_put+0x224/0x460 lib/kobject.c:729 do_floppy_init+0x373/0xc59 drivers/block/floppy.c:4758 async_run_entry_fn+0xa2/0x410 kernel/async.c:127 process_one_work+0x909/0x1380 kernel/workqueue.c:2289 worker_thread+0xa5f/0x1210 kernel/workqueue.c:2436 kthread+0x268/0x300 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306 -> #1 (&blkcg->lock){....}-{2:2}: lock_acquire+0x23a/0x630 kernel/locking/lockdep.c:5669 __raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline] _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:154 spin_lock include/linux/spinlock.h:350 [inline] blkg_create+0xa94/0x1280 block/blk-cgroup.c:336 blkcg_init_disk+0xee/0x350 block/blk-cgroup.c:1260 __alloc_disk_node+0x2ce/0x590 block/genhd.c:1385 __blk_alloc_disk+0x2c/0x80 block/genhd.c:1424 brd_alloc+0x2f9/0x6a0 drivers/block/brd.c:397 brd_init+0x100/0x1c2 drivers/block/brd.c:484 do_one_initcall+0x2d6/0xa80 init/main.c:1303 do_initcall_level+0x157/0x207 init/main.c:1376 do_initcalls+0x49/0x86 init/main.c:1392 kernel_init_freeable+0x473/0x61f init/main.c:1631 kernel_init+0x19/0x290 init/main.c:1519 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306 -> #0 (&q->queue_lock){..-.}-{2:2}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056 lock_acquire+0x23a/0x630 kernel/locking/lockdep.c:5669 __raw_spin_lock_irq include/linux/spinlock_api_smp.h:119 [inline] _raw_spin_lock_irq+0xcf/0x110 kernel/locking/spinlock.c:170 spin_lock_irq include/linux/spinlock.h:375 [inline] throtl_pending_timer_fn+0x10d/0x1be0 block/blk-throttle.c:1193 call_timer_fn+0x200/0x840 kernel/time/timer.c:1474 expire_timers kernel/time/timer.c:1519 [inline] __run_timers+0x67c/0x890 kernel/time/timer.c:1790 run_timer_softirq+0x63/0xf0 kernel/time/timer.c:1803 __do_softirq+0x30d/0xb1b kernel/softirq.c:571 invoke_softirq kernel/softirq.c:445 [inline] __irq_exit_rcu+0x155/0x240 kernel/softirq.c:650 irq_exit_rcu+0x5/0x20 kernel/softirq.c:662 sysvec_apic_timer_interrupt+0x91/0xb0 arch/x86/kernel/apic/apic.c:1107 asm_sysvec_apic_timer_interrupt+0x16/0x20 arch/x86/include/asm/idtentry.h:649 finish_lock_switch+0x91/0x100 kernel/sched/core.c:4998 finish_task_switch+0x134/0x630 kernel/sched/core.c:5115 context_switch kernel/sched/core.c:5241 [inline] __schedule+0x1399/0x4390 kernel/sched/core.c:6551 schedule+0xbf/0x180 kernel/sched/core.c:6627 exit_to_user_mode_loop+0x44/0x100 kernel/entry/common.c:159 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:203 irqentry_exit_to_user_mode+0x5/0x30 kernel/entry/common.c:309 asm_sysvec_reschedule_ipi+0x16/0x20 arch/x86/include/asm/idtentry.h:654 other info that might help us debug this: Chain exists of: &q->queue_lock --> &blkcg->lock --> (&sq->pending_timer) Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock((&sq->pending_timer)); lock(&blkcg->lock); lock((&sq->pending_timer)); lock(&q->queue_lock); *** DEADLOCK *** 1 lock held by syz-fuzzer/3662: #0: ffffc900001e0bc0 ((&sq->pending_timer)){+.-.}-{0:0}, at: lockdep_copy_map include/linux/lockdep.h:41 [inline] #0: ffffc900001e0bc0 ((&sq->pending_timer)){+.-.}-{0:0}, at: call_timer_fn+0xbd/0x840 kernel/time/timer.c:1464 stack backtrace: CPU: 1 PID: 3662 Comm: syz-fuzzer Not tainted 6.1.16-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056 lock_acquire+0x23a/0x630 kernel/locking/lockdep.c:5669 __raw_spin_lock_irq include/linux/spinlock_api_smp.h:119 [inline] _raw_spin_lock_irq+0xcf/0x110 kernel/locking/spinlock.c:170 spin_lock_irq include/linux/spinlock.h:375 [inline] throtl_pending_timer_fn+0x10d/0x1be0 block/blk-throttle.c:1193 call_timer_fn+0x200/0x840 kernel/time/timer.c:1474 expire_timers kernel/time/timer.c:1519 [inline] __run_timers+0x67c/0x890 kernel/time/timer.c:1790 run_timer_softirq+0x63/0xf0 kernel/time/timer.c:1803 __do_softirq+0x30d/0xb1b kernel/softirq.c:571 invoke_softirq kernel/softirq.c:445 [inline] __irq_exit_rcu+0x155/0x240 kernel/softirq.c:650 irq_exit_rcu+0x5/0x20 kernel/softirq.c:662 sysvec_apic_timer_interrupt+0x91/0xb0 arch/x86/kernel/apic/apic.c:1107 asm_sysvec_apic_timer_interrupt+0x16/0x20 arch/x86/include/asm/idtentry.h:649 RIP: 0010:finish_lock_switch+0x91/0x100 kernel/sched/core.c:4998 Code: 45 31 c9 68 e7 9c 60 81 e8 1c a3 09 00 48 83 c4 08 4c 89 ff e8 90 c9 fe ff 66 90 4c 89 ff e8 f6 e0 32 09 e8 b1 73 30 00 fb 5b <41> 5c 41 5d 41 5e 41 5f c3 44 89 f1 80 e1 07 80 c1 03 38 c1 7c 87 RSP: 0018:ffffc90003e3fc98 EFLAGS: 00000286 RAX: 2c6ccd396a0fd900 RBX: ffff88807630bab4 RCX: ffffffff91a5e003 RDX: dffffc0000000000 RSI: ffffffff8aebd320 RDI: ffffffff8b3d0ba0 RBP: ffffc90003e3fd10 R08: dffffc0000000000 R09: ffffed10173273b9 R10: 0000000000000000 R11: dffffc0000000001 R12: dffffc0000000000 R13: 1ffff11017327563 R14: ffff8880b993ab18 R15: ffff8880b9939dc0 finish_task_switch+0x134/0x630 kernel/sched/core.c:5115 context_switch kernel/sched/core.c:5241 [inline] __schedule+0x1399/0x4390 kernel/sched/core.c:6551 schedule+0xbf/0x180 kernel/sched/core.c:6627 exit_to_user_mode_loop+0x44/0x100 kernel/entry/common.c:159 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:203 irqentry_exit_to_user_mode+0x5/0x30 kernel/entry/common.c:309 asm_sysvec_reschedule_ipi+0x16/0x20 arch/x86/include/asm/idtentry.h:654 RIP: 0033:0x512d67 Code: 48 89 8f d8 01 00 00 eb 15 48 8d 87 d8 01 00 00 48 89 fa 48 89 c7 e8 48 6a f5 ff 48 89 d7 48 89 f8 31 f6 48 89 b0 68 01 00 00 <48> 8b 6c 24 20 48 83 c4 28 c3 48 8b 6c 24 20 48 83 c4 28 c3 48 89 RSP: 002b:000000c010393390 EFLAGS: 00000287 RAX: 000000c00022c1e0 RBX: 0000000000000000 RCX: 0000000000000022 RDX: 0000000000000003 RSI: 0000000000000025 RDI: 0000000000000081 RBP: 000000c0103933b0 R08: ffffffffffffffff R09: 0000000221cf2904 R10: 000000000110f9e0 R11: 0000000000000001 R12: 0000000000000102 R13: 0000000000000000 R14: 000000c000fc21a0 R15: 000000c0000ae900 ---------------- Code disassembly (best guess): 0: 45 31 c9 xor %r9d,%r9d 3: 68 e7 9c 60 81 pushq $0xffffffff81609ce7 8: e8 1c a3 09 00 callq 0x9a329 d: 48 83 c4 08 add $0x8,%rsp 11: 4c 89 ff mov %r15,%rdi 14: e8 90 c9 fe ff callq 0xfffec9a9 19: 66 90 xchg %ax,%ax 1b: 4c 89 ff mov %r15,%rdi 1e: e8 f6 e0 32 09 callq 0x932e119 23: e8 b1 73 30 00 callq 0x3073d9 28: fb sti 29: 5b pop %rbx * 2a: 41 5c pop %r12 <-- trapping instruction 2c: 41 5d pop %r13 2e: 41 5e pop %r14 30: 41 5f pop %r15 32: c3 retq 33: 44 89 f1 mov %r14d,%ecx 36: 80 e1 07 and $0x7,%cl 39: 80 c1 03 add $0x3,%cl 3c: 38 c1 cmp %al,%cl 3e: 7c 87 jl 0xffffffc7