====================================================== WARNING: possible circular locking dependency detected 4.19.211-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/11763 is trying to acquire lock: 00000000977d62b3 (&sbi->alloc_mutex){+.+.}, at: hfsplus_block_free+0xdb/0x5d0 fs/hfsplus/bitmap.c:182 but task is already holding lock: 000000004a3c5d3b (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_truncate+0x1e2/0x1040 fs/hfsplus/extents.c:576 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}: hfsplus_get_block+0x292/0x960 fs/hfsplus/extents.c:260 IPVS: ftp: loaded support on port[0] = 21 block_read_full_page+0x288/0xd10 fs/buffer.c:2259 do_read_cache_page+0x533/0x1170 mm/filemap.c:2828 read_mapping_page include/linux/pagemap.h:402 [inline] hfsplus_block_allocate+0x197/0xa60 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0x436/0xf40 fs/hfsplus/extents.c:468 hfsplus_get_block+0x196/0x960 fs/hfsplus/extents.c:245 __block_write_begin_int+0x46c/0x17b0 fs/buffer.c:1978 __block_write_begin fs/buffer.c:2028 [inline] block_write_begin+0x58/0x2e0 fs/buffer.c:2087 cont_write_begin+0x55a/0x820 fs/buffer.c:2440 hfsplus_write_begin+0x87/0x150 fs/hfsplus/inode.c:52 cont_expand_zero fs/buffer.c:2367 [inline] cont_write_begin+0x2ee/0x820 fs/buffer.c:2430 hfsplus_write_begin+0x87/0x150 fs/hfsplus/inode.c:52 generic_perform_write+0x1f8/0x4d0 mm/filemap.c:3170 __generic_file_write_iter+0x24b/0x610 mm/filemap.c:3295 generic_file_write_iter+0x3f8/0x730 mm/filemap.c:3323 call_write_iter include/linux/fs.h:1821 [inline] do_iter_readv_writev+0x668/0x790 fs/read_write.c:681 do_iter_write+0x182/0x5d0 fs/read_write.c:960 vfs_writev+0x153/0x2e0 fs/read_write.c:1005 do_pwritev+0x1b6/0x270 fs/read_write.c:1094 __do_sys_pwritev2 fs/read_write.c:1153 [inline] __se_sys_pwritev2 fs/read_write.c:1144 [inline] __x64_sys_pwritev2+0xeb/0x150 fs/read_write.c:1144 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #0 (&sbi->alloc_mutex){+.+.}: __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 hfsplus_block_free+0xdb/0x5d0 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x228/0x520 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0xd96/0x1040 fs/hfsplus/extents.c:591 hfsplus_setattr+0x1e7/0x310 fs/hfsplus/inode.c:263 notify_change+0x70b/0xfc0 fs/attr.c:334 do_truncate+0x134/0x1f0 fs/open.c:63 handle_truncate fs/namei.c:3009 [inline] do_last fs/namei.c:3427 [inline] path_openat+0x2308/0x2df0 fs/namei.c:3537 do_filp_open+0x18c/0x3f0 fs/namei.c:3567 do_sys_open+0x3b3/0x520 fs/open.c:1085 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 3 locks held by syz-executor.2/11763: #0: 000000002b68a770 (sb_writers#21){.+.+}, at: sb_start_write include/linux/fs.h:1579 [inline] #0: 000000002b68a770 (sb_writers#21){.+.+}, at: mnt_want_write+0x3a/0xb0 fs/namespace.c:360 IPVS: ftp: loaded support on port[0] = 21 #1: 00000000ee76478e (&sb->s_type->i_mutex_key#25){+.+.}, at: inode_lock include/linux/fs.h:748 [inline] #1: 00000000ee76478e (&sb->s_type->i_mutex_key#25){+.+.}, at: do_truncate+0x125/0x1f0 fs/open.c:61 #2: 000000004a3c5d3b (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_truncate+0x1e2/0x1040 fs/hfsplus/extents.c:576 stack backtrace: CPU: 0 PID: 11763 Comm: syz-executor.2 Not tainted 4.19.211-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1fc/0x2ef lib/dump_stack.c:118 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222 check_prev_add kernel/locking/lockdep.c:1866 [inline] check_prevs_add kernel/locking/lockdep.c:1979 [inline] validate_chain kernel/locking/lockdep.c:2420 [inline] __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908 __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 hfsplus_block_free+0xdb/0x5d0 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x228/0x520 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0xd96/0x1040 fs/hfsplus/extents.c:591 hfsplus_setattr+0x1e7/0x310 fs/hfsplus/inode.c:263 notify_change+0x70b/0xfc0 fs/attr.c:334 do_truncate+0x134/0x1f0 fs/open.c:63 handle_truncate fs/namei.c:3009 [inline] do_last fs/namei.c:3427 [inline] path_openat+0x2308/0x2df0 fs/namei.c:3537 do_filp_open+0x18c/0x3f0 fs/namei.c:3567 do_sys_open+0x3b3/0x520 fs/open.c:1085 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7f9c41b130d9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f9c40085168 EFLAGS: 00000246 ORIG_RAX: 0000000000000002 RAX: ffffffffffffffda RBX: 00007f9c41c32f80 RCX: 00007f9c41b130d9 RDX: 0000000000000000 RSI: 0000000000143242 RDI: 0000000020000000 RBP: 00007f9c41b6eae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffe75bb835f R14: 00007f9c40085300 R15: 0000000000022000 kvm: vcpu 0: requested 8 ns lapic timer period limited to 200000 ns syz-executor.1 (11926) used greatest stack depth: 22704 bytes left IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 kvm: vcpu 0: requested 8 ns lapic timer period limited to 200000 ns EXT4-fs (loop2): mounted filesystem without journal. Opts: ,errors=continue 9pnet: Insufficient options for proto=fd kvm: vcpu 0: requested 8 ns lapic timer period limited to 200000 ns EXT4-fs (loop2): mounted filesystem without journal. Opts: ,errors=continue 9pnet: Insufficient options for proto=fd kvm: vcpu 0: requested 8 ns lapic timer period limited to 200000 ns kvm: vcpu 0: requested 8 ns lapic timer period limited to 200000 ns EXT4-fs (loop2): mounted filesystem without journal. Opts: ,errors=continue EXT4-fs (loop5): mounted filesystem without journal. Opts: ,errors=continue 9pnet: Insufficient options for proto=fd 9pnet: Insufficient options for proto=fd EXT4-fs (loop2): mounted filesystem without journal. Opts: ,errors=continue 9pnet: Insufficient options for proto=fd EXT4-fs (loop2): mounted filesystem without journal. Opts: ,errors=continue bridge: RTM_NEWNEIGH with invalid state 0x0 ebtables: ebtables: counters copy to user failed while replacing table 9pnet: Insufficient options for proto=fd bridge: RTM_NEWNEIGH with invalid state 0x0 ebtables: ebtables: counters copy to user failed while replacing table EXT4-fs (loop2): mounted filesystem without journal. Opts: ,errors=continue bridge: RTM_NEWNEIGH with invalid state 0x0 ebtables: ebtables: counters copy to user failed while replacing table 9pnet: Insufficient options for proto=fd kvm: vcpu 0: requested 8 ns lapic timer period limited to 200000 ns kvm: vcpu 0: requested 8 ns lapic timer period limited to 200000 ns EXT4-fs (loop2): mounted filesystem without journal. Opts: ,errors=continue kvm: vcpu 0: requested 8 ns lapic timer period limited to 200000 ns EXT4-fs (loop5): mounted filesystem without journal. Opts: ,errors=continue 9pnet: Insufficient options for proto=fd 9pnet: Insufficient options for proto=fd kvm: vcpu 0: requested 8 ns lapic timer period limited to 200000 ns kvm: vcpu 0: requested 8 ns lapic timer period limited to 200000 ns kvm: vcpu 0: requested 8 ns lapic timer period limited to 200000 ns kvm: vcpu 0: requested 8 ns lapic timer period limited to 200000 ns EXT4-fs (loop2): mounted filesystem without journal. Opts: ,errors=continue EXT4-fs (loop5): mounted filesystem without journal. Opts: ,errors=continue 9pnet: Insufficient options for proto=fd 9pnet: Insufficient options for proto=fd kvm: vcpu 0: requested 8 ns lapic timer period limited to 200000 ns kvm: vcpu 0: requested 8 ns lapic timer period limited to 200000 ns