======================================================
WARNING: possible circular locking dependency detected
4.19.211-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.0/28630 is trying to acquire lock:
000000000c43dfef (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_get_block+0x292/0x960 fs/hfsplus/extents.c:260

but task is already holding lock:
0000000058836810 (&sbi->alloc_mutex){+.+.}, at: hfsplus_block_allocate+0xe0/0xa60 fs/hfsplus/bitmap.c:35

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&sbi->alloc_mutex){+.+.}:
       hfsplus_block_allocate+0xe0/0xa60 fs/hfsplus/bitmap.c:35
       hfsplus_file_extend+0x436/0xf40 fs/hfsplus/extents.c:468
       hfsplus_get_block+0x196/0x960 fs/hfsplus/extents.c:245
       __block_write_full_page+0x2fc/0xf60 fs/buffer.c:1730
       block_write_full_page+0x1f3/0x260 fs/buffer.c:2951
       __mpage_writepage+0x6b1/0x1570 fs/mpage.c:678
       write_cache_pages+0x802/0x12d0 mm/page-writeback.c:2240
       mpage_writepages+0xd1/0x230 fs/mpage.c:730
       do_writepages+0xe5/0x290 mm/page-writeback.c:2344
       __filemap_fdatawrite_range+0x27d/0x350 mm/filemap.c:446
       __filemap_fdatawrite mm/filemap.c:454 [inline]
       filemap_fdatawrite mm/filemap.c:459 [inline]
       filemap_write_and_wait mm/filemap.c:640 [inline]
       filemap_write_and_wait+0x42/0xd0 mm/filemap.c:635
       hfsplus_file_fsync+0x399/0x4f0 fs/hfsplus/inode.c:317
       vfs_fsync_range+0x13a/0x220 fs/sync.c:197
       generic_write_sync include/linux/fs.h:2750 [inline]
       generic_file_write_iter+0x4be/0x730 mm/filemap.c:3327
       call_write_iter include/linux/fs.h:1821 [inline]
       new_sync_write fs/read_write.c:474 [inline]
       __vfs_write+0x51b/0x770 fs/read_write.c:487
       vfs_write+0x1f3/0x540 fs/read_write.c:549
       ksys_write+0x12b/0x2a0 fs/read_write.c:599
       do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

-> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:937 [inline]
       __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078
       hfsplus_get_block+0x292/0x960 fs/hfsplus/extents.c:260
       block_read_full_page+0x288/0xd10 fs/buffer.c:2259
       do_read_cache_page+0x533/0x1170 mm/filemap.c:2828
       read_mapping_page include/linux/pagemap.h:402 [inline]
       hfsplus_block_allocate+0x197/0xa60 fs/hfsplus/bitmap.c:37
       hfsplus_file_extend+0x436/0xf40 fs/hfsplus/extents.c:468
       hfsplus_get_block+0x196/0x960 fs/hfsplus/extents.c:245
       __block_write_begin_int+0x46c/0x17b0 fs/buffer.c:1978
       __block_write_begin fs/buffer.c:2028 [inline]
       block_write_begin+0x58/0x2e0 fs/buffer.c:2087
       cont_write_begin+0x55a/0x820 fs/buffer.c:2440
       hfsplus_write_begin+0x87/0x150 fs/hfsplus/inode.c:52
       generic_perform_write+0x1f8/0x4d0 mm/filemap.c:3170
       __generic_file_write_iter+0x24b/0x610 mm/filemap.c:3295
       generic_file_write_iter+0x3f8/0x730 mm/filemap.c:3323
       call_write_iter include/linux/fs.h:1821 [inline]
       new_sync_write fs/read_write.c:474 [inline]
       __vfs_write+0x51b/0x770 fs/read_write.c:487
       vfs_write+0x1f3/0x540 fs/read_write.c:549
       ksys_write+0x12b/0x2a0 fs/read_write.c:599
       do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sbi->alloc_mutex);
                               lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&sbi->alloc_mutex);
  lock(&HFSPLUS_I(inode)->extents_lock);

 *** DEADLOCK ***

5 locks held by syz-executor.0/28630:
 #0: 00000000f515c09c (&f->f_pos_lock){+.+.}, at: __fdget_pos+0x26f/0x310 fs/file.c:767
 #1: 00000000a72f68b1 (sb_writers#14){.+.+}, at: file_start_write include/linux/fs.h:2779 [inline]
 #1: 00000000a72f68b1 (sb_writers#14){.+.+}, at: vfs_write+0x463/0x540 fs/read_write.c:548
 #2: 00000000d2d8744a (&sb->s_type->i_mutex_key#22){+.+.}, at: inode_lock include/linux/fs.h:748 [inline]
 #2: 00000000d2d8744a (&sb->s_type->i_mutex_key#22){+.+.}, at: generic_file_write_iter+0x99/0x730 mm/filemap.c:3320
 #3: 00000000e2a5ddde (&hip->extents_lock){+.+.}, at: hfsplus_file_extend+0x1bb/0xf40 fs/hfsplus/extents.c:457
 #4: 0000000058836810 (&sbi->alloc_mutex){+.+.}, at: hfsplus_block_allocate+0xe0/0xa60 fs/hfsplus/bitmap.c:35

stack backtrace:
CPU: 1 PID: 28630 Comm: syz-executor.0 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/21/2023
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222
 check_prev_add kernel/locking/lockdep.c:1866 [inline]
 check_prevs_add kernel/locking/lockdep.c:1979 [inline]
 validate_chain kernel/locking/lockdep.c:2420 [inline]
 __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416
 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908
 __mutex_lock_common kernel/locking/mutex.c:937 [inline]
 __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078
 hfsplus_get_block+0x292/0x960 fs/hfsplus/extents.c:260
 block_read_full_page+0x288/0xd10 fs/buffer.c:2259
 do_read_cache_page+0x533/0x1170 mm/filemap.c:2828
 read_mapping_page include/linux/pagemap.h:402 [inline]
 hfsplus_block_allocate+0x197/0xa60 fs/hfsplus/bitmap.c:37
 hfsplus_file_extend+0x436/0xf40 fs/hfsplus/extents.c:468
 hfsplus_get_block+0x196/0x960 fs/hfsplus/extents.c:245
 __block_write_begin_int+0x46c/0x17b0 fs/buffer.c:1978
 __block_write_begin fs/buffer.c:2028 [inline]
 block_write_begin+0x58/0x2e0 fs/buffer.c:2087
 cont_write_begin+0x55a/0x820 fs/buffer.c:2440
 hfsplus_write_begin+0x87/0x150 fs/hfsplus/inode.c:52
 generic_perform_write+0x1f8/0x4d0 mm/filemap.c:3170
 __generic_file_write_iter+0x24b/0x610 mm/filemap.c:3295
 generic_file_write_iter+0x3f8/0x730 mm/filemap.c:3323
 call_write_iter include/linux/fs.h:1821 [inline]
 new_sync_write fs/read_write.c:474 [inline]
 __vfs_write+0x51b/0x770 fs/read_write.c:487
 vfs_write+0x1f3/0x540 fs/read_write.c:549
 ksys_write+0x12b/0x2a0 fs/read_write.c:599
 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f2a179730f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f2a15ee5168 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f2a17a92f80 RCX: 00007f2a179730f9
RDX: 0000000000000081 RSI: 0000000020000300 RDI: 0000000000000004
RBP: 00007f2a179ceae9 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fffcf7f65ef R14: 00007f2a15ee5300 R15: 0000000000022000
nla_parse: 391 callbacks suppressed
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
sch_tbf: peakrate 3 is lower than or equals to rate 14 !
sch_tbf: peakrate 3 is lower than or equals to rate 14 !
sch_tbf: peakrate 3 is lower than or equals to rate 14 !
dlm: non-version read from control device 218
nla_parse: 470 callbacks suppressed
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'.