====================================================== WARNING: possible circular locking dependency detected 6.1.83-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/8505 is trying to acquire lock: ffff0000e27d70e0 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x2ac/0x1850 fs/ext4/inode.c:574 but task is already holding lock: ffff0000d2e38208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x11c/0x188 fs/quota/quota_v2.c:354 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: down_read+0x64/0x308 kernel/locking/rwsem.c:1520 v2_read_dquot+0x50/0x11c fs/quota/quota_v2.c:332 dquot_acquire+0x130/0x5c4 fs/quota/dquot.c:463 ext4_acquire_dquot+0x270/0x398 fs/ext4/super.c:6769 dqget+0x660/0xcb4 fs/quota/dquot.c:986 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1516 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1578 ext4_process_orphan+0x5c/0x2b8 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x974/0x1134 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5533 [inline] ext4_fill_super+0x6f04/0x7570 fs/ext4/super.c:5664 get_tree_bdev+0x360/0x54c fs/super.c:1355 ext4_get_tree+0x28/0x38 fs/ext4/super.c:5694 vfs_get_tree+0x90/0x274 fs/super.c:1562 do_new_mount+0x278/0x8fc fs/namespace.c:3051 path_mount+0x590/0xe5c fs/namespace.c:3381 do_mount fs/namespace.c:3394 [inline] __do_sys_mount fs/namespace.c:3602 [inline] __se_sys_mount fs/namespace.c:3579 [inline] __arm64_sys_mount+0x45c/0x594 fs/namespace.c:3579 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #1 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 dquot_commit+0x54/0x240 fs/quota/dquot.c:507 ext4_write_dquot+0x1b0/0x284 fs/ext4/super.c:6753 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6801 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0x1f8/0x424 fs/quota/dquot.c:412 __dquot_alloc_space+0xb28/0xf50 fs/quota/dquot.c:1751 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0xf04/0x468c fs/ext4/mballoc.c:5658 ext4_ext_map_blocks+0x15a8/0x6644 fs/ext4/extents.c:4316 ext4_map_blocks+0x828/0x1850 fs/ext4/inode.c:651 _ext4_get_block+0x1c0/0x5a0 fs/ext4/inode.c:798 ext4_get_block+0x4c/0x60 fs/ext4/inode.c:815 ext4_block_write_begin+0x500/0x1130 fs/ext4/inode.c:1100 ext4_write_begin+0x620/0x138c generic_perform_write+0x278/0x55c mm/filemap.c:3817 ext4_buffered_write_iter+0x2e0/0x538 fs/ext4/file.c:285 ext4_file_write_iter+0x18c/0x1638 call_write_iter include/linux/fs.h:2265 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x610/0x914 fs/read_write.c:584 ksys_write+0x15c/0x26c fs/read_write.c:637 __do_sys_write fs/read_write.c:649 [inline] __se_sys_write fs/read_write.c:646 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:646 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 down_read+0x64/0x308 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x2ac/0x1850 fs/ext4/inode.c:574 ext4_getblk+0x198/0x6ec fs/ext4/inode.c:866 ext4_bread+0x3c/0x1b0 fs/ext4/inode.c:922 ext4_quota_write+0x230/0x54c fs/ext4/super.c:7135 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x28c/0x598 fs/quota/quota_tree.c:130 do_insert_tree+0x1fc/0x1474 fs/quota/quota_tree.c:340 do_insert_tree+0x510/0x1474 fs/quota/quota_tree.c:375 do_insert_tree+0x510/0x1474 fs/quota/quota_tree.c:375 do_insert_tree+0x510/0x1474 fs/quota/quota_tree.c:375 dq_insert_tree fs/quota/quota_tree.c:401 [inline] qtree_write_dquot+0x318/0x488 fs/quota/quota_tree.c:420 v2_write_dquot+0xf4/0x188 fs/quota/quota_v2.c:358 dquot_acquire+0x2c4/0x5c4 fs/quota/dquot.c:472 ext4_acquire_dquot+0x270/0x398 fs/ext4/super.c:6769 dqget+0x660/0xcb4 fs/quota/dquot.c:986 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1516 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1578 ext4_create+0xb4/0x480 fs/ext4/namei.c:2827 lookup_open fs/namei.c:3484 [inline] open_last_lookups fs/namei.c:3552 [inline] path_openat+0xeac/0x2548 fs/namei.c:3782 do_filp_open+0x1bc/0x3cc fs/namei.c:3812 do_sys_openat2+0x128/0x3d8 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1345 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 4 locks held by syz-executor.2/8505: #0: ffff0000d2e38460 (sb_writers#3){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:393 #1: ffff0000e27d5e48 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff0000e27d5e48 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: open_last_lookups fs/namei.c:3549 [inline] #1: ffff0000e27d5e48 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: path_openat+0x5ec/0x2548 fs/namei.c:3782 #2: ffff0000e2680268 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x68/0x5c4 fs/quota/dquot.c:460 #3: ffff0000d2e38208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x11c/0x188 fs/quota/quota_v2.c:354 stack backtrace: CPU: 1 PID: 8505 Comm: syz-executor.2 Not tainted 6.1.83-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x5c lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 down_read+0x64/0x308 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x2ac/0x1850 fs/ext4/inode.c:574 ext4_getblk+0x198/0x6ec fs/ext4/inode.c:866 ext4_bread+0x3c/0x1b0 fs/ext4/inode.c:922 ext4_quota_write+0x230/0x54c fs/ext4/super.c:7135 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x28c/0x598 fs/quota/quota_tree.c:130 do_insert_tree+0x1fc/0x1474 fs/quota/quota_tree.c:340 do_insert_tree+0x510/0x1474 fs/quota/quota_tree.c:375 do_insert_tree+0x510/0x1474 fs/quota/quota_tree.c:375 do_insert_tree+0x510/0x1474 fs/quota/quota_tree.c:375 dq_insert_tree fs/quota/quota_tree.c:401 [inline] qtree_write_dquot+0x318/0x488 fs/quota/quota_tree.c:420 v2_write_dquot+0xf4/0x188 fs/quota/quota_v2.c:358 dquot_acquire+0x2c4/0x5c4 fs/quota/dquot.c:472 ext4_acquire_dquot+0x270/0x398 fs/ext4/super.c:6769 dqget+0x660/0xcb4 fs/quota/dquot.c:986 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1516 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1578 ext4_create+0xb4/0x480 fs/ext4/namei.c:2827 lookup_open fs/namei.c:3484 [inline] open_last_lookups fs/namei.c:3552 [inline] path_openat+0xeac/0x2548 fs/namei.c:3782 do_filp_open+0x1bc/0x3cc fs/namei.c:3812 do_sys_openat2+0x128/0x3d8 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1345 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 EXT4-fs error (device loop2): ext4_do_update_inode:5210: inode #3: comm syz-executor.2: corrupted inode contents EXT4-fs error (device loop2): ext4_dirty_inode:6072: inode #3: comm syz-executor.2: mark_inode_dirty error EXT4-fs error (device loop2): ext4_validate_block_bitmap:438: comm syz-executor.2: bg 0: block 64: padding at end of block bitmap is not set Quota error (device loop2): write_blk: dquota write failed Quota error (device loop2): qtree_write_dquot: Error -117 occurred while creating quota