====================================================== WARNING: possible circular locking dependency detected 5.15.133-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/16680 is trying to acquire lock: ffff88802dd7d238 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x3a6/0x1e00 fs/ext4/inode.c:568 but task is already holding lock: ffff888053eba208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1488 v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332 dquot_acquire+0x188/0x680 fs/quota/dquot.c:459 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6180 dqget+0x752/0xe30 fs/quota/dquot.c:972 __dquot_initialize+0x2d9/0xe10 fs/quota/dquot.c:1550 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x9d9/0x1240 fs/ext4/orphan.c:474 ext4_fill_super+0x98de/0xa110 fs/ext4/super.c:4966 mount_bdev+0x2c9/0x3f0 fs/super.c:1387 legacy_get_tree+0xeb/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1517 do_new_mount+0x28b/0xae0 fs/namespace.c:2994 do_mount fs/namespace.c:3337 [inline] __do_sys_mount fs/namespace.c:3545 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3522 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb -> #1 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 dquot_commit+0x57/0x510 fs/quota/dquot.c:503 ext4_write_dquot+0x1e8/0x2b0 fs/ext4/super.c:6164 mark_dquot_dirty fs/quota/dquot.c:370 [inline] mark_all_dquot_dirty fs/quota/dquot.c:408 [inline] __dquot_alloc_space+0x53a/0xf30 fs/quota/dquot.c:1780 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline] dquot_alloc_space include/linux/quotaops.h:310 [inline] dquot_alloc_block include/linux/quotaops.h:334 [inline] ext4_mb_new_blocks+0x12bb/0x4d50 fs/ext4/mballoc.c:5646 ext4_new_meta_blocks+0x206/0x4f0 fs/ext4/balloc.c:738 ext4_alloc_branch fs/ext4/indirect.c:342 [inline] ext4_ind_map_blocks+0x1193/0x29d0 fs/ext4/indirect.c:635 ext4_map_blocks+0xa47/0x1e00 fs/ext4/inode.c:647 _ext4_get_block+0x23b/0x660 fs/ext4/inode.c:792 ext4_block_write_begin+0x6b0/0x13a0 fs/ext4/inode.c:1077 ext4_write_begin+0x6c6/0x15f0 generic_perform_write+0x2bf/0x5b0 mm/filemap.c:3776 ext4_buffered_write_iter+0x227/0x360 fs/ext4/file.c:268 ext4_dio_write_iter fs/ext4/file.c:590 [inline] ext4_file_write_iter+0x14d2/0x1990 fs/ext4/file.c:681 call_write_iter include/linux/fs.h:2103 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0xacf/0xe50 fs/read_write.c:594 ksys_write+0x1a2/0x2c0 fs/read_write.c:647 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1488 ext4_map_blocks+0x3a6/0x1e00 fs/ext4/inode.c:568 ext4_getblk+0x19f/0x710 fs/ext4/inode.c:846 ext4_bread+0x2a/0x170 fs/ext4/inode.c:899 ext4_quota_read+0x1a1/0x2c0 fs/ext4/super.c:6500 read_blk fs/quota/quota_tree.c:55 [inline] find_tree_dqentry+0x192/0xb60 fs/quota/quota_tree.c:617 find_tree_dqentry+0x41a/0xb60 fs/quota/quota_tree.c:635 find_tree_dqentry+0x41a/0xb60 fs/quota/quota_tree.c:635 find_tree_dqentry+0x41a/0xb60 fs/quota/quota_tree.c:635 find_dqentry fs/quota/quota_tree.c:647 [inline] qtree_read_dquot+0x13f/0x650 fs/quota/quota_tree.c:667 v2_read_dquot+0xbe/0x100 fs/quota/quota_v2.c:333 dquot_acquire+0x188/0x680 fs/quota/dquot.c:459 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6180 dqget+0x752/0xe30 fs/quota/dquot.c:972 __dquot_initialize+0x2d9/0xe10 fs/quota/dquot.c:1550 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x9d9/0x1240 fs/ext4/orphan.c:474 ext4_fill_super+0x98de/0xa110 fs/ext4/super.c:4966 mount_bdev+0x2c9/0x3f0 fs/super.c:1387 legacy_get_tree+0xeb/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1517 do_new_mount+0x28b/0xae0 fs/namespace.c:2994 do_mount fs/namespace.c:3337 [inline] __do_sys_mount fs/namespace.c:3545 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3522 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 3 locks held by syz-executor.2/16680: #0: ffff888053eba0e0 (&type->s_umount_key#28/1){+.+.}-{3:3}, at: alloc_super+0x210/0x940 fs/super.c:229 #1: ffff888026f35ca8 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x64/0x680 fs/quota/dquot.c:456 #2: ffff888053eba208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332 stack backtrace: CPU: 0 PID: 16680 Comm: syz-executor.2 Not tainted 5.15.133-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1488 ext4_map_blocks+0x3a6/0x1e00 fs/ext4/inode.c:568 ext4_getblk+0x19f/0x710 fs/ext4/inode.c:846 ext4_bread+0x2a/0x170 fs/ext4/inode.c:899 ext4_quota_read+0x1a1/0x2c0 fs/ext4/super.c:6500 read_blk fs/quota/quota_tree.c:55 [inline] find_tree_dqentry+0x192/0xb60 fs/quota/quota_tree.c:617 find_tree_dqentry+0x41a/0xb60 fs/quota/quota_tree.c:635 find_tree_dqentry+0x41a/0xb60 fs/quota/quota_tree.c:635 find_tree_dqentry+0x41a/0xb60 fs/quota/quota_tree.c:635 find_dqentry fs/quota/quota_tree.c:647 [inline] qtree_read_dquot+0x13f/0x650 fs/quota/quota_tree.c:667 v2_read_dquot+0xbe/0x100 fs/quota/quota_v2.c:333 dquot_acquire+0x188/0x680 fs/quota/dquot.c:459 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6180 dqget+0x752/0xe30 fs/quota/dquot.c:972 __dquot_initialize+0x2d9/0xe10 fs/quota/dquot.c:1550 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x9d9/0x1240 fs/ext4/orphan.c:474 ext4_fill_super+0x98de/0xa110 fs/ext4/super.c:4966 mount_bdev+0x2c9/0x3f0 fs/super.c:1387 legacy_get_tree+0xeb/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1517 do_new_mount+0x28b/0xae0 fs/namespace.c:2994 do_mount fs/namespace.c:3337 [inline] __do_sys_mount fs/namespace.c:3545 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3522 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb RIP: 0033:0x7f5ddaa321ea Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 09 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f5dd8fb1ee8 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007f5dd8fb1f80 RCX: 00007f5ddaa321ea RDX: 0000000020000000 RSI: 0000000020000500 RDI: 00007f5dd8fb1f40 RBP: 0000000020000000 R08: 00007f5dd8fb1f80 R09: 0000000000000802 R10: 0000000000000802 R11: 0000000000000202 R12: 0000000020000500 R13: 00007f5dd8fb1f40 R14: 0000000000000510 R15: 0000000020000040 EXT4-fs error (device loop2): ext4_validate_block_bitmap:438: comm syz-executor.2: bg 0: block 97: padding at end of block bitmap is not set Quota error (device loop2): write_blk: dquota write failed Quota error (device loop2): qtree_write_dquot: Error -117 occurred while creating quota EXT4-fs error (device loop2): ext4_xattr_delete_inode:2925: inode #15: comm syz-executor.2: corrupted xattr block 19 EXT4-fs warning (device loop2): ext4_evict_inode:302: xattr delete (err -117) EXT4-fs (loop2): 1 orphan inode deleted EXT4-fs (loop2): mounted filesystem without journal. Opts: ,errors=continue. Quota mode: writeback. ext4 filesystem being mounted at /root/syzkaller-testdir1164339385/syzkaller.uXk1Gc/572/file0 supports timestamps until 2038 (0x7fffffff)