vcan0: j1939_tp_rxtimer: 0xffff88807d1b0800: rx timeout, send abort ====================================================== WARNING: possible circular locking dependency detected 5.19.0-rc3-syzkaller-00271-g6a0a17e6c6d1 #0 Not tainted ------------------------------------------------------ syz-executor.5/3651 is trying to acquire lock: ffff88807ef790d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline] ffff88807ef790d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: j1939_sk_errqueue+0x9f/0x1a0 net/can/j1939/socket.c:1078 but task is already holding lock: ffff88807ef79088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline] ffff88807ef79088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline] ffff88807ef79088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_tp_rxtimer+0xe5/0x220 net/can/j1939/transport.c:1240 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&priv->active_session_list_lock){+.-.}-{2:2}: __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:354 [inline] j1939_session_list_lock net/can/j1939/transport.c:238 [inline] j1939_session_activate+0x43/0x4b0 net/can/j1939/transport.c:1553 j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline] j1939_sk_queue_activate_next+0x29b/0x460 net/can/j1939/socket.c:205 j1939_session_deactivate_activate_next net/can/j1939/transport.c:1101 [inline] j1939_session_completed+0x19a/0x1f0 net/can/j1939/transport.c:1214 j1939_xtp_rx_eoma_one net/can/j1939/transport.c:1384 [inline] j1939_xtp_rx_eoma+0x2a6/0x5f0 net/can/j1939/transport.c:1399 j1939_tp_cmd_recv net/can/j1939/transport.c:2088 [inline] j1939_tp_recv+0x930/0xcb0 net/can/j1939/transport.c:2133 j1939_can_recv+0x6ff/0x9a0 net/can/j1939/main.c:108 deliver net/can/af_can.c:574 [inline] can_rcv_filter+0x5d4/0x8d0 net/can/af_can.c:608 can_receive+0x31d/0x580 net/can/af_can.c:665 can_rcv+0x120/0x1c0 net/can/af_can.c:696 __netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:5480 __netif_receive_skb+0x24/0x1b0 net/core/dev.c:5594 process_backlog+0x3a0/0x7c0 net/core/dev.c:5922 __napi_poll+0xb3/0x6e0 net/core/dev.c:6488 napi_poll net/core/dev.c:6555 [inline] net_rx_action+0x9c1/0xd90 net/core/dev.c:6666 __do_softirq+0x29b/0x9c2 kernel/softirq.c:571 run_ksoftirqd kernel/softirq.c:934 [inline] run_ksoftirqd+0x2d/0x60 kernel/softirq.c:926 smpboot_thread_fn+0x645/0x9c0 kernel/smpboot.c:164 kthread+0x2e9/0x3a0 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:302 -> #1 (&jsk->sk_session_queue_lock){+.-.}-{2:2}: __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:354 [inline] j1939_sk_queue_drop_all+0x40/0x2f0 net/can/j1939/socket.c:139 j1939_sk_netdev_event_netdown+0x7b/0x160 net/can/j1939/socket.c:1272 j1939_netdev_notify+0x199/0x1d0 net/can/j1939/main.c:372 notifier_call_chain+0xb5/0x200 kernel/notifier.c:87 call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1945 call_netdevice_notifiers_extack net/core/dev.c:1983 [inline] call_netdevice_notifiers net/core/dev.c:1997 [inline] __dev_notify_flags+0x1da/0x2b0 net/core/dev.c:8573 dev_change_flags+0x112/0x170 net/core/dev.c:8609 do_setlink+0x961/0x3bb0 net/core/rtnetlink.c:2780 __rtnl_newlink+0xd6a/0x17e0 net/core/rtnetlink.c:3546 rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3593 rtnetlink_rcv_msg+0x43a/0xc90 net/core/rtnetlink.c:6089 netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2501 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline] netlink_unicast+0x543/0x7f0 net/netlink/af_netlink.c:1345 netlink_sendmsg+0x917/0xe10 net/netlink/af_netlink.c:1921 sock_sendmsg_nosec net/socket.c:714 [inline] sock_sendmsg+0xcf/0x120 net/socket.c:734 ____sys_sendmsg+0x6eb/0x810 net/socket.c:2492 ___sys_sendmsg+0xf3/0x170 net/socket.c:2546 __sys_sendmsg+0xec/0x1b0 net/socket.c:2575 do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline] __do_fast_syscall_32+0x65/0xf0 arch/x86/entry/common.c:178 do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:203 entry_SYSENTER_compat_after_hwframe+0x53/0x62 -> #0 (&priv->j1939_socks_lock){+.-.}-{2:2}: check_prev_add kernel/locking/lockdep.c:3095 [inline] check_prevs_add kernel/locking/lockdep.c:3214 [inline] validate_chain kernel/locking/lockdep.c:3829 [inline] __lock_acquire+0x2abe/0x5660 kernel/locking/lockdep.c:5053 lock_acquire kernel/locking/lockdep.c:5665 [inline] lock_acquire+0x1ab/0x570 kernel/locking/lockdep.c:5630 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:354 [inline] j1939_sk_errqueue+0x9f/0x1a0 net/can/j1939/socket.c:1078 __j1939_session_cancel+0x3b9/0x460 net/can/j1939/transport.c:1124 j1939_tp_rxtimer.cold+0x1f6/0x24f net/can/j1939/transport.c:1249 __run_hrtimer kernel/time/hrtimer.c:1685 [inline] __hrtimer_run_queues+0x609/0xe50 kernel/time/hrtimer.c:1749 hrtimer_run_softirq+0x17b/0x360 kernel/time/hrtimer.c:1766 __do_softirq+0x29b/0x9c2 kernel/softirq.c:571 invoke_softirq kernel/softirq.c:445 [inline] __irq_exit_rcu+0x123/0x180 kernel/softirq.c:650 irq_exit_rcu+0x5/0x20 kernel/softirq.c:662 sysvec_apic_timer_interrupt+0x93/0xc0 arch/x86/kernel/apic/apic.c:1106 asm_sysvec_apic_timer_interrupt+0x1b/0x20 arch/x86/include/asm/idtentry.h:649 lock_is_held_type+0xff/0x140 kernel/locking/lockdep.c:5713 lock_is_held include/linux/lockdep.h:279 [inline] task_css include/linux/cgroup.h:495 [inline] mem_cgroup_from_task+0x77/0x130 mm/memcontrol.c:907 get_obj_cgroup_from_current+0x10e/0x250 mm/memcontrol.c:2923 memcg_slab_pre_alloc_hook mm/slab.h:489 [inline] slab_pre_alloc_hook mm/slab.h:728 [inline] slab_alloc_node mm/slub.c:3157 [inline] slab_alloc mm/slub.c:3251 [inline] __kmem_cache_alloc_lru mm/slub.c:3258 [inline] kmem_cache_alloc+0x78/0x3b0 mm/slub.c:3268 anon_vma_chain_alloc mm/rmap.c:140 [inline] anon_vma_clone+0xe0/0x5f0 mm/rmap.c:286 anon_vma_fork+0x82/0x630 mm/rmap.c:349 dup_mmap kernel/fork.c:658 [inline] dup_mm+0xa07/0x1390 kernel/fork.c:1524 copy_mm kernel/fork.c:1576 [inline] copy_process+0x3bba/0x7020 kernel/fork.c:2240 kernel_clone+0xe7/0xab0 kernel/fork.c:2655 __do_compat_sys_ia32_clone+0x9e/0xd0 arch/x86/kernel/sys_ia32.c:254 do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline] __do_fast_syscall_32+0x65/0xf0 arch/x86/entry/common.c:178 do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:203 entry_SYSENTER_compat_after_hwframe+0x53/0x62 other info that might help us debug this: Chain exists of: &priv->j1939_socks_lock --> &jsk->sk_session_queue_lock --> &priv->active_session_list_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&priv->active_session_list_lock); lock(&jsk->sk_session_queue_lock); lock(&priv->active_session_list_lock); lock(&priv->j1939_socks_lock); *** DEADLOCK *** 6 locks held by syz-executor.5/3651: #0: ffffffff8be67290 (dup_mmap_sem){.+.+}-{0:0}, at: dup_mmap kernel/fork.c:589 [inline] #0: ffffffff8be67290 (dup_mmap_sem){.+.+}-{0:0}, at: dup_mm+0x108/0x1390 kernel/fork.c:1524 #1: ffff888077c06328 (&mm->mmap_lock#2){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:87 [inline] #1: ffff888077c06328 (&mm->mmap_lock#2){++++}-{3:3}, at: dup_mmap kernel/fork.c:590 [inline] #1: ffff888077c06328 (&mm->mmap_lock#2){++++}-{3:3}, at: dup_mm+0x12e/0x1390 kernel/fork.c:1524 #2: ffff88807ecc4e28 (&mm->mmap_lock/1){+.+.}-{3:3}, at: mmap_write_lock_nested include/linux/mmap_lock.h:78 [inline] #2: ffff88807ecc4e28 (&mm->mmap_lock/1){+.+.}-{3:3}, at: dup_mmap kernel/fork.c:599 [inline] #2: ffff88807ecc4e28 (&mm->mmap_lock/1){+.+.}-{3:3}, at: dup_mm+0x18a/0x1390 kernel/fork.c:1524 #3: ffff888073232678 (&anon_vma->rwsem){++++}-{3:3}, at: lock_anon_vma_root mm/rmap.c:249 [inline] #3: ffff888073232678 (&anon_vma->rwsem){++++}-{3:3}, at: anon_vma_clone+0x145/0x5f0 mm/rmap.c:295 #4: ffffffff8bd86660 (rcu_read_lock){....}-{1:2}, at: memcg_kmem_bypass mm/memcontrol.c:976 [inline] #4: ffffffff8bd86660 (rcu_read_lock){....}-{1:2}, at: get_obj_cgroup_from_current+0xae/0x250 mm/memcontrol.c:2916 #5: ffff88807ef79088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline] #5: ffff88807ef79088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline] #5: ffff88807ef79088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_tp_rxtimer+0xe5/0x220 net/can/j1939/transport.c:1240 stack backtrace: CPU: 0 PID: 3651 Comm: syz-executor.5 Not tainted 5.19.0-rc3-syzkaller-00271-g6a0a17e6c6d1 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2175 check_prev_add kernel/locking/lockdep.c:3095 [inline] check_prevs_add kernel/locking/lockdep.c:3214 [inline] validate_chain kernel/locking/lockdep.c:3829 [inline] __lock_acquire+0x2abe/0x5660 kernel/locking/lockdep.c:5053 lock_acquire kernel/locking/lockdep.c:5665 [inline] lock_acquire+0x1ab/0x570 kernel/locking/lockdep.c:5630 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:354 [inline] j1939_sk_errqueue+0x9f/0x1a0 net/can/j1939/socket.c:1078 __j1939_session_cancel+0x3b9/0x460 net/can/j1939/transport.c:1124 j1939_tp_rxtimer.cold+0x1f6/0x24f net/can/j1939/transport.c:1249 __run_hrtimer kernel/time/hrtimer.c:1685 [inline] __hrtimer_run_queues+0x609/0xe50 kernel/time/hrtimer.c:1749 hrtimer_run_softirq+0x17b/0x360 kernel/time/hrtimer.c:1766 __do_softirq+0x29b/0x9c2 kernel/softirq.c:571 invoke_softirq kernel/softirq.c:445 [inline] __irq_exit_rcu+0x123/0x180 kernel/softirq.c:650 irq_exit_rcu+0x5/0x20 kernel/softirq.c:662 sysvec_apic_timer_interrupt+0x93/0xc0 arch/x86/kernel/apic/apic.c:1106 asm_sysvec_apic_timer_interrupt+0x1b/0x20 arch/x86/include/asm/idtentry.h:649 RIP: 0010:lock_is_held_type+0xff/0x140 kernel/locking/lockdep.c:5713 Code: 00 00 b8 ff ff ff ff 65 0f c1 05 a4 80 8b 76 83 f8 01 75 29 9c 58 f6 c4 02 75 3d 48 f7 04 24 00 02 00 00 74 01 fb 48 83 c4 08 <44> 89 e8 5b 5d 41 5c 41 5d 41 5e 41 5f c3 45 31 ed eb b9 0f 0b 48 RSP: 0018:ffffc9000379f8f0 EFLAGS: 00000296 RAX: 0000000000000046 RBX: 0000000000000005 RCX: 0000000000000001 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 RBP: ffffffff8bdcb988 R08: 0000000000000000 R09: ffffffff9067d907 R10: fffffbfff20cfb20 R11: 0000000000000001 R12: ffff888024f10000 R13: 0000000000000000 R14: 00000000ffffffff R15: ffff888024f10b00 lock_is_held include/linux/lockdep.h:279 [inline] task_css include/linux/cgroup.h:495 [inline] mem_cgroup_from_task+0x77/0x130 mm/memcontrol.c:907 get_obj_cgroup_from_current+0x10e/0x250 mm/memcontrol.c:2923 memcg_slab_pre_alloc_hook mm/slab.h:489 [inline] slab_pre_alloc_hook mm/slab.h:728 [inline] slab_alloc_node mm/slub.c:3157 [inline] slab_alloc mm/slub.c:3251 [inline] __kmem_cache_alloc_lru mm/slub.c:3258 [inline] kmem_cache_alloc+0x78/0x3b0 mm/slub.c:3268 anon_vma_chain_alloc mm/rmap.c:140 [inline] anon_vma_clone+0xe0/0x5f0 mm/rmap.c:286 anon_vma_fork+0x82/0x630 mm/rmap.c:349 dup_mmap kernel/fork.c:658 [inline] dup_mm+0xa07/0x1390 kernel/fork.c:1524 copy_mm kernel/fork.c:1576 [inline] copy_process+0x3bba/0x7020 kernel/fork.c:2240 kernel_clone+0xe7/0xab0 kernel/fork.c:2655 __do_compat_sys_ia32_clone+0x9e/0xd0 arch/x86/kernel/sys_ia32.c:254 do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline] __do_fast_syscall_32+0x65/0xf0 arch/x86/entry/common.c:178 do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:203 entry_SYSENTER_compat_after_hwframe+0x53/0x62 RIP: 0023:0xf7fd7549 Code: 03 74 c0 01 10 05 03 74 b8 01 10 06 03 74 b4 01 10 07 03 74 b0 01 10 08 03 74 d8 01 00 00 00 00 00 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d b4 26 00 00 00 00 8d b4 26 00 00 00 00 RSP: 002b:00000000f748fd30 EFLAGS: 00000206 ORIG_RAX: 0000000000000078 RAX: ffffffffffffffda RBX: 0000000001200011 RCX: 0000000000000000 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 00000000583b93e8 RBP: 00000000f6f36000 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000282 R12: 0000000000000000 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 vcan0: j1939_tp_rxtimer: 0xffff88807d1b0800: abort rx timeout. Force session deactivation vcan0: j1939_tp_rxtimer: 0xffff88804645c000: rx timeout, send abort vcan0: j1939_tp_rxtimer: 0xffff88804645c000: abort rx timeout. Force session deactivation vcan0: j1939_tp_rxtimer: 0xffff88804ab26400: rx timeout, send abort vcan0: j1939_tp_rxtimer: 0xffff88804ab26000: rx timeout, send abort vcan0: j1939_tp_rxtimer: 0xffff88804ab26400: abort rx timeout. Force session deactivation vcan0: j1939_tp_rxtimer: 0xffff88804ab26000: abort rx timeout. Force session deactivation ---------------- Code disassembly (best guess): 0: 00 00 add %al,(%rax) 2: b8 ff ff ff ff mov $0xffffffff,%eax 7: 65 0f c1 05 a4 80 8b xadd %eax,%gs:0x768b80a4(%rip) # 0x768b80b3 e: 76 f: 83 f8 01 cmp $0x1,%eax 12: 75 29 jne 0x3d 14: 9c pushfq 15: 58 pop %rax 16: f6 c4 02 test $0x2,%ah 19: 75 3d jne 0x58 1b: 48 f7 04 24 00 02 00 testq $0x200,(%rsp) 22: 00 23: 74 01 je 0x26 25: fb sti 26: 48 83 c4 08 add $0x8,%rsp * 2a: 44 89 e8 mov %r13d,%eax <-- trapping instruction 2d: 5b pop %rbx 2e: 5d pop %rbp 2f: 41 5c pop %r12 31: 41 5d pop %r13 33: 41 5e pop %r14 35: 41 5f pop %r15 37: c3 retq 38: 45 31 ed xor %r13d,%r13d 3b: eb b9 jmp 0xfffffff6 3d: 0f 0b ud2 3f: 48 rex.W