vcan0: j1939_tp_rxtimer: 0xffff8880783e7c00: rx timeout, send abort vcan0: j1939_tp_rxtimer: 0xffff8880783e5000: rx timeout, send abort ====================================================== WARNING: possible circular locking dependency detected 6.3.0-rc3-syzkaller-00005-g7d31677bb7b1 #0 Not tainted ------------------------------------------------------ kworker/u4:10/31942 is trying to acquire lock: ffff88802c0550d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline] ffff88802c0550d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: j1939_sk_errqueue+0xa3/0x1a0 net/can/j1939/socket.c:1081 but task is already holding lock: ffff88802c055088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline] ffff88802c055088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline] ffff88802c055088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_tp_rxtimer+0xe4/0x4b0 net/can/j1939/transport.c:1244 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&priv->active_session_list_lock){+.-.}-{2:2}: __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_session_list_lock net/can/j1939/transport.c:238 [inline] j1939_session_activate+0x47/0x4b0 net/can/j1939/transport.c:1557 j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline] j1939_sk_queue_activate_next+0x2bf/0x4d0 net/can/j1939/socket.c:208 j1939_session_deactivate_activate_next net/can/j1939/transport.c:1105 [inline] j1939_session_completed+0xb6/0x170 net/can/j1939/transport.c:1218 j1939_xtp_rx_eoma_one net/can/j1939/transport.c:1388 [inline] j1939_xtp_rx_eoma+0x2a1/0x680 net/can/j1939/transport.c:1403 j1939_tp_cmd_recv net/can/j1939/transport.c:2092 [inline] j1939_tp_recv+0x71e/0xf50 net/can/j1939/transport.c:2137 j1939_can_recv net/can/j1939/main.c:112 [inline] j1939_can_recv+0x78e/0xa80 net/can/j1939/main.c:38 deliver net/can/af_can.c:572 [inline] can_rcv_filter+0x5d4/0x8d0 net/can/af_can.c:606 can_receive+0x31d/0x5c0 net/can/af_can.c:663 can_rcv+0x1e1/0x280 net/can/af_can.c:687 __netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:5479 __netif_receive_skb+0x1f/0x1c0 net/core/dev.c:5593 process_backlog+0x239/0x800 net/core/dev.c:5921 __napi_poll+0xb7/0x6f0 net/core/dev.c:6482 napi_poll net/core/dev.c:6549 [inline] net_rx_action+0x9c2/0xd80 net/core/dev.c:6659 __do_softirq+0x1d4/0x905 kernel/softirq.c:571 run_ksoftirqd kernel/softirq.c:934 [inline] run_ksoftirqd+0x31/0x60 kernel/softirq.c:926 smpboot_thread_fn+0x659/0x9e0 kernel/smpboot.c:164 kthread+0x2e8/0x3a0 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 -> #1 (&jsk->sk_session_queue_lock){+.-.}-{2:2}: __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_sk_queue_drop_all+0x3b/0x2f0 net/can/j1939/socket.c:139 j1939_sk_netdev_event_netdown+0x7f/0x160 net/can/j1939/socket.c:1275 j1939_netdev_notify+0x19d/0x1d0 net/can/j1939/main.c:379 notifier_call_chain+0xb5/0x200 kernel/notifier.c:87 call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1937 call_netdevice_notifiers_extack net/core/dev.c:1975 [inline] call_netdevice_notifiers net/core/dev.c:1989 [inline] __dev_notify_flags+0x1ea/0x2d0 net/core/dev.c:8568 dev_change_flags+0x11b/0x170 net/core/dev.c:8604 do_setlink+0x9f4/0x3d30 net/core/rtnetlink.c:2833 __rtnl_newlink+0xd69/0x1840 net/core/rtnetlink.c:3623 rtnl_newlink+0x68/0xa0 net/core/rtnetlink.c:3670 rtnetlink_rcv_msg+0x43d/0xd50 net/core/rtnetlink.c:6174 netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2574 netlink_unicast_kernel net/netlink/af_netlink.c:1339 [inline] netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1365 netlink_sendmsg+0x925/0xe30 net/netlink/af_netlink.c:1942 sock_sendmsg_nosec net/socket.c:724 [inline] sock_sendmsg+0xde/0x190 net/socket.c:747 ____sys_sendmsg+0x71c/0x900 net/socket.c:2501 ___sys_sendmsg+0x110/0x1b0 net/socket.c:2555 __sys_sendmsg+0xf7/0x1c0 net/socket.c:2584 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&priv->j1939_socks_lock){+.-.}-{2:2}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire kernel/locking/lockdep.c:5669 [inline] lock_acquire+0x1af/0x520 kernel/locking/lockdep.c:5634 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_sk_errqueue+0xa3/0x1a0 net/can/j1939/socket.c:1081 __j1939_session_cancel+0x3b9/0x460 net/can/j1939/transport.c:1128 j1939_tp_rxtimer+0x3df/0x4b0 net/can/j1939/transport.c:1253 __run_hrtimer kernel/time/hrtimer.c:1685 [inline] __hrtimer_run_queues+0x5fa/0xbe0 kernel/time/hrtimer.c:1749 hrtimer_run_softirq+0x17f/0x360 kernel/time/hrtimer.c:1766 __do_softirq+0x1d4/0x905 kernel/softirq.c:571 invoke_softirq kernel/softirq.c:445 [inline] __irq_exit_rcu+0x114/0x190 kernel/softirq.c:650 irq_exit_rcu+0x9/0x20 kernel/softirq.c:662 sysvec_apic_timer_interrupt+0x97/0xc0 arch/x86/kernel/apic/apic.c:1107 asm_sysvec_apic_timer_interrupt+0x1a/0x20 arch/x86/include/asm/idtentry.h:645 lock_acquire+0x1f3/0x520 kernel/locking/lockdep.c:5637 rcu_lock_acquire include/linux/rcupdate.h:327 [inline] rcu_read_lock include/linux/rcupdate.h:773 [inline] batadv_nc_purge_orig_hash net/batman-adv/network-coding.c:408 [inline] batadv_nc_worker+0x131/0xfe0 net/batman-adv/network-coding.c:719 process_one_work+0x991/0x15c0 kernel/workqueue.c:2390 worker_thread+0x669/0x1090 kernel/workqueue.c:2537 kthread+0x2e8/0x3a0 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 other info that might help us debug this: Chain exists of: &priv->j1939_socks_lock --> &jsk->sk_session_queue_lock --> &priv->active_session_list_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&priv->active_session_list_lock); lock(&jsk->sk_session_queue_lock); lock(&priv->active_session_list_lock); lock(&priv->j1939_socks_lock); *** DEADLOCK *** 4 locks held by kworker/u4:10/31942: #0: ffff888149e1c138 ((wq_completion)bat_events){+.+.}-{0:0}, at: arch_atomic64_set arch/x86/include/asm/atomic64_64.h:34 [inline] #0: ffff888149e1c138 ((wq_completion)bat_events){+.+.}-{0:0}, at: arch_atomic_long_set include/linux/atomic/atomic-long.h:41 [inline] #0: ffff888149e1c138 ((wq_completion)bat_events){+.+.}-{0:0}, at: atomic_long_set include/linux/atomic/atomic-instrumented.h:1280 [inline] #0: ffff888149e1c138 ((wq_completion)bat_events){+.+.}-{0:0}, at: set_work_data kernel/workqueue.c:639 [inline] #0: ffff888149e1c138 ((wq_completion)bat_events){+.+.}-{0:0}, at: set_work_pool_and_clear_pending kernel/workqueue.c:666 [inline] #0: ffff888149e1c138 ((wq_completion)bat_events){+.+.}-{0:0}, at: process_one_work+0x87a/0x15c0 kernel/workqueue.c:2361 #1: ffffc9000390fda8 ((work_completion)(&(&bat_priv->nc.work)->work)){+.+.}-{0:0}, at: process_one_work+0x8ae/0x15c0 kernel/workqueue.c:2365 #2: ffffffff8c7956c0 (rcu_read_lock){....}-{1:2}, at: batadv_nc_purge_orig_hash net/batman-adv/network-coding.c:406 [inline] #2: ffffffff8c7956c0 (rcu_read_lock){....}-{1:2}, at: batadv_nc_worker+0xf7/0xfe0 net/batman-adv/network-coding.c:719 #3: ffff88802c055088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline] #3: ffff88802c055088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline] #3: ffff88802c055088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_tp_rxtimer+0xe4/0x4b0 net/can/j1939/transport.c:1244 stack backtrace: CPU: 1 PID: 31942 Comm: kworker/u4:10 Not tainted 6.3.0-rc3-syzkaller-00005-g7d31677bb7b1 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Workqueue: bat_events batadv_nc_worker Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire kernel/locking/lockdep.c:5669 [inline] lock_acquire+0x1af/0x520 kernel/locking/lockdep.c:5634 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_sk_errqueue+0xa3/0x1a0 net/can/j1939/socket.c:1081 __j1939_session_cancel+0x3b9/0x460 net/can/j1939/transport.c:1128 j1939_tp_rxtimer+0x3df/0x4b0 net/can/j1939/transport.c:1253 __run_hrtimer kernel/time/hrtimer.c:1685 [inline] __hrtimer_run_queues+0x5fa/0xbe0 kernel/time/hrtimer.c:1749 hrtimer_run_softirq+0x17f/0x360 kernel/time/hrtimer.c:1766 __do_softirq+0x1d4/0x905 kernel/softirq.c:571 invoke_softirq kernel/softirq.c:445 [inline] __irq_exit_rcu+0x114/0x190 kernel/softirq.c:650 irq_exit_rcu+0x9/0x20 kernel/softirq.c:662 sysvec_apic_timer_interrupt+0x97/0xc0 arch/x86/kernel/apic/apic.c:1107 asm_sysvec_apic_timer_interrupt+0x1a/0x20 arch/x86/include/asm/idtentry.h:645 RIP: 0010:lock_acquire+0x1f3/0x520 kernel/locking/lockdep.c:5637 Code: ce 9d 7e 83 f8 01 0f 85 b9 02 00 00 9c 58 f6 c4 02 0f 85 a4 02 00 00 48 83 7c 24 08 00 74 01 fb 48 b8 00 00 00 00 00 fc ff df <48> 01 c3 48 c7 03 00 00 00 00 48 c7 43 08 00 00 00 00 48 8b 84 24 RSP: 0018:ffffc9000390fb98 EFLAGS: 00000206 RAX: dffffc0000000000 RBX: 1ffff92000721f75 RCX: 375b18e0aec8b6b9 RDX: 1ffff1100e050146 RSI: 0000000000000000 RDI: 0000000000000000 RBP: 0000000000000000 R08: 0000000000000000 R09: ffffffff914dab87 R10: fffffbfff229b570 R11: 0000000000000000 R12: 0000000000000002 R13: 0000000000000000 R14: ffffffff8c7956c0 R15: 0000000000000000 rcu_lock_acquire include/linux/rcupdate.h:327 [inline] rcu_read_lock include/linux/rcupdate.h:773 [inline] batadv_nc_purge_orig_hash net/batman-adv/network-coding.c:408 [inline] batadv_nc_worker+0x131/0xfe0 net/batman-adv/network-coding.c:719 process_one_work+0x991/0x15c0 kernel/workqueue.c:2390 worker_thread+0x669/0x1090 kernel/workqueue.c:2537 kthread+0x2e8/0x3a0 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 vcan0: j1939_xtp_rx_abort_one: 0xffff8880783e7c00: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_xtp_rx_abort_one: 0xffff8880783e5000: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_tp_rxtimer: 0xffff888026980800: rx timeout, send abort vcan0: j1939_tp_rxtimer: 0xffff888026981800: rx timeout, send abort vcan0: j1939_xtp_rx_abort_one: 0xffff888026980800: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_xtp_rx_abort_one: 0xffff888026981800: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_tp_rxtimer: 0xffff888028361800: rx timeout, send abort vcan0: j1939_tp_rxtimer: 0xffff88805f21b800: rx timeout, send abort vcan0: j1939_xtp_rx_abort_one: 0xffff888028361800: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. vcan0: j1939_xtp_rx_abort_one: 0xffff88805f21b800: 0x00000: (3) A timeout occurred and this is the connection abort to close the session. ---------------- Code disassembly (best guess), 1 bytes skipped: 0: 9d popfq 1: 7e 83 jle 0xffffff86 3: f8 clc 4: 01 0f add %ecx,(%rdi) 6: 85 b9 02 00 00 9c test %edi,-0x63fffffe(%rcx) c: 58 pop %rax d: f6 c4 02 test $0x2,%ah 10: 0f 85 a4 02 00 00 jne 0x2ba 16: 48 83 7c 24 08 00 cmpq $0x0,0x8(%rsp) 1c: 74 01 je 0x1f 1e: fb sti 1f: 48 b8 00 00 00 00 00 movabs $0xdffffc0000000000,%rax 26: fc ff df * 29: 48 01 c3 add %rax,%rbx <-- trapping instruction 2c: 48 c7 03 00 00 00 00 movq $0x0,(%rbx) 33: 48 c7 43 08 00 00 00 movq $0x0,0x8(%rbx) 3a: 00 3b: 48 rex.W 3c: 8b .byte 0x8b 3d: 84 .byte 0x84 3e: 24 .byte 0x24