====================================================== WARNING: possible circular locking dependency detected 5.15.167-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor/4031 is trying to acquire lock: ffff0000e5c03450 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x2bc/0x1a44 fs/ext4/inode.c:597 but task is already holding lock: ffff0000c7b8e208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x11c/0x188 fs/quota/quota_v2.c:354 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 v2_read_dquot+0x50/0x11c fs/quota/quota_v2.c:332 dquot_acquire+0x130/0x5e4 fs/quota/dquot.c:463 ext4_acquire_dquot+0x270/0x420 fs/ext4/super.c:6192 dqget+0x664/0xd0c fs/quota/dquot.c:986 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1515 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1577 ext4_process_orphan+0x5c/0x2b8 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x8bc/0x1048 fs/ext4/orphan.c:474 ext4_fill_super+0x8044/0x8768 fs/ext4/super.c:4974 mount_bdev+0x274/0x370 fs/super.c:1398 ext4_mount+0x44/0x58 fs/ext4/super.c:6602 legacy_get_tree+0xd4/0x16c fs/fs_context.c:611 vfs_get_tree+0x90/0x274 fs/super.c:1528 do_new_mount+0x278/0x8fc fs/namespace.c:3005 path_mount+0x594/0x101c fs/namespace.c:3335 do_mount fs/namespace.c:3348 [inline] __do_sys_mount fs/namespace.c:3556 [inline] __se_sys_mount fs/namespace.c:3533 [inline] __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #1 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 dquot_commit+0x54/0x240 fs/quota/dquot.c:507 ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6172 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6232 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412 __dquot_alloc_space+0xb54/0xf7c fs/quota/dquot.c:1750 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline] dquot_alloc_space include/linux/quotaops.h:310 [inline] dquot_alloc_block include/linux/quotaops.h:334 [inline] ext4_mb_new_blocks+0xe78/0x4278 fs/ext4/mballoc.c:5742 ext4_ext_map_blocks+0x1500/0x6418 fs/ext4/extents.c:4318 ext4_map_blocks+0x8d0/0x1a44 fs/ext4/inode.c:672 ext4_iomap_alloc fs/ext4/inode.c:3407 [inline] ext4_iomap_begin+0x66c/0xa80 fs/ext4/inode.c:3457 iomap_iter+0x5f0/0xffc fs/iomap/iter.c:74 __iomap_dio_rw+0x924/0x1ad0 fs/iomap/direct-io.c:585 iomap_dio_rw+0x50/0x98 fs/iomap/direct-io.c:672 ext4_dio_write_iter fs/ext4/file.c:570 [inline] ext4_file_write_iter+0x12c0/0x162c fs/ext4/file.c:681 do_iter_readv_writev+0x420/0x5f8 do_iter_write+0x1b8/0x66c fs/read_write.c:855 vfs_iter_write+0x88/0xac fs/read_write.c:896 ovl_write_iter+0x654/0x8b8 fs/overlayfs/file.c:378 do_iter_readv_writev+0x420/0x5f8 do_iter_write+0x1b8/0x66c fs/read_write.c:855 vfs_writev fs/read_write.c:928 [inline] do_writev+0x220/0x3ec fs/read_write.c:971 __do_sys_writev fs/read_write.c:1044 [inline] __se_sys_writev fs/read_write.c:1041 [inline] __arm64_sys_writev+0x80/0x94 fs/read_write.c:1041 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 ext4_map_blocks+0x2bc/0x1a44 fs/ext4/inode.c:597 ext4_getblk+0x160/0x688 fs/ext4/inode.c:869 ext4_bread+0x3c/0x1d4 fs/ext4/inode.c:922 ext4_quota_write+0x238/0x564 fs/ext4/super.c:6566 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x2dc/0x6a0 fs/quota/quota_tree.c:125 do_insert_tree+0x238/0x14cc fs/quota/quota_tree.c:335 do_insert_tree+0x4b8/0x14cc fs/quota/quota_tree.c:366 dq_insert_tree fs/quota/quota_tree.c:392 [inline] qtree_write_dquot+0x318/0x488 fs/quota/quota_tree.c:411 v2_write_dquot+0xf4/0x188 fs/quota/quota_v2.c:358 dquot_acquire+0x2cc/0x5e4 fs/quota/dquot.c:472 ext4_acquire_dquot+0x270/0x420 fs/ext4/super.c:6192 dqget+0x664/0xd0c fs/quota/dquot.c:986 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1515 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1577 ext4_unlink+0x134/0x6a0 fs/ext4/namei.c:3361 vfs_unlink+0x2f0/0x508 fs/namei.c:4280 do_unlinkat+0x4cc/0x830 fs/namei.c:4348 __do_sys_unlinkat fs/namei.c:4391 [inline] __se_sys_unlinkat fs/namei.c:4384 [inline] __arm64_sys_unlinkat+0xcc/0xfc fs/namei.c:4384 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 5 locks held by syz-executor/4031: #0: ffff0000c7b8e460 (sb_writers#3){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:377 #1: ffff0000ddd3abd0 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] #1: ffff0000ddd3abd0 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: do_unlinkat+0x2d0/0x830 fs/namei.c:4331 #2: ffff0000e5c067a0 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #2: ffff0000e5c067a0 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: vfs_unlink+0xd8/0x508 fs/namei.c:4269 #3: ffff0000e5c6e0a8 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x68/0x5e4 fs/quota/dquot.c:460 #4: ffff0000c7b8e208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x11c/0x188 fs/quota/quota_v2.c:354 stack backtrace: CPU: 0 PID: 4031 Comm: syz-executor Not tainted 5.15.167-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 ext4_map_blocks+0x2bc/0x1a44 fs/ext4/inode.c:597 ext4_getblk+0x160/0x688 fs/ext4/inode.c:869 ext4_bread+0x3c/0x1d4 fs/ext4/inode.c:922 ext4_quota_write+0x238/0x564 fs/ext4/super.c:6566 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x2dc/0x6a0 fs/quota/quota_tree.c:125 do_insert_tree+0x238/0x14cc fs/quota/quota_tree.c:335 do_insert_tree+0x4b8/0x14cc fs/quota/quota_tree.c:366 dq_insert_tree fs/quota/quota_tree.c:392 [inline] qtree_write_dquot+0x318/0x488 fs/quota/quota_tree.c:411 v2_write_dquot+0xf4/0x188 fs/quota/quota_v2.c:358 dquot_acquire+0x2cc/0x5e4 fs/quota/dquot.c:472 ext4_acquire_dquot+0x270/0x420 fs/ext4/super.c:6192 dqget+0x664/0xd0c fs/quota/dquot.c:986 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1515 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1577 ext4_unlink+0x134/0x6a0 fs/ext4/namei.c:3361 vfs_unlink+0x2f0/0x508 fs/namei.c:4280 do_unlinkat+0x4cc/0x830 fs/namei.c:4348 __do_sys_unlinkat fs/namei.c:4391 [inline] __se_sys_unlinkat fs/namei.c:4384 [inline] __arm64_sys_unlinkat+0xcc/0xfc fs/namei.c:4384 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584