====================================================== WARNING: possible circular locking dependency detected 6.3.0-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.0/3325 is trying to acquire lock: ffff88802bd6c098 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_lock include/linux/mmap_lock.h:117 [inline] ffff88802bd6c098 (&mm->mmap_lock){++++}-{3:3}, at: do_user_addr_fault arch/x86/mm/fault.c:1358 [inline] ffff88802bd6c098 (&mm->mmap_lock){++++}-{3:3}, at: handle_page_fault arch/x86/mm/fault.c:1498 [inline] ffff88802bd6c098 (&mm->mmap_lock){++++}-{3:3}, at: exc_page_fault+0x486/0x7c0 arch/x86/mm/fault.c:1554 but task is already holding lock: ffff88801d8120b0 (&tree->tree_lock#2){+.+.}-{3:3}, at: hfsplus_find_init+0x14a/0x1c0 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&tree->tree_lock#2){+.+.}-{3:3}: lock_acquire+0x1e1/0x520 kernel/locking/lockdep.c:5669 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799 hfsplus_file_truncate+0x811/0xb40 fs/hfsplus/extents.c:595 hfsplus_setattr+0x1bd/0x280 fs/hfsplus/inode.c:269 notify_change+0xc8b/0xf40 fs/attr.c:482 do_truncate+0x220/0x300 fs/open.c:66 handle_truncate fs/namei.c:3219 [inline] do_open fs/namei.c:3564 [inline] path_openat+0x294e/0x3170 fs/namei.c:3715 do_filp_open+0x234/0x490 fs/namei.c:3742 do_sys_openat2+0x13f/0x500 fs/open.c:1348 do_sys_open fs/open.c:1364 [inline] __do_sys_open fs/open.c:1372 [inline] __se_sys_open fs/open.c:1368 [inline] __x64_sys_open+0x225/0x270 fs/open.c:1368 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #2 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1e1/0x520 kernel/locking/lockdep.c:5669 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799 hfsplus_get_block+0x383/0x14e0 fs/hfsplus/extents.c:260 block_read_full_folio+0x47b/0x1000 fs/buffer.c:2319 read_pages+0x5fa/0x830 mm/readahead.c:181 page_cache_ra_unbounded+0x697/0x7c0 mm/readahead.c:270 page_cache_sync_readahead include/linux/pagemap.h:1214 [inline] filemap_get_pages+0x49c/0x20c0 mm/filemap.c:2598 filemap_read+0x45a/0x1170 mm/filemap.c:2693 __kernel_read+0x422/0x8a0 fs/read_write.c:428 integrity_kernel_read+0xb0/0xf0 security/integrity/iint.c:199 ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:485 [inline] ima_calc_file_shash security/integrity/ima/ima_crypto.c:516 [inline] ima_calc_file_hash+0xa5b/0x1c00 security/integrity/ima/ima_crypto.c:573 ima_collect_measurement+0x3a7/0x880 security/integrity/ima/ima_api.c:293 process_measurement+0xfdb/0x1ce0 security/integrity/ima/ima_main.c:341 ima_file_check+0xf1/0x170 security/integrity/ima/ima_main.c:539 do_open fs/namei.c:3562 [inline] path_openat+0x280a/0x3170 fs/namei.c:3715 do_filp_open+0x234/0x490 fs/namei.c:3742 do_sys_openat2+0x13f/0x500 fs/open.c:1348 do_sys_open fs/open.c:1364 [inline] __do_sys_open fs/open.c:1372 [inline] __se_sys_open fs/open.c:1368 [inline] __x64_sys_open+0x225/0x270 fs/open.c:1368 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (mapping.invalidate_lock#14){.+.+}-{3:3}: lock_acquire+0x1e1/0x520 kernel/locking/lockdep.c:5669 down_read+0x3d/0x50 kernel/locking/rwsem.c:1520 filemap_invalidate_lock_shared include/linux/fs.h:813 [inline] filemap_fault+0x644/0x1800 mm/filemap.c:3274 __do_fault+0x136/0x500 mm/memory.c:4155 do_read_fault mm/memory.c:4506 [inline] do_fault mm/memory.c:4635 [inline] handle_pte_fault mm/memory.c:4923 [inline] __handle_mm_fault mm/memory.c:5065 [inline] handle_mm_fault+0x3357/0x51c0 mm/memory.c:5211 do_user_addr_fault arch/x86/mm/fault.c:1407 [inline] handle_page_fault arch/x86/mm/fault.c:1498 [inline] exc_page_fault+0x5b1/0x7c0 arch/x86/mm/fault.c:1554 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570 strncpy_from_user+0x15d/0x370 lib/strncpy_from_user.c:139 getname_flags+0xf9/0x4e0 fs/namei.c:151 do_sys_openat2+0xd6/0x500 fs/open.c:1342 do_sys_open fs/open.c:1364 [inline] __do_sys_creat fs/open.c:1440 [inline] __se_sys_creat fs/open.c:1434 [inline] __x64_sys_creat+0x123/0x160 fs/open.c:1434 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&mm->mmap_lock){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3832 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056 lock_acquire+0x1e1/0x520 kernel/locking/lockdep.c:5669 down_read+0x3d/0x50 kernel/locking/rwsem.c:1520 mmap_read_lock include/linux/mmap_lock.h:117 [inline] do_user_addr_fault arch/x86/mm/fault.c:1358 [inline] handle_page_fault arch/x86/mm/fault.c:1498 [inline] exc_page_fault+0x486/0x7c0 arch/x86/mm/fault.c:1554 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570 filldir+0x30b/0x720 fs/readdir.c:249 dir_emit include/linux/fs.h:3140 [inline] hfsplus_readdir+0xcb8/0x1300 fs/hfsplus/dir.c:248 iterate_dir+0x228/0x570 __do_sys_getdents fs/readdir.c:286 [inline] __se_sys_getdents+0x1ef/0x4c0 fs/readdir.c:271 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &mm->mmap_lock --> &HFSPLUS_I(inode)->extents_lock --> &tree->tree_lock#2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock#2); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock#2); lock(&mm->mmap_lock); *** DEADLOCK *** 3 locks held by syz-executor.0/3325: #0: ffff88807e13c868 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x254/0x2f0 fs/file.c:1047 #1: ffff88815043ef00 (&type->i_mutex_dir_key#13){++++}-{3:3}, at: iterate_dir+0x10e/0x570 fs/readdir.c:55 #2: ffff88801d8120b0 (&tree->tree_lock#2){+.+.}-{3:3}, at: hfsplus_find_init+0x14a/0x1c0 stack backtrace: CPU: 0 PID: 3325 Comm: syz-executor.0 Not tainted 6.3.0-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/14/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2fe/0x3b0 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3832 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056 lock_acquire+0x1e1/0x520 kernel/locking/lockdep.c:5669 down_read+0x3d/0x50 kernel/locking/rwsem.c:1520 mmap_read_lock include/linux/mmap_lock.h:117 [inline] do_user_addr_fault arch/x86/mm/fault.c:1358 [inline] handle_page_fault arch/x86/mm/fault.c:1498 [inline] exc_page_fault+0x486/0x7c0 arch/x86/mm/fault.c:1554 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570 RIP: 0010:filldir+0x30b/0x720 fs/readdir.c:253 Code: 48 29 eb 48 89 df 4c 89 e6 e8 31 75 95 ff 85 ed 0f 88 4e 02 00 00 4c 39 e3 0f 82 45 02 00 00 0f 01 cb 0f ae e8 48 8b 44 24 30 <49> 89 44 24 08 48 8b 4c 24 08 48 8b 44 24 58 48 89 01 48 8b 44 24 RSP: 0018:ffffc900037df8a8 EFLAGS: 00050202 RAX: 0000000000000006 RBX: 00007fffffffefe0 RCX: ffff88801f603a80 RDX: ffff88801f603a80 RSI: 0000000000000000 RDI: 00007fffffffefe0 RBP: 0000000000000020 R08: ffffffff81f5066f R09: 0000000000000008 R10: 0000000000000006 R11: ffff88801f603a80 R12: 0000000000000000 R13: ffffc900037dfe70 R14: 0000000000000005 R15: ffff88807602b000 dir_emit include/linux/fs.h:3140 [inline] hfsplus_readdir+0xcb8/0x1300 fs/hfsplus/dir.c:248 iterate_dir+0x228/0x570 __do_sys_getdents fs/readdir.c:286 [inline] __se_sys_getdents+0x1ef/0x4c0 fs/readdir.c:271 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f8b0368c169 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f8b044c3168 EFLAGS: 00000246 ORIG_RAX: 000000000000004e RAX: ffffffffffffffda RBX: 00007f8b037abf80 RCX: 00007f8b0368c169 RDX: 0000000000000054 RSI: 0000000000000000 RDI: 0000000000000006 RBP: 00007f8b036e7ca1 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffc3fff67cf R14: 00007f8b044c3300 R15: 0000000000022000 ---------------- Code disassembly (best guess): 0: 48 29 eb sub %rbp,%rbx 3: 48 89 df mov %rbx,%rdi 6: 4c 89 e6 mov %r12,%rsi 9: e8 31 75 95 ff callq 0xff95753f e: 85 ed test %ebp,%ebp 10: 0f 88 4e 02 00 00 js 0x264 16: 4c 39 e3 cmp %r12,%rbx 19: 0f 82 45 02 00 00 jb 0x264 1f: 0f 01 cb stac 22: 0f ae e8 lfence 25: 48 8b 44 24 30 mov 0x30(%rsp),%rax * 2a: 49 89 44 24 08 mov %rax,0x8(%r12) <-- trapping instruction 2f: 48 8b 4c 24 08 mov 0x8(%rsp),%rcx 34: 48 8b 44 24 58 mov 0x58(%rsp),%rax 39: 48 89 01 mov %rax,(%rcx) 3c: 48 rex.W 3d: 8b .byte 0x8b 3e: 44 rex.R 3f: 24 .byte 0x24