====================================================== WARNING: possible circular locking dependency detected 6.10.0-rc6-syzkaller-00051-g1dfe225e9af5 #0 Not tainted ------------------------------------------------------ syz.2.1097/10022 is trying to acquire lock: ffff88802d2ab870 (&newdev->mutex){+.+.}-{3:3}, at: uinput_request_send drivers/input/misc/uinput.c:151 [inline] ffff88802d2ab870 (&newdev->mutex){+.+.}-{3:3}, at: uinput_request_submit.part.0+0x25/0x2e0 drivers/input/misc/uinput.c:182 but task is already holding lock: ffff888060b9c0b0 (&ff->mutex){+.+.}-{3:3}, at: input_ff_upload+0x1dd/0xbf0 drivers/input/ff-core.c:122 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&ff->mutex){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 input_ff_flush+0x63/0x170 drivers/input/ff-core.c:242 uinput_dev_flush+0x2a/0x40 drivers/input/misc/uinput.c:283 input_flush_device+0x97/0xd0 drivers/input/input.c:686 evdev_release+0x343/0x400 drivers/input/evdev.c:444 __fput+0x408/0xbb0 fs/file_table.c:422 __fput_sync+0x47/0x50 fs/file_table.c:507 __do_sys_close fs/open.c:1563 [inline] __se_sys_close fs/open.c:1548 [inline] __x64_sys_close+0x86/0x100 fs/open.c:1548 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&dev->mutex#2){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 input_register_handle+0x71/0x4e0 drivers/input/input.c:2629 kbd_connect+0xca/0x160 drivers/tty/vt/keyboard.c:1589 input_attach_handler.isra.0+0x181/0x260 drivers/input/input.c:1064 input_register_device+0xb22/0x1140 drivers/input/input.c:2470 acpi_button_add+0x51b/0xb80 drivers/acpi/button.c:604 acpi_device_probe+0xc6/0x330 drivers/acpi/bus.c:1074 call_driver_probe drivers/base/dd.c:578 [inline] really_probe+0x23e/0xa90 drivers/base/dd.c:656 __driver_probe_device+0x1de/0x440 drivers/base/dd.c:798 driver_probe_device+0x4c/0x1b0 drivers/base/dd.c:828 __driver_attach+0x283/0x580 drivers/base/dd.c:1214 bus_for_each_dev+0x13c/0x1d0 drivers/base/bus.c:368 bus_add_driver+0x2e9/0x690 drivers/base/bus.c:673 driver_register+0x15c/0x4b0 drivers/base/driver.c:246 __acpi_bus_register_driver+0xdf/0x130 drivers/acpi/bus.c:1025 acpi_button_register_driver drivers/acpi/button.c:734 [inline] acpi_button_driver_init+0x82/0x110 drivers/acpi/button.c:743 do_one_initcall+0x128/0x700 init/main.c:1267 do_initcall_level init/main.c:1329 [inline] do_initcalls init/main.c:1345 [inline] do_basic_setup init/main.c:1364 [inline] kernel_init_freeable+0x69d/0xca0 init/main.c:1578 kernel_init+0x1c/0x2b0 init/main.c:1467 ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 -> #1 (input_mutex){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 input_register_device+0xa2b/0x1140 drivers/input/input.c:2463 uinput_create_device drivers/input/misc/uinput.c:365 [inline] uinput_ioctl_handler.isra.0+0x130c/0x1d70 drivers/input/misc/uinput.c:904 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl fs/ioctl.c:893 [inline] __x64_sys_ioctl+0x193/0x220 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&newdev->mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2478/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 uinput_request_send drivers/input/misc/uinput.c:151 [inline] uinput_request_submit.part.0+0x25/0x2e0 drivers/input/misc/uinput.c:182 uinput_request_submit drivers/input/misc/uinput.c:179 [inline] uinput_dev_upload_effect+0x175/0x1f0 drivers/input/misc/uinput.c:257 input_ff_upload+0x55b/0xbf0 drivers/input/ff-core.c:152 evdev_do_ioctl+0xf40/0x1ae0 drivers/input/evdev.c:1183 evdev_ioctl_handler drivers/input/evdev.c:1272 [inline] evdev_ioctl+0x170/0x1a0 drivers/input/evdev.c:1281 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl fs/ioctl.c:893 [inline] __x64_sys_ioctl+0x193/0x220 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &newdev->mutex --> &dev->mutex#2 --> &ff->mutex Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ff->mutex); lock(&dev->mutex#2); lock(&ff->mutex); lock(&newdev->mutex); *** DEADLOCK *** 2 locks held by syz.2.1097/10022: #0: ffff88807fa1b110 (&evdev->mutex){+.+.}-{3:3}, at: evdev_ioctl_handler drivers/input/evdev.c:1263 [inline] #0: ffff88807fa1b110 (&evdev->mutex){+.+.}-{3:3}, at: evdev_ioctl+0x86/0x1a0 drivers/input/evdev.c:1281 #1: ffff888060b9c0b0 (&ff->mutex){+.+.}-{3:3}, at: input_ff_upload+0x1dd/0xbf0 drivers/input/ff-core.c:122 stack backtrace: CPU: 0 PID: 10022 Comm: syz.2.1097 Not tainted 6.10.0-rc6-syzkaller-00051-g1dfe225e9af5 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:114 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2478/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 uinput_request_send drivers/input/misc/uinput.c:151 [inline] uinput_request_submit.part.0+0x25/0x2e0 drivers/input/misc/uinput.c:182 uinput_request_submit drivers/input/misc/uinput.c:179 [inline] uinput_dev_upload_effect+0x175/0x1f0 drivers/input/misc/uinput.c:257 input_ff_upload+0x55b/0xbf0 drivers/input/ff-core.c:152 evdev_do_ioctl+0xf40/0x1ae0 drivers/input/evdev.c:1183 evdev_ioctl_handler drivers/input/evdev.c:1272 [inline] evdev_ioctl+0x170/0x1a0 drivers/input/evdev.c:1281 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl fs/ioctl.c:893 [inline] __x64_sys_ioctl+0x193/0x220 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f3e48d75f19 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f3e49b3d048 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f3e48f04038 RCX: 00007f3e48d75f19 RDX: 0000000020000340 RSI: 0000000040304580 RDI: 0000000000000007 RBP: 00007f3e48de4bcd R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000006e R14: 00007f3e48f04038 R15: 00007ffdc0cdc828