ntfs3: loop4: Mark volume as dirty due to NTFS errors ====================================================== WARNING: possible circular locking dependency detected 5.15.167-syzkaller #0 Not tainted ------------------------------------------------------ syz.4.301/4678 is trying to acquire lock: ffff888062649720 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1100 [inline] ffff888062649720 (&ni->ni_lock/4){+.+.}-{3:3}, at: mi_read+0x2dd/0x5a0 fs/ntfs3/record.c:148 but task is already holding lock: ffff88806264e0e0 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1115 [inline] ffff88806264e0e0 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x16b/0x1070 fs/ntfs3/frecord.c:3198 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ni->ni_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 ntfs_set_state+0x1fa/0x660 fs/ntfs3/fsntfs.c:925 ni_remove_name+0x2bc/0x9a0 fs/ntfs3/frecord.c:2880 ni_rename+0x13e/0x1e0 fs/ntfs3/frecord.c:3025 ntfs_rename+0x74a/0xd40 fs/ntfs3/namei.c:318 vfs_rename+0xd32/0x10f0 fs/namei.c:4832 do_renameat2+0xe0f/0x1700 fs/namei.c:4985 __do_sys_rename fs/namei.c:5031 [inline] __se_sys_rename fs/namei.c:5029 [inline] __x64_sys_rename+0x82/0x90 fs/namei.c:5029 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&ni->ni_lock/4){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 ni_lock fs/ntfs3/ntfs_fs.h:1100 [inline] mi_read+0x2dd/0x5a0 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x472/0x38e0 fs/ntfs3/inode.c:525 ni_update_parent+0x93f/0xdc0 fs/ntfs3/frecord.c:3154 ni_write_inode+0xe32/0x1070 fs/ntfs3/frecord.c:3252 write_inode fs/fs-writeback.c:1495 [inline] __writeback_single_inode+0x644/0xe30 fs/fs-writeback.c:1705 writeback_single_inode+0x22c/0x960 fs/fs-writeback.c:1760 write_inode_now+0x26e/0x2f0 fs/fs-writeback.c:2800 ntfs_extend+0x3c2/0x4c0 fs/ntfs3/file.c:455 ntfs_file_write_iter+0x2eb/0x540 fs/ntfs3/file.c:1138 call_write_iter include/linux/fs.h:2172 [inline] aio_write+0x566/0x780 fs/aio.c:1594 io_submit_one+0x768/0x18d0 fs/aio.c:2013 __do_sys_io_submit fs/aio.c:2072 [inline] __se_sys_io_submit+0x17b/0x2f0 fs/aio.c:2042 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->ni_lock); lock(&ni->ni_lock/4); lock(&ni->ni_lock); lock(&ni->ni_lock/4); *** DEADLOCK *** 2 locks held by syz.4.301/4678: #0: ffff88806264e380 (&sb->s_type->i_mutex_key#27){+.+.}-{3:3}, at: inode_trylock include/linux/fs.h:809 [inline] #0: ffff88806264e380 (&sb->s_type->i_mutex_key#27){+.+.}-{3:3}, at: ntfs_file_write_iter+0x1ca/0x540 fs/ntfs3/file.c:1122 #1: ffff88806264e0e0 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1115 [inline] #1: ffff88806264e0e0 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x16b/0x1070 fs/ntfs3/frecord.c:3198 stack backtrace: CPU: 1 PID: 4678 Comm: syz.4.301 Not tainted 5.15.167-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 ni_lock fs/ntfs3/ntfs_fs.h:1100 [inline] mi_read+0x2dd/0x5a0 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x472/0x38e0 fs/ntfs3/inode.c:525 ni_update_parent+0x93f/0xdc0 fs/ntfs3/frecord.c:3154 ni_write_inode+0xe32/0x1070 fs/ntfs3/frecord.c:3252 write_inode fs/fs-writeback.c:1495 [inline] __writeback_single_inode+0x644/0xe30 fs/fs-writeback.c:1705 writeback_single_inode+0x22c/0x960 fs/fs-writeback.c:1760 write_inode_now+0x26e/0x2f0 fs/fs-writeback.c:2800 ntfs_extend+0x3c2/0x4c0 fs/ntfs3/file.c:455 ntfs_file_write_iter+0x2eb/0x540 fs/ntfs3/file.c:1138 call_write_iter include/linux/fs.h:2172 [inline] aio_write+0x566/0x780 fs/aio.c:1594 io_submit_one+0x768/0x18d0 fs/aio.c:2013 __do_sys_io_submit fs/aio.c:2072 [inline] __se_sys_io_submit+0x17b/0x2f0 fs/aio.c:2042 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7f567b06cef9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f56794e5038 EFLAGS: 00000246 ORIG_RAX: 00000000000000d1 RAX: ffffffffffffffda RBX: 00007f567b224f80 RCX: 00007f567b06cef9 RDX: 00000000200002c0 RSI: 0000000000000001 RDI: 00007f567b1fe000 RBP: 00007f567b0dfb76 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f567b224f80 R15: 00007ffd53042b88 ntfs3: loop4: ino=1d, "file1" failed to open parent directory r=400 to update