sp0: Synchronizing with TNC sp0: Found TNC ===================================================== WARNING: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected 6.12.0-rc4-syzkaller-00261-g850925a8133c #0 Not tainted ----------------------------------------------------- syz.9.2667/20375 [HC0[0]:SC0[0]:HE0:SE1] is trying to acquire: ffffffff8f4a7418 (disc_data_lock#4){.+.+}-{2:2}, at: sp_get drivers/net/hamradio/6pack.c:370 [inline] ffffffff8f4a7418 (disc_data_lock#4){.+.+}-{2:2}, at: sixpack_write_wakeup+0x30/0x440 drivers/net/hamradio/6pack.c:391 and this task is already holding: ffffffff9a6e4758 (&port_lock_key){-.-.}-{2:2}, at: uart_port_lock_irqsave include/linux/serial_core.h:711 [inline] ffffffff9a6e4758 (&port_lock_key){-.-.}-{2:2}, at: uart_write+0x107/0xa40 drivers/tty/serial/serial_core.c:626 which would create a new lock dependency: (&port_lock_key){-.-.}-{2:2} -> (disc_data_lock#4){.+.+}-{2:2} but this new dependency connects a HARDIRQ-irq-safe lock: (&port_lock_key){-.-.}-{2:2} ... which became HARDIRQ-irq-safe at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0xd5/0x120 kernel/locking/spinlock.c:162 uart_port_lock_irqsave include/linux/serial_core.h:711 [inline] serial8250_handle_irq+0x6d/0xb80 drivers/tty/serial/8250/8250_port.c:1900 serial8250_default_handle_irq+0xd1/0x1f0 drivers/tty/serial/8250/8250_port.c:1949 serial8250_interrupt+0xa9/0x1f0 drivers/tty/serial/8250/8250_core.c:86 __handle_irq_event_percpu+0x29a/0xa80 kernel/irq/handle.c:158 handle_irq_event_percpu kernel/irq/handle.c:193 [inline] handle_irq_event+0x89/0x1f0 kernel/irq/handle.c:210 handle_edge_irq+0x25f/0xc20 kernel/irq/chip.c:831 generic_handle_irq_desc include/linux/irqdesc.h:173 [inline] handle_irq arch/x86/kernel/irq.c:247 [inline] call_irq_handler arch/x86/kernel/irq.c:259 [inline] __common_interrupt+0x136/0x230 arch/x86/kernel/irq.c:285 common_interrupt+0xb4/0xd0 arch/x86/kernel/irq.c:278 asm_common_interrupt+0x26/0x40 arch/x86/include/asm/idtentry.h:693 __raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:152 [inline] _raw_spin_unlock_irqrestore+0xd8/0x140 kernel/locking/spinlock.c:194 spin_unlock_irqrestore include/linux/spinlock.h:406 [inline] uart_port_unlock_irqrestore include/linux/serial_core.h:782 [inline] uart_write+0x3e4/0xa40 drivers/tty/serial/serial_core.c:636 process_output_block drivers/tty/n_tty.c:574 [inline] n_tty_write+0xd62/0x1230 drivers/tty/n_tty.c:2389 iterate_tty_write drivers/tty/tty_io.c:1015 [inline] file_tty_write+0x546/0x9b0 drivers/tty/tty_io.c:1090 new_sync_write fs/read_write.c:590 [inline] vfs_write+0xaeb/0xd30 fs/read_write.c:683 ksys_write+0x183/0x2b0 fs/read_write.c:736 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f to a HARDIRQ-irq-unsafe lock: (disc_data_lock#4){.+.+}-{2:2} ... which became HARDIRQ-irq-unsafe at: ... lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_read_lock include/linux/rwlock_api_smp.h:150 [inline] _raw_read_lock+0x36/0x50 kernel/locking/spinlock.c:228 sp_get drivers/net/hamradio/6pack.c:370 [inline] sixpack_receive_buf+0x5c/0x15f0 drivers/net/hamradio/6pack.c:433 tiocsti+0x24d/0x300 drivers/tty/tty_io.c:2299 tty_ioctl+0x518/0xdc0 drivers/tty/tty_io.c:2717 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible interrupt unsafe locking scenario: CPU0 CPU1 ---- ---- lock(disc_data_lock#4); local_irq_disable(); lock(&port_lock_key); lock(disc_data_lock#4); lock(&port_lock_key); *** DEADLOCK *** 4 locks held by syz.9.2667/20375: #0: ffff88805fd9f0a0 (&tty->ldisc_sem){++++}-{0:0}, at: tty_ldisc_ref_wait+0x25/0x70 drivers/tty/tty_ldisc.c:243 #1: ffff888024af8ca0 (&buf->lock){+.+.}-{3:3}, at: tiocsti+0x1e6/0x300 drivers/tty/tty_io.c:2297 #2: ffffffff9a6e4758 (&port_lock_key){-.-.}-{2:2}, at: uart_port_lock_irqsave include/linux/serial_core.h:711 [inline] #2: ffffffff9a6e4758 (&port_lock_key){-.-.}-{2:2}, at: uart_write+0x107/0xa40 drivers/tty/serial/serial_core.c:626 #3: ffff88805fd9f0a0 (&tty->ldisc_sem){++++}-{0:0}, at: tty_ldisc_ref+0x1c/0x80 drivers/tty/tty_ldisc.c:263 the dependencies between HARDIRQ-irq-safe lock and the holding lock: -> (&port_lock_key){-.-.}-{2:2} { IN-HARDIRQ-W at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0xd5/0x120 kernel/locking/spinlock.c:162 uart_port_lock_irqsave include/linux/serial_core.h:711 [inline] serial8250_handle_irq+0x6d/0xb80 drivers/tty/serial/8250/8250_port.c:1900 serial8250_default_handle_irq+0xd1/0x1f0 drivers/tty/serial/8250/8250_port.c:1949 serial8250_interrupt+0xa9/0x1f0 drivers/tty/serial/8250/8250_core.c:86 __handle_irq_event_percpu+0x29a/0xa80 kernel/irq/handle.c:158 handle_irq_event_percpu kernel/irq/handle.c:193 [inline] handle_irq_event+0x89/0x1f0 kernel/irq/handle.c:210 handle_edge_irq+0x25f/0xc20 kernel/irq/chip.c:831 generic_handle_irq_desc include/linux/irqdesc.h:173 [inline] handle_irq arch/x86/kernel/irq.c:247 [inline] call_irq_handler arch/x86/kernel/irq.c:259 [inline] __common_interrupt+0x136/0x230 arch/x86/kernel/irq.c:285 common_interrupt+0xb4/0xd0 arch/x86/kernel/irq.c:278 asm_common_interrupt+0x26/0x40 arch/x86/include/asm/idtentry.h:693 __raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:152 [inline] _raw_spin_unlock_irqrestore+0xd8/0x140 kernel/locking/spinlock.c:194 spin_unlock_irqrestore include/linux/spinlock.h:406 [inline] uart_port_unlock_irqrestore include/linux/serial_core.h:782 [inline] uart_write+0x3e4/0xa40 drivers/tty/serial/serial_core.c:636 process_output_block drivers/tty/n_tty.c:574 [inline] n_tty_write+0xd62/0x1230 drivers/tty/n_tty.c:2389 iterate_tty_write drivers/tty/tty_io.c:1015 [inline] file_tty_write+0x546/0x9b0 drivers/tty/tty_io.c:1090 new_sync_write fs/read_write.c:590 [inline] vfs_write+0xaeb/0xd30 fs/read_write.c:683 ksys_write+0x183/0x2b0 fs/read_write.c:736 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f IN-SOFTIRQ-W at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0xd5/0x120 kernel/locking/spinlock.c:162 uart_port_lock_irqsave include/linux/serial_core.h:711 [inline] serial8250_handle_irq+0x6d/0xb80 drivers/tty/serial/8250/8250_port.c:1900 serial8250_default_handle_irq+0xd1/0x1f0 drivers/tty/serial/8250/8250_port.c:1949 serial8250_interrupt+0xa9/0x1f0 drivers/tty/serial/8250/8250_core.c:86 __handle_irq_event_percpu+0x29a/0xa80 kernel/irq/handle.c:158 handle_irq_event_percpu kernel/irq/handle.c:193 [inline] handle_irq_event+0x89/0x1f0 kernel/irq/handle.c:210 handle_edge_irq+0x25f/0xc20 kernel/irq/chip.c:831 generic_handle_irq_desc include/linux/irqdesc.h:173 [inline] handle_irq arch/x86/kernel/irq.c:247 [inline] call_irq_handler arch/x86/kernel/irq.c:259 [inline] __common_interrupt+0x136/0x230 arch/x86/kernel/irq.c:285 common_interrupt+0xb4/0xd0 arch/x86/kernel/irq.c:278 asm_common_interrupt+0x26/0x40 arch/x86/include/asm/idtentry.h:693 __raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:152 [inline] _raw_spin_unlock_irqrestore+0xd8/0x140 kernel/locking/spinlock.c:194 __debug_check_no_obj_freed lib/debugobjects.c:998 [inline] debug_check_no_obj_freed+0x561/0x580 lib/debugobjects.c:1019 slab_free_hook mm/slub.c:2273 [inline] slab_free mm/slub.c:4579 [inline] kmem_cache_free+0x11f/0x420 mm/slub.c:4681 vma_lock_free kernel/fork.c:458 [inline] __vm_area_free+0xe3/0x110 kernel/fork.c:514 rcu_do_batch kernel/rcu/tree.c:2567 [inline] rcu_core+0xaaa/0x17a0 kernel/rcu/tree.c:2823 handle_softirqs+0x2c5/0x980 kernel/softirq.c:554 run_ksoftirqd+0xca/0x130 kernel/softirq.c:927 smpboot_thread_fn+0x544/0xa30 kernel/smpboot.c:164 kthread+0x2f0/0x390 kernel/kthread.c:389 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 INITIAL USE at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0xd5/0x120 kernel/locking/spinlock.c:162 uart_port_lock_irqsave include/linux/serial_core.h:711 [inline] serial8250_do_set_termios+0x4da/0x1c70 drivers/tty/serial/8250/8250_port.c:2742 uart_set_options+0x3eb/0x730 drivers/tty/serial/serial_core.c:2327 serial8250_console_setup+0x3db/0x670 drivers/tty/serial/8250/8250_port.c:3456 univ8250_console_setup+0x426/0x530 drivers/tty/serial/8250/8250_core.c:428 console_call_setup kernel/printk/printk.c:3743 [inline] try_enable_preferred_console+0x46b/0x5c0 kernel/printk/printk.c:3787 register_console+0x37a/0xfd0 kernel/printk/printk.c:3981 univ8250_console_init+0x52/0x90 drivers/tty/serial/8250/8250_core.c:513 console_init+0x1b8/0x6f0 kernel/printk/printk.c:4262 start_kernel+0x2d8/0x500 init/main.c:1040 x86_64_start_reservations+0x2a/0x30 arch/x86/kernel/head64.c:507 x86_64_start_kernel+0x9f/0xa0 arch/x86/kernel/head64.c:488 common_startup_64+0x13e/0x147 } ... key at: [] port_lock_key+0x0/0x20 the dependencies between the lock to be acquired and HARDIRQ-irq-unsafe lock: -> (disc_data_lock#4){.+.+}-{2:2} { HARDIRQ-ON-R at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_read_lock include/linux/rwlock_api_smp.h:150 [inline] _raw_read_lock+0x36/0x50 kernel/locking/spinlock.c:228 sp_get drivers/net/hamradio/6pack.c:370 [inline] sixpack_receive_buf+0x5c/0x15f0 drivers/net/hamradio/6pack.c:433 tiocsti+0x24d/0x300 drivers/tty/tty_io.c:2299 tty_ioctl+0x518/0xdc0 drivers/tty/tty_io.c:2717 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f SOFTIRQ-ON-R at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_read_lock include/linux/rwlock_api_smp.h:150 [inline] _raw_read_lock+0x36/0x50 kernel/locking/spinlock.c:228 sp_get drivers/net/hamradio/6pack.c:370 [inline] sixpack_receive_buf+0x5c/0x15f0 drivers/net/hamradio/6pack.c:433 tiocsti+0x24d/0x300 drivers/tty/tty_io.c:2299 tty_ioctl+0x518/0xdc0 drivers/tty/tty_io.c:2717 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f INITIAL READ USE at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_read_lock include/linux/rwlock_api_smp.h:150 [inline] _raw_read_lock+0x36/0x50 kernel/locking/spinlock.c:228 sp_get drivers/net/hamradio/6pack.c:370 [inline] sixpack_receive_buf+0x5c/0x15f0 drivers/net/hamradio/6pack.c:433 tiocsti+0x24d/0x300 drivers/tty/tty_io.c:2299 tty_ioctl+0x518/0xdc0 drivers/tty/tty_io.c:2717 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f } ... key at: [] disc_data_lock+0x18/0x100 ... acquired at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_read_lock include/linux/rwlock_api_smp.h:150 [inline] _raw_read_lock+0x36/0x50 kernel/locking/spinlock.c:228 sp_get drivers/net/hamradio/6pack.c:370 [inline] sixpack_write_wakeup+0x30/0x440 drivers/net/hamradio/6pack.c:391 tty_wakeup+0xbb/0x100 drivers/tty/tty_io.c:517 tty_port_default_wakeup+0xa6/0xf0 drivers/tty/tty_port.c:69 serial8250_tx_chars+0x6e2/0x930 drivers/tty/serial/8250/8250_port.c:1821 __start_tx+0x32e/0x470 drivers/tty/serial/8250/8250_port.c:1527 __uart_start+0x2bc/0x450 drivers/tty/serial/serial_core.c:160 uart_write+0x280/0xa40 drivers/tty/serial/serial_core.c:635 decode_prio_command drivers/net/hamradio/6pack.c:868 [inline] sixpack_decode drivers/net/hamradio/6pack.c:943 [inline] sixpack_receive_buf+0x490/0x15f0 drivers/net/hamradio/6pack.c:447 tiocsti+0x24d/0x300 drivers/tty/tty_io.c:2299 tty_ioctl+0x518/0xdc0 drivers/tty/tty_io.c:2717 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f stack backtrace: CPU: 1 UID: 0 PID: 20375 Comm: syz.9.2667 Not tainted 6.12.0-rc4-syzkaller-00261-g850925a8133c #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_bad_irq_dependency kernel/locking/lockdep.c:2647 [inline] check_irq_usage kernel/locking/lockdep.c:2888 [inline] check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x4ebd/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5202 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_read_lock include/linux/rwlock_api_smp.h:150 [inline] _raw_read_lock+0x36/0x50 kernel/locking/spinlock.c:228 sp_get drivers/net/hamradio/6pack.c:370 [inline] sixpack_write_wakeup+0x30/0x440 drivers/net/hamradio/6pack.c:391 tty_wakeup+0xbb/0x100 drivers/tty/tty_io.c:517 tty_port_default_wakeup+0xa6/0xf0 drivers/tty/tty_port.c:69 serial8250_tx_chars+0x6e2/0x930 drivers/tty/serial/8250/8250_port.c:1821 __start_tx+0x32e/0x470 drivers/tty/serial/8250/8250_port.c:1527 __uart_start+0x2bc/0x450 drivers/tty/serial/serial_core.c:160 uart_write+0x280/0xa40 drivers/tty/serial/serial_core.c:635 decode_prio_command drivers/net/hamradio/6pack.c:868 [inline] sixpack_decode drivers/net/hamradio/6pack.c:943 [inline] sixpack_receive_buf+0x490/0x15f0 drivers/net/hamradio/6pack.c:447 tiocsti+0x24d/0x300 drivers/tty/tty_io.c:2299 tty_ioctl+0x518/0xdc0 drivers/tty/tty_io.c:2717 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f382bb7e719 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f382c8d0038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f382bd35f80 RCX: 00007f382bb7e719 RDX: 0000000020000200 RSI: 0000000000005412 RDI: 0000000000000003 RBP: 00007f382bbf132e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f382bd35f80 R15: 00007ffd2d7a6dc8