====================================================== WARNING: possible circular locking dependency detected 5.15.136-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.3/11374 is trying to acquire lock: ffff000103dc80f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x8c/0x800 fs/hfsplus/bitmap.c:35 but task is already holding lock: ffff0000d48dd208 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x198/0x14e0 fs/hfsplus/extents.c:457 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 hfsplus_get_block+0x2c4/0x1194 fs/hfsplus/extents.c:260 block_read_full_page+0x2a0/0xc4c fs/buffer.c:2290 hfsplus_readpage+0x28/0x38 fs/hfsplus/inode.c:28 do_read_cache_page+0x60c/0x950 read_cache_page+0x68/0x84 mm/filemap.c:3565 read_mapping_page include/linux/pagemap.h:515 [inline] hfsplus_block_allocate+0xe0/0x800 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0x770/0x14e0 fs/hfsplus/extents.c:468 hfsplus_get_block+0x398/0x1194 fs/hfsplus/extents.c:245 __block_write_begin_int+0x3ec/0x1608 fs/buffer.c:2012 __block_write_begin fs/buffer.c:2062 [inline] block_write_begin fs/buffer.c:2122 [inline] cont_write_begin+0x538/0x710 fs/buffer.c:2471 hfsplus_write_begin+0xa8/0xf8 fs/hfsplus/inode.c:53 pagecache_write_begin+0xa0/0xc0 mm/filemap.c:3599 cont_expand_zero fs/buffer.c:2431 [inline] cont_write_begin+0x5a8/0x710 fs/buffer.c:2461 hfsplus_write_begin+0xa8/0xf8 fs/hfsplus/inode.c:53 pagecache_write_begin+0xa0/0xc0 mm/filemap.c:3599 generic_cont_expand_simple+0x12c/0x208 fs/buffer.c:2362 hfsplus_setattr+0x148/0x25c fs/hfsplus/inode.c:261 notify_change+0xa34/0xcf8 fs/attr.c:505 do_truncate+0x1c0/0x28c fs/open.c:65 do_sys_ftruncate+0x288/0x31c fs/open.c:193 __do_sys_ftruncate fs/open.c:204 [inline] __se_sys_ftruncate fs/open.c:202 [inline] __arm64_sys_ftruncate+0x60/0x74 fs/open.c:202 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3787 [inline] __lock_acquire+0x32cc/0x7620 kernel/locking/lockdep.c:5011 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5622 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 hfsplus_block_allocate+0x8c/0x800 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0x770/0x14e0 fs/hfsplus/extents.c:468 hfsplus_get_block+0x398/0x1194 fs/hfsplus/extents.c:245 get_more_blocks fs/direct-io.c:673 [inline] do_direct_IO fs/direct-io.c:959 [inline] do_blockdev_direct_IO fs/direct-io.c:1276 [inline] __blockdev_direct_IO+0x139c/0x3824 fs/direct-io.c:1368 blockdev_direct_IO include/linux/fs.h:3232 [inline] hfsplus_direct_IO+0xf4/0x1e0 fs/hfsplus/inode.c:135 generic_file_direct_write+0x234/0x538 mm/filemap.c:3678 __generic_file_write_iter+0x280/0x454 mm/filemap.c:3860 generic_file_write_iter+0xb4/0x1b8 mm/filemap.c:3935 call_write_iter include/linux/fs.h:2103 [inline] aio_write+0x604/0x8dc fs/aio.c:1583 io_submit_one+0x878/0x161c fs/aio.c:2002 __do_sys_io_submit fs/aio.c:2061 [inline] __se_sys_io_submit fs/aio.c:2031 [inline] __arm64_sys_io_submit+0x26c/0x3ec fs/aio.c:2031 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 2 locks held by syz-executor.3/11374: #0: ffff0000d48dd400 (&sb->s_type->i_mutex_key#25){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline] #0: ffff0000d48dd400 (&sb->s_type->i_mutex_key#25){+.+.}-{3:3}, at: generic_file_write_iter+0x84/0x1b8 mm/filemap.c:3932 #1: ffff0000d48dd208 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x198/0x14e0 fs/hfsplus/extents.c:457 stack backtrace: CPU: 0 PID: 11374 Comm: syz-executor.3 Not tainted 5.15.136-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3787 [inline] __lock_acquire+0x32cc/0x7620 kernel/locking/lockdep.c:5011 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5622 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 hfsplus_block_allocate+0x8c/0x800 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0x770/0x14e0 fs/hfsplus/extents.c:468 hfsplus_get_block+0x398/0x1194 fs/hfsplus/extents.c:245 get_more_blocks fs/direct-io.c:673 [inline] do_direct_IO fs/direct-io.c:959 [inline] do_blockdev_direct_IO fs/direct-io.c:1276 [inline] __blockdev_direct_IO+0x139c/0x3824 fs/direct-io.c:1368 blockdev_direct_IO include/linux/fs.h:3232 [inline] hfsplus_direct_IO+0xf4/0x1e0 fs/hfsplus/inode.c:135 generic_file_direct_write+0x234/0x538 mm/filemap.c:3678 __generic_file_write_iter+0x280/0x454 mm/filemap.c:3860 generic_file_write_iter+0xb4/0x1b8 mm/filemap.c:3935 call_write_iter include/linux/fs.h:2103 [inline] aio_write+0x604/0x8dc fs/aio.c:1583 io_submit_one+0x878/0x161c fs/aio.c:2002 __do_sys_io_submit fs/aio.c:2061 [inline] __se_sys_io_submit fs/aio.c:2031 [inline] __arm64_sys_io_submit+0x26c/0x3ec fs/aio.c:2031 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584