====================================================== WARNING: possible circular locking dependency detected 5.15.169-syzkaller #0 Not tainted ------------------------------------------------------ syz.2.224/5145 is trying to acquire lock: ffff0000dc836650 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_acquire_dquot+0x3b4/0xa90 fs/ocfs2/quota_global.c:843 but task is already holding lock: ffff0000ddb9ea20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: down_write+0xbc/0x12c kernel/locking/rwsem.c:1551 ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x258/0xa90 fs/ocfs2/quota_global.c:811 dqget+0x664/0xd0c fs/quota/dquot.c:986 dquot_set_dqblk+0x40/0xfec fs/quota/dquot.c:2824 quota_setquota+0x5f4/0x728 fs/quota/quota.c:309 do_quotactl+0x508/0x698 fs/quota/quota.c:801 __do_sys_quotactl fs/quota/quota.c:959 [inline] __se_sys_quotactl fs/quota/quota.c:915 [inline] __arm64_sys_quotactl+0x2d8/0x7a4 fs/quota/quota.c:915 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}: down_write+0xbc/0x12c kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:789 [inline] ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x258/0xa90 fs/ocfs2/quota_global.c:811 dqget+0x664/0xd0c fs/quota/dquot.c:986 dquot_set_dqblk+0x40/0xfec fs/quota/dquot.c:2824 quota_setquota+0x5f4/0x728 fs/quota/quota.c:309 do_quotactl+0x508/0x698 fs/quota/quota.c:801 __do_sys_quotactl fs/quota/quota.c:959 [inline] __se_sys_quotactl fs/quota/quota.c:915 [inline] __arm64_sys_quotactl+0x2d8/0x7a4 fs/quota/quota.c:915 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #4 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 dquot_commit+0x54/0x240 fs/quota/dquot.c:507 ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6173 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6233 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412 __dquot_alloc_space+0xb54/0xf7c fs/quota/dquot.c:1750 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline] dquot_alloc_space include/linux/quotaops.h:310 [inline] dquot_alloc_block include/linux/quotaops.h:334 [inline] ext4_mb_new_blocks+0xe78/0x4278 fs/ext4/mballoc.c:5739 ext4_ext_map_blocks+0x1500/0x6418 fs/ext4/extents.c:4339 ext4_map_blocks+0x8d0/0x1a44 fs/ext4/inode.c:672 _ext4_get_block+0x1c0/0x5c0 fs/ext4/inode.c:815 ext4_get_block+0x4c/0x60 fs/ext4/inode.c:832 ext4_block_write_begin+0x520/0x1130 fs/ext4/inode.c:1100 ext4_write_begin+0x5e4/0xe84 ext4_da_write_begin+0x3b4/0x8e8 fs/ext4/inode.c:2974 generic_perform_write+0x24c/0x520 mm/filemap.c:3785 ext4_buffered_write_iter+0x3fc/0x528 fs/ext4/file.c:268 ext4_file_write_iter+0x684/0x1618 call_write_iter include/linux/fs.h:2174 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0x884/0xb44 fs/read_write.c:594 ksys_write+0x15c/0x26c fs/read_write.c:647 __do_sys_write fs/read_write.c:659 [inline] __se_sys_write fs/read_write.c:656 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:656 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #3 (&ei->i_data_sem){++++}-{3:3}: down_write+0xbc/0x12c kernel/locking/rwsem.c:1551 ext4_truncate+0x7c0/0x1058 fs/ext4/inode.c:4244 ext4_setattr+0xc48/0x1440 fs/ext4/inode.c:5553 notify_change+0xa34/0xcf8 fs/attr.c:505 do_truncate+0x1c0/0x28c fs/open.c:65 do_sys_ftruncate+0x288/0x31c fs/open.c:193 __do_sys_ftruncate fs/open.c:204 [inline] __se_sys_ftruncate fs/open.c:202 [inline] __arm64_sys_ftruncate+0x60/0x74 fs/open.c:202 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #2 (jbd2_handle){++++}-{0:0}: start_this_handle+0xfc0/0x12a4 fs/jbd2/transaction.c:464 jbd2__journal_start+0x29c/0x7b4 fs/jbd2/transaction.c:521 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:560 ocfs2_start_trans+0x468/0x804 fs/ocfs2/journal.c:354 ocfs2_mknod+0xe68/0x24f8 fs/ocfs2/namei.c:359 ocfs2_create+0x184/0x4c8 fs/ocfs2/namei.c:672 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0xf18/0x26cc fs/namei.c:3739 do_filp_open+0x1a8/0x3b4 fs/namei.c:3769 do_sys_openat2+0x128/0x3e0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_openat fs/open.c:1285 [inline] __se_sys_openat fs/open.c:1280 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1280 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #1 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 ocfs2_start_trans+0x45c/0x804 fs/ocfs2/journal.c:352 ocfs2_mknod+0xe68/0x24f8 fs/ocfs2/namei.c:359 ocfs2_create+0x184/0x4c8 fs/ocfs2/namei.c:672 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0xf18/0x26cc fs/namei.c:3739 do_filp_open+0x1a8/0x3b4 fs/namei.c:3769 do_sys_openat2+0x128/0x3e0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_openat fs/open.c:1285 [inline] __se_sys_openat fs/open.c:1280 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1280 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (sb_internal#4){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1813 [inline] sb_start_intwrite include/linux/fs.h:1930 [inline] ocfs2_start_trans+0x2dc/0x804 fs/ocfs2/journal.c:350 ocfs2_acquire_dquot+0x3b4/0xa90 fs/ocfs2/quota_global.c:843 dqget+0x664/0xd0c fs/quota/dquot.c:986 dquot_set_dqblk+0x40/0xfec fs/quota/dquot.c:2824 quota_setquota+0x5f4/0x728 fs/quota/quota.c:309 do_quotactl+0x508/0x698 fs/quota/quota.c:801 __do_sys_quotactl fs/quota/quota.c:959 [inline] __se_sys_quotactl fs/quota/quota.c:915 [inline] __arm64_sys_quotactl+0x2d8/0x7a4 fs/quota/quota.c:915 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Chain exists of: sb_internal#4 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); lock(&ocfs2_quota_ip_alloc_sem_key); lock(sb_internal#4); *** DEADLOCK *** 4 locks held by syz.2.224/5145: #0: ffff0000dc8360e0 (&type->s_umount_key#62){++++}-{3:3}, at: user_get_super+0x11c/0x240 fs/super.c:850 #1: ffff0000dd9540a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x24c/0xa90 fs/ocfs2/quota_global.c:806 #2: ffff0000ddb9ed88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #2: ffff0000ddb9ed88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 #3: ffff0000ddb9ea20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 stack backtrace: CPU: 1 PID: 5145 Comm: syz.2.224 Not tainted 5.15.169-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1813 [inline] sb_start_intwrite include/linux/fs.h:1930 [inline] ocfs2_start_trans+0x2dc/0x804 fs/ocfs2/journal.c:350 ocfs2_acquire_dquot+0x3b4/0xa90 fs/ocfs2/quota_global.c:843 dqget+0x664/0xd0c fs/quota/dquot.c:986 dquot_set_dqblk+0x40/0xfec fs/quota/dquot.c:2824 quota_setquota+0x5f4/0x728 fs/quota/quota.c:309 do_quotactl+0x508/0x698 fs/quota/quota.c:801 __do_sys_quotactl fs/quota/quota.c:959 [inline] __se_sys_quotactl fs/quota/quota.c:915 [inline] __arm64_sys_quotactl+0x2d8/0x7a4 fs/quota/quota.c:915 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584