====================================================== WARNING: possible circular locking dependency detected 6.7.0-syzkaller-12991-g7a396820222d #0 Not tainted ------------------------------------------------------ syz-executor.2/11721 is trying to acquire lock: ffff88802b005f88 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1c1/0x1090 fs/hfsplus/extents.c:457 but task is already holding lock: ffff888028b960b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x1a3/0x200 fs/hfsplus/bfind.c:30 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&tree->tree_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9d0 kernel/locking/mutex.c:752 hfsplus_file_truncate+0x882/0x9d0 fs/hfsplus/extents.c:595 hfsplus_setattr+0x1eb/0x310 fs/hfsplus/inode.c:265 notify_change+0x742/0x11c0 fs/attr.c:499 do_truncate+0x15c/0x220 fs/open.c:66 handle_truncate fs/namei.c:3299 [inline] do_open fs/namei.c:3645 [inline] path_openat+0x24b6/0x2990 fs/namei.c:3798 do_filp_open+0x1de/0x430 fs/namei.c:3825 do_sys_openat2+0x176/0x1e0 fs/open.c:1404 do_sys_open fs/open.c:1419 [inline] __do_sys_creat fs/open.c:1495 [inline] __se_sys_creat fs/open.c:1489 [inline] __x64_sys_creat+0xcd/0x120 fs/open.c:1489 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xd3/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b -> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2445/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1ae/0x520 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9d0 kernel/locking/mutex.c:752 hfsplus_file_extend+0x1c1/0x1090 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0x318/0x410 fs/hfsplus/btree.c:358 hfsplus_rename_cat+0x2ad/0x1230 fs/hfsplus/catalog.c:456 hfsplus_unlink+0x48e/0x7f0 fs/hfsplus/dir.c:376 vfs_unlink+0x2f1/0x900 fs/namei.c:4334 do_unlinkat+0x5bc/0x740 fs/namei.c:4398 __do_sys_unlink fs/namei.c:4446 [inline] __se_sys_unlink fs/namei.c:4444 [inline] __x64_sys_unlink+0xc8/0x110 fs/namei.c:4444 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xd3/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); *** DEADLOCK *** 5 locks held by syz-executor.2/11721: #0: ffff888065b18420 (sb_writers#14){.+.+}-{0:0}, at: do_unlinkat+0x1cf/0x740 fs/namei.c:4381 #1: ffff88802b0075c0 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:837 [inline] #1: ffff88802b0075c0 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: do_unlinkat+0x284/0x740 fs/namei.c:4385 #2: ffff8880634c9080 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:802 [inline] #2: ffff8880634c9080 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: vfs_unlink+0xd3/0x900 fs/namei.c:4323 #3: ffff8880769f6198 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x184/0x7f0 fs/hfsplus/dir.c:370 #4: ffff888028b960b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x1a3/0x200 fs/hfsplus/bfind.c:30 stack backtrace: CPU: 0 PID: 11721 Comm: syz-executor.2 Not tainted 6.7.0-syzkaller-12991-g7a396820222d #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106 check_noncircular+0x317/0x400 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2445/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1ae/0x520 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9d0 kernel/locking/mutex.c:752 hfsplus_file_extend+0x1c1/0x1090 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0x318/0x410 fs/hfsplus/btree.c:358 hfsplus_rename_cat+0x2ad/0x1230 fs/hfsplus/catalog.c:456 hfsplus_unlink+0x48e/0x7f0 fs/hfsplus/dir.c:376 vfs_unlink+0x2f1/0x900 fs/namei.c:4334 do_unlinkat+0x5bc/0x740 fs/namei.c:4398 __do_sys_unlink fs/namei.c:4446 [inline] __se_sys_unlink fs/namei.c:4444 [inline] __x64_sys_unlink+0xc8/0x110 fs/namei.c:4444 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xd3/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b RIP: 0033:0x7ffb0087cda9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffb016910c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000057 RAX: ffffffffffffffda RBX: 00007ffb009ac120 RCX: 00007ffb0087cda9 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000280 RBP: 00007ffb008c947a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000006e R14: 00007ffb009ac120 R15: 00007ffdd8c21838