ip_tables: iptables: counters copy to user failed while replacing table ====================================================== WARNING: possible circular locking dependency detected 4.14.171-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.1/11227 is trying to acquire lock: (rtnl_mutex){+.+.}, at: [] rtnl_lock+0x17/0x20 net/core/rtnetlink.c:72 but task is already holding lock: (&xt[i].mutex){+.+.}, at: [] xt_find_table_lock+0x3c/0x3d0 net/netfilter/x_tables.c:1092 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&xt[i].mutex){+.+.}: lock_acquire+0x16f/0x430 kernel/locking/lockdep.c:3994 __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:908 xt_find_revision+0x82/0x200 net/netfilter/x_tables.c:373 nfnl_compat_get+0x229/0x950 net/netfilter/nft_compat.c:678 nfnetlink_rcv_msg+0xa08/0xc00 net/netfilter/nfnetlink.c:214 netlink_rcv_skb+0x14f/0x3c0 net/netlink/af_netlink.c:2432 nfnetlink_rcv+0x1ab/0x1650 net/netfilter/nfnetlink.c:515 netlink_unicast_kernel net/netlink/af_netlink.c:1286 [inline] netlink_unicast+0x44d/0x650 net/netlink/af_netlink.c:1312 netlink_sendmsg+0x7c4/0xc60 net/netlink/af_netlink.c:1877 sock_sendmsg_nosec net/socket.c:646 [inline] sock_sendmsg+0xce/0x110 net/socket.c:656 ___sys_sendmsg+0x70a/0x840 net/socket.c:2062 __sys_sendmsg+0xb9/0x140 net/socket.c:2096 SYSC_sendmsg net/socket.c:2107 [inline] SyS_sendmsg+0x2d/0x50 net/socket.c:2103 do_syscall_64+0x1e8/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x42/0xb7 -> #1 (&table[i].mutex){+.+.}: lock_acquire+0x16f/0x430 kernel/locking/lockdep.c:3994 __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:908 nfnl_lock+0x24/0x30 net/netfilter/nfnetlink.c:61 nf_tables_netdev_event+0x13f/0x580 net/netfilter/nf_tables_netdev.c:122 notifier_call_chain+0x111/0x1b0 kernel/notifier.c:93 __raw_notifier_call_chain kernel/notifier.c:394 [inline] raw_notifier_call_chain+0x2e/0x40 kernel/notifier.c:401 call_netdevice_notifiers_info+0x56/0x70 net/core/dev.c:1671 call_netdevice_notifiers net/core/dev.c:1687 [inline] rollback_registered_many+0x70d/0xb60 net/core/dev.c:7205 rollback_registered+0xdd/0x180 net/core/dev.c:7247 unregister_netdevice_queue net/core/dev.c:8259 [inline] unregister_netdevice_queue+0x1ae/0x230 net/core/dev.c:8252 br_dev_delete+0x13a/0x190 net/bridge/br_if.c:318 br_dev_newlink net/bridge/br_netlink.c:1238 [inline] br_dev_newlink+0xee/0x110 net/bridge/br_netlink.c:1219 rtnl_newlink+0xecb/0x1700 net/core/rtnetlink.c:2728 rtnetlink_rcv_msg+0x3da/0xb70 net/core/rtnetlink.c:4315 netlink_rcv_skb+0x14f/0x3c0 net/netlink/af_netlink.c:2432 rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:4327 netlink_unicast_kernel net/netlink/af_netlink.c:1286 [inline] netlink_unicast+0x44d/0x650 net/netlink/af_netlink.c:1312 netlink_sendmsg+0x7c4/0xc60 net/netlink/af_netlink.c:1877 sock_sendmsg_nosec net/socket.c:646 [inline] sock_sendmsg+0xce/0x110 net/socket.c:656 ___sys_sendmsg+0x70a/0x840 net/socket.c:2062 __sys_sendmsg+0xb9/0x140 net/socket.c:2096 SYSC_sendmsg net/socket.c:2107 [inline] SyS_sendmsg+0x2d/0x50 net/socket.c:2103 do_syscall_64+0x1e8/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x42/0xb7 -> #0 (rtnl_mutex){+.+.}: check_prev_add kernel/locking/lockdep.c:1901 [inline] check_prevs_add kernel/locking/lockdep.c:2018 [inline] validate_chain kernel/locking/lockdep.c:2460 [inline] __lock_acquire+0x2cb3/0x4620 kernel/locking/lockdep.c:3487 lock_acquire+0x16f/0x430 kernel/locking/lockdep.c:3994 __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:908 rtnl_lock+0x17/0x20 net/core/rtnetlink.c:72 unregister_netdevice_notifier+0x5f/0x2c0 net/core/dev.c:1634 tee_tg_destroy+0x61/0xc0 net/netfilter/xt_TEE.c:123 cleanup_entry+0x17d/0x230 net/ipv4/netfilter/ip_tables.c:666 __do_replace+0x3c5/0x5b0 net/ipv4/netfilter/ip_tables.c:1086 do_replace net/ipv4/netfilter/ip_tables.c:1142 [inline] do_ipt_set_ctl+0x296/0x3ee net/ipv4/netfilter/ip_tables.c:1674 nf_sockopt net/netfilter/nf_sockopt.c:106 [inline] nf_setsockopt+0x67/0xc0 net/netfilter/nf_sockopt.c:115 ip_setsockopt net/ipv4/ip_sockglue.c:1255 [inline] ip_setsockopt+0x9b/0xb0 net/ipv4/ip_sockglue.c:1240 udp_setsockopt+0x4e/0x90 net/ipv4/udp.c:2451 sock_common_setsockopt+0x94/0xd0 net/core/sock.c:2968 SYSC_setsockopt net/socket.c:1865 [inline] SyS_setsockopt+0x13c/0x210 net/socket.c:1844 do_syscall_64+0x1e8/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x42/0xb7 other info that might help us debug this: Chain exists of: rtnl_mutex --> &table[i].mutex --> &xt[i].mutex Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&xt[i].mutex); lock(&table[i].mutex); lock(&xt[i].mutex); lock(rtnl_mutex); *** DEADLOCK *** 1 lock held by syz-executor.1/11227: #0: (&xt[i].mutex){+.+.}, at: [] xt_find_table_lock+0x3c/0x3d0 net/netfilter/x_tables.c:1092 stack backtrace: CPU: 1 PID: 11227 Comm: syz-executor.1 Not tainted 4.14.171-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x142/0x197 lib/dump_stack.c:58 print_circular_bug.isra.0.cold+0x1cc/0x28f kernel/locking/lockdep.c:1258 check_prev_add kernel/locking/lockdep.c:1901 [inline] check_prevs_add kernel/locking/lockdep.c:2018 [inline] validate_chain kernel/locking/lockdep.c:2460 [inline] __lock_acquire+0x2cb3/0x4620 kernel/locking/lockdep.c:3487 lock_acquire+0x16f/0x430 kernel/locking/lockdep.c:3994 __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:908 rtnl_lock+0x17/0x20 net/core/rtnetlink.c:72 unregister_netdevice_notifier+0x5f/0x2c0 net/core/dev.c:1634 tee_tg_destroy+0x61/0xc0 net/netfilter/xt_TEE.c:123 cleanup_entry+0x17d/0x230 net/ipv4/netfilter/ip_tables.c:666 __do_replace+0x3c5/0x5b0 net/ipv4/netfilter/ip_tables.c:1086 do_replace net/ipv4/netfilter/ip_tables.c:1142 [inline] do_ipt_set_ctl+0x296/0x3ee net/ipv4/netfilter/ip_tables.c:1674 nf_sockopt net/netfilter/nf_sockopt.c:106 [inline] nf_setsockopt+0x67/0xc0 net/netfilter/nf_sockopt.c:115 ip_setsockopt net/ipv4/ip_sockglue.c:1255 [inline] ip_setsockopt+0x9b/0xb0 net/ipv4/ip_sockglue.c:1240 udp_setsockopt+0x4e/0x90 net/ipv4/udp.c:2451 sock_common_setsockopt+0x94/0xd0 net/core/sock.c:2968 SYSC_setsockopt net/socket.c:1865 [inline] SyS_setsockopt+0x13c/0x210 net/socket.c:1844 do_syscall_64+0x1e8/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x42/0xb7 RIP: 0033:0x45c449 RSP: 002b:00007ff146b74c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000036 RAX: ffffffffffffffda RBX: 00007ff146b756d4 RCX: 000000000045c449 RDX: 0000000000000040 RSI: 0000000000000000 RDI: 0000000000000003 RBP: 000000000076bf20 R08: 0000000000000408 R09: 0000000000000000 R10: 0000000020000700 R11: 0000000000000246 R12: 00000000ffffffff R13: 0000000000000a0b R14: 00000000004cc75d R15: 000000000076bf2c ieee80211 phy9: hwaddr 02:00:00:00:09:00 registered ip_tables: iptables: counters copy to user failed while replacing table EXT4-fs (sda1): re-mounted. Opts: (null) device batadv0 entered promiscuous mode lo: Cannot use loopback or non-ethernet device as HSR slave. device batadv0 left promiscuous mode ieee80211 phy10: Selected rate control algorithm 'minstrel_ht' ieee80211 phy10: hwaddr 02:00:00:00:0a:00 registered device batadv0 entered promiscuous mode lo: Cannot use loopback or non-ethernet device as HSR slave. device batadv0 left promiscuous mode device batadv0 entered promiscuous mode lo: Cannot use loopback or non-ethernet device as HSR slave. device batadv0 left promiscuous mode device batadv0 entered promiscuous mode lo: Cannot use loopback or non-ethernet device as HSR slave. device batadv0 left promiscuous mode PF_BRIDGE: RTM_NEWNEIGH with invalid ifindex device batadv0 entered promiscuous mode lo: Cannot use loopback or non-ethernet device as HSR slave. device batadv0 left promiscuous mode ieee80211 phy11: Selected rate control algorithm 'minstrel_ht' ieee80211 phy11: hwaddr 02:00:00:00:0b:00 registered device batadv0 entered promiscuous mode lo: Cannot use loopback or non-ethernet device as HSR slave. device batadv0 left promiscuous mode EXT4-fs (loop5): ext4_check_descriptors: Block bitmap for group 0 overlaps block group descriptors EXT4-fs (loop5): ext4_check_descriptors: Inode table for group 0 overlaps superblock EXT4-fs (loop5): ext4_check_descriptors: Inode table for group 0 not in group (block 0)! ieee80211 phy12: Selected rate control algorithm 'minstrel_ht' EXT4-fs (loop5): group descriptors corrupted! ieee80211 phy12: hwaddr 02:00:00:00:0c:00 registered device batadv0 entered promiscuous mode lo: Cannot use loopback or non-ethernet device as HSR slave. EXT4-fs (loop5): ext4_check_descriptors: Block bitmap for group 0 overlaps block group descriptors device batadv0 left promiscuous mode EXT4-fs (loop5): ext4_check_descriptors: Inode table for group 0 overlaps superblock IPVS: ftp: loaded support on port[0] = 21 EXT4-fs (loop5): ext4_check_descriptors: Inode table for group 0 not in group (block 0)! EXT4-fs (loop5): group descriptors corrupted! ieee80211 phy13: Selected rate control algorithm 'minstrel_ht' ieee80211 phy13: hwaddr 02:00:00:00:0d:00 registered ieee80211 phy14: Selected rate control algorithm 'minstrel_ht' ieee80211 phy14: hwaddr 02:00:00:00:0e:00 registered ieee80211 phy15: Selected rate control algorithm 'minstrel_ht' IPVS: ftp: loaded support on port[0] = 21 ieee80211 phy15: hwaddr 02:00:00:00:0f:00 registered ieee80211 phy16: Selected rate control algorithm 'minstrel_ht' ieee80211 phy16: hwaddr 02:00:00:00:10:00 registered device batadv0 entered promiscuous mode lo: Cannot use loopback or non-ethernet device as HSR slave. device batadv0 left promiscuous mode ieee80211 phy17: Selected rate control algorithm 'minstrel_ht' ieee80211 phy17: hwaddr 02:00:00:00:11:00 registered IPVS: set_ctl: invalid protocol: 0 172.20.20.170:20003 IPVS: set_ctl: invalid protocol: 0 172.20.20.170:20003 ieee80211 phy18: Selected rate control algorithm 'minstrel_ht' ieee80211 phy18: hwaddr 02:00:00:00:12:00 registered device batadv0 entered promiscuous mode lo: Cannot use loopback or non-ethernet device as HSR slave. device batadv0 left promiscuous mode ieee80211 phy19: Selected rate control algorithm 'minstrel_ht' ieee80211 phy19: hwaddr 02:00:00:00:13:00 registered ieee80211 phy20: Selected rate control algorithm 'minstrel_ht' ieee80211 phy20: hwaddr 02:00:00:00:14:00 registered ieee80211 phy21: Selected rate control algorithm 'minstrel_ht' ieee80211 phy21: hwaddr 02:00:00:00:15:00 registered ieee80211 phy22: Selected rate control algorithm 'minstrel_ht' ieee80211 phy22: hwaddr 02:00:00:00:16:00 registered ieee80211 phy23: Selected rate control algorithm 'minstrel_ht' ieee80211 phy23: hwaddr 02:00:00:00:17:00 registered ieee80211 phy24: Selected rate control algorithm 'minstrel_ht' ieee80211 phy24: hwaddr 02:00:00:00:18:00 registered device batadv0 entered promiscuous mode lo: Cannot use loopback or non-ethernet device as HSR slave. device batadv0 left promiscuous mode ieee80211 phy25: Selected rate control algorithm 'minstrel_ht' ieee80211 phy25: hwaddr 02:00:00:00:19:00 registered IPVS: ftp: loaded support on port[0] = 21 ieee80211 phy26: Selected rate control algorithm 'minstrel_ht' ieee80211 phy26: hwaddr 02:00:00:00:1a:00 registered ieee80211 phy27: Selected rate control algorithm 'minstrel_ht' ieee80211 phy27: hwaddr 02:00:00:00:1b:00 registered ieee80211 phy28: Selected rate control algorithm 'minstrel_ht' ieee80211 phy28: hwaddr 02:00:00:00:1c:00 registered device batadv0 entered promiscuous mode lo: Cannot use loopback or non-ethernet device as HSR slave. device batadv0 left promiscuous mode ieee80211 phy29: Selected rate control algorithm 'minstrel_ht' ieee80211 phy29: hwaddr 02:00:00:00:1d:00 registered IPVS: ftp: loaded support on port[0] = 21 ieee80211 phy30: Selected rate control algorithm 'minstrel_ht' ieee80211 phy30: hwaddr 02:00:00:00:1e:00 registered ieee80211 phy31: Selected rate control algorithm 'minstrel_ht' ieee80211 phy31: hwaddr 02:00:00:00:1f:00 registered device batadv0 entered promiscuous mode lo: Cannot use loopback or non-ethernet device as HSR slave. device batadv0 left promiscuous mode ieee80211 phy32: Selected rate control algorithm 'minstrel_ht' ieee80211 phy32: hwaddr 02:00:00:00:20:00 registered IPVS: ftp: loaded support on port[0] = 21 ieee80211 phy33: Selected rate control algorithm 'minstrel_ht' ieee80211 phy33: hwaddr 02:00:00:00:21:00 registered device batadv0 entered promiscuous mode lo: Cannot use loopback or non-ethernet device as HSR slave. device batadv0 left promiscuous mode ieee80211 phy34: Selected rate control algorithm 'minstrel_ht' ieee80211 phy34: hwaddr 02:00:00:00:22:00 registered ieee80211 phy35: Selected rate control algorithm 'minstrel_ht' ieee80211 phy35: hwaddr 02:00:00:00:23:00 registered device batadv0 entered promiscuous mode lo: Cannot use loopback or non-ethernet device as HSR slave. device batadv0 left promiscuous mode IPVS: ftp: loaded support on port[0] = 21 device batadv0 entered promiscuous mode lo: Cannot use loopback or non-ethernet device as HSR slave. device batadv0 left promiscuous mode ieee80211 phy36: Selected rate control algorithm 'minstrel_ht' ieee80211 phy36: hwaddr 02:00:00:00:24:00 registered device batadv0 entered promiscuous mode lo: Cannot use loopback or non-ethernet device as HSR slave. device batadv0 left promiscuous mode IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 device batadv0 entered promiscuous mode lo: Cannot use loopback or non-ethernet device as HSR slave. device batadv0 left promiscuous mode ieee80211 phy37: Selected rate control algorithm 'minstrel_ht' ieee80211 phy37: hwaddr 02:00:00:00:25:00 registered IPVS: ftp: loaded support on port[0] = 21