====================================================== WARNING: possible circular locking dependency detected 6.3.0-syzkaller-13027-g1a5304fecee5 #0 Not tainted ------------------------------------------------------ syz-executor.3/24872 is trying to acquire lock: ffff8880344ce0b0 (&tree->tree_lock/1 ){+.+.}-{3:3}, at: hfs_find_init+0x16e/0x1f0 but task is already holding lock: ffff888075ba27f8 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}, at: hfs_get_block+0x26f/0xb60 fs/hfs/extent.c:365 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5691 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799 hfs_extend_file+0xff/0x1440 fs/hfs/extent.c:397 hfs_bmap_reserve+0xd9/0x3f0 fs/hfs/btree.c:234 __hfs_ext_write_extent+0x22e/0x4f0 fs/hfs/extent.c:121 __hfs_ext_cache_extent+0x6a/0x990 fs/hfs/extent.c:174 hfs_ext_read_extent fs/hfs/extent.c:202 [inline] hfs_extend_file+0x344/0x1440 fs/hfs/extent.c:401 hfs_get_block+0x3e4/0xb60 fs/hfs/extent.c:353 __block_write_begin_int+0x548/0x1a50 fs/buffer.c:2064 __block_write_begin fs/buffer.c:2114 [inline] block_write_begin+0x9c/0x1f0 fs/buffer.c:2175 cont_write_begin+0x643/0x880 fs/buffer.c:2534 hfs_write_begin+0x8a/0xd0 fs/hfs/inode.c:58 cont_expand_zero fs/buffer.c:2461 [inline] cont_write_begin+0x316/0x880 fs/buffer.c:2524 hfs_write_begin+0x8a/0xd0 fs/hfs/inode.c:58 hfs_file_truncate+0x1ed/0xa20 fs/hfs/extent.c:494 hfs_inode_setattr+0x461/0x6a0 fs/hfs/inode.c:656 notify_change+0xc8b/0xf40 fs/attr.c:483 do_truncate+0x220/0x300 fs/open.c:66 do_sys_ftruncate+0x2e4/0x380 fs/open.c:194 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&tree->tree_lock/1){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3108 [inline] check_prevs_add kernel/locking/lockdep.c:3227 [inline] validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3842 __lock_acquire+0x1295/0x2000 kernel/locking/lockdep.c:5074 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5691 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799 hfs_find_init+0x16e/0x1f0 hfs_ext_read_extent fs/hfs/extent.c:200 [inline] hfs_get_block+0x4f4/0xb60 fs/hfs/extent.c:366 block_read_full_folio+0x47b/0x1000 fs/buffer.c:2349 filemap_read_folio+0x19d/0x7a0 mm/filemap.c:2421 do_read_cache_folio+0x134/0x820 mm/filemap.c:3680 do_read_cache_page+0x32/0x220 mm/filemap.c:3746 read_mapping_page include/linux/pagemap.h:772 [inline] hfs_btree_open+0x50b/0xf20 fs/hfs/btree.c:78 hfs_mdb_get+0x14c4/0x21b0 fs/hfs/mdb.c:204 hfs_fill_super+0x107d/0x1790 fs/hfs/super.c:406 mount_bdev+0x274/0x3a0 fs/super.c:1380 legacy_get_tree+0xef/0x190 fs/fs_context.c:610 vfs_get_tree+0x8c/0x270 fs/super.c:1510 do_new_mount+0x28f/0xae0 fs/namespace.c:3039 do_mount fs/namespace.c:3382 [inline] __do_sys_mount fs/namespace.c:3591 [inline] __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3568 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFS_I(tree->inode)->extents_lock); lock(&tree->tree_lock/1); lock(&HFS_I(tree->inode)->extents_lock); lock(&tree->tree_lock/1); *** DEADLOCK *** 2 locks held by syz-executor.3/24872: #0: ffff88807b0780e0 (&type->s_umount_key#49/1){+.+.}-{3:3}, at: alloc_super+0x217/0x930 fs/super.c:228 #1: ffff888075ba27f8 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}, at: hfs_get_block+0x26f/0xb60 fs/hfs/extent.c:365 stack backtrace: CPU: 0 PID: 24872 Comm: syz-executor.3 Not tainted 6.3.0-syzkaller-13027-g1a5304fecee5 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/14/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2fe/0x3b0 kernel/locking/lockdep.c:2188 check_prev_add kernel/locking/lockdep.c:3108 [inline] check_prevs_add kernel/locking/lockdep.c:3227 [inline] validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3842 __lock_acquire+0x1295/0x2000 kernel/locking/lockdep.c:5074 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5691 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799 hfs_find_init+0x16e/0x1f0 hfs_ext_read_extent fs/hfs/extent.c:200 [inline] hfs_get_block+0x4f4/0xb60 fs/hfs/extent.c:366 block_read_full_folio+0x47b/0x1000 fs/buffer.c:2349 filemap_read_folio+0x19d/0x7a0 mm/filemap.c:2421 do_read_cache_folio+0x134/0x820 mm/filemap.c:3680 do_read_cache_page+0x32/0x220 mm/filemap.c:3746 read_mapping_page include/linux/pagemap.h:772 [inline] hfs_btree_open+0x50b/0xf20 fs/hfs/btree.c:78 hfs_mdb_get+0x14c4/0x21b0 fs/hfs/mdb.c:204 hfs_fill_super+0x107d/0x1790 fs/hfs/super.c:406 mount_bdev+0x274/0x3a0 fs/super.c:1380 legacy_get_tree+0xef/0x190 fs/fs_context.c:610 vfs_get_tree+0x8c/0x270 fs/super.c:1510 do_new_mount+0x28f/0xae0 fs/namespace.c:3039 do_mount fs/namespace.c:3382 [inline] __do_sys_mount fs/namespace.c:3591 [inline] __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3568 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f4d0088d69a Code: 48 c7 c2 b8 ff ff ff f7 d8 64 89 02 b8 ff ff ff ff eb d2 e8 b8 04 00 00 0f 1f 84 00 00 00 00 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f4d01674f88 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00000000000002a0 RCX: 00007f4d0088d69a RDX: 0000000020000100 RSI: 0000000020000080 RDI: 00007f4d01674fe0 RBP: 00007f4d01675020 R08: 00007f4d01675020 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000202 R12: 0000000020000100 R13: 0000000020000080 R14: 00007f4d01674fe0 R15: 0000000020000040 hfs: unable to open catalog tree hfs: can't find a HFS filesystem on dev loop3