====================================================== WARNING: possible circular locking dependency detected 6.13.0-rc3-next-20241218-syzkaller #0 Not tainted ------------------------------------------------------ syz.6.139/6690 is trying to acquire lock: ffff88807810bff8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_init_acl+0x397/0x930 fs/ocfs2/acl.c:366 but task is already holding lock: ffff88803415e950 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1e94/0x2110 fs/jbd2/transaction.c:448 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (jbd2_handle){++++}-{0:0}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 start_this_handle+0x1eb4/0x2110 fs/jbd2/transaction.c:448 jbd2__journal_start+0x2da/0x5d0 fs/jbd2/transaction.c:505 jbd2_journal_start+0x29/0x40 fs/jbd2/transaction.c:544 ocfs2_start_trans+0x3c9/0x700 fs/ocfs2/journal.c:352 ocfs2_mknod+0x150c/0x2b30 fs/ocfs2/namei.c:361 ocfs2_create+0x1ab/0x470 fs/ocfs2/namei.c:674 lookup_open fs/namei.c:3649 [inline] open_last_lookups fs/namei.c:3748 [inline] path_openat+0x192f/0x3580 fs/namei.c:3984 do_filp_open+0x27f/0x4e0 fs/namei.c:4014 do_sys_openat2+0x13e/0x1d0 fs/open.c:1427 do_sys_open fs/open.c:1442 [inline] __do_sys_open fs/open.c:1450 [inline] __se_sys_open fs/open.c:1446 [inline] __x64_sys_open+0x225/0x270 fs/open.c:1446 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #3 (&journal->j_trans_barrier){.+.+}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x3be/0x700 fs/ocfs2/journal.c:350 ocfs2_mknod+0x150c/0x2b30 fs/ocfs2/namei.c:361 ocfs2_create+0x1ab/0x470 fs/ocfs2/namei.c:674 lookup_open fs/namei.c:3649 [inline] open_last_lookups fs/namei.c:3748 [inline] path_openat+0x192f/0x3580 fs/namei.c:3984 do_filp_open+0x27f/0x4e0 fs/namei.c:4014 do_sys_openat2+0x13e/0x1d0 fs/open.c:1427 do_sys_open fs/open.c:1442 [inline] __do_sys_open fs/open.c:1450 [inline] __se_sys_open fs/open.c:1446 [inline] __x64_sys_open+0x225/0x270 fs/open.c:1446 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (sb_internal#3){.+.+}-{0:0}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1771 [inline] sb_start_intwrite include/linux/fs.h:1954 [inline] ocfs2_start_trans+0x2b9/0x700 fs/ocfs2/journal.c:348 ocfs2_orphan_for_truncate fs/ocfs2/file.c:396 [inline] ocfs2_truncate_file+0x69a/0x1560 fs/ocfs2/file.c:500 ocfs2_setattr+0x1890/0x1ef0 fs/ocfs2/file.c:1212 notify_change+0xbca/0xe90 fs/attr.c:552 do_truncate+0x220/0x310 fs/open.c:65 handle_truncate fs/namei.c:3449 [inline] do_open fs/namei.c:3832 [inline] path_openat+0x2e0e/0x3580 fs/namei.c:3987 do_filp_open+0x27f/0x4e0 fs/namei.c:4014 do_sys_openat2+0x13e/0x1d0 fs/open.c:1427 do_sys_open fs/open.c:1442 [inline] __do_sys_openat fs/open.c:1458 [inline] __se_sys_openat fs/open.c:1453 [inline] __x64_sys_openat+0x247/0x2a0 fs/open.c:1453 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&oi->ip_alloc_sem){++++}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 ocfs2_try_remove_refcount_tree+0xb6/0x330 fs/ocfs2/refcounttree.c:932 ocfs2_truncate_file+0xe1b/0x1560 fs/ocfs2/file.c:521 ocfs2_setattr+0x1890/0x1ef0 fs/ocfs2/file.c:1212 notify_change+0xbca/0xe90 fs/attr.c:552 do_truncate+0x220/0x310 fs/open.c:65 handle_truncate fs/namei.c:3449 [inline] do_open fs/namei.c:3832 [inline] path_openat+0x2e0e/0x3580 fs/namei.c:3987 do_filp_open+0x27f/0x4e0 fs/namei.c:4014 do_sys_openat2+0x13e/0x1d0 fs/open.c:1427 do_sys_open fs/open.c:1442 [inline] __do_sys_openat fs/open.c:1458 [inline] __se_sys_openat fs/open.c:1453 [inline] __x64_sys_openat+0x247/0x2a0 fs/open.c:1453 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&oi->ip_xattr_sem){++++}-{4:4}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524 ocfs2_init_acl+0x397/0x930 fs/ocfs2/acl.c:366 ocfs2_mknod+0x1c05/0x2b30 fs/ocfs2/namei.c:410 ocfs2_create+0x1ab/0x470 fs/ocfs2/namei.c:674 vfs_create+0x23c/0x3d0 fs/namei.c:3348 do_mknodat+0x447/0x5b0 fs/namei.c:4239 __do_sys_mknod fs/namei.c:4272 [inline] __se_sys_mknod fs/namei.c:4270 [inline] __x64_sys_mknod+0x8c/0xa0 fs/namei.c:4270 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &oi->ip_xattr_sem --> &journal->j_trans_barrier --> jbd2_handle Possible unsafe locking scenario: CPU0 CPU1 ---- ---- rlock(jbd2_handle); lock(&journal->j_trans_barrier); lock(jbd2_handle); rlock(&oi->ip_xattr_sem); *** DEADLOCK *** 8 locks held by syz.6.139/6690: #0: ffff8880327fc420 (sb_writers#16){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:548 #1: ffff88807810c2c0 (&type->i_mutex_dir_key#10/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:898 [inline] #1: ffff88807810c2c0 (&type->i_mutex_dir_key#10/1){+.+.}-{4:4}, at: filename_create+0x260/0x540 fs/namei.c:4080 #2: ffff8880500c09c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:863 [inline] #2: ffff8880500c09c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x192/0x4e70 fs/ocfs2/suballoc.c:786 #3: ffff88807810ed80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:863 [inline] #3: ffff88807810ed80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x192/0x4e70 fs/ocfs2/suballoc.c:786 #4: ffff8880500c2640 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:863 [inline] #4: ffff8880500c2640 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}, at: ocfs2_reserve_local_alloc_bits+0x132/0x2840 fs/ocfs2/localalloc.c:636 #5: ffff8880327fc610 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_mknod+0x150c/0x2b30 fs/ocfs2/namei.c:361 #6: ffff8880213420e8 (&journal->j_trans_barrier){.+.+}-{4:4}, at: ocfs2_start_trans+0x3be/0x700 fs/ocfs2/journal.c:350 #7: ffff88803415e950 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1e94/0x2110 fs/jbd2/transaction.c:448 stack backtrace: CPU: 0 UID: 0 PID: 6690 Comm: syz.6.139 Not tainted 6.13.0-rc3-next-20241218-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/25/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524 ocfs2_init_acl+0x397/0x930 fs/ocfs2/acl.c:366 ocfs2_mknod+0x1c05/0x2b30 fs/ocfs2/namei.c:410 ocfs2_create+0x1ab/0x470 fs/ocfs2/namei.c:674 vfs_create+0x23c/0x3d0 fs/namei.c:3348 do_mknodat+0x447/0x5b0 fs/namei.c:4239 __do_sys_mknod fs/namei.c:4272 [inline] __se_sys_mknod fs/namei.c:4270 [inline] __x64_sys_mknod+0x8c/0xa0 fs/namei.c:4270 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f9fd2785d29 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f9fd354e038 EFLAGS: 00000246 ORIG_RAX: 0000000000000085 RAX: ffffffffffffffda RBX: 00007f9fd2975fa0 RCX: 00007f9fd2785d29 RDX: 000000000000070c RSI: 0000000000000000 RDI: 0000000020000000 RBP: 00007f9fd2801a20 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f9fd2975fa0 R15: 00007ffcea63db48 syz.6.139 (6690) used greatest stack depth: 16984 bytes left