====================================================== WARNING: possible circular locking dependency detected 5.15.169-syzkaller #0 Not tainted ------------------------------------------------------ syz.0.18/3805 is trying to acquire lock: ffff888062403488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] ffff888062403488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x18e/0x4c70 fs/ocfs2/suballoc.c:782 but task is already holding lock: ffff888062419808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] ffff888062419808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0x12e/0x27a0 fs/ocfs2/localalloc.c:635 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:789 [inline] ocfs2_reserve_local_alloc_bits+0x12e/0x27a0 fs/ocfs2/localalloc.c:635 ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline] ocfs2_lock_allocators+0x306/0x620 fs/ocfs2/suballoc.c:2669 ocfs2_extend_allocation+0x4e8/0x1ba0 fs/ocfs2/file.c:588 ocfs2_extend_no_holes+0x1f2/0x490 fs/ocfs2/file.c:1030 ocfs2_acquire_dquot+0x631/0xb40 fs/ocfs2/quota_global.c:836 dqget+0x762/0xe90 fs/quota/dquot.c:986 ocfs2_setattr+0xcf3/0x1c70 fs/ocfs2/file.c:1233 notify_change+0xc6d/0xf50 fs/attr.c:505 chown_common+0x592/0x890 fs/open.c:680 vfs_fchown fs/open.c:748 [inline] ksys_fchown+0xde/0x150 fs/open.c:759 __do_sys_fchown fs/open.c:767 [inline] __se_sys_fchown fs/open.c:765 [inline] __x64_sys_fchown+0x76/0x80 fs/open.c:765 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #7 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x299/0xb40 fs/ocfs2/quota_global.c:811 dqget+0x762/0xe90 fs/quota/dquot.c:986 ocfs2_setattr+0xcf3/0x1c70 fs/ocfs2/file.c:1233 notify_change+0xc6d/0xf50 fs/attr.c:505 chown_common+0x592/0x890 fs/open.c:680 vfs_fchown fs/open.c:748 [inline] ksys_fchown+0xde/0x150 fs/open.c:759 __do_sys_fchown fs/open.c:767 [inline] __se_sys_fchown fs/open.c:765 [inline] __x64_sys_fchown+0x76/0x80 fs/open.c:765 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:789 [inline] ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x299/0xb40 fs/ocfs2/quota_global.c:811 dqget+0x762/0xe90 fs/quota/dquot.c:986 ocfs2_setattr+0xcf3/0x1c70 fs/ocfs2/file.c:1233 notify_change+0xc6d/0xf50 fs/attr.c:505 chown_common+0x592/0x890 fs/open.c:680 vfs_fchown fs/open.c:748 [inline] ksys_fchown+0xde/0x150 fs/open.c:759 __do_sys_fchown fs/open.c:767 [inline] __se_sys_fchown fs/open.c:765 [inline] __x64_sys_fchown+0x76/0x80 fs/open.c:765 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #5 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6173 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_alloc_space+0xdd8/0x1090 fs/quota/dquot.c:1750 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline] dquot_alloc_space include/linux/quotaops.h:310 [inline] dquot_alloc_block include/linux/quotaops.h:334 [inline] ext4_mb_new_blocks+0x12d8/0x4d60 fs/ext4/mballoc.c:5739 ext4_ext_map_blocks+0x1b01/0x7630 fs/ext4/extents.c:4339 ext4_map_blocks+0xa66/0x1c70 fs/ext4/inode.c:672 _ext4_get_block+0x23b/0x660 fs/ext4/inode.c:815 ext4_block_write_begin+0x6b0/0x13a0 fs/ext4/inode.c:1100 ext4_write_begin+0x6c6/0x15f0 generic_perform_write+0x2bf/0x5b0 mm/filemap.c:3785 ext4_buffered_write_iter+0x227/0x360 fs/ext4/file.c:268 ext4_file_write_iter+0x1d1/0x1940 fs/ext4/file.c:662 call_write_iter include/linux/fs.h:2174 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0xacd/0xe50 fs/read_write.c:594 ksys_write+0x1a2/0x2c0 fs/read_write.c:647 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #4 (&ei->i_data_sem){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 ext4_map_blocks+0x9a2/0x1c70 fs/ext4/inode.c:665 mpage_map_one_extent fs/ext4/inode.c:2407 [inline] mpage_map_and_submit_extent fs/ext4/inode.c:2460 [inline] ext4_writepages+0x160e/0x3d10 fs/ext4/inode.c:2828 do_writepages+0x481/0x730 mm/page-writeback.c:2386 __writeback_single_inode+0x15b/0xe30 fs/fs-writeback.c:1647 writeback_sb_inodes+0xbce/0x1a40 fs/fs-writeback.c:1930 __writeback_inodes_wb+0x114/0x400 fs/fs-writeback.c:2001 wb_writeback+0x465/0xc50 fs/fs-writeback.c:2106 wb_check_background_flush fs/fs-writeback.c:2172 [inline] wb_do_writeback fs/fs-writeback.c:2260 [inline] wb_workfn+0xd07/0x1130 fs/fs-writeback.c:2288 process_one_work+0x8a1/0x10c0 kernel/workqueue.c:2310 worker_thread+0xaca/0x1280 kernel/workqueue.c:2457 kthread+0x3f6/0x4f0 kernel/kthread.c:334 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287 -> #3 (jbd2_handle){++++}-{0:0}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 start_this_handle+0x12e1/0x1570 fs/jbd2/transaction.c:464 jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:521 jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:560 ocfs2_start_trans+0x3c2/0x6f0 fs/ocfs2/journal.c:354 ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416 ocfs2_dismount_volume+0x1db/0x8b0 fs/ocfs2/super.c:1882 generic_shutdown_super+0x130/0x310 fs/super.c:475 kill_block_super+0x7a/0xe0 fs/super.c:1427 deactivate_locked_super+0xa0/0x110 fs/super.c:335 cleanup_mnt+0x44e/0x500 fs/namespace.c:1143 task_work_run+0x129/0x1a0 kernel/task_work.c:188 tracehook_notify_resume include/linux/tracehook.h:189 [inline] exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214 __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline] syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307 do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #2 (&journal->j_trans_barrier){.+.+}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 ocfs2_start_trans+0x3b7/0x6f0 fs/ocfs2/journal.c:352 ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416 ocfs2_dismount_volume+0x1db/0x8b0 fs/ocfs2/super.c:1882 generic_shutdown_super+0x130/0x310 fs/super.c:475 kill_block_super+0x7a/0xe0 fs/super.c:1427 deactivate_locked_super+0xa0/0x110 fs/super.c:335 cleanup_mnt+0x44e/0x500 fs/namespace.c:1143 task_work_run+0x129/0x1a0 kernel/task_work.c:188 tracehook_notify_resume include/linux/tracehook.h:189 [inline] exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214 __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline] syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307 do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (sb_internal#5){.+.+}-{0:0}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1813 [inline] sb_start_intwrite include/linux/fs.h:1930 [inline] ocfs2_start_trans+0x2b2/0x6f0 fs/ocfs2/journal.c:350 ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416 ocfs2_dismount_volume+0x1db/0x8b0 fs/ocfs2/super.c:1882 generic_shutdown_super+0x130/0x310 fs/super.c:475 kill_block_super+0x7a/0xe0 fs/super.c:1427 deactivate_locked_super+0xa0/0x110 fs/super.c:335 cleanup_mnt+0x44e/0x500 fs/namespace.c:1143 task_work_run+0x129/0x1a0 kernel/task_work.c:188 tracehook_notify_resume include/linux/tracehook.h:189 [inline] exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214 __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline] syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307 do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:789 [inline] ocfs2_reserve_suballoc_bits+0x18e/0x4c70 fs/ocfs2/suballoc.c:782 ocfs2_reserve_cluster_bitmap_bits+0xc1/0x1d0 fs/ocfs2/suballoc.c:1128 ocfs2_local_alloc_reserve_for_window fs/ocfs2/localalloc.c:1131 [inline] ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1267 [inline] ocfs2_reserve_local_alloc_bits+0x941/0x27a0 fs/ocfs2/localalloc.c:668 ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline] ocfs2_lock_allocators+0x306/0x620 fs/ocfs2/suballoc.c:2669 ocfs2_extend_allocation+0x4e8/0x1ba0 fs/ocfs2/file.c:588 ocfs2_extend_no_holes+0x1f2/0x490 fs/ocfs2/file.c:1030 ocfs2_acquire_dquot+0x631/0xb40 fs/ocfs2/quota_global.c:836 dqget+0x762/0xe90 fs/quota/dquot.c:986 ocfs2_setattr+0xcf3/0x1c70 fs/ocfs2/file.c:1233 notify_change+0xc6d/0xf50 fs/attr.c:505 chown_common+0x592/0x890 fs/open.c:680 vfs_fchown fs/open.c:748 [inline] ksys_fchown+0xde/0x150 fs/open.c:759 __do_sys_fchown fs/open.c:767 [inline] __se_sys_fchown fs/open.c:765 [inline] __x64_sys_fchown+0x76/0x80 fs/open.c:765 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3 --> &ocfs2_quota_ip_alloc_sem_key --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5); lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3); *** DEADLOCK *** 6 locks held by syz.0.18/3805: #0: ffff88807d440460 (sb_writers#21){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:421 #1: ffff8880738009c8 (&type->i_mutex_dir_key#16){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #1: ffff8880738009c8 (&type->i_mutex_dir_key#16){+.+.}-{3:3}, at: chown_common+0x499/0x890 fs/open.c:674 #2: ffff8880624220a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x28c/0xb40 fs/ocfs2/quota_global.c:806 #3: ffff8880624042c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #3: ffff8880624042c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313 #4: ffff888062403f60 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314 #5: ffff888062419808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #5: ffff888062419808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0x12e/0x27a0 fs/ocfs2/localalloc.c:635 stack backtrace: CPU: 0 PID: 3805 Comm: syz.0.18 Not tainted 5.15.169-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:789 [inline] ocfs2_reserve_suballoc_bits+0x18e/0x4c70 fs/ocfs2/suballoc.c:782 ocfs2_reserve_cluster_bitmap_bits+0xc1/0x1d0 fs/ocfs2/suballoc.c:1128 ocfs2_local_alloc_reserve_for_window fs/ocfs2/localalloc.c:1131 [inline] ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1267 [inline] ocfs2_reserve_local_alloc_bits+0x941/0x27a0 fs/ocfs2/localalloc.c:668 ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline] ocfs2_lock_allocators+0x306/0x620 fs/ocfs2/suballoc.c:2669 ocfs2_extend_allocation+0x4e8/0x1ba0 fs/ocfs2/file.c:588 ocfs2_extend_no_holes+0x1f2/0x490 fs/ocfs2/file.c:1030 ocfs2_acquire_dquot+0x631/0xb40 fs/ocfs2/quota_global.c:836 dqget+0x762/0xe90 fs/quota/dquot.c:986 ocfs2_setattr+0xcf3/0x1c70 fs/ocfs2/file.c:1233 notify_change+0xc6d/0xf50 fs/attr.c:505 chown_common+0x592/0x890 fs/open.c:680 vfs_fchown fs/open.c:748 [inline] ksys_fchown+0xde/0x150 fs/open.c:759 __do_sys_fchown fs/open.c:767 [inline] __se_sys_fchown fs/open.c:765 [inline] __x64_sys_fchown+0x76/0x80 fs/open.c:765 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7fa7ab7afff9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fa7a9c28038 EFLAGS: 00000246 ORIG_RAX: 000000000000005d RAX: ffffffffffffffda RBX: 00007fa7ab967f80 RCX: 00007fa7ab7afff9 RDX: 0000000000000000 RSI: 000000003a736e6f RDI: 0000000000000004 RBP: 00007fa7ab822296 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fa7ab967f80 R15: 00007ffe0c33d2a8 (syz.0.18,3805,1):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xdf8356d3, computed 0x5b86c303. Applying ECC. (syz.0.18,3805,1):ocfs2_block_check_validate:416 ERROR: Fixed CRC32 failed: stored: 0xdf8356d3, computed 0x4bf4182b (syz.0.18,3805,1):ocfs2_read_quota_phys_block:160 ERROR: status = -5 (syz.0.18,3805,1):ocfs2_quota_read:201 ERROR: status = -5 Quota error (device loop0): qtree_write_dquot: Error -5 occurred while creating quota (syz.0.18,3805,1):ocfs2_acquire_dquot:873 ERROR: status = -5