====================================================== WARNING: possible circular locking dependency detected 6.14.0-rc1-syzkaller-00026-gd009de7d5428 #0 Not tainted ------------------------------------------------------ syz.2.9185/26853 is trying to acquire lock: ffff888059d7a610 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_acquire_dquot+0x6df/0xb70 fs/ocfs2/quota_global.c:860 but task is already holding lock: ffff88807b146a20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x225/0x2b0 fs/ocfs2/quota_global.c:314 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 ocfs2_lock_global_qf+0x225/0x2b0 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x2b0/0xb70 fs/ocfs2/quota_global.c:828 dqget+0x772/0xeb0 fs/quota/dquot.c:977 __dquot_initialize+0x2e3/0xec0 fs/quota/dquot.c:1505 ocfs2_get_init_inode+0x158/0x1d0 fs/ocfs2/namei.c:202 ocfs2_mknod+0xcfa/0x2b30 fs/ocfs2/namei.c:310 ocfs2_mkdir+0x1ab/0x470 fs/ocfs2/namei.c:656 vfs_mkdir+0x2fb/0x4f0 fs/namei.c:4313 do_mkdirat+0x264/0x3a0 fs/namei.c:4336 __do_sys_mkdirat fs/namei.c:4351 [inline] __se_sys_mkdirat fs/namei.c:4349 [inline] __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4349 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:865 [inline] ocfs2_lock_global_qf+0x206/0x2b0 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x2b0/0xb70 fs/ocfs2/quota_global.c:828 dqget+0x772/0xeb0 fs/quota/dquot.c:977 __dquot_initialize+0x2e3/0xec0 fs/quota/dquot.c:1505 ocfs2_get_init_inode+0x158/0x1d0 fs/ocfs2/namei.c:202 ocfs2_mknod+0xcfa/0x2b30 fs/ocfs2/namei.c:310 ocfs2_mkdir+0x1ab/0x470 fs/ocfs2/namei.c:656 vfs_mkdir+0x2fb/0x4f0 fs/namei.c:4313 do_mkdirat+0x264/0x3a0 fs/namei.c:4336 __do_sys_mkdirat fs/namei.c:4351 [inline] __se_sys_mkdirat fs/namei.c:4349 [inline] __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4349 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #4 (&dquot->dq_lock){+.+.}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x19c/0x1010 kernel/locking/mutex.c:730 wait_on_dquot fs/quota/dquot.c:354 [inline] dqget+0x6e6/0xeb0 fs/quota/dquot.c:972 dquot_transfer+0x2c2/0x6d0 fs/quota/dquot.c:2140 ext4_setattr+0xb49/0x1da0 fs/ext4/inode.c:5401 notify_change+0xbcc/0xe90 fs/attr.c:552 chown_common+0x501/0x850 fs/open.c:782 do_fchownat+0x16a/0x240 fs/open.c:813 __do_sys_lchown fs/open.c:838 [inline] __se_sys_lchown fs/open.c:836 [inline] __x64_sys_lchown+0x85/0xa0 fs/open.c:836 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #3 (&ei->xattr_sem){++++}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524 ext4_setattr+0xb37/0x1da0 fs/ext4/inode.c:5400 notify_change+0xbcc/0xe90 fs/attr.c:552 chown_common+0x501/0x850 fs/open.c:782 do_fchownat+0x16a/0x240 fs/open.c:813 __do_sys_chown fs/open.c:833 [inline] __se_sys_chown fs/open.c:831 [inline] __x64_sys_chown+0x82/0x90 fs/open.c:831 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (jbd2_handle){++++}-{0:0}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 start_this_handle+0x1eb4/0x2110 fs/jbd2/transaction.c:448 jbd2__journal_start+0x2da/0x5d0 fs/jbd2/transaction.c:505 jbd2_journal_start+0x29/0x40 fs/jbd2/transaction.c:544 ocfs2_start_trans+0x3c9/0x700 fs/ocfs2/journal.c:352 ocfs2_shutdown_local_alloc+0x218/0xa90 fs/ocfs2/localalloc.c:417 ocfs2_dismount_volume+0x202/0x910 fs/ocfs2/super.c:1822 generic_shutdown_super+0x13b/0x2d0 fs/super.c:642 kill_block_super+0x44/0x90 fs/super.c:1710 deactivate_locked_super+0xc6/0x130 fs/super.c:473 cleanup_mnt+0x41f/0x4b0 fs/namespace.c:1413 task_work_run+0x251/0x310 kernel/task_work.c:227 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] exit_to_user_mode_loop kernel/entry/common.c:114 [inline] exit_to_user_mode_prepare include/linux/entry-common.h:329 [inline] __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline] syscall_exit_to_user_mode+0x13f/0x340 kernel/entry/common.c:218 do_syscall_64+0x100/0x230 arch/x86/entry/common.c:89 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&journal->j_trans_barrier){.+.+}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x3be/0x700 fs/ocfs2/journal.c:350 ocfs2_shutdown_local_alloc+0x218/0xa90 fs/ocfs2/localalloc.c:417 ocfs2_dismount_volume+0x202/0x910 fs/ocfs2/super.c:1822 generic_shutdown_super+0x13b/0x2d0 fs/super.c:642 kill_block_super+0x44/0x90 fs/super.c:1710 deactivate_locked_super+0xc6/0x130 fs/super.c:473 cleanup_mnt+0x41f/0x4b0 fs/namespace.c:1413 task_work_run+0x251/0x310 kernel/task_work.c:227 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] exit_to_user_mode_loop kernel/entry/common.c:114 [inline] exit_to_user_mode_prepare include/linux/entry-common.h:329 [inline] __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline] syscall_exit_to_user_mode+0x13f/0x340 kernel/entry/common.c:218 do_syscall_64+0x100/0x230 arch/x86/entry/common.c:89 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (sb_internal#3){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3163 [inline] check_prevs_add kernel/locking/lockdep.c:3282 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3906 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5228 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1773 [inline] sb_start_intwrite include/linux/fs.h:1956 [inline] ocfs2_start_trans+0x2b9/0x700 fs/ocfs2/journal.c:348 ocfs2_acquire_dquot+0x6df/0xb70 fs/ocfs2/quota_global.c:860 dqget+0x772/0xeb0 fs/quota/dquot.c:977 dquot_get_next_dqblk+0xbd/0x3a0 fs/quota/dquot.c:2705 quota_getnextquota+0x2c7/0x6c0 fs/quota/quota.c:250 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl+0x2c4/0xa30 fs/quota/quota.c:917 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: sb_internal#3 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); lock(&ocfs2_quota_ip_alloc_sem_key); rlock(sb_internal#3); *** DEADLOCK *** 4 locks held by syz.2.9185/26853: #0: ffff888059d7a0e0 (&type->s_umount_key#90){++++}-{4:4}, at: __super_lock fs/super.c:58 [inline] #0: ffff888059d7a0e0 (&type->s_umount_key#90){++++}-{4:4}, at: super_lock+0x27c/0x400 fs/super.c:120 #1: ffff88807b2600a8 (&dquot->dq_lock){+.+.}-{4:4}, at: ocfs2_acquire_dquot+0x2a3/0xb70 fs/ocfs2/quota_global.c:823 #2: ffff88807b146d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:865 [inline] #2: ffff88807b146d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x206/0x2b0 fs/ocfs2/quota_global.c:313 #3: ffff88807b146a20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x225/0x2b0 fs/ocfs2/quota_global.c:314 stack backtrace: CPU: 1 UID: 0 PID: 26853 Comm: syz.2.9185 Not tainted 6.14.0-rc1-syzkaller-00026-gd009de7d5428 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2076 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2208 check_prev_add kernel/locking/lockdep.c:3163 [inline] check_prevs_add kernel/locking/lockdep.c:3282 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3906 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5228 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1773 [inline] sb_start_intwrite include/linux/fs.h:1956 [inline] ocfs2_start_trans+0x2b9/0x700 fs/ocfs2/journal.c:348 ocfs2_acquire_dquot+0x6df/0xb70 fs/ocfs2/quota_global.c:860 dqget+0x772/0xeb0 fs/quota/dquot.c:977 dquot_get_next_dqblk+0xbd/0x3a0 fs/quota/dquot.c:2705 quota_getnextquota+0x2c7/0x6c0 fs/quota/quota.c:250 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl+0x2c4/0xa30 fs/quota/quota.c:917 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fd0e238cda9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fd0e3190038 EFLAGS: 00000246 ORIG_RAX: 00000000000000b3 RAX: ffffffffffffffda RBX: 00007fd0e25a5fa0 RCX: 00007fd0e238cda9 RDX: 0000000000000000 RSI: 0000000020000880 RDI: ffffffff80000900 RBP: 00007fd0e240e2a0 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fd0e25a5fa0 R15: 00007ffd474a4b28