====================================================== WARNING: possible circular locking dependency detected 5.15.161-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor/18081 is trying to acquire lock: ffff8880243583f8 (&journal->j_checkpoint_mutex){+.+.}-{3:3}, at: __jbd2_log_wait_for_space+0x213/0x760 fs/jbd2/checkpoint.c:71 but task is already holding lock: ffff888024354558 (sb_pagefaults){.+.+}-{0:0}, at: __sb_start_write include/linux/fs.h:1811 [inline] ffff888024354558 (sb_pagefaults){.+.+}-{0:0}, at: sb_start_pagefault include/linux/fs.h:1910 [inline] ffff888024354558 (sb_pagefaults){.+.+}-{0:0}, at: ext4_page_mkwrite+0x1b5/0x1290 fs/ext4/inode.c:6110 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (sb_pagefaults){.+.+}-{0:0}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 percpu_down_read+0x46/0x1b0 include/linux/percpu-rwsem.h:51 __sb_start_write include/linux/fs.h:1811 [inline] sb_start_pagefault include/linux/fs.h:1910 [inline] ext4_page_mkwrite+0x1b5/0x1290 fs/ext4/inode.c:6110 do_page_mkwrite+0x1a9/0x440 mm/memory.c:2892 wp_page_shared+0x179/0x690 mm/memory.c:3229 handle_pte_fault mm/memory.c:4639 [inline] __handle_mm_fault mm/memory.c:4756 [inline] handle_mm_fault+0x2a3d/0x5950 mm/memory.c:4854 do_user_addr_fault arch/x86/mm/fault.c:1357 [inline] handle_page_fault arch/x86/mm/fault.c:1445 [inline] exc_page_fault+0x271/0x700 arch/x86/mm/fault.c:1501 asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:568 -> #2 (&mm->mmap_lock){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 internal_get_user_pages_fast+0x212/0x2820 mm/gup.c:2895 iov_iter_get_pages+0x25a/0x570 lib/iov_iter.c:1544 __bio_iov_iter_get_pages block/bio.c:1136 [inline] bio_iov_iter_get_pages+0x477/0x18e0 block/bio.c:1195 iomap_dio_bio_iter+0xab9/0x1540 fs/iomap/direct-io.c:321 __iomap_dio_rw+0xf9f/0x1f40 fs/iomap/direct-io.c:586 iomap_dio_rw+0x38/0x80 fs/iomap/direct-io.c:672 ext4_dio_write_iter fs/ext4/file.c:570 [inline] ext4_file_write_iter+0x1779/0x1990 fs/ext4/file.c:681 call_write_iter include/linux/fs.h:2172 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0xacf/0xe50 fs/read_write.c:594 ksys_write+0x1a2/0x2c0 fs/read_write.c:647 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (&sb->s_type->i_mutex_key#9){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 inode_lock_shared include/linux/fs.h:799 [inline] ext4_bmap+0x4b/0x410 fs/ext4/inode.c:3152 bmap+0xa1/0xd0 fs/inode.c:1756 jbd2_journal_bmap fs/jbd2/journal.c:980 [inline] __jbd2_journal_erase fs/jbd2/journal.c:1790 [inline] jbd2_journal_flush+0x7a2/0xc90 fs/jbd2/journal.c:2496 ext4_ioctl_checkpoint fs/ext4/ioctl.c:849 [inline] __ext4_ioctl fs/ext4/ioctl.c:1267 [inline] ext4_ioctl+0x3249/0x5b80 fs/ext4/ioctl.c:1276 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:874 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&journal->j_checkpoint_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 mutex_lock_io_nested+0x45/0x60 kernel/locking/mutex.c:777 __jbd2_log_wait_for_space+0x213/0x760 fs/jbd2/checkpoint.c:71 add_transaction_credits+0x950/0xc00 fs/jbd2/transaction.c:299 start_this_handle+0x747/0x1570 fs/jbd2/transaction.c:423 jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:521 __ext4_journal_start_sb+0x175/0x370 fs/ext4/ext4_jbd2.c:105 __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline] ext4_dirty_inode+0x8b/0x100 fs/ext4/inode.c:5990 __mark_inode_dirty+0x2fd/0xd60 fs/fs-writeback.c:2464 generic_update_time+0x1cb/0x1e0 fs/inode.c:1817 inode_update_time fs/inode.c:1830 [inline] file_update_time+0x3eb/0x460 fs/inode.c:2019 ext4_page_mkwrite+0x1cc/0x1290 fs/ext4/inode.c:6111 do_page_mkwrite+0x1a9/0x440 mm/memory.c:2892 do_shared_fault mm/memory.c:4298 [inline] do_fault mm/memory.c:4366 [inline] handle_pte_fault mm/memory.c:4621 [inline] __handle_mm_fault mm/memory.c:4756 [inline] handle_mm_fault+0x2803/0x5950 mm/memory.c:4854 do_user_addr_fault arch/x86/mm/fault.c:1357 [inline] handle_page_fault arch/x86/mm/fault.c:1445 [inline] exc_page_fault+0x271/0x700 arch/x86/mm/fault.c:1501 asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:568 other info that might help us debug this: Chain exists of: &journal->j_checkpoint_mutex --> &mm->mmap_lock --> sb_pagefaults Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(sb_pagefaults); lock(&mm->mmap_lock); lock(sb_pagefaults); lock(&journal->j_checkpoint_mutex); *** DEADLOCK *** 2 locks held by syz-executor/18081: #0: ffff88801f854728 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_trylock include/linux/mmap_lock.h:136 [inline] #0: ffff88801f854728 (&mm->mmap_lock){++++}-{3:3}, at: do_user_addr_fault arch/x86/mm/fault.c:1298 [inline] #0: ffff88801f854728 (&mm->mmap_lock){++++}-{3:3}, at: handle_page_fault arch/x86/mm/fault.c:1445 [inline] #0: ffff88801f854728 (&mm->mmap_lock){++++}-{3:3}, at: exc_page_fault+0x181/0x700 arch/x86/mm/fault.c:1501 #1: ffff888024354558 (sb_pagefaults){.+.+}-{0:0}, at: __sb_start_write include/linux/fs.h:1811 [inline] #1: ffff888024354558 (sb_pagefaults){.+.+}-{0:0}, at: sb_start_pagefault include/linux/fs.h:1910 [inline] #1: ffff888024354558 (sb_pagefaults){.+.+}-{0:0}, at: ext4_page_mkwrite+0x1b5/0x1290 fs/ext4/inode.c:6110 stack backtrace: CPU: 1 PID: 18081 Comm: syz-executor Not tainted 5.15.161-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 mutex_lock_io_nested+0x45/0x60 kernel/locking/mutex.c:777 __jbd2_log_wait_for_space+0x213/0x760 fs/jbd2/checkpoint.c:71 add_transaction_credits+0x950/0xc00 fs/jbd2/transaction.c:299 start_this_handle+0x747/0x1570 fs/jbd2/transaction.c:423 jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:521 __ext4_journal_start_sb+0x175/0x370 fs/ext4/ext4_jbd2.c:105 __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline] ext4_dirty_inode+0x8b/0x100 fs/ext4/inode.c:5990 __mark_inode_dirty+0x2fd/0xd60 fs/fs-writeback.c:2464 generic_update_time+0x1cb/0x1e0 fs/inode.c:1817 inode_update_time fs/inode.c:1830 [inline] file_update_time+0x3eb/0x460 fs/inode.c:2019 ext4_page_mkwrite+0x1cc/0x1290 fs/ext4/inode.c:6111 do_page_mkwrite+0x1a9/0x440 mm/memory.c:2892 do_shared_fault mm/memory.c:4298 [inline] do_fault mm/memory.c:4366 [inline] handle_pte_fault mm/memory.c:4621 [inline] __handle_mm_fault mm/memory.c:4756 [inline] handle_mm_fault+0x2803/0x5950 mm/memory.c:4854 do_user_addr_fault arch/x86/mm/fault.c:1357 [inline] handle_page_fault arch/x86/mm/fault.c:1445 [inline] exc_page_fault+0x271/0x700 arch/x86/mm/fault.c:1501 asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:568 RIP: 0033:0x7fc43063f3f9 Code: c7 05 97 c3 de 00 01 00 00 00 66 89 3d 98 c3 de 00 48 c7 05 95 c3 de 00 00 00 00 00 48 89 1d 0e c3 de 00 0f 29 05 57 c3 de 00 <89> 32 8b 5a 04 48 39 c3 0f 83 ff 0f 00 00 48 85 db 0f 85 63 0c 00 RSP: 002b:00007ffe92e09e60 EFLAGS: 00010246 RAX: 00000000003ffdf0 RBX: 00007fc430858e10 RCX: 0000000000000000 RDX: 0000001b32720000 RSI: 0000000000400000 RDI: 0000000000000100 RBP: 0000000000000001 R08: 0000000000000004 R09: 0000000000040000 R10: 0000000000000011 R11: 0000000000000293 R12: 0000000000000032 R13: 0000000000001388 R14: 00007ffe92e0a130 R15: 00007ffe92e0a130