====================================================== WARNING: possible circular locking dependency detected 6.0.0-rc4-syzkaller-00284-gce888220d5c7 #0 Not tainted ------------------------------------------------------ syz-executor.2/19226 is trying to acquire lock: ffff88801a4a8650 (sb_internal){.+.+}-{0:0}, at: evict+0x2ed/0x6b0 fs/inode.c:665 but task is already holding lock: ffff88801acdcbd8 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_ext_migrate+0x22c/0x1c10 fs/ext4/migrate.c:437 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] ext4_writepages+0x1c4/0x3b60 fs/ext4/inode.c:2687 do_writepages+0x1ab/0x690 mm/page-writeback.c:2468 filemap_fdatawrite_wbc mm/filemap.c:388 [inline] filemap_fdatawrite_wbc+0x143/0x1b0 mm/filemap.c:378 __filemap_fdatawrite_range+0xb4/0xf0 mm/filemap.c:421 filemap_write_and_wait_range+0x85/0x100 mm/filemap.c:673 __iomap_dio_rw+0x5ed/0x1c20 fs/iomap/direct-io.c:573 iomap_dio_rw+0x3c/0xa0 fs/iomap/direct-io.c:690 ext4_dio_read_iter fs/ext4/file.c:79 [inline] ext4_file_read_iter+0x434/0x600 fs/ext4/file.c:130 call_read_iter include/linux/fs.h:2181 [inline] generic_file_splice_read+0x17e/0x4b0 fs/splice.c:309 do_splice_to+0x1b9/0x240 fs/splice.c:793 splice_direct_to_actor+0x2a7/0x8a0 fs/splice.c:865 do_splice_direct+0x1a7/0x270 fs/splice.c:974 do_sendfile+0xb19/0x1270 fs/read_write.c:1249 __do_compat_sys_sendfile fs/read_write.c:1338 [inline] __se_compat_sys_sendfile fs/read_write.c:1321 [inline] __ia32_compat_sys_sendfile+0x1dd/0x220 fs/read_write.c:1321 do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline] __do_fast_syscall_32+0x65/0xf0 arch/x86/entry/common.c:178 do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:203 entry_SYSENTER_compat_after_hwframe+0x70/0x82 -> #2 (&sb->s_type->i_mutex_key#8){++++}-{3:3}: down_read+0x98/0x450 kernel/locking/rwsem.c:1499 inode_lock_shared include/linux/fs.h:766 [inline] ext4_bmap+0x4e/0x460 fs/ext4/inode.c:3157 bmap+0xaa/0x120 fs/inode.c:1799 jbd2_journal_bmap+0xa8/0x180 fs/jbd2/journal.c:971 __jbd2_journal_erase fs/jbd2/journal.c:1784 [inline] jbd2_journal_flush+0x84f/0xc00 fs/jbd2/journal.c:2490 ext4_ioctl_checkpoint fs/ext4/ioctl.c:1082 [inline] __ext4_ioctl+0x28fd/0x4ab0 fs/ext4/ioctl.c:1586 ext4_ioctl fs/ext4/ioctl.c:1606 [inline] ext4_compat_ioctl+0x171/0x400 fs/ext4/ioctl.c:1682 __do_compat_sys_ioctl+0x1c7/0x290 fs/ioctl.c:968 do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline] __do_fast_syscall_32+0x65/0xf0 arch/x86/entry/common.c:178 do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:203 entry_SYSENTER_compat_after_hwframe+0x70/0x82 -> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] mutex_lock_io_nested+0x13f/0x1190 kernel/locking/mutex.c:833 __jbd2_log_wait_for_space+0x234/0x460 fs/jbd2/checkpoint.c:110 add_transaction_credits+0xa2d/0xb70 fs/jbd2/transaction.c:298 start_this_handle+0x3ae/0x14a0 fs/jbd2/transaction.c:422 jbd2__journal_start+0x38c/0x910 fs/jbd2/transaction.c:520 __ext4_journal_start_sb+0x3a3/0x490 fs/ext4/ext4_jbd2.c:105 __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline] ext4_evict_inode+0x990/0x1d40 fs/ext4/inode.c:251 evict+0x2ed/0x6b0 fs/inode.c:665 iput_final fs/inode.c:1748 [inline] iput.part.0+0x55d/0x810 fs/inode.c:1774 iput+0x58/0x70 fs/inode.c:1764 do_unlinkat+0x41b/0x650 fs/namei.c:4304 __do_sys_unlink fs/namei.c:4345 [inline] __se_sys_unlink fs/namei.c:4343 [inline] __ia32_sys_unlink+0xc6/0x110 fs/namei.c:4343 do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline] __do_fast_syscall_32+0x65/0xf0 arch/x86/entry/common.c:178 do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:203 entry_SYSENTER_compat_after_hwframe+0x70/0x82 -> #0 (sb_internal){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3095 [inline] check_prevs_add kernel/locking/lockdep.c:3214 [inline] validate_chain kernel/locking/lockdep.c:3829 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5053 lock_acquire kernel/locking/lockdep.c:5666 [inline] lock_acquire+0x1ab/0x570 kernel/locking/lockdep.c:5631 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1826 [inline] sb_start_intwrite include/linux/fs.h:1948 [inline] ext4_evict_inode+0x11de/0x1d40 fs/ext4/inode.c:240 evict+0x2ed/0x6b0 fs/inode.c:665 iput_final fs/inode.c:1748 [inline] iput.part.0+0x55d/0x810 fs/inode.c:1774 iput+0x58/0x70 fs/inode.c:1764 ext4_ext_migrate+0xb9d/0x1c10 fs/ext4/migrate.c:587 ext4_ioctl_setflags fs/ext4/ioctl.c:692 [inline] ext4_fileattr_set+0xe37/0x1930 fs/ext4/ioctl.c:1001 vfs_fileattr_set+0x7f5/0xbe0 fs/ioctl.c:696 ioctl_fssetxattr fs/ioctl.c:758 [inline] do_vfs_ioctl+0xe62/0x15c0 fs/ioctl.c:845 __do_compat_sys_ioctl+0x110/0x290 fs/ioctl.c:962 do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline] __do_fast_syscall_32+0x65/0xf0 arch/x86/entry/common.c:178 do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:203 entry_SYSENTER_compat_after_hwframe+0x70/0x82 other info that might help us debug this: Chain exists of: sb_internal --> &sb->s_type->i_mutex_key#8 --> &sbi->s_writepages_rwsem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sbi->s_writepages_rwsem); lock(&sb->s_type->i_mutex_key#8); lock(&sbi->s_writepages_rwsem); lock(sb_internal); *** DEADLOCK *** 3 locks held by syz-executor.2/19226: #0: ffff88801a4a8460 (sb_writers#4){.+.+}-{0:0}, at: ioctl_setflags fs/ioctl.c:725 [inline] #0: ffff88801a4a8460 (sb_writers#4){.+.+}-{0:0}, at: do_vfs_ioctl+0xe27/0x15c0 fs/ioctl.c:839 #1: ffff88801cfbb628 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline] #1: ffff88801cfbb628 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: vfs_fileattr_set+0x148/0xbe0 fs/ioctl.c:681 #2: ffff88801acdcbd8 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_ext_migrate+0x22c/0x1c10 fs/ext4/migrate.c:437 stack backtrace: CPU: 3 PID: 19226 Comm: syz-executor.2 Not tainted 6.0.0-rc4-syzkaller-00284-gce888220d5c7 #0 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-2 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2175 check_prev_add kernel/locking/lockdep.c:3095 [inline] check_prevs_add kernel/locking/lockdep.c:3214 [inline] validate_chain kernel/locking/lockdep.c:3829 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5053 lock_acquire kernel/locking/lockdep.c:5666 [inline] lock_acquire+0x1ab/0x570 kernel/locking/lockdep.c:5631 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1826 [inline] sb_start_intwrite include/linux/fs.h:1948 [inline] ext4_evict_inode+0x11de/0x1d40 fs/ext4/inode.c:240 evict+0x2ed/0x6b0 fs/inode.c:665 iput_final fs/inode.c:1748 [inline] iput.part.0+0x55d/0x810 fs/inode.c:1774 iput+0x58/0x70 fs/inode.c:1764 ext4_ext_migrate+0xb9d/0x1c10 fs/ext4/migrate.c:587 ext4_ioctl_setflags fs/ext4/ioctl.c:692 [inline] ext4_fileattr_set+0xe37/0x1930 fs/ext4/ioctl.c:1001 vfs_fileattr_set+0x7f5/0xbe0 fs/ioctl.c:696 ioctl_fssetxattr fs/ioctl.c:758 [inline] do_vfs_ioctl+0xe62/0x15c0 fs/ioctl.c:845 __do_compat_sys_ioctl+0x110/0x290 fs/ioctl.c:962 do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline] __do_fast_syscall_32+0x65/0xf0 arch/x86/entry/common.c:178 do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:203 entry_SYSENTER_compat_after_hwframe+0x70/0x82 RIP: 0023:0xf7f45549 Code: 03 74 c0 01 10 05 03 74 b8 01 10 06 03 74 b4 01 10 07 03 74 b0 01 10 08 03 74 d8 01 00 00 00 00 00 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d b4 26 00 00 00 00 8d b4 26 00 00 00 00 RSP: 002b:00000000f7f405cc EFLAGS: 00000296 ORIG_RAX: 0000000000000036 RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000040046602 RDX: 0000000020000000 RSI: 0000000000000000 RDI: 0000000000000000 RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 ---------------- Code disassembly (best guess): 0: 03 74 c0 01 add 0x1(%rax,%rax,8),%esi 4: 10 05 03 74 b8 01 adc %al,0x1b87403(%rip) # 0x1b8740d a: 10 06 adc %al,(%rsi) c: 03 74 b4 01 add 0x1(%rsp,%rsi,4),%esi 10: 10 07 adc %al,(%rdi) 12: 03 74 b0 01 add 0x1(%rax,%rsi,4),%esi 16: 10 08 adc %cl,(%rax) 18: 03 74 d8 01 add 0x1(%rax,%rbx,8),%esi 1c: 00 00 add %al,(%rax) 1e: 00 00 add %al,(%rax) 20: 00 51 52 add %dl,0x52(%rcx) 23: 55 push %rbp 24: 89 e5 mov %esp,%ebp 26: 0f 34 sysenter 28: cd 80 int $0x80 * 2a: 5d pop %rbp <-- trapping instruction 2b: 5a pop %rdx 2c: 59 pop %rcx 2d: c3 retq 2e: 90 nop 2f: 90 nop 30: 90 nop 31: 90 nop 32: 8d b4 26 00 00 00 00 lea 0x0(%rsi,%riz,1),%esi 39: 8d b4 26 00 00 00 00 lea 0x0(%rsi,%riz,1),%esi