====================================================== WARNING: possible circular locking dependency detected 6.14.0-rc1-syzkaller-00187-g8f6629c004b1 #0 Not tainted ------------------------------------------------------ syz.2.2531/14084 is trying to acquire lock: ffff8880551c09c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:877 [inline] ffff8880551c09c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: ocfs2_remove_inode fs/ocfs2/inode.c:669 [inline] ffff8880551c09c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: ocfs2_wipe_inode fs/ocfs2/inode.c:832 [inline] ffff8880551c09c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline] ffff8880551c09c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: ocfs2_evict_inode+0x209f/0x4630 fs/ocfs2/inode.c:1230 but task is already holding lock: ffff888057451800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:877 [inline] ffff888057451800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_wipe_inode fs/ocfs2/inode.c:790 [inline] ffff888057451800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline] ffff888057451800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_evict_inode+0x1b17/0x4630 fs/ocfs2/inode.c:1230 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:877 [inline] ocfs2_del_inode_from_orphan+0x159/0x800 fs/ocfs2/namei.c:2727 ocfs2_dio_end_io_write fs/ocfs2/aops.c:2310 [inline] ocfs2_dio_end_io+0x55b/0x1250 fs/ocfs2/aops.c:2408 dio_complete+0x252/0x720 fs/direct-io.c:281 __blockdev_direct_IO+0x3eb6/0x4890 fs/direct-io.c:1303 ocfs2_direct_IO+0x255/0x2c0 fs/ocfs2/aops.c:2445 generic_file_direct_write+0x1e8/0x400 mm/filemap.c:4112 __generic_file_write_iter+0x126/0x230 mm/filemap.c:4276 ocfs2_file_write_iter+0x19af/0x2180 fs/ocfs2/file.c:2469 iter_file_splice_write+0xbfc/0x1510 fs/splice.c:743 do_splice_from fs/splice.c:941 [inline] direct_splice_actor+0x11d/0x220 fs/splice.c:1164 splice_direct_to_actor+0x588/0xc80 fs/splice.c:1108 do_splice_direct_actor fs/splice.c:1207 [inline] do_splice_direct+0x289/0x3e0 fs/splice.c:1233 do_sendfile+0x564/0x8a0 fs/read_write.c:1363 __do_sys_sendfile64 fs/read_write.c:1424 [inline] __se_sys_sendfile64+0x17c/0x1e0 fs/read_write.c:1410 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 ocfs2_create_local_dquot+0x1de/0x1d70 fs/ocfs2/quota_local.c:1232 ocfs2_acquire_dquot+0x833/0xb70 fs/ocfs2/quota_global.c:883 dqget+0x772/0xeb0 fs/quota/dquot.c:977 __dquot_initialize+0x2e3/0xec0 fs/quota/dquot.c:1505 ocfs2_get_init_inode+0x158/0x1d0 fs/ocfs2/namei.c:202 ocfs2_mknod+0xcfa/0x2b30 fs/ocfs2/namei.c:310 vfs_mknod+0x36f/0x3b0 fs/namei.c:4191 do_mknodat+0x3ec/0x5b0 __do_sys_mknod fs/namei.c:4274 [inline] __se_sys_mknod fs/namei.c:4272 [inline] __x64_sys_mknod+0x8c/0xa0 fs/namei.c:4272 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&dquot->dq_lock){+.+.}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x19c/0x1010 kernel/locking/mutex.c:730 wait_on_dquot fs/quota/dquot.c:354 [inline] dqget+0x6e6/0xeb0 fs/quota/dquot.c:972 __dquot_initialize+0x2e3/0xec0 fs/quota/dquot.c:1505 ocfs2_get_init_inode+0x158/0x1d0 fs/ocfs2/namei.c:202 ocfs2_mknod+0xcfa/0x2b30 fs/ocfs2/namei.c:310 vfs_mknod+0x36f/0x3b0 fs/namei.c:4191 do_mknodat+0x3ec/0x5b0 __do_sys_mknod fs/namei.c:4274 [inline] __se_sys_mknod fs/namei.c:4272 [inline] __x64_sys_mknod+0x8c/0xa0 fs/namei.c:4272 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3163 [inline] check_prevs_add kernel/locking/lockdep.c:3282 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3906 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5228 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:877 [inline] ocfs2_remove_inode fs/ocfs2/inode.c:669 [inline] ocfs2_wipe_inode fs/ocfs2/inode.c:832 [inline] ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline] ocfs2_evict_inode+0x209f/0x4630 fs/ocfs2/inode.c:1230 evict+0x4ea/0x9a0 fs/inode.c:796 ocfs2_dentry_iput+0x232/0x380 fs/ocfs2/dcache.c:407 __dentry_kill+0x20d/0x630 fs/dcache.c:643 dput+0x19f/0x2b0 fs/dcache.c:885 do_renameat2+0xda1/0x13f0 fs/namei.c:5228 __do_sys_rename fs/namei.c:5273 [inline] __se_sys_rename fs/namei.c:5271 [inline] __x64_sys_rename+0x82/0x90 fs/namei.c:5271 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4 --> &ocfs2_quota_ip_alloc_sem_key --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type] Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]); lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4); *** DEADLOCK *** 4 locks held by syz.2.2531/14084: #0: ffff88806e69c420 (sb_writers#30){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:547 #1: ffff8880574509c0 (&type->i_mutex_dir_key#22/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:912 [inline] #1: ffff8880574509c0 (&type->i_mutex_dir_key#22/1){+.+.}-{4:4}, at: lock_rename fs/namei.c:3217 [inline] #1: ffff8880574509c0 (&type->i_mutex_dir_key#22/1){+.+.}-{4:4}, at: do_renameat2+0x62c/0x13f0 fs/namei.c:5161 #2: ffff88802a218bd0 (&osb->nfs_sync_rwlock){.+.+}-{4:4}, at: ocfs2_nfs_sync_lock+0x109/0x260 fs/ocfs2/dlmglue.c:2875 #3: ffff888057451800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:877 [inline] #3: ffff888057451800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_wipe_inode fs/ocfs2/inode.c:790 [inline] #3: ffff888057451800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline] #3: ffff888057451800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_evict_inode+0x1b17/0x4630 fs/ocfs2/inode.c:1230 stack backtrace: CPU: 1 UID: 0 PID: 14084 Comm: syz.2.2531 Not tainted 6.14.0-rc1-syzkaller-00187-g8f6629c004b1 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2076 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2208 check_prev_add kernel/locking/lockdep.c:3163 [inline] check_prevs_add kernel/locking/lockdep.c:3282 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3906 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5228 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:877 [inline] ocfs2_remove_inode fs/ocfs2/inode.c:669 [inline] ocfs2_wipe_inode fs/ocfs2/inode.c:832 [inline] ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline] ocfs2_evict_inode+0x209f/0x4630 fs/ocfs2/inode.c:1230 evict+0x4ea/0x9a0 fs/inode.c:796 ocfs2_dentry_iput+0x232/0x380 fs/ocfs2/dcache.c:407 __dentry_kill+0x20d/0x630 fs/dcache.c:643 dput+0x19f/0x2b0 fs/dcache.c:885 do_renameat2+0xda1/0x13f0 fs/namei.c:5228 __do_sys_rename fs/namei.c:5273 [inline] __se_sys_rename fs/namei.c:5271 [inline] __x64_sys_rename+0x82/0x90 fs/namei.c:5271 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7ff08938cde9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ff0891b7038 EFLAGS: 00000246 ORIG_RAX: 0000000000000052 RAX: ffffffffffffffda RBX: 00007ff0895a6160 RCX: 00007ff08938cde9 RDX: 0000000000000000 RSI: 00004000000000c0 RDI: 0000400000000040 RBP: 00007ff08940e2a0 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000001 R14: 00007ff0895a6160 R15: 00007ffd9148aa48