ntfs3: loop4: ino=0, attr_set_size ====================================================== WARNING: possible circular locking dependency detected 6.6.0-rc4-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.4/8039 is trying to acquire lock: ffff88802e6ed220 (&ni->ni_lock#2){+.+.}-{3:3}, at: ntfs_set_state+0x1d2/0x6e0 fs/ntfs3/fsntfs.c:946 but task is already holding lock: ffff88802e6e9070 (&ni->file.run_lock#2){++++}-{3:3}, at: ntfs_extend_mft+0x138/0x430 fs/ntfs3/fsntfs.c:511 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&ni->file.run_lock#2){++++}-{3:3}: down_write+0x93/0x200 kernel/locking/rwsem.c:1573 ntfs_extend_mft+0x138/0x430 fs/ntfs3/fsntfs.c:511 ntfs_look_free_mft+0x777/0xdd0 fs/ntfs3/fsntfs.c:590 ntfs_create_inode+0x32d/0x4290 fs/ntfs3/inode.c:1310 ntfs_atomic_open+0x4d2/0x650 fs/ntfs3/namei.c:422 atomic_open fs/namei.c:3358 [inline] lookup_open.isra.0+0xc44/0x1360 fs/namei.c:3466 open_last_lookups fs/namei.c:3563 [inline] path_openat+0x931/0x29c0 fs/namei.c:3793 do_filp_open+0x1de/0x430 fs/namei.c:3823 do_sys_openat2+0x176/0x1e0 fs/open.c:1422 do_sys_open fs/open.c:1437 [inline] __do_sys_open fs/open.c:1445 [inline] __se_sys_open fs/open.c:1441 [inline] __x64_sys_open+0x154/0x1e0 fs/open.c:1441 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&wnd->rw_lock/1){+.+.}-{3:3}: down_write_nested+0x97/0x200 kernel/locking/rwsem.c:1689 ntfs_mark_rec_free+0x2f4/0x400 fs/ntfs3/fsntfs.c:742 ni_write_inode+0x475/0x2810 fs/ntfs3/frecord.c:3353 write_inode fs/fs-writeback.c:1456 [inline] __writeback_single_inode+0xa81/0xe70 fs/fs-writeback.c:1673 writeback_sb_inodes+0x599/0x1070 fs/fs-writeback.c:1899 wb_writeback+0x2a5/0xa90 fs/fs-writeback.c:2075 wb_do_writeback fs/fs-writeback.c:2222 [inline] wb_workfn+0x29c/0xfd0 fs/fs-writeback.c:2262 process_one_work+0x884/0x15c0 kernel/workqueue.c:2630 process_scheduled_works kernel/workqueue.c:2703 [inline] worker_thread+0x8b9/0x1290 kernel/workqueue.c:2784 kthread+0x33c/0x440 kernel/kthread.c:388 ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:304 -> #0 (&ni->ni_lock#2){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5136 lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1340 kernel/locking/mutex.c:747 ntfs_set_state+0x1d2/0x6e0 fs/ntfs3/fsntfs.c:946 attr_set_size+0x139c/0x2ca0 fs/ntfs3/attrib.c:866 ntfs_extend_mft+0x29f/0x430 fs/ntfs3/fsntfs.c:527 ntfs_look_free_mft+0x777/0xdd0 fs/ntfs3/fsntfs.c:590 ni_create_attr_list+0x937/0x1520 fs/ntfs3/frecord.c:876 ni_ins_attr_ext+0x23f/0xaf0 fs/ntfs3/frecord.c:974 ni_insert_attr+0x310/0x870 fs/ntfs3/frecord.c:1141 ni_insert_resident+0xd2/0x3a0 fs/ntfs3/frecord.c:1525 ntfs_set_ea+0xf46/0x13d0 fs/ntfs3/xattr.c:437 ntfs_save_wsl_perm+0x134/0x3d0 fs/ntfs3/xattr.c:946 ntfs3_setattr+0x92e/0xb20 fs/ntfs3/file.c:708 notify_change+0x742/0x11c0 fs/attr.c:499 chown_common+0x596/0x660 fs/open.c:783 do_fchownat+0x140/0x1f0 fs/open.c:814 __do_sys_lchown fs/open.c:839 [inline] __se_sys_lchown fs/open.c:837 [inline] __x64_sys_lchown+0x7e/0xc0 fs/open.c:837 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &ni->ni_lock#2 --> &wnd->rw_lock/1 --> &ni->file.run_lock#2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->file.run_lock#2); lock(&wnd->rw_lock/1); lock(&ni->file.run_lock#2); lock(&ni->ni_lock#2); *** DEADLOCK *** 5 locks held by syz-executor.4/8039: #0: ffff88801f78a410 (sb_writers#28){.+.+}-{0:0}, at: do_fchownat+0x11c/0x1f0 fs/open.c:811 #1: ffff88802e6ee380 (&sb->s_type->i_mutex_key#36){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:802 [inline] #1: ffff88802e6ee380 (&sb->s_type->i_mutex_key#36){+.+.}-{3:3}, at: chown_common+0x333/0x660 fs/open.c:773 #2: ffff88802e6ee0e0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline] #2: ffff88802e6ee0e0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_save_wsl_perm+0x8c/0x3d0 fs/ntfs3/xattr.c:944 #3: ffff88801f788120 (&wnd->rw_lock/1){+.+.}-{3:3}, at: ntfs_look_free_mft+0x342/0xdd0 fs/ntfs3/fsntfs.c:571 #4: ffff88802e6e9070 (&ni->file.run_lock#2){++++}-{3:3}, at: ntfs_extend_mft+0x138/0x430 fs/ntfs3/fsntfs.c:511 stack backtrace: CPU: 1 PID: 8039 Comm: syz-executor.4 Not tainted 6.6.0-rc4-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106 check_noncircular+0x311/0x3f0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5136 lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1340 kernel/locking/mutex.c:747 ntfs_set_state+0x1d2/0x6e0 fs/ntfs3/fsntfs.c:946 attr_set_size+0x139c/0x2ca0 fs/ntfs3/attrib.c:866 ntfs_extend_mft+0x29f/0x430 fs/ntfs3/fsntfs.c:527 ntfs_look_free_mft+0x777/0xdd0 fs/ntfs3/fsntfs.c:590 ni_create_attr_list+0x937/0x1520 fs/ntfs3/frecord.c:876 ni_ins_attr_ext+0x23f/0xaf0 fs/ntfs3/frecord.c:974 ni_insert_attr+0x310/0x870 fs/ntfs3/frecord.c:1141 ni_insert_resident+0xd2/0x3a0 fs/ntfs3/frecord.c:1525 ntfs_set_ea+0xf46/0x13d0 fs/ntfs3/xattr.c:437 ntfs_save_wsl_perm+0x134/0x3d0 fs/ntfs3/xattr.c:946 ntfs3_setattr+0x92e/0xb20 fs/ntfs3/file.c:708 notify_change+0x742/0x11c0 fs/attr.c:499 chown_common+0x596/0x660 fs/open.c:783 do_fchownat+0x140/0x1f0 fs/open.c:814 __do_sys_lchown fs/open.c:839 [inline] __se_sys_lchown fs/open.c:837 [inline] __x64_sys_lchown+0x7e/0xc0 fs/open.c:837 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f3b5787cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f3b585dd0c8 EFLAGS: 00000246 ORIG_RAX: 000000000000005e RAX: ffffffffffffffda RBX: 00007f3b5799bf80 RCX: 00007f3b5787cae9 RDX: 0000000000000000 RSI: 000000000000ee00 RDI: 0000000020000140 RBP: 00007f3b578c847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f3b5799bf80 R15: 00007ffc0e9fe4b8 ntfs3: loop4: Mark volume as dirty due to NTFS errors