hfsplus: catalog searching failed ====================================================== WARNING: possible circular locking dependency detected 6.11.0-syzkaller-08833-gde5cb0dcb74c #0 Not tainted ------------------------------------------------------ syz.1.100/6048 is trying to acquire lock: ffff88807a7aa8f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x9e/0x8c0 fs/hfsplus/bitmap.c:35 but task is already holding lock: ffff88802e49f3c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:458 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5822 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfsplus_get_block+0x383/0x14f0 fs/hfsplus/extents.c:260 block_read_full_folio+0x418/0xcd0 fs/buffer.c:2401 filemap_read_folio+0x14b/0x630 mm/filemap.c:2363 do_read_cache_folio+0x3f5/0x850 mm/filemap.c:3821 do_read_cache_page+0x30/0x200 mm/filemap.c:3887 read_mapping_page include/linux/pagemap.h:1005 [inline] hfsplus_block_allocate+0xee/0x8c0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:469 hfsplus_get_block+0x406/0x14f0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x50c/0x1a70 fs/buffer.c:2121 block_write_begin fs/buffer.c:2231 [inline] cont_write_begin+0x6e2/0x9d0 fs/buffer.c:2582 hfsplus_write_begin+0x68/0xb0 fs/hfsplus/inode.c:46 generic_perform_write+0x344/0x6d0 mm/filemap.c:4050 generic_file_write_iter+0xae/0x310 mm/filemap.c:4177 new_sync_write fs/read_write.c:590 [inline] vfs_write+0xa6d/0xc90 fs/read_write.c:683 ksys_write+0x1a0/0x2c0 fs/read_write.c:736 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3158 [inline] check_prevs_add kernel/locking/lockdep.c:3277 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3901 __lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5199 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5822 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfsplus_block_allocate+0x9e/0x8c0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:469 hfsplus_get_block+0x406/0x14f0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x50c/0x1a70 fs/buffer.c:2121 block_write_begin fs/buffer.c:2231 [inline] cont_write_begin+0x6e2/0x9d0 fs/buffer.c:2582 hfsplus_write_begin+0x68/0xb0 fs/hfsplus/inode.c:46 cont_expand_zero fs/buffer.c:2509 [inline] cont_write_begin+0x338/0x9d0 fs/buffer.c:2572 hfsplus_write_begin+0x68/0xb0 fs/hfsplus/inode.c:46 generic_perform_write+0x344/0x6d0 mm/filemap.c:4050 generic_file_write_iter+0xae/0x310 mm/filemap.c:4177 new_sync_write fs/read_write.c:590 [inline] vfs_write+0xa6d/0xc90 fs/read_write.c:683 ksys_pwrite64 fs/read_write.c:798 [inline] __do_sys_pwrite64 fs/read_write.c:808 [inline] __se_sys_pwrite64 fs/read_write.c:805 [inline] __x64_sys_pwrite64+0x1aa/0x230 fs/read_write.c:805 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 3 locks held by syz.1.100/6048: #0: ffff88802d518420 (sb_writers#28){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2930 [inline] #0: ffff88802d518420 (sb_writers#28){.+.+}-{0:0}, at: vfs_write+0x224/0xc90 fs/read_write.c:679 #1: ffff88802e49f5b8 (&sb->s_type->i_mutex_key#35){++++}-{3:3}, at: inode_lock include/linux/fs.h:815 [inline] #1: ffff88802e49f5b8 (&sb->s_type->i_mutex_key#35){++++}-{3:3}, at: generic_file_write_iter+0x82/0x310 mm/filemap.c:4174 #2: ffff88802e49f3c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:458 stack backtrace: CPU: 1 UID: 0 PID: 6048 Comm: syz.1.100 Not tainted 6.11.0-syzkaller-08833-gde5cb0dcb74c #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2203 check_prev_add kernel/locking/lockdep.c:3158 [inline] check_prevs_add kernel/locking/lockdep.c:3277 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3901 __lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5199 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5822 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 hfsplus_block_allocate+0x9e/0x8c0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:469 hfsplus_get_block+0x406/0x14f0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x50c/0x1a70 fs/buffer.c:2121 block_write_begin fs/buffer.c:2231 [inline] cont_write_begin+0x6e2/0x9d0 fs/buffer.c:2582 hfsplus_write_begin+0x68/0xb0 fs/hfsplus/inode.c:46 cont_expand_zero fs/buffer.c:2509 [inline] cont_write_begin+0x338/0x9d0 fs/buffer.c:2572 hfsplus_write_begin+0x68/0xb0 fs/hfsplus/inode.c:46 generic_perform_write+0x344/0x6d0 mm/filemap.c:4050 generic_file_write_iter+0xae/0x310 mm/filemap.c:4177 new_sync_write fs/read_write.c:590 [inline] vfs_write+0xa6d/0xc90 fs/read_write.c:683 ksys_pwrite64 fs/read_write.c:798 [inline] __do_sys_pwrite64 fs/read_write.c:808 [inline] __se_sys_pwrite64 fs/read_write.c:805 [inline] __x64_sys_pwrite64+0x1aa/0x230 fs/read_write.c:805 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f705d37def9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f705e1c6038 EFLAGS: 00000246 ORIG_RAX: 0000000000000012 RAX: ffffffffffffffda RBX: 00007f705d535f80 RCX: 00007f705d37def9 RDX: 000000000000fdef RSI: 0000000020000140 RDI: 0000000000000006 RBP: 00007f705d3f0b76 R08: 0000000000000000 R09: 0000000000000000 R10: 000000000000fecc R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f705d535f80 R15: 00007ffed955a258