====================================================== WARNING: possible circular locking dependency detected 6.3.0-rc7-syzkaller-00089-gcb0856346a60 #0 Not tainted ------------------------------------------------------ syz-executor.4/15195 is trying to acquire lock: ffff888032e826c8 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x267/0x18d0 fs/ext4/inode.c:574 but task is already holding lock: ffff88803a7fe208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x8f/0x250 fs/quota/quota_v2.c:354 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: down_read+0x3d/0x50 kernel/locking/rwsem.c:1520 v2_read_dquot+0x4d/0x120 fs/quota/quota_v2.c:332 dquot_acquire+0x1b3/0x6c0 fs/quota/dquot.c:435 ext4_acquire_dquot+0x2b1/0x3d0 fs/ext4/super.c:6770 dqget+0x67d/0x1080 fs/quota/dquot.c:914 __dquot_initialize+0x560/0xbe0 fs/quota/dquot.c:1492 ext4_process_orphan+0x47/0x410 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x6e5/0x1110 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5509 [inline] ext4_fill_super+0x94b6/0xb300 fs/ext4/super.c:5637 get_tree_bdev+0x444/0x760 fs/super.c:1303 vfs_get_tree+0x8d/0x350 fs/super.c:1510 do_new_mount fs/namespace.c:3042 [inline] path_mount+0x1342/0x1e40 fs/namespace.c:3372 do_mount fs/namespace.c:3385 [inline] __do_sys_mount fs/namespace.c:3594 [inline] __se_sys_mount fs/namespace.c:3571 [inline] __x64_sys_mount+0x283/0x300 fs/namespace.c:3571 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747 dquot_commit+0x51/0x570 fs/quota/dquot.c:479 ext4_write_dquot+0x25f/0x330 fs/ext4/super.c:6754 ext4_mark_dquot_dirty fs/ext4/super.c:6802 [inline] ext4_mark_dquot_dirty+0x115/0x1b0 fs/ext4/super.c:6796 mark_dquot_dirty fs/quota/dquot.c:346 [inline] mark_all_dquot_dirty fs/quota/dquot.c:384 [inline] __dquot_alloc_space+0x5f9/0xb80 fs/quota/dquot.c:1722 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0x5d5/0x4b20 fs/ext4/mballoc.c:5571 ext4_ext_map_blocks+0x1fdb/0x5be0 fs/ext4/extents.c:4286 ext4_map_blocks+0x779/0x18d0 fs/ext4/inode.c:651 _ext4_get_block+0x241/0x580 fs/ext4/inode.c:807 ext4_block_write_begin+0x570/0x1780 fs/ext4/inode.c:1097 ext4_write_begin+0x53c/0x1000 fs/ext4/inode.c:1229 ext4_da_write_begin+0x222/0xa10 fs/ext4/inode.c:3057 generic_perform_write+0x256/0x570 mm/filemap.c:3926 ext4_buffered_write_iter+0x15b/0x460 fs/ext4/file.c:289 ext4_file_write_iter+0xbe0/0x1740 fs/ext4/file.c:710 call_write_iter include/linux/fs.h:1851 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x9ed/0xe10 fs/read_write.c:584 ksys_write+0x12b/0x250 fs/read_write.c:637 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire kernel/locking/lockdep.c:5669 [inline] lock_acquire+0x1af/0x520 kernel/locking/lockdep.c:5634 down_read+0x3d/0x50 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x267/0x18d0 fs/ext4/inode.c:574 ext4_getblk+0x61f/0x850 fs/ext4/inode.c:863 ext4_bread+0x2e/0x190 fs/ext4/inode.c:919 ext4_quota_write+0x218/0x620 fs/ext4/super.c:7135 write_blk+0x12e/0x220 fs/quota/quota_tree.c:64 get_free_dqblk+0x104/0x2f0 fs/quota/quota_tree.c:130 do_insert_tree+0x3c5/0x12d0 fs/quota/quota_tree.c:340 do_insert_tree+0x113e/0x12d0 fs/quota/quota_tree.c:375 dq_insert_tree fs/quota/quota_tree.c:401 [inline] qtree_write_dquot+0x3b4/0x570 fs/quota/quota_tree.c:420 v2_write_dquot+0x120/0x250 fs/quota/quota_v2.c:358 dquot_acquire+0x3d1/0x6c0 fs/quota/dquot.c:444 ext4_acquire_dquot+0x2b1/0x3d0 fs/ext4/super.c:6770 dqget+0x67d/0x1080 fs/quota/dquot.c:914 __dquot_initialize+0x560/0xbe0 fs/quota/dquot.c:1492 ext4_process_orphan+0x47/0x410 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x6e5/0x1110 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5509 [inline] ext4_fill_super+0x94b6/0xb300 fs/ext4/super.c:5637 get_tree_bdev+0x444/0x760 fs/super.c:1303 vfs_get_tree+0x8d/0x350 fs/super.c:1510 do_new_mount fs/namespace.c:3042 [inline] path_mount+0x1342/0x1e40 fs/namespace.c:3372 do_mount fs/namespace.c:3385 [inline] __do_sys_mount fs/namespace.c:3594 [inline] __se_sys_mount fs/namespace.c:3571 [inline] __x64_sys_mount+0x283/0x300 fs/namespace.c:3571 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 3 locks held by syz-executor.4/15195: #0: ffff88803a7fe0e0 (&type->s_umount_key#27/1){+.+.}-{3:3}, at: alloc_super+0x22e/0xb60 fs/super.c:228 #1: ffff88803cce0ea8 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x51/0x6c0 fs/quota/dquot.c:432 #2: ffff88803a7fe208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x8f/0x250 fs/quota/quota_v2.c:354 stack backtrace: CPU: 0 PID: 15195 Comm: syz-executor.4 Not tainted 6.3.0-rc7-syzkaller-00089-gcb0856346a60 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/30/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire kernel/locking/lockdep.c:5669 [inline] lock_acquire+0x1af/0x520 kernel/locking/lockdep.c:5634 down_read+0x3d/0x50 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x267/0x18d0 fs/ext4/inode.c:574 ext4_getblk+0x61f/0x850 fs/ext4/inode.c:863 ext4_bread+0x2e/0x190 fs/ext4/inode.c:919 ext4_quota_write+0x218/0x620 fs/ext4/super.c:7135 write_blk+0x12e/0x220 fs/quota/quota_tree.c:64 get_free_dqblk+0x104/0x2f0 fs/quota/quota_tree.c:130 do_insert_tree+0x3c5/0x12d0 fs/quota/quota_tree.c:340 do_insert_tree+0x113e/0x12d0 fs/quota/quota_tree.c:375 dq_insert_tree fs/quota/quota_tree.c:401 [inline] qtree_write_dquot+0x3b4/0x570 fs/quota/quota_tree.c:420 v2_write_dquot+0x120/0x250 fs/quota/quota_v2.c:358 dquot_acquire+0x3d1/0x6c0 fs/quota/dquot.c:444 ext4_acquire_dquot+0x2b1/0x3d0 fs/ext4/super.c:6770 dqget+0x67d/0x1080 fs/quota/dquot.c:914 __dquot_initialize+0x560/0xbe0 fs/quota/dquot.c:1492 ext4_process_orphan+0x47/0x410 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x6e5/0x1110 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5509 [inline] ext4_fill_super+0x94b6/0xb300 fs/ext4/super.c:5637 get_tree_bdev+0x444/0x760 fs/super.c:1303 vfs_get_tree+0x8d/0x350 fs/super.c:1510 do_new_mount fs/namespace.c:3042 [inline] path_mount+0x1342/0x1e40 fs/namespace.c:3372 do_mount fs/namespace.c:3385 [inline] __do_sys_mount fs/namespace.c:3594 [inline] __se_sys_mount fs/namespace.c:3571 [inline] __x64_sys_mount+0x283/0x300 fs/namespace.c:3571 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f46a5e8d69a Code: 48 c7 c2 b8 ff ff ff f7 d8 64 89 02 b8 ff ff ff ff eb d2 e8 b8 04 00 00 0f 1f 84 00 00 00 00 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f46a6b6af88 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00000000000004b4 RCX: 00007f46a5e8d69a RDX: 0000000020000040 RSI: 0000000020000500 RDI: 00007f46a6b6afe0 RBP: 00007f46a6b6b020 R08: 00007f46a6b6b020 R09: 0000000000004500 R10: 0000000000004500 R11: 0000000000000202 R12: 0000000020000040 R13: 0000000020000500 R14: 00007f46a6b6afe0 R15: 00000000200000c0 EXT4-fs (loop4): 1 orphan inode deleted EXT4-fs (loop4): mounted filesystem 00000000-0000-0000-0000-000000000000 without journal. Quota mode: writeback. ext4 filesystem being mounted at /root/syzkaller-testdir4177619994/syzkaller.reMDET/3484/file1 supports timestamps until 2038 (0x7fffffff)