====================================================== WARNING: possible circular locking dependency detected 6.1.118-syzkaller #0 Not tainted ------------------------------------------------------ syz.2.253/5699 is trying to acquire lock: ffff888077cc4650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_acquire_dquot+0x68c/0xb60 fs/ocfs2/quota_global.c:843 but task is already holding lock: ffff8880596eb120 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811 dqget+0x762/0xe90 fs/quota/dquot.c:986 dquot_set_dqblk+0x27/0xf20 fs/quota/dquot.c:2831 quota_setquota+0x6d3/0x840 fs/quota/quota.c:310 __do_sys_quotactl fs/quota/quota.c:960 [inline] __se_sys_quotactl+0x2b1/0x770 fs/quota/quota.c:916 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811 dqget+0x762/0xe90 fs/quota/dquot.c:986 dquot_set_dqblk+0x27/0xf20 fs/quota/dquot.c:2831 quota_setquota+0x6d3/0x840 fs/quota/quota.c:310 __do_sys_quotactl fs/quota/quota.c:960 [inline] __se_sys_quotactl+0x2b1/0x770 fs/quota/quota.c:916 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #4 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6777 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_alloc_space+0xb68/0x10e0 fs/quota/dquot.c:1750 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0x1302/0x4b80 fs/ext4/mballoc.c:5727 ext4_ext_map_blocks+0x1c1c/0x7ab0 fs/ext4/extents.c:4339 ext4_map_blocks+0xa2b/0x1cb0 fs/ext4/inode.c:678 ext4_alloc_file_blocks+0x3db/0xce0 fs/ext4/extents.c:4523 ext4_zero_range+0x4f3/0xe40 fs/ext4/extents.c:4640 ext4_fallocate+0x5e6/0x2190 fs/ext4/extents.c:4775 vfs_fallocate+0x547/0x6b0 fs/open.c:323 ksys_fallocate fs/open.c:346 [inline] __do_sys_fallocate fs/open.c:354 [inline] __se_sys_fallocate fs/open.c:352 [inline] __x64_sys_fallocate+0xb9/0x100 fs/open.c:352 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #3 (&ei->i_data_sem){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 ext4_map_blocks+0x955/0x1cb0 fs/ext4/inode.c:671 mpage_map_one_extent fs/ext4/inode.c:2433 [inline] mpage_map_and_submit_extent fs/ext4/inode.c:2486 [inline] ext4_writepages+0x1643/0x3de0 fs/ext4/inode.c:2854 do_writepages+0x3a2/0x670 mm/page-writeback.c:2491 __writeback_single_inode+0x15d/0x11e0 fs/fs-writeback.c:1612 writeback_sb_inodes+0xc2b/0x1b20 fs/fs-writeback.c:1903 __writeback_inodes_wb+0x114/0x400 fs/fs-writeback.c:1974 wb_writeback+0x4b1/0xe10 fs/fs-writeback.c:2079 wb_check_background_flush fs/fs-writeback.c:2145 [inline] wb_do_writeback fs/fs-writeback.c:2233 [inline] wb_workfn+0xc9e/0x1020 fs/fs-writeback.c:2260 process_one_work+0x8a9/0x11d0 kernel/workqueue.c:2292 worker_thread+0xa47/0x1200 kernel/workqueue.c:2439 kthread+0x28d/0x320 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 -> #2 (jbd2_handle){++++}-{0:0}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 start_this_handle+0x1f71/0x21b0 fs/jbd2/transaction.c:463 jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520 jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:559 ocfs2_start_trans+0x3c0/0x6f0 fs/ocfs2/journal.c:354 ocfs2_mknod+0x1638/0x2e20 fs/ocfs2/namei.c:359 ocfs2_create+0x1c0/0x4e0 fs/ocfs2/namei.c:672 lookup_open fs/namei.c:3482 [inline] open_last_lookups fs/namei.c:3550 [inline] path_openat+0x12f1/0x2e60 fs/namei.c:3780 do_filp_open+0x230/0x480 fs/namei.c:3810 do_sys_openat2+0x13b/0x4f0 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __x64_sys_openat+0x243/0x290 fs/open.c:1345 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #1 (&journal->j_trans_barrier){.+.+}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ocfs2_start_trans+0x3b5/0x6f0 fs/ocfs2/journal.c:352 ocfs2_mknod+0x1638/0x2e20 fs/ocfs2/namei.c:359 ocfs2_create+0x1c0/0x4e0 fs/ocfs2/namei.c:672 lookup_open fs/namei.c:3482 [inline] open_last_lookups fs/namei.c:3550 [inline] path_openat+0x12f1/0x2e60 fs/namei.c:3780 do_filp_open+0x230/0x480 fs/namei.c:3810 do_sys_openat2+0x13b/0x4f0 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __x64_sys_openat+0x243/0x290 fs/open.c:1345 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (sb_internal#5){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1891 [inline] sb_start_intwrite include/linux/fs.h:2013 [inline] ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350 ocfs2_acquire_dquot+0x68c/0xb60 fs/ocfs2/quota_global.c:843 dqget+0x762/0xe90 fs/quota/dquot.c:986 dquot_set_dqblk+0x27/0xf20 fs/quota/dquot.c:2831 quota_setquota+0x6d3/0x840 fs/quota/quota.c:310 __do_sys_quotactl fs/quota/quota.c:960 [inline] __se_sys_quotactl+0x2b1/0x770 fs/quota/quota.c:916 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Chain exists of: sb_internal#5 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); lock(&ocfs2_quota_ip_alloc_sem_key); lock(sb_internal#5); *** DEADLOCK *** 4 locks held by syz.2.253/5699: #0: ffff888077cc40e0 (&type->s_umount_key#57){++++}-{3:3}, at: user_get_super+0x11a/0x250 fs/super.c:889 #1: ffff88807207c0a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x2a0/0xb60 fs/ocfs2/quota_global.c:806 #2: ffff8880596eb488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #2: ffff8880596eb488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313 #3: ffff8880596eb120 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314 stack backtrace: CPU: 1 PID: 5699 Comm: syz.2.253 Not tainted 6.1.118-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1891 [inline] sb_start_intwrite include/linux/fs.h:2013 [inline] ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350 ocfs2_acquire_dquot+0x68c/0xb60 fs/ocfs2/quota_global.c:843 dqget+0x762/0xe90 fs/quota/dquot.c:986 dquot_set_dqblk+0x27/0xf20 fs/quota/dquot.c:2831 quota_setquota+0x6d3/0x840 fs/quota/quota.c:310 __do_sys_quotactl fs/quota/quota.c:960 [inline] __se_sys_quotactl+0x2b1/0x770 fs/quota/quota.c:916 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7ff31377e719 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ff314551038 EFLAGS: 00000246 ORIG_RAX: 00000000000000b3 RAX: ffffffffffffffda RBX: 00007ff313935f80 RCX: 00007ff31377e719 RDX: 0000000000000000 RSI: 0000000020000040 RDI: ffffffff80000801 RBP: 00007ff3137f175e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000020000100 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007ff313935f80 R15: 00007ffe0827e668