hfsplus: xattr searching failed hfsplus: xattr searching failed ====================================================== WARNING: possible circular locking dependency detected 6.5.0-rc1-syzkaller-00033-geb26cbb1a754 #0 Not tainted ------------------------------------------------------ syz-executor189/5015 is trying to acquire lock: ffff888019f2c0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0xeb4/0x1110 fs/hfsplus/extents.c:595 but task is already holding lock: ffff888018b13608 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x20f/0x1110 fs/hfsplus/extents.c:576 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x14d/0x12d0 kernel/locking/mutex.c:747 hfsplus_file_extend+0x1bd/0xf80 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0x318/0x410 fs/hfsplus/btree.c:358 hfsplus_create_cat+0x1e4/0x10c0 fs/hfsplus/catalog.c:272 hfsplus_mknod+0x169/0x300 fs/hfsplus/dir.c:494 lookup_open.isra.0+0x1049/0x1360 fs/namei.c:3492 open_last_lookups fs/namei.c:3560 [inline] path_openat+0x931/0x2990 fs/namei.c:3790 do_filp_open+0x1cb/0x410 fs/namei.c:3820 do_sys_openat2+0x15c/0x1c0 fs/open.c:1407 do_sys_open fs/open.c:1422 [inline] __do_sys_openat fs/open.c:1438 [inline] __se_sys_openat fs/open.c:1433 [inline] __x64_sys_openat+0x175/0x210 fs/open.c:1433 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&tree->tree_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5144 lock_acquire kernel/locking/lockdep.c:5761 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5726 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x14d/0x12d0 kernel/locking/mutex.c:747 hfsplus_file_truncate+0xeb4/0x1110 fs/hfsplus/extents.c:595 hfsplus_setattr+0x1eb/0x310 fs/hfsplus/inode.c:269 notify_change+0x670/0x1160 fs/attr.c:483 do_truncate+0x13d/0x1f0 fs/open.c:66 vfs_truncate+0x3eb/0x4d0 fs/open.c:112 do_sys_truncate.part.0+0x126/0x150 fs/open.c:135 do_sys_truncate fs/open.c:129 [inline] __do_sys_truncate fs/open.c:147 [inline] __se_sys_truncate fs/open.c:145 [inline] __x64_sys_truncate+0x6b/0x90 fs/open.c:145 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock); *** DEADLOCK *** 3 locks held by syz-executor189/5015: #0: ffff88807cda2410 (sb_writers#10){.+.+}-{0:0}, at: vfs_truncate+0xea/0x4d0 fs/open.c:85 #1: ffff888018b13800 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:771 [inline] #1: ffff888018b13800 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: do_truncate+0x12b/0x1f0 fs/open.c:64 #2: ffff888018b13608 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x20f/0x1110 fs/hfsplus/extents.c:576 stack backtrace: CPU: 1 PID: 5015 Comm: syz-executor189 Not tainted 6.5.0-rc1-syzkaller-00033-geb26cbb1a754 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/03/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106 check_noncircular+0x2f7/0x3d0 kernel/locking/lockdep.c:2195 check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5144 lock_acquire kernel/locking/lockdep.c:5761 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5726 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x14d/0x12d0 kernel/locking/mutex.c:747 hfsplus_file_truncate+0xeb4/0x1110 fs/hfsplus/extents.c:595 hfsplus_setattr+0x1eb/0x310 fs/hfsplus/inode.c:269 notify_change+0x670/0x1160 fs/attr.c:483 do_truncate+0x13d/0x1f0 fs/open.c:66 vfs_truncate+0x3eb/0x4d0 fs/open.c:112 do_sys_truncate.part.0+0x126/0x150 fs/open.c:135 do_sys_truncate fs/open.c:129 [inline] __do_sys_truncate fs/open.c:147 [inline] __se_sys_truncate fs/open.c:145 [inline] __x64_sys_truncate+0x6b/0x90 fs/open.c:145 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7fe3f8d105f9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffcc79321e8 EFLAGS: 00000246 ORIG_RAX: 000000000000004c RAX: ffffffffffffffda RBX: 00007ffcc79323c8 RCX: 00007fe3f8d105f9 RDX: 00007fe3f8d105f9 RSI: 0000000000000000 RDI: 0000000020000000 RBP: 00007fe3f8d83610 R08: 0000000000000000 R09: 0000000000000000 R10: 000000000000063c R11: 0000000000000246 R12: 0000000000000001 R13: 00007ffcc79323b8 R14: 0000000000000001 R15: 0000000000000001