====================================================== WARNING: possible circular locking dependency detected 6.15.0-rc5-syzkaller-gc32f8dc5aaf9 #0 Not tainted ------------------------------------------------------ syz.0.452/9044 is trying to acquire lock: ffff0000f1e78610 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_acquire_dquot+0x594/0xa10 fs/ocfs2/quota_global.c:860 but task is already holding lock: ffff0000f63fbf60 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x1a8/0x22c fs/ocfs2/quota_global.c:314 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 ocfs2_lock_global_qf+0x1a8/0x22c fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x258/0xa10 fs/ocfs2/quota_global.c:828 dqget+0x654/0xccc fs/quota/dquot.c:977 dquot_set_dqblk+0x40/0xe50 fs/quota/dquot.c:2820 quota_setquota+0x3b4/0x3bc fs/quota/quota.c:310 do_quotactl+0x65c/0x738 fs/quota/quota.c:802 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl fs/quota/quota.c:917 [inline] __arm64_sys_quotactl+0x298/0xb30 fs/quota/quota.c:917 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x17c arch/arm64/kernel/entry-common.c:767 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:786 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:867 [inline] ocfs2_lock_global_qf+0x18c/0x22c fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x258/0xa10 fs/ocfs2/quota_global.c:828 dqget+0x654/0xccc fs/quota/dquot.c:977 dquot_set_dqblk+0x40/0xe50 fs/quota/dquot.c:2820 quota_setquota+0x3b4/0x3bc fs/quota/quota.c:310 do_quotactl+0x65c/0x738 fs/quota/quota.c:802 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl fs/quota/quota.c:917 [inline] __arm64_sys_quotactl+0x298/0xb30 fs/quota/quota.c:917 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x17c arch/arm64/kernel/entry-common.c:767 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:786 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #4 (&dquot->dq_lock){+.+.}-{4:4}: __mutex_lock_common+0x1d0/0x2190 kernel/locking/mutex.c:601 __mutex_lock kernel/locking/mutex.c:746 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:798 wait_on_dquot fs/quota/dquot.c:354 [inline] dqget+0x5e4/0xccc fs/quota/dquot.c:972 __dquot_initialize+0x2d4/0xa80 fs/quota/dquot.c:1505 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1567 __ext4_new_inode+0x614/0x3220 fs/ext4/ialloc.c:994 ext4_xattr_inode_create fs/ext4/xattr.c:1478 [inline] ext4_xattr_inode_lookup_create+0x82c/0x1768 fs/ext4/xattr.c:1588 ext4_xattr_block_set+0x1bc/0x24bc fs/ext4/xattr.c:1908 ext4_xattr_set_handle+0xde8/0x1260 fs/ext4/xattr.c:2447 ext4_xattr_set+0x1e4/0x2b8 fs/ext4/xattr.c:2549 ext4_xattr_trusted_set+0x4c/0x64 fs/ext4/xattr_trusted.c:38 __vfs_setxattr+0x3d8/0x400 fs/xattr.c:200 __vfs_setxattr_noperm+0x120/0x5c4 fs/xattr.c:234 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:295 vfs_setxattr+0x158/0x2ac fs/xattr.c:321 do_setxattr fs/xattr.c:636 [inline] filename_setxattr+0x20c/0x4f8 fs/xattr.c:665 path_setxattrat+0x2e8/0x320 fs/xattr.c:713 __do_sys_setxattr fs/xattr.c:747 [inline] __se_sys_setxattr fs/xattr.c:743 [inline] __arm64_sys_setxattr+0xc0/0xdc fs/xattr.c:743 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x17c arch/arm64/kernel/entry-common.c:767 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:786 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #3 (&ei->xattr_sem){++++}-{4:4}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 ext4_write_lock_xattr fs/ext4/xattr.h:157 [inline] ext4_xattr_set_handle+0x11c/0x1260 fs/ext4/xattr.c:2362 ext4_initxattrs+0xa4/0x11c fs/ext4/xattr_security.c:44 security_inode_init_security+0x6dc/0x7f4 security/security.c:1852 ext4_init_security+0x44/0x58 fs/ext4/xattr_security.c:58 __ext4_new_inode+0x2858/0x3220 fs/ext4/ialloc.c:1326 ext4_create+0x1f8/0x3fc fs/ext4/namei.c:2824 lookup_open fs/namei.c:3701 [inline] open_last_lookups fs/namei.c:3800 [inline] path_openat+0x12d8/0x2c40 fs/namei.c:4036 do_filp_open+0x18c/0x36c fs/namei.c:4066 do_sys_openat2+0x11c/0x1b4 fs/open.c:1429 do_sys_open fs/open.c:1444 [inline] __do_sys_openat fs/open.c:1460 [inline] __se_sys_openat fs/open.c:1455 [inline] __arm64_sys_openat+0x120/0x158 fs/open.c:1455 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x17c arch/arm64/kernel/entry-common.c:767 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:786 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #2 (jbd2_handle){++++}-{0:0}: start_this_handle+0xe74/0x10dc fs/jbd2/transaction.c:444 jbd2__journal_start+0x288/0x51c fs/jbd2/transaction.c:501 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:540 ocfs2_start_trans+0x368/0x6ac fs/ocfs2/journal.c:352 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline] ocfs2_reserve_suballoc_bits+0x630/0x3b60 fs/ocfs2/suballoc.c:832 ocfs2_reserve_new_metadata_blocks+0x368/0x810 fs/ocfs2/suballoc.c:982 ocfs2_expand_inline_dir fs/ocfs2/dir.c:2837 [inline] ocfs2_extend_dir+0x970/0x3964 fs/ocfs2/dir.c:3199 ocfs2_prepare_dir_for_insert+0x281c/0x4664 fs/ocfs2/dir.c:4304 ocfs2_mknod+0x6ec/0x1cf0 fs/ocfs2/namei.c:294 ocfs2_create+0x190/0x474 fs/ocfs2/namei.c:673 lookup_open fs/namei.c:3701 [inline] open_last_lookups fs/namei.c:3800 [inline] path_openat+0x12d8/0x2c40 fs/namei.c:4036 do_filp_open+0x18c/0x36c fs/namei.c:4066 do_sys_openat2+0x11c/0x1b4 fs/open.c:1429 do_sys_open fs/open.c:1444 [inline] __do_sys_openat fs/open.c:1460 [inline] __se_sys_openat fs/open.c:1455 [inline] __arm64_sys_openat+0x120/0x158 fs/open.c:1455 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x17c arch/arm64/kernel/entry-common.c:767 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:786 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #1 (&journal->j_trans_barrier){.+.+}-{4:4}: down_read+0x58/0x2f8 kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x35c/0x6ac fs/ocfs2/journal.c:350 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline] ocfs2_reserve_suballoc_bits+0x630/0x3b60 fs/ocfs2/suballoc.c:832 ocfs2_reserve_new_metadata_blocks+0x368/0x810 fs/ocfs2/suballoc.c:982 ocfs2_expand_inline_dir fs/ocfs2/dir.c:2837 [inline] ocfs2_extend_dir+0x970/0x3964 fs/ocfs2/dir.c:3199 ocfs2_prepare_dir_for_insert+0x281c/0x4664 fs/ocfs2/dir.c:4304 ocfs2_mknod+0x6ec/0x1cf0 fs/ocfs2/namei.c:294 ocfs2_create+0x190/0x474 fs/ocfs2/namei.c:673 lookup_open fs/namei.c:3701 [inline] open_last_lookups fs/namei.c:3800 [inline] path_openat+0x12d8/0x2c40 fs/namei.c:4036 do_filp_open+0x18c/0x36c fs/namei.c:4066 do_sys_openat2+0x11c/0x1b4 fs/open.c:1429 do_sys_open fs/open.c:1444 [inline] __do_sys_openat fs/open.c:1460 [inline] __se_sys_openat fs/open.c:1455 [inline] __arm64_sys_openat+0x120/0x158 fs/open.c:1455 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x17c arch/arm64/kernel/entry-common.c:767 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:786 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #0 (sb_internal#5){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3166 [inline] check_prevs_add kernel/locking/lockdep.c:3285 [inline] validate_chain kernel/locking/lockdep.c:3909 [inline] __lock_acquire+0x1728/0x3058 kernel/locking/lockdep.c:5235 lock_acquire+0x14c/0x2e0 kernel/locking/lockdep.c:5866 percpu_down_read include/linux/percpu-rwsem.h:52 [inline] __sb_start_write include/linux/fs.h:1783 [inline] sb_start_intwrite include/linux/fs.h:1966 [inline] ocfs2_start_trans+0x1f4/0x6ac fs/ocfs2/journal.c:348 ocfs2_acquire_dquot+0x594/0xa10 fs/ocfs2/quota_global.c:860 dqget+0x654/0xccc fs/quota/dquot.c:977 dquot_set_dqblk+0x40/0xe50 fs/quota/dquot.c:2820 quota_setquota+0x3b4/0x3bc fs/quota/quota.c:310 do_quotactl+0x65c/0x738 fs/quota/quota.c:802 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl fs/quota/quota.c:917 [inline] __arm64_sys_quotactl+0x298/0xb30 fs/quota/quota.c:917 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x17c arch/arm64/kernel/entry-common.c:767 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:786 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 other info that might help us debug this: Chain exists of: sb_internal#5 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); lock(&ocfs2_quota_ip_alloc_sem_key); rlock(sb_internal#5); *** DEADLOCK *** 4 locks held by syz.0.452/9044: #0: ffff0000f1e780e0 (&type->s_umount_key#80){++++}-{4:4}, at: __super_lock fs/super.c:58 [inline] #0: ffff0000f1e780e0 (&type->s_umount_key#80){++++}-{4:4}, at: super_lock+0x240/0x32c fs/super.c:120 #1: ffff000100dd00a8 (&dquot->dq_lock){+.+.}-{4:4}, at: ocfs2_acquire_dquot+0x24c/0xa10 fs/ocfs2/quota_global.c:823 #2: ffff0000f63fc2c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline] #2: ffff0000f63fc2c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x18c/0x22c fs/ocfs2/quota_global.c:313 #3: ffff0000f63fbf60 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x1a8/0x22c fs/ocfs2/quota_global.c:314 stack backtrace: CPU: 1 UID: 0 PID: 9044 Comm: syz.0.452 Not tainted 6.15.0-rc5-syzkaller-gc32f8dc5aaf9 #0 PREEMPT Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025 Call trace: show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:466 (C) __dump_stack+0x30/0x40 lib/dump_stack.c:94 dump_stack_lvl+0xd8/0x12c lib/dump_stack.c:120 dump_stack+0x1c/0x28 lib/dump_stack.c:129 print_circular_bug+0x324/0x32c kernel/locking/lockdep.c:2079 check_noncircular+0x154/0x174 kernel/locking/lockdep.c:2211 check_prev_add kernel/locking/lockdep.c:3166 [inline] check_prevs_add kernel/locking/lockdep.c:3285 [inline] validate_chain kernel/locking/lockdep.c:3909 [inline] __lock_acquire+0x1728/0x3058 kernel/locking/lockdep.c:5235 lock_acquire+0x14c/0x2e0 kernel/locking/lockdep.c:5866 percpu_down_read include/linux/percpu-rwsem.h:52 [inline] __sb_start_write include/linux/fs.h:1783 [inline] sb_start_intwrite include/linux/fs.h:1966 [inline] ocfs2_start_trans+0x1f4/0x6ac fs/ocfs2/journal.c:348 ocfs2_acquire_dquot+0x594/0xa10 fs/ocfs2/quota_global.c:860 dqget+0x654/0xccc fs/quota/dquot.c:977 dquot_set_dqblk+0x40/0xe50 fs/quota/dquot.c:2820 quota_setquota+0x3b4/0x3bc fs/quota/quota.c:310 do_quotactl+0x65c/0x738 fs/quota/quota.c:802 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl fs/quota/quota.c:917 [inline] __arm64_sys_quotactl+0x298/0xb30 fs/quota/quota.c:917 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x17c arch/arm64/kernel/entry-common.c:767 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:786 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600