====================================================== WARNING: possible circular locking dependency detected 5.15.133-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.5/29552 is trying to acquire lock: ffff888033c5aa58 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x3a6/0x1e00 fs/ext4/inode.c:568 but task is already holding lock: ffff888076f8e208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:354 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1488 v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332 dquot_acquire+0x188/0x680 fs/quota/dquot.c:459 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6180 dqget+0x752/0xe30 fs/quota/dquot.c:972 __dquot_initialize+0x2d9/0xe10 fs/quota/dquot.c:1550 ext4_mkdir+0x197/0xce0 fs/ext4/namei.c:3010 vfs_mkdir+0x419/0x640 fs/namei.c:3994 do_mkdirat+0x260/0x520 fs/namei.c:4019 __do_sys_mkdirat fs/namei.c:4034 [inline] __se_sys_mkdirat fs/namei.c:4032 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4032 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb -> #1 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 dquot_commit+0x57/0x510 fs/quota/dquot.c:503 ext4_write_dquot+0x1e8/0x2b0 fs/ext4/super.c:6164 mark_dquot_dirty fs/quota/dquot.c:370 [inline] mark_all_dquot_dirty fs/quota/dquot.c:408 [inline] __dquot_alloc_space+0x53a/0xf30 fs/quota/dquot.c:1780 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline] dquot_alloc_space include/linux/quotaops.h:310 [inline] dquot_alloc_block include/linux/quotaops.h:334 [inline] ext4_mb_new_blocks+0x12bb/0x4d50 fs/ext4/mballoc.c:5646 ext4_ext_map_blocks+0x1986/0x7220 fs/ext4/extents.c:4287 ext4_map_blocks+0xaad/0x1e00 fs/ext4/inode.c:645 ext4_getblk+0x19f/0x710 fs/ext4/inode.c:846 ext4_bread+0x2a/0x170 fs/ext4/inode.c:899 ext4_append+0x31f/0x5c0 fs/ext4/namei.c:83 ext4_init_new_dir+0x33a/0xa20 fs/ext4/namei.c:2981 ext4_mkdir+0x4f2/0xce0 fs/ext4/namei.c:3027 vfs_mkdir+0x419/0x640 fs/namei.c:3994 do_mkdirat+0x260/0x520 fs/namei.c:4019 __do_sys_mkdirat fs/namei.c:4034 [inline] __se_sys_mkdirat fs/namei.c:4032 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4032 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1488 ext4_map_blocks+0x3a6/0x1e00 fs/ext4/inode.c:568 ext4_getblk+0x19f/0x710 fs/ext4/inode.c:846 ext4_bread+0x2a/0x170 fs/ext4/inode.c:899 ext4_quota_write+0x21e/0x580 fs/ext4/super.c:6546 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x3a9/0x800 fs/quota/quota_tree.c:125 do_insert_tree+0x2b4/0x1c20 fs/quota/quota_tree.c:335 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 dq_insert_tree fs/quota/quota_tree.c:392 [inline] qtree_write_dquot+0x3b9/0x530 fs/quota/quota_tree.c:411 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:358 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:468 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6180 dqget+0x752/0xe30 fs/quota/dquot.c:972 dquot_transfer+0x1d1/0x4e0 fs/quota/dquot.c:2157 ext4_setattr+0x91a/0x1990 fs/ext4/inode.c:5405 notify_change+0xc6d/0xf50 fs/attr.c:505 chown_common+0x592/0x890 fs/open.c:680 do_fchownat+0x169/0x240 fs/open.c:711 __do_sys_chown fs/open.c:731 [inline] __se_sys_chown fs/open.c:729 [inline] __x64_sys_chown+0x7e/0x90 fs/open.c:729 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 5 locks held by syz-executor.5/29552: #0: ffff888076f8e460 (sb_writers#5){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377 #1: ffff888033c5e7a0 (&type->i_mutex_dir_key#4){++++}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline] #1: ffff888033c5e7a0 (&type->i_mutex_dir_key#4){++++}-{3:3}, at: chown_common+0x499/0x890 fs/open.c:674 #2: ffff888033c5e478 (&ei->xattr_sem){++++}-{3:3}, at: ext4_setattr+0x90d/0x1990 fs/ext4/inode.c:5404 #3: ffff8880733dd3e8 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x64/0x680 fs/quota/dquot.c:456 #4: ffff888076f8e208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:354 stack backtrace: CPU: 1 PID: 29552 Comm: syz-executor.5 Not tainted 5.15.133-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1488 ext4_map_blocks+0x3a6/0x1e00 fs/ext4/inode.c:568 ext4_getblk+0x19f/0x710 fs/ext4/inode.c:846 ext4_bread+0x2a/0x170 fs/ext4/inode.c:899 ext4_quota_write+0x21e/0x580 fs/ext4/super.c:6546 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x3a9/0x800 fs/quota/quota_tree.c:125 do_insert_tree+0x2b4/0x1c20 fs/quota/quota_tree.c:335 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366 dq_insert_tree fs/quota/quota_tree.c:392 [inline] qtree_write_dquot+0x3b9/0x530 fs/quota/quota_tree.c:411 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:358 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:468 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6180 dqget+0x752/0xe30 fs/quota/dquot.c:972 dquot_transfer+0x1d1/0x4e0 fs/quota/dquot.c:2157 ext4_setattr+0x91a/0x1990 fs/ext4/inode.c:5405 notify_change+0xc6d/0xf50 fs/attr.c:505 chown_common+0x592/0x890 fs/open.c:680 do_fchownat+0x169/0x240 fs/open.c:711 __do_sys_chown fs/open.c:731 [inline] __se_sys_chown fs/open.c:729 [inline] __x64_sys_chown+0x7e/0x90 fs/open.c:729 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb RIP: 0033:0x7f54f5bf0ae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f54ebd910c8 EFLAGS: 00000246 ORIG_RAX: 000000000000005c RAX: ffffffffffffffda RBX: 00007f54f5d10050 RCX: 00007f54f5bf0ae9 RDX: 000000000000ee00 RSI: 000000000000ee01 RDI: 0000000020000180 RBP: 00007f54f5c3c47a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000006e R14: 00007f54f5d10050 R15: 00007fff8a2c2eb8