EXT4-fs error (device loop3): htree_dirblock_to_tree:1082: inode #2: comm syz.3.1839: Directory hole found for htree leaf block ====================================================== WARNING: possible circular locking dependency detected 5.15.162-syzkaller #0 Not tainted ------------------------------------------------------ syz.3.1839/10311 is trying to acquire lock: ffff888021cbf020 (&ei->i_data_sem/1){+.+.}-{3:3}, at: swap_inode_boot_loader fs/ext4/ioctl.c:176 [inline] ffff888021cbf020 (&ei->i_data_sem/1){+.+.}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1056 [inline] ffff888021cbf020 (&ei->i_data_sem/1){+.+.}-{3:3}, at: ext4_ioctl+0x3dec/0x5b80 fs/ext4/ioctl.c:1276 but task is already holding lock: ffff888021cbdc30 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x28/0x40 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&ei->i_data_sem/2){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 ext4_map_blocks+0x3a6/0x1e00 fs/ext4/inode.c:568 ext4_getblk+0x19f/0x710 fs/ext4/inode.c:846 ext4_bread+0x2a/0x170 fs/ext4/inode.c:899 ext4_quota_read+0x1a1/0x2c0 fs/ext4/super.c:6520 read_blk fs/quota/quota_tree.c:55 [inline] find_tree_dqentry+0x192/0xb60 fs/quota/quota_tree.c:617 find_tree_dqentry+0x41a/0xb60 fs/quota/quota_tree.c:635 find_tree_dqentry+0x41a/0xb60 fs/quota/quota_tree.c:635 find_tree_dqentry+0x41a/0xb60 fs/quota/quota_tree.c:635 find_dqentry fs/quota/quota_tree.c:647 [inline] qtree_read_dquot+0x13f/0x650 fs/quota/quota_tree.c:667 v2_read_dquot+0xbe/0x100 fs/quota/quota_v2.c:333 dquot_acquire+0x188/0x680 fs/quota/dquot.c:463 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6192 dqget+0x74e/0xe30 fs/quota/dquot.c:986 __dquot_initialize+0x45e/0xea0 fs/quota/dquot.c:1516 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x9d9/0x1240 fs/ext4/orphan.c:474 ext4_fill_super+0x98de/0xa110 fs/ext4/super.c:4974 mount_bdev+0x2c9/0x3f0 fs/super.c:1387 legacy_get_tree+0xeb/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1517 do_new_mount+0x2ba/0xb40 fs/namespace.c:3005 do_mount fs/namespace.c:3348 [inline] __do_sys_mount fs/namespace.c:3556 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3533 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332 dquot_acquire+0x188/0x680 fs/quota/dquot.c:463 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6192 dqget+0x74e/0xe30 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1516 ext4_xattr_set+0x104/0x3d0 fs/ext4/xattr.c:2491 __vfs_setxattr+0x3e7/0x420 fs/xattr.c:182 __vfs_setxattr_noperm+0x12a/0x5e0 fs/xattr.c:216 vfs_setxattr+0x21d/0x420 fs/xattr.c:303 do_setxattr fs/xattr.c:588 [inline] setxattr+0x27e/0x2e0 fs/xattr.c:611 path_setxattr+0x1bc/0x2a0 fs/xattr.c:630 __do_sys_lsetxattr fs/xattr.c:653 [inline] __se_sys_lsetxattr fs/xattr.c:649 [inline] __x64_sys_lsetxattr+0xb4/0xd0 fs/xattr.c:649 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6172 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_alloc_space+0xdd8/0x1090 fs/quota/dquot.c:1751 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline] dquot_alloc_space include/linux/quotaops.h:310 [inline] dquot_alloc_block include/linux/quotaops.h:334 [inline] ext4_mb_new_blocks+0x12d8/0x4d60 fs/ext4/mballoc.c:5743 ext4_new_meta_blocks+0x206/0x4f0 fs/ext4/balloc.c:738 ext4_ext_grow_indepth fs/ext4/extents.c:1323 [inline] ext4_ext_create_new_leaf fs/ext4/extents.c:1429 [inline] ext4_ext_insert_extent+0xf43/0x4e60 fs/ext4/extents.c:2099 ext4_split_extent_at+0x80e/0x10f0 fs/ext4/extents.c:3229 ext4_force_split_extent_at fs/ext4/extents.c:319 [inline] ext4_swap_extents+0x136e/0x2340 fs/ext4/extents.c:5752 move_extent_per_page+0x18b6/0x3010 fs/ext4/move_extent.c:360 ext4_move_extents+0x9e2/0xe80 fs/ext4/move_extent.c:674 __ext4_ioctl fs/ext4/ioctl.c:990 [inline] ext4_ioctl+0x2fcb/0x5b80 fs/ext4/ioctl.c:1276 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:874 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&ei->i_data_sem/1){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667 swap_inode_boot_loader fs/ext4/ioctl.c:176 [inline] __ext4_ioctl fs/ext4/ioctl.c:1056 [inline] ext4_ioctl+0x3dec/0x5b80 fs/ext4/ioctl.c:1276 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:874 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: &ei->i_data_sem/1 --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ei->i_data_sem/2); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); lock(&ei->i_data_sem/1); *** DEADLOCK *** 5 locks held by syz.3.1839/10311: #0: ffff8880624e6460 (sb_writers#5){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:421 #1: ffff888021cbdda8 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #1: ffff888021cbdda8 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: lock_two_nondirectories+0xde/0x130 fs/inode.c:1083 #2: ffff888021cbf198 (&sb->s_type->i_mutex_key#9/4){+.+.}-{3:3}, at: swap_inode_boot_loader fs/ext4/ioctl.c:135 [inline] #2: ffff888021cbf198 (&sb->s_type->i_mutex_key#9/4){+.+.}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1056 [inline] #2: ffff888021cbf198 (&sb->s_type->i_mutex_key#9/4){+.+.}-{3:3}, at: ext4_ioctl+0x1fb2/0x5b80 fs/ext4/ioctl.c:1276 #3: ffff888021cbf338 (mapping.invalidate_lock){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:834 [inline] #3: ffff888021cbf338 (mapping.invalidate_lock){++++}-{3:3}, at: swap_inode_boot_loader fs/ext4/ioctl.c:152 [inline] #3: ffff888021cbf338 (mapping.invalidate_lock){++++}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1056 [inline] #3: ffff888021cbf338 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_ioctl+0x3965/0x5b80 fs/ext4/ioctl.c:1276 #4: ffff888021cbdc30 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x28/0x40 stack backtrace: CPU: 1 PID: 10311 Comm: syz.3.1839 Not tainted 5.15.162-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667 swap_inode_boot_loader fs/ext4/ioctl.c:176 [inline] __ext4_ioctl fs/ext4/ioctl.c:1056 [inline] ext4_ioctl+0x3dec/0x5b80 fs/ext4/ioctl.c:1276 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:874 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7fe89a07cbd9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fe898afd048 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007fe89a20af60 RCX: 00007fe89a07cbd9 RDX: 0000000000000000 RSI: 0000000000006611 RDI: 0000000000000005 RBP: 00007fe89a0ebe60 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007fe89a20af60 R15: 00007ffdaf4e0518