====================================================== WARNING: possible circular locking dependency detected 6.15.0-rc4-syzkaller-ge0f4c8dd9d2d #0 Not tainted ------------------------------------------------------ syz.2.178/7355 is trying to acquire lock: ffff0000d2000610 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_setattr+0xa04/0x17a0 fs/ocfs2/file.c:1263 but task is already holding lock: ffff0000f1b0b120 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0x9f8/0x17a0 fs/ocfs2/file.c:1262 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&oi->ip_alloc_sem){+.+.}-{4:4}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 ocfs2_try_remove_refcount_tree+0xb4/0x2d8 fs/ocfs2/refcounttree.c:932 ocfs2_xattr_set+0x460/0xe9c fs/ocfs2/xattr.c:3669 ocfs2_set_acl+0x574/0x628 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x190/0x25c fs/ocfs2/acl.c:286 set_posix_acl fs/posix_acl.c:954 [inline] vfs_remove_acl+0x408/0x664 fs/posix_acl.c:1241 ovl_do_remove_acl fs/overlayfs/overlayfs.h:353 [inline] ovl_workdir_create+0x2f4/0x6ec fs/overlayfs/super.c:353 ovl_make_workdir fs/overlayfs/super.c:669 [inline] ovl_get_workdir+0x2b4/0x11d8 fs/overlayfs/super.c:827 ovl_fill_super+0x1028/0x2c80 fs/overlayfs/super.c:1406 vfs_get_super fs/super.c:1280 [inline] get_tree_nodev+0xb4/0x144 fs/super.c:1299 ovl_get_tree+0x28/0x38 fs/overlayfs/params.c:701 vfs_get_tree+0x90/0x28c fs/super.c:1759 do_new_mount+0x228/0x814 fs/namespace.c:3884 path_mount+0x5b4/0xde0 fs/namespace.c:4211 do_mount fs/namespace.c:4224 [inline] __do_sys_mount fs/namespace.c:4435 [inline] __se_sys_mount fs/namespace.c:4412 [inline] __arm64_sys_mount+0x3e8/0x468 fs/namespace.c:4412 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x150 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #3 (&oi->ip_xattr_sem){++++}-{4:4}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 ocfs2_xattr_set_handle+0x2a8/0x5e4 fs/ocfs2/xattr.c:3501 ocfs2_init_security_set+0xb4/0xd8 fs/ocfs2/xattr.c:7307 ocfs2_mknod+0x106c/0x1cf0 fs/ocfs2/namei.c:419 ocfs2_create+0x190/0x474 fs/ocfs2/namei.c:673 lookup_open fs/namei.c:3701 [inline] open_last_lookups fs/namei.c:3800 [inline] path_openat+0x12d8/0x2c40 fs/namei.c:4036 do_filp_open+0x18c/0x36c fs/namei.c:4066 do_sys_openat2+0x11c/0x1b4 fs/open.c:1429 do_sys_open fs/open.c:1444 [inline] __do_sys_openat fs/open.c:1460 [inline] __se_sys_openat fs/open.c:1455 [inline] __arm64_sys_openat+0x120/0x158 fs/open.c:1455 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x150 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #2 (jbd2_handle){++++}-{0:0}: start_this_handle+0xe74/0x10dc fs/jbd2/transaction.c:444 jbd2__journal_start+0x288/0x51c fs/jbd2/transaction.c:501 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:540 ocfs2_start_trans+0x368/0x6ac fs/ocfs2/journal.c:352 ocfs2_shutdown_local_alloc+0x1ac/0x7e4 fs/ocfs2/localalloc.c:417 ocfs2_dismount_volume+0x1e4/0x8c4 fs/ocfs2/super.c:1822 ocfs2_put_super+0xec/0x320 fs/ocfs2/super.c:1553 generic_shutdown_super+0x12c/0x2b8 fs/super.c:642 kill_block_super+0x44/0x90 fs/super.c:1710 deactivate_locked_super+0xc4/0x12c fs/super.c:473 deactivate_super+0xe0/0x100 fs/super.c:506 cleanup_mnt+0x31c/0x3ac fs/namespace.c:1435 __cleanup_mnt+0x20/0x30 fs/namespace.c:1442 task_work_run+0x1dc/0x260 kernel/task_work.c:227 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] do_notify_resume+0x16c/0x1ec arch/arm64/kernel/entry-common.c:151 exit_to_user_mode_prepare arch/arm64/kernel/entry-common.c:169 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:178 [inline] el0_svc+0xb0/0x150 arch/arm64/kernel/entry-common.c:745 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #1 (&journal->j_trans_barrier){.+.+}-{4:4}: down_read+0x58/0x2f8 kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x35c/0x6ac fs/ocfs2/journal.c:350 ocfs2_shutdown_local_alloc+0x1ac/0x7e4 fs/ocfs2/localalloc.c:417 ocfs2_dismount_volume+0x1e4/0x8c4 fs/ocfs2/super.c:1822 ocfs2_put_super+0xec/0x320 fs/ocfs2/super.c:1553 generic_shutdown_super+0x12c/0x2b8 fs/super.c:642 kill_block_super+0x44/0x90 fs/super.c:1710 deactivate_locked_super+0xc4/0x12c fs/super.c:473 deactivate_super+0xe0/0x100 fs/super.c:506 cleanup_mnt+0x31c/0x3ac fs/namespace.c:1435 __cleanup_mnt+0x20/0x30 fs/namespace.c:1442 task_work_run+0x1dc/0x260 kernel/task_work.c:227 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] do_notify_resume+0x16c/0x1ec arch/arm64/kernel/entry-common.c:151 exit_to_user_mode_prepare arch/arm64/kernel/entry-common.c:169 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:178 [inline] el0_svc+0xb0/0x150 arch/arm64/kernel/entry-common.c:745 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #0 (sb_internal#3){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3166 [inline] check_prevs_add kernel/locking/lockdep.c:3285 [inline] validate_chain kernel/locking/lockdep.c:3909 [inline] __lock_acquire+0x1728/0x3058 kernel/locking/lockdep.c:5235 lock_acquire+0x14c/0x2e0 kernel/locking/lockdep.c:5866 percpu_down_read include/linux/percpu-rwsem.h:52 [inline] __sb_start_write include/linux/fs.h:1783 [inline] sb_start_intwrite include/linux/fs.h:1966 [inline] ocfs2_start_trans+0x1f4/0x6ac fs/ocfs2/journal.c:348 ocfs2_setattr+0xa04/0x17a0 fs/ocfs2/file.c:1263 notify_change+0x9a4/0xc50 fs/attr.c:552 ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline] ovl_workdir_create+0x570/0x6ec fs/overlayfs/super.c:363 ovl_make_workdir fs/overlayfs/super.c:669 [inline] ovl_get_workdir+0x2b4/0x11d8 fs/overlayfs/super.c:827 ovl_fill_super+0x1028/0x2c80 fs/overlayfs/super.c:1406 vfs_get_super fs/super.c:1280 [inline] get_tree_nodev+0xb4/0x144 fs/super.c:1299 ovl_get_tree+0x28/0x38 fs/overlayfs/params.c:701 vfs_get_tree+0x90/0x28c fs/super.c:1759 do_new_mount+0x228/0x814 fs/namespace.c:3884 path_mount+0x5b4/0xde0 fs/namespace.c:4211 do_mount fs/namespace.c:4224 [inline] __do_sys_mount fs/namespace.c:4435 [inline] __se_sys_mount fs/namespace.c:4412 [inline] __arm64_sys_mount+0x3e8/0x468 fs/namespace.c:4412 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x150 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 other info that might help us debug this: Chain exists of: sb_internal#3 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_alloc_sem); lock(&oi->ip_xattr_sem); lock(&oi->ip_alloc_sem); rlock(sb_internal#3); *** DEADLOCK *** 5 locks held by syz.2.178/7355: #0: ffff0000c7ac40e0 (&type->s_umount_key#52/1){+.+.}-{4:4}, at: alloc_super+0x1a0/0x80c fs/super.c:344 #1: ffff0000d2000420 (sb_writers#25){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:556 #2: ffff0000f1b09800 (&sb->s_type->i_mutex_key#33/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:902 [inline] #2: ffff0000f1b09800 (&sb->s_type->i_mutex_key#33/1){+.+.}-{4:4}, at: ovl_workdir_create+0x11c/0x6ec fs/overlayfs/super.c:302 #3: ffff0000f1b0b480 (&sb->s_type->i_mutex_key#35){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline] #3: ffff0000f1b0b480 (&sb->s_type->i_mutex_key#35){+.+.}-{4:4}, at: ovl_workdir_create+0x514/0x6ec fs/overlayfs/super.c:362 #4: ffff0000f1b0b120 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0x9f8/0x17a0 fs/ocfs2/file.c:1262 stack backtrace: CPU: 0 UID: 0 PID: 7355 Comm: syz.2.178 Not tainted 6.15.0-rc4-syzkaller-ge0f4c8dd9d2d #0 PREEMPT Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025 Call trace: show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:466 (C) __dump_stack+0x30/0x40 lib/dump_stack.c:94 dump_stack_lvl+0xd8/0x12c lib/dump_stack.c:120 dump_stack+0x1c/0x28 lib/dump_stack.c:129 print_circular_bug+0x324/0x32c kernel/locking/lockdep.c:2079 check_noncircular+0x154/0x174 kernel/locking/lockdep.c:2211 check_prev_add kernel/locking/lockdep.c:3166 [inline] check_prevs_add kernel/locking/lockdep.c:3285 [inline] validate_chain kernel/locking/lockdep.c:3909 [inline] __lock_acquire+0x1728/0x3058 kernel/locking/lockdep.c:5235 lock_acquire+0x14c/0x2e0 kernel/locking/lockdep.c:5866 percpu_down_read include/linux/percpu-rwsem.h:52 [inline] __sb_start_write include/linux/fs.h:1783 [inline] sb_start_intwrite include/linux/fs.h:1966 [inline] ocfs2_start_trans+0x1f4/0x6ac fs/ocfs2/journal.c:348 ocfs2_setattr+0xa04/0x17a0 fs/ocfs2/file.c:1263 notify_change+0x9a4/0xc50 fs/attr.c:552 ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline] ovl_workdir_create+0x570/0x6ec fs/overlayfs/super.c:363 ovl_make_workdir fs/overlayfs/super.c:669 [inline] ovl_get_workdir+0x2b4/0x11d8 fs/overlayfs/super.c:827 ovl_fill_super+0x1028/0x2c80 fs/overlayfs/super.c:1406 vfs_get_super fs/super.c:1280 [inline] get_tree_nodev+0xb4/0x144 fs/super.c:1299 ovl_get_tree+0x28/0x38 fs/overlayfs/params.c:701 vfs_get_tree+0x90/0x28c fs/super.c:1759 do_new_mount+0x228/0x814 fs/namespace.c:3884 path_mount+0x5b4/0xde0 fs/namespace.c:4211 do_mount fs/namespace.c:4224 [inline] __do_sys_mount fs/namespace.c:4435 [inline] __se_sys_mount fs/namespace.c:4412 [inline] __arm64_sys_mount+0x3e8/0x468 fs/namespace.c:4412 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x58/0x150 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x78/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 overlayfs: upper fs does not support tmpfile. (syz.2.178,7355,1):ocfs2_check_dir_entry:325 ERROR: bad entry in directory #72: rec_len % 4 != 0 - offset=16, inode=66, rec_len=491, name_len=2 (syz.2.178,7355,1):ocfs2_prepare_dir_for_insert:4294 ERROR: status = -2 (syz.2.178,7355,1):__ocfs2_prepare_orphan_dir:2180 ERROR: status = -2 (syz.2.178,7355,1):ocfs2_prepare_orphan_dir:2224 ERROR: status = -2 (syz.2.178,7355,1):ocfs2_prepare_orphan_dir:2240 ERROR: status = -2 (syz.2.178,7355,1):ocfs2_unlink:964 ERROR: status = -2 overlayfs: cleanup of 'work/#7' failed (-2) overlayfs: upper fs does not support RENAME_WHITEOUT. overlayfs: upper fs missing required features.