ip6_tables: ip6tables: counters copy to user failed while replacing table
======================================================
WARNING: possible circular locking dependency detected
4.14.305-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.0/7981 is trying to acquire lock:
 (rtnl_mutex){+.+.}, at: [<ffffffff85c3239e>] unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1630

but task is already holding lock:
 (&xt[i].mutex){+.+.}, at: [<ffffffff85f22d08>] xt_find_table_lock+0x38/0x3d0 net/netfilter/x_tables.c:1088

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&xt[i].mutex){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
       xt_find_target+0x3e/0x1e0 net/netfilter/x_tables.c:232
       xt_request_find_target net/netfilter/x_tables.c:261 [inline]
       xt_request_find_target+0x72/0xe0 net/netfilter/x_tables.c:254
       ipt_init_target+0xb9/0x250 net/sched/act_ipt.c:45
       __tcf_ipt_init+0x48d/0xc00 net/sched/act_ipt.c:168
       tcf_ipt_init+0x43/0x50 net/sched/act_ipt.c:202
       tcf_action_init_1+0x51a/0x9e0 net/sched/act_api.c:691
       tcf_action_init+0x26d/0x400 net/sched/act_api.c:760
       tcf_action_add net/sched/act_api.c:1088 [inline]
       tc_ctl_action+0x2e3/0x510 net/sched/act_api.c:1140
       rtnetlink_rcv_msg+0x3be/0xb10 net/core/rtnetlink.c:4322
       netlink_rcv_skb+0x125/0x390 net/netlink/af_netlink.c:2461
       netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
       netlink_unicast+0x437/0x610 net/netlink/af_netlink.c:1328
       netlink_sendmsg+0x651/0xbc0 net/netlink/af_netlink.c:1900
       sock_sendmsg_nosec net/socket.c:646 [inline]
       sock_sendmsg+0xb5/0x100 net/socket.c:656
       ___sys_sendmsg+0x6c8/0x800 net/socket.c:2062
       __sys_sendmsg+0xa3/0x120 net/socket.c:2096
       SYSC_sendmsg net/socket.c:2107 [inline]
       SyS_sendmsg+0x27/0x40 net/socket.c:2103
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

-> #0 (rtnl_mutex){+.+.}:
       lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
       unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1630
       tee_tg_destroy+0x5c/0xb0 net/netfilter/xt_TEE.c:123
       cleanup_entry+0x232/0x310 net/ipv6/netfilter/ip6_tables.c:685
       __do_replace+0x38d/0x580 net/ipv4/netfilter/arp_tables.c:930
       do_replace net/ipv6/netfilter/ip6_tables.c:1162 [inline]
       do_ip6t_set_ctl+0x256/0x3b0 net/ipv6/netfilter/ip6_tables.c:1688
       nf_sockopt net/netfilter/nf_sockopt.c:106 [inline]
       nf_setsockopt+0x5f/0xb0 net/netfilter/nf_sockopt.c:115
       ipv6_setsockopt+0xc0/0x120 net/ipv6/ipv6_sockglue.c:944
       tcp_setsockopt+0x7b/0xc0 net/ipv4/tcp.c:2831
       SYSC_setsockopt net/socket.c:1865 [inline]
       SyS_setsockopt+0x110/0x1e0 net/socket.c:1844
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x5e/0xd3

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&xt[i].mutex);
                               lock(rtnl_mutex);
                               lock(&xt[i].mutex);
  lock(rtnl_mutex);

 *** DEADLOCK ***

1 lock held by syz-executor.0/7981:
 #0:  (&xt[i].mutex){+.+.}, at: [<ffffffff85f22d08>] xt_find_table_lock+0x38/0x3d0 net/netfilter/x_tables.c:1088

stack backtrace:
CPU: 1 PID: 7981 Comm: syz-executor.0 Not tainted 4.14.305-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/21/2023
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x1b2/0x281 lib/dump_stack.c:58
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
 check_prev_add kernel/locking/lockdep.c:1905 [inline]
 check_prevs_add kernel/locking/lockdep.c:2022 [inline]
 validate_chain kernel/locking/lockdep.c:2464 [inline]
 __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
 __mutex_lock_common kernel/locking/mutex.c:756 [inline]
 __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
 unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1630
 tee_tg_destroy+0x5c/0xb0 net/netfilter/xt_TEE.c:123
 cleanup_entry+0x232/0x310 net/ipv6/netfilter/ip6_tables.c:685
 __do_replace+0x38d/0x580 net/ipv4/netfilter/arp_tables.c:930
 do_replace net/ipv6/netfilter/ip6_tables.c:1162 [inline]
 do_ip6t_set_ctl+0x256/0x3b0 net/ipv6/netfilter/ip6_tables.c:1688
 nf_sockopt net/netfilter/nf_sockopt.c:106 [inline]
 nf_setsockopt+0x5f/0xb0 net/netfilter/nf_sockopt.c:115
 ipv6_setsockopt+0xc0/0x120 net/ipv6/ipv6_sockglue.c:944
 tcp_setsockopt+0x7b/0xc0 net/ipv4/tcp.c:2831
 SYSC_setsockopt net/socket.c:1865 [inline]
 SyS_setsockopt+0x110/0x1e0 net/socket.c:1844
 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
 entry_SYSCALL_64_after_hwframe+0x5e/0xd3
RIP: 0033:0x7f033f55b74a
RSP: 002b:00007ffe31e78948 EFLAGS: 00000206 ORIG_RAX: 0000000000000036
RAX: ffffffffffffffda RBX: 0000000000000029 RCX: 00007f033f55b74a
RDX: 0000000000000040 RSI: 0000000000000029 RDI: 0000000000000003
RBP: 00007ffe31e78970 R08: 00000000000003b8 R09: ffff000000000000
R10: 00007f033f6536c0 R11: 0000000000000206 R12: 00007ffe31e789d0
R13: 0000000000000003 R14: 00007ffe31e7896c R15: 00007f033f653660
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.4'.
ip6_tables: ip6tables: counters copy to user failed while replacing table
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.1'.
[EXT4 FS bs=2048, gc=1, bpg=16384, ipg=32, mo=8802e018, mo2=0002]
ip6_tables: ip6tables: counters copy to user failed while replacing table
EXT4-fs (loop5): mounted filesystem without journal. Opts: debug,barrier,nouid32,noblock_validity,,errors=continue
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.4'.
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.4'.
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.1'.
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.4'.
ip6_tables: ip6tables: counters copy to user failed while replacing table
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.1'.
[EXT4 FS bs=2048, gc=1, bpg=16384, ipg=32, mo=8802e018, mo2=0002]
EXT4-fs (loop5): mounted filesystem without journal. Opts: debug,barrier,nouid32,noblock_validity,,errors=continue
ip6_tables: ip6tables: counters copy to user failed while replacing table
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.4'.
[EXT4 FS bs=2048, gc=1, bpg=16384, ipg=32, mo=8802e018, mo2=0002]
EXT4-fs (loop5): mounted filesystem without journal. Opts: debug,barrier,nouid32,noblock_validity,,errors=continue
ip6_tables: ip6tables: counters copy to user failed while replacing table
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.4'.
ip6_tables: ip6tables: counters copy to user failed while replacing table
audit: type=1800 audit(1676078527.166:208): pid=19186 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.5" name="bus" dev="loop5" ino=18 res=0
NILFS (loop5): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
audit: type=1804 audit(1676078527.196:209): pid=19186 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.5" name="/root/syzkaller-testdir278170904/syzkaller.0xVpyr/300/file0/bus" dev="loop5" ino=18 res=1
audit: type=1800 audit(1676078527.196:210): pid=19186 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.5" name="bus" dev="loop5" ino=18 res=0
audit: type=1800 audit(1676078527.776:211): pid=19213 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.0" name="bus" dev="sda1" ino=14322 res=0
NILFS (loop5): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
audit: type=1800 audit(1676078527.826:212): pid=19218 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.5" name="bus" dev="loop5" ino=18 res=0
audit: type=1804 audit(1676078527.846:213): pid=19218 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.5" name="/root/syzkaller-testdir278170904/syzkaller.0xVpyr/301/file0/bus" dev="loop5" ino=18 res=1
NILFS (loop3): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
audit: type=1800 audit(1676078527.846:214): pid=19218 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.5" name="bus" dev="loop5" ino=18 res=0
audit: type=1804 audit(1676078527.846:215): pid=19213 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.0" name="/root/syzkaller-testdir2915211675/syzkaller.mWEGHl/312/bus" dev="sda1" ino=14322 res=1
audit: type=1800 audit(1676078527.846:216): pid=19213 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.0" name="bus" dev="sda1" ino=14322 res=0
audit: type=1800 audit(1676078528.036:217): pid=19233 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.3" name="bus" dev="loop3" ino=18 res=0
NILFS (loop5): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
NILFS (loop3): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
NILFS (loop3): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
NILFS (loop5): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds