======================================================== WARNING: possible irq lock inversion dependency detected 6.11.0-syzkaller-12113-ge7ed34365879 #0 Not tainted -------------------------------------------------------- ksoftirqd/1/24 just changed the state of lock: ffff88805dc8ea48 (&pch->upl){+..-}-{2:2}, at: ppp_input_error+0x60/0x1b0 drivers/net/ppp/ppp_generic.c:2344 but this lock took another, SOFTIRQ-unsafe lock in the past: (&pch->downl){+.+.}-{2:2} and interrupts could create inverse lock ordering between them. other info that might help us debug this: Chain exists of: &pch->upl --> &ppp->wlock --> &pch->downl Possible interrupt unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&pch->downl); local_irq_disable(); lock(&pch->upl); lock(&ppp->wlock); lock(&pch->upl); *** DEADLOCK *** no locks held by ksoftirqd/1/24. the shortest dependencies between 2nd lock and 1st lock: -> (&pch->downl){+.+.}-{2:2} { HARDIRQ-ON-W at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:356 [inline] ppp_unregister_channel+0x7c/0x300 drivers/net/ppp/ppp_generic.c:2992 pppox_unbind_sock+0x5c/0xb0 drivers/net/ppp/pppox.c:58 pppol2tp_release+0x99/0x230 net/l2tp/l2tp_ppp.c:436 __sock_release net/socket.c:658 [inline] sock_close+0xbc/0x240 net/socket.c:1426 __fput+0x23f/0x880 fs/file_table.c:431 task_work_run+0x24f/0x310 kernel/task_work.c:228 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] exit_to_user_mode_loop kernel/entry/common.c:114 [inline] exit_to_user_mode_prepare include/linux/entry-common.h:328 [inline] __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline] syscall_exit_to_user_mode+0x168/0x370 kernel/entry/common.c:218 do_syscall_64+0x100/0x230 arch/x86/entry/common.c:89 entry_SYSCALL_64_after_hwframe+0x77/0x7f SOFTIRQ-ON-W at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline] _raw_spin_lock+0x2e/0x40 kernel/locking/spinlock.c:154 spin_lock include/linux/spinlock.h:351 [inline] ppp_channel_bridge_input drivers/net/ppp/ppp_generic.c:2272 [inline] ppp_input+0x18b/0xa10 drivers/net/ppp/ppp_generic.c:2304 pppoe_rcv_core+0x117/0x310 drivers/net/ppp/pppoe.c:379 sk_backlog_rcv include/net/sock.h:1113 [inline] __release_sock+0x243/0x350 net/core/sock.c:3072 release_sock+0x61/0x1f0 net/core/sock.c:3626 pppoe_sendmsg+0xd5/0x750 drivers/net/ppp/pppoe.c:903 sock_sendmsg_nosec net/socket.c:729 [inline] __sock_sendmsg+0x221/0x270 net/socket.c:744 ____sys_sendmsg+0x52a/0x7e0 net/socket.c:2602 ___sys_sendmsg net/socket.c:2656 [inline] __sys_sendmmsg+0x3ab/0x730 net/socket.c:2742 __do_sys_sendmmsg net/socket.c:2771 [inline] __se_sys_sendmmsg net/socket.c:2768 [inline] __x64_sys_sendmmsg+0xa0/0xb0 net/socket.c:2768 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f INITIAL USE at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:356 [inline] ppp_unregister_channel+0x7c/0x300 drivers/net/ppp/ppp_generic.c:2992 pppox_unbind_sock+0x5c/0xb0 drivers/net/ppp/pppox.c:58 pppol2tp_release+0x99/0x230 net/l2tp/l2tp_ppp.c:436 __sock_release net/socket.c:658 [inline] sock_close+0xbc/0x240 net/socket.c:1426 __fput+0x23f/0x880 fs/file_table.c:431 task_work_run+0x24f/0x310 kernel/task_work.c:228 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] exit_to_user_mode_loop kernel/entry/common.c:114 [inline] exit_to_user_mode_prepare include/linux/entry-common.h:328 [inline] __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline] syscall_exit_to_user_mode+0x168/0x370 kernel/entry/common.c:218 do_syscall_64+0x100/0x230 arch/x86/entry/common.c:89 entry_SYSCALL_64_after_hwframe+0x77/0x7f } ... key at: [] ppp_register_net_channel.__key.1+0x0/0x20 ... acquired at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:356 [inline] ppp_connect_channel+0x194/0x650 drivers/net/ppp/ppp_generic.c:3485 ppp_ioctl+0xdd4/0x1cd0 drivers/net/ppp/ppp_generic.c:761 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> (&ppp->rlock){+...}-{2:2} { HARDIRQ-ON-W at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:356 [inline] ppp_get_stats64+0x33/0x290 drivers/net/ppp/ppp_generic.c:1534 dev_get_stats+0xad/0xa00 net/core/dev.c:10937 rtnl_fill_stats+0x47/0x880 net/core/rtnetlink.c:1268 rtnl_fill_ifinfo+0x18da/0x2270 net/core/rtnetlink.c:1909 rtmsg_ifinfo_build_skb+0x18a/0x260 net/core/rtnetlink.c:4079 rtmsg_ifinfo_event net/core/rtnetlink.c:4112 [inline] rtmsg_ifinfo+0x91/0x1b0 net/core/rtnetlink.c:4121 register_netdevice+0x1774/0x1b00 net/core/dev.c:10534 ppp_unit_register drivers/net/ppp/ppp_generic.c:1219 [inline] ppp_dev_configure+0x883/0xb10 drivers/net/ppp/ppp_generic.c:1275 ppp_create_interface drivers/net/ppp/ppp_generic.c:3348 [inline] ppp_unattached_ioctl drivers/net/ppp/ppp_generic.c:1060 [inline] ppp_ioctl+0x797/0x1cd0 drivers/net/ppp/ppp_generic.c:733 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f INITIAL USE at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:356 [inline] ppp_get_stats64+0x33/0x290 drivers/net/ppp/ppp_generic.c:1534 dev_get_stats+0xad/0xa00 net/core/dev.c:10937 rtnl_fill_stats+0x47/0x880 net/core/rtnetlink.c:1268 rtnl_fill_ifinfo+0x18da/0x2270 net/core/rtnetlink.c:1909 rtmsg_ifinfo_build_skb+0x18a/0x260 net/core/rtnetlink.c:4079 rtmsg_ifinfo_event net/core/rtnetlink.c:4112 [inline] rtmsg_ifinfo+0x91/0x1b0 net/core/rtnetlink.c:4121 register_netdevice+0x1774/0x1b00 net/core/dev.c:10534 ppp_unit_register drivers/net/ppp/ppp_generic.c:1219 [inline] ppp_dev_configure+0x883/0xb10 drivers/net/ppp/ppp_generic.c:1275 ppp_create_interface drivers/net/ppp/ppp_generic.c:3348 [inline] ppp_unattached_ioctl drivers/net/ppp/ppp_generic.c:1060 [inline] ppp_ioctl+0x797/0x1cd0 drivers/net/ppp/ppp_generic.c:733 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f } ... key at: [] ppp_dev_configure.__key+0x0/0x20 ... acquired at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:356 [inline] ppp_dev_uninit+0x6c/0x1a0 drivers/net/ppp/ppp_generic.c:1572 unregister_netdevice_many_notify+0x1735/0x1da0 net/core/dev.c:11421 unregister_netdevice_many net/core/dev.c:11461 [inline] unregister_netdevice_queue+0x303/0x370 net/core/dev.c:11335 unregister_netdevice include/linux/netdevice.h:3118 [inline] ppp_release+0xed/0x1f0 drivers/net/ppp/ppp_generic.c:410 __fput+0x23f/0x880 fs/file_table.c:431 task_work_run+0x24f/0x310 kernel/task_work.c:228 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] exit_to_user_mode_loop kernel/entry/common.c:114 [inline] exit_to_user_mode_prepare include/linux/entry-common.h:328 [inline] __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline] syscall_exit_to_user_mode+0x168/0x370 kernel/entry/common.c:218 do_syscall_64+0x100/0x230 arch/x86/entry/common.c:89 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> (&ppp->wlock){+...}-{2:2} { HARDIRQ-ON-W at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:356 [inline] ppp_get_stats64+0xc3/0x290 drivers/net/ppp/ppp_generic.c:1539 dev_get_stats+0xad/0xa00 net/core/dev.c:10937 rtnl_fill_stats+0x47/0x880 net/core/rtnetlink.c:1268 rtnl_fill_ifinfo+0x18da/0x2270 net/core/rtnetlink.c:1909 rtmsg_ifinfo_build_skb+0x18a/0x260 net/core/rtnetlink.c:4079 rtmsg_ifinfo_event net/core/rtnetlink.c:4112 [inline] rtmsg_ifinfo+0x91/0x1b0 net/core/rtnetlink.c:4121 register_netdevice+0x1774/0x1b00 net/core/dev.c:10534 ppp_unit_register drivers/net/ppp/ppp_generic.c:1219 [inline] ppp_dev_configure+0x883/0xb10 drivers/net/ppp/ppp_generic.c:1275 ppp_create_interface drivers/net/ppp/ppp_generic.c:3348 [inline] ppp_unattached_ioctl drivers/net/ppp/ppp_generic.c:1060 [inline] ppp_ioctl+0x797/0x1cd0 drivers/net/ppp/ppp_generic.c:733 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f INITIAL USE at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:356 [inline] ppp_get_stats64+0xc3/0x290 drivers/net/ppp/ppp_generic.c:1539 dev_get_stats+0xad/0xa00 net/core/dev.c:10937 rtnl_fill_stats+0x47/0x880 net/core/rtnetlink.c:1268 rtnl_fill_ifinfo+0x18da/0x2270 net/core/rtnetlink.c:1909 rtmsg_ifinfo_build_skb+0x18a/0x260 net/core/rtnetlink.c:4079 rtmsg_ifinfo_event net/core/rtnetlink.c:4112 [inline] rtmsg_ifinfo+0x91/0x1b0 net/core/rtnetlink.c:4121 register_netdevice+0x1774/0x1b00 net/core/dev.c:10534 ppp_unit_register drivers/net/ppp/ppp_generic.c:1219 [inline] ppp_dev_configure+0x883/0xb10 drivers/net/ppp/ppp_generic.c:1275 ppp_create_interface drivers/net/ppp/ppp_generic.c:3348 [inline] ppp_unattached_ioctl drivers/net/ppp/ppp_generic.c:1060 [inline] ppp_ioctl+0x797/0x1cd0 drivers/net/ppp/ppp_generic.c:733 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f } ... key at: [] ppp_dev_configure.__key.67+0x0/0x20 ... acquired at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:356 [inline] ppp_connect_channel+0x174/0x650 drivers/net/ppp/ppp_generic.c:3484 ppp_ioctl+0xdd4/0x1cd0 drivers/net/ppp/ppp_generic.c:761 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> (&pch->upl){+..-}-{2:2} { HARDIRQ-ON-W at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_write_lock_bh include/linux/rwlock_api_smp.h:202 [inline] _raw_write_lock_bh+0x35/0x50 kernel/locking/spinlock.c:334 ppp_bridge_channels+0x32/0x4c0 drivers/net/ppp/ppp_generic.c:643 ppp_ioctl+0xe8f/0x1cd0 drivers/net/ppp/ppp_generic.c:783 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f IN-SOFTIRQ-R at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_read_lock_bh include/linux/rwlock_api_smp.h:176 [inline] _raw_read_lock_bh+0x3d/0x50 kernel/locking/spinlock.c:252 ppp_input_error+0x60/0x1b0 drivers/net/ppp/ppp_generic.c:2344 ppp_sync_process+0x82/0x160 drivers/net/ppp/ppp_synctty.c:486 tasklet_action_common+0x321/0x4d0 kernel/softirq.c:784 handle_softirqs+0x2c5/0x980 kernel/softirq.c:554 run_ksoftirqd+0xca/0x130 kernel/softirq.c:927 smpboot_thread_fn+0x544/0xa30 kernel/smpboot.c:164 kthread+0x2f0/0x390 kernel/kthread.c:389 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 INITIAL USE at: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_write_lock_bh include/linux/rwlock_api_smp.h:202 [inline] _raw_write_lock_bh+0x35/0x50 kernel/locking/spinlock.c:334 ppp_bridge_channels+0x32/0x4c0 drivers/net/ppp/ppp_generic.c:643 ppp_ioctl+0xe8f/0x1cd0 drivers/net/ppp/ppp_generic.c:783 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:907 [inline] __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f } ... key at: [] ppp_register_net_channel.__key.3+0x0/0x20 ... acquired at: mark_lock+0x223/0x360 kernel/locking/lockdep.c:4725 __lock_acquire+0xbf9/0x2050 kernel/locking/lockdep.c:5156 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_read_lock_bh include/linux/rwlock_api_smp.h:176 [inline] _raw_read_lock_bh+0x3d/0x50 kernel/locking/spinlock.c:252 ppp_input_error+0x60/0x1b0 drivers/net/ppp/ppp_generic.c:2344 ppp_sync_process+0x82/0x160 drivers/net/ppp/ppp_synctty.c:486 tasklet_action_common+0x321/0x4d0 kernel/softirq.c:784 handle_softirqs+0x2c5/0x980 kernel/softirq.c:554 run_ksoftirqd+0xca/0x130 kernel/softirq.c:927 smpboot_thread_fn+0x544/0xa30 kernel/smpboot.c:164 kthread+0x2f0/0x390 kernel/kthread.c:389 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 stack backtrace: CPU: 1 UID: 0 PID: 24 Comm: ksoftirqd/1 Not tainted 6.11.0-syzkaller-12113-ge7ed34365879 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_irq_inversion_bug+0x33d/0x390 kernel/locking/lockdep.c:4121 mark_lock_irq+0x80c/0xc20 kernel/locking/lockdep.c:4290 mark_lock+0x223/0x360 kernel/locking/lockdep.c:4725 __lock_acquire+0xbf9/0x2050 kernel/locking/lockdep.c:5156 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 __raw_read_lock_bh include/linux/rwlock_api_smp.h:176 [inline] _raw_read_lock_bh+0x3d/0x50 kernel/locking/spinlock.c:252 ppp_input_error+0x60/0x1b0 drivers/net/ppp/ppp_generic.c:2344 ppp_sync_process+0x82/0x160 drivers/net/ppp/ppp_synctty.c:486 tasklet_action_common+0x321/0x4d0 kernel/softirq.c:784 handle_softirqs+0x2c5/0x980 kernel/softirq.c:554 run_ksoftirqd+0xca/0x130 kernel/softirq.c:927 smpboot_thread_fn+0x544/0xa30 kernel/smpboot.c:164 kthread+0x2f0/0x390 kernel/kthread.c:389 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244