audit: type=1804 audit(1677993737.959:58): pid=10756 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.3" name="/root/syzkaller-testdir1410560562/syzkaller.b0axEF/17/bus" dev="sda1" ino=14011 res=1 ====================================================== WARNING: possible circular locking dependency detected audit: type=1804 audit(1677993737.959:59): pid=10756 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.3" name="/root/syzkaller-testdir1410560562/syzkaller.b0axEF/17/bus" dev="sda1" ino=14011 res=1 4.19.211-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.4/10753 is trying to acquire lock: 00000000def79bd6 (&tree->tree_lock){+.+.}, at: hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595 but task is already holding lock: 000000009e5dd1ce (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_truncate+0x1e2/0x1040 fs/hfsplus/extents.c:576 audit: type=1804 audit(1677993737.959:60): pid=10756 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.3" name="/root/syzkaller-testdir1410560562/syzkaller.b0axEF/17/bus" dev="sda1" ino=14011 res=1 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}: hfsplus_get_block+0x292/0x960 fs/hfsplus/extents.c:260 block_read_full_page+0x288/0xd10 fs/buffer.c:2259 do_read_cache_page+0x533/0x1170 mm/filemap.c:2828 audit: type=1804 audit(1677993737.959:61): pid=10756 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.3" name="/root/syzkaller-testdir1410560562/syzkaller.b0axEF/17/bus" dev="sda1" ino=14011 res=1 read_mapping_page include/linux/pagemap.h:402 [inline] __hfs_bnode_create+0x5b7/0xb60 fs/hfsplus/bnode.c:447 hfsplus_bnode_find+0x2aa/0xb80 fs/hfsplus/bnode.c:497 hfsplus_brec_find+0x2af/0x500 fs/hfsplus/bfind.c:183 hfsplus_brec_read+0x28/0x120 fs/hfsplus/bfind.c:222 hfsplus_find_cat+0x1d0/0x480 fs/hfsplus/catalog.c:202 hfsplus_iget+0x400/0x790 fs/hfsplus/super.c:81 hfsplus_fill_super+0xc5f/0x19e0 fs/hfsplus/super.c:503 audit: type=1804 audit(1677993737.959:62): pid=10754 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=ToMToU comm="syz-executor.3" name="/root/syzkaller-testdir1410560562/syzkaller.b0axEF/17/bus" dev="sda1" ino=14011 res=1 mount_bdev+0x2fc/0x3b0 fs/super.c:1158 mount_fs+0xa3/0x310 fs/super.c:1261 vfs_kern_mount.part.0+0x68/0x470 fs/namespace.c:961 vfs_kern_mount fs/namespace.c:951 [inline] do_new_mount fs/namespace.c:2492 [inline] do_mount+0x115c/0x2f50 fs/namespace.c:2822 ksys_mount+0xcf/0x130 fs/namespace.c:3038 __do_sys_mount fs/namespace.c:3052 [inline] __se_sys_mount fs/namespace.c:3049 [inline] __x64_sys_mount+0xba/0x150 fs/namespace.c:3049 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #0 (&tree->tree_lock){+.+.}: __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595 hfsplus_setattr+0x1e7/0x310 fs/hfsplus/inode.c:263 notify_change+0x70b/0xfc0 fs/attr.c:334 do_truncate+0x134/0x1f0 fs/open.c:63 handle_truncate fs/namei.c:3009 [inline] do_last fs/namei.c:3427 [inline] path_openat+0x2308/0x2df0 fs/namei.c:3537 do_filp_open+0x18c/0x3f0 fs/namei.c:3567 do_sys_open+0x3b3/0x520 fs/open.c:1085 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock); *** DEADLOCK *** 3 locks held by syz-executor.4/10753: #0: 00000000dd319087 (sb_writers#19){.+.+}, at: sb_start_write include/linux/fs.h:1579 [inline] #0: 00000000dd319087 (sb_writers#19){.+.+}, at: mnt_want_write+0x3a/0xb0 fs/namespace.c:360 #1: 00000000edd9d8ea (&sb->s_type->i_mutex_key#27){+.+.}, at: inode_lock include/linux/fs.h:748 [inline] #1: 00000000edd9d8ea (&sb->s_type->i_mutex_key#27){+.+.}, at: do_truncate+0x125/0x1f0 fs/open.c:61 #2: 000000009e5dd1ce (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_truncate+0x1e2/0x1040 fs/hfsplus/extents.c:576 stack backtrace: CPU: 0 PID: 10753 Comm: syz-executor.4 Not tainted 4.19.211-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1fc/0x2ef lib/dump_stack.c:118 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222 check_prev_add kernel/locking/lockdep.c:1866 [inline] check_prevs_add kernel/locking/lockdep.c:1979 [inline] validate_chain kernel/locking/lockdep.c:2420 [inline] __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908 __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595 hfsplus_setattr+0x1e7/0x310 fs/hfsplus/inode.c:263 notify_change+0x70b/0xfc0 fs/attr.c:334 do_truncate+0x134/0x1f0 fs/open.c:63 handle_truncate fs/namei.c:3009 [inline] do_last fs/namei.c:3427 [inline] path_openat+0x2308/0x2df0 fs/namei.c:3537 do_filp_open+0x18c/0x3f0 fs/namei.c:3567 do_sys_open+0x3b3/0x520 fs/open.c:1085 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7f0a672800f9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f0a657f2168 EFLAGS: 00000246 ORIG_RAX: 0000000000000002 RAX: ffffffffffffffda RBX: 00007f0a6739ff80 RCX: 00007f0a672800f9 RDX: 0000000000000000 RSI: 0000000000143242 RDI: 0000000020000000 RBP: 00007f0a672dbae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffccf008c9f R14: 00007f0a657f2300 R15: 0000000000022000 EXT4-fs (loop0): Invalid journal IO priority (must be 0-7) netlink: 4 bytes leftover after parsing attributes in process `syz-executor.1'. EXT4-fs (loop0): Invalid journal IO priority (must be 0-7) netlink: 4 bytes leftover after parsing attributes in process `syz-executor.3'. xt_connbytes: Forcing CT accounting to be enabled EXT4-fs (loop0): Invalid journal IO priority (must be 0-7) xt_connbytes: Forcing CT accounting to be enabled xt_connbytes: Forcing CT accounting to be enabled EXT4-fs (loop0): orphan cleanup on readonly fs EXT4-fs (loop0): 1 truncate cleaned up EXT4-fs (loop0): mounted filesystem without journal. Opts: nobarrier,noblock_validity,nolazytime,barrier=0x000000007fff0038,data_err=abort,resgid=0x0000000000000000,resuid=0x0000000000000000,resgid=0x000000000000ee01,resgid=0x000000000000ee002,errors=continue EXT4-fs (loop0): orphan cleanup on readonly fs EXT4-fs (loop0): 1 truncate cleaned up EXT4-fs (loop0): mounted filesystem without journal. Opts: nobarrier,noblock_validity,nolazytime,barrier=0x000000007fff0038,data_err=abort,resgid=0x0000000000000000,resuid=0x0000000000000000,resgid=0x000000000000ee01,resgid=0x000000000000ee002,errors=continue BTRFS: device fsid 24c7a497-3402-47dd-bef8-82358f5f30e0 devid 1 transid 8 /dev/loop1 BTRFS info (device loop1): enabling inode map caching BTRFS info (device loop1): force clearing of disk cache BTRFS info (device loop1): disabling free space tree BTRFS info (device loop1): has skinny extents EXT4-fs (loop0): orphan cleanup on readonly fs EXT4-fs (loop0): 1 truncate cleaned up EXT4-fs (loop0): mounted filesystem without journal. Opts: nobarrier,noblock_validity,nolazytime,barrier=0x000000007fff0038,data_err=abort,resgid=0x0000000000000000,resuid=0x0000000000000000,resgid=0x000000000000ee01,resgid=0x000000000000ee002,errors=continue BTRFS info (device loop1): clearing free space tree BTRFS info (device loop1): clearing 1 ro feature flag BTRFS info (device loop1): clearing 2 ro feature flag BTRFS info (device loop4): enabling inode map caching BTRFS info (device loop4): force clearing of disk cache BTRFS info (device loop4): disabling free space tree BTRFS info (device loop4): has skinny extents BTRFS info (device loop4): clearing free space tree BTRFS info (device loop4): clearing 1 ro feature flag BTRFS info (device loop4): clearing 2 ro feature flag BTRFS warning (device ): duplicate device /dev/loop1 devid 1 generation 8 scanned by syz-executor.1 (11079) BTRFS warning (device ): duplicate device /dev/loop1 devid 1 generation 8 scanned by systemd-udevd (11116) BTRFS warning (device ): duplicate device /dev/loop3 devid 1 generation 8 scanned by syz-executor.3 (11087) BTRFS warning (device ): duplicate device /dev/loop3 devid 1 generation 8 scanned by systemd-udevd (11124) BTRFS info (device loop1): enabling inode map caching BTRFS info (device loop1): force clearing of disk cache BTRFS info (device loop1): disabling free space tree BTRFS info (device loop1): has skinny extents BTRFS info (device loop1): clearing free space tree BTRFS info (device loop1): clearing 1 ro feature flag BTRFS info (device loop1): clearing 2 ro feature flag BTRFS info (device loop4): enabling inode map caching BTRFS info (device loop4): force clearing of disk cache BTRFS info (device loop4): disabling free space tree BTRFS info (device loop4): has skinny extents BTRFS info (device loop4): clearing free space tree BTRFS info (device loop4): clearing 1 ro feature flag BTRFS warning (device ): duplicate device /dev/loop3 devid 1 generation 8 scanned by syz-executor.3 (11172) BTRFS info (device loop4): clearing 2 ro feature flag netlink: 8 bytes leftover after parsing attributes in process `syz-executor.1'. netlink: 8 bytes leftover after parsing attributes in process `syz-executor.1'. netlink: 8 bytes leftover after parsing attributes in process `syz-executor.1'. netlink: 8 bytes leftover after parsing attributes in process `syz-executor.1'. netlink: 8 bytes leftover after parsing attributes in process `syz-executor.1'. netlink: 8 bytes leftover after parsing attributes in process `syz-executor.1'. BTRFS info (device loop3): enabling inode map caching BTRFS info (device loop3): force clearing of disk cache BTRFS info (device loop3): disabling free space tree UDF-fs: INFO Mounting volume 'LinuxUDF', timestamp 2022/11/22 14:59 (1000) BTRFS info (device loop3): has skinny extents BTRFS warning (device ): duplicate device /dev/loop4 devid 1 generation 8 scanned by syz-executor.4 (11259) dccp_close: ABORT with 103 bytes unread BTRFS warning (device ): duplicate device /dev/loop4 devid 1 generation 8 scanned by systemd-udevd (11298) BTRFS info (device loop3): clearing free space tree BTRFS info (device loop3): clearing 1 ro feature flag BTRFS info (device loop3): clearing 2 ro feature flag BTRFS info (device loop4): enabling inode map caching BTRFS info (device loop4): force clearing of disk cache BTRFS info (device loop4): disabling free space tree BTRFS info (device loop4): has skinny extents BTRFS info (device loop4): clearing free space tree BTRFS info (device loop4): clearing 1 ro feature flag BTRFS info (device loop4): clearing 2 ro feature flag UDF-fs: INFO Mounting volume 'LinuxUDF', timestamp 2022/11/22 14:59 (1000) BTRFS info (device loop4): enabling inode map caching BTRFS info (device loop4): force clearing of disk cache BTRFS info (device loop4): disabling free space tree dccp_close: ABORT with 103 bytes unread BTRFS info (device loop4): has skinny extents BTRFS warning (device ): duplicate device /dev/loop3 devid 1 generation 8 scanned by syz-executor.3 (11485) BTRFS warning (device ): duplicate device /dev/loop3 devid 1 generation 8 scanned by systemd-udevd (11506) BTRFS info (device loop4): clearing free space tree BTRFS info (device loop4): clearing 1 ro feature flag BTRFS info (device loop4): clearing 2 ro feature flag ieee802154 phy0 wpan0: encryption failed: -22 ieee802154 phy1 wpan1: encryption failed: -22 UDF-fs: INFO Mounting volume 'LinuxUDF', timestamp 2022/11/22 14:59 (1000) BTRFS info (device loop3): enabling inode map caching BTRFS info (device loop3): force clearing of disk cache BTRFS info (device loop3): disabling free space tree BTRFS info (device loop3): has skinny extents BTRFS warning (device ): duplicate device /dev/loop4 devid 1 generation 8 scanned by syz-executor.4 (11541) BTRFS warning (device ): duplicate device /dev/loop4 devid 1 generation 8 scanned by systemd-udevd (11576) BTRFS info (device loop3): clearing free space tree BTRFS info (device loop3): clearing 1 ro feature flag BTRFS info (device loop3): clearing 2 ro feature flag BTRFS info (device loop4): enabling inode map caching BTRFS info (device loop4): force clearing of disk cache BTRFS info (device loop4): disabling free space tree BTRFS info (device loop4): has skinny extents BTRFS info (device loop4): clearing free space tree BTRFS info (device loop4): clearing 1 ro feature flag BTRFS info (device loop4): clearing 2 ro feature flag BTRFS warning (device ): duplicate device /dev/loop3 devid 1 generation 8 scanned by syz-executor.3 (11630) BTRFS info (device loop4): enabling inode map caching BTRFS info (device loop4): force clearing of disk cache BTRFS info (device loop4): disabling free space tree BTRFS info (device loop4): has skinny extents BTRFS warning (device ): duplicate device /dev/loop1 devid 1 generation 8 scanned by syz-executor.1 (11702) BTRFS warning (device ): duplicate device /dev/loop1 devid 1 generation 8 scanned by systemd-udevd (11742) BTRFS info (device loop4): clearing free space tree BTRFS info (device loop4): clearing 1 ro feature flag BTRFS warning (device ): duplicate device /dev/loop3 devid 1 generation 8 scanned by syz-executor.3 (11720) BTRFS info (device loop4): clearing 2 ro feature flag BTRFS warning (device ): duplicate device /dev/loop3 devid 1 generation 8 scanned by systemd-udevd (11768) BTRFS info (device loop1): enabling inode map caching BTRFS info (device loop1): force clearing of disk cache BTRFS info (device loop1): disabling free space tree BTRFS info (device loop1): has skinny extents BTRFS info (device loop1): clearing free space tree BTRFS info (device loop1): clearing 1 ro feature flag BTRFS warning (device ): duplicate device /dev/loop3 devid 1 generation 8 scanned by syz-executor.3 (11781) BTRFS info (device loop1): clearing 2 ro feature flag BTRFS warning (device ): duplicate device /dev/loop4 devid 1 generation 8 scanned by syz-executor.4 (11795) BTRFS warning (device ): duplicate device /dev/loop3 devid 1 generation 8 scanned by systemd-udevd (11838) BTRFS warning (device ): duplicate device /dev/loop4 devid 1 generation 8 scanned by systemd-udevd (11842) BTRFS info (device loop0): enabling inode map caching BTRFS info (device loop0): force clearing of disk cache BTRFS info (device loop0): disabling free space tree BTRFS info (device loop0): has skinny extents BTRFS warning (device ): duplicate device /dev/loop3 devid 1 generation 8 scanned by syz-executor.3 (11853) BTRFS warning (device ): duplicate device /dev/loop1 devid 1 generation 8 scanned by syz-executor.1 (11863) BTRFS warning (device ): duplicate device /dev/loop3 devid 1 generation 8 scanned by systemd-udevd (11900) BTRFS warning (device ): duplicate device /dev/loop4 devid 1 generation 8 scanned by syz-executor.4 (11852)