vivid-007: Boolean: ====================================================== WARNING: possible circular locking dependency detected 6.9.0-rc5-syzkaller-00007-g4d2008430ce8 #0 Not tainted ------------------------------------------------------ syz-executor124/5078 is trying to acquire lock: ffff8880271406e0 (vivid_ctrls:1606:(hdl_user_gen)->_lock){+.+.}-{3:3}, at: v4l2_ctrl_lock include/media/v4l2-ctrls.h:572 [inline] ffff8880271406e0 (vivid_ctrls:1606:(hdl_user_gen)->_lock){+.+.}-{3:3}, at: log_ctrl drivers/media/v4l2-core/v4l2-ctrls-core.c:2519 [inline] ffff8880271406e0 (vivid_ctrls:1606:(hdl_user_gen)->_lock){+.+.}-{3:3}, at: v4l2_ctrl_handler_log_status+0x274/0x600 drivers/media/v4l2-core/v4l2-ctrls-core.c:2557 but task is already holding lock: ffff888027144a30 (vivid_ctrls:1636:(hdl_meta_cap)->_lock){+.+.}-{3:3}, at: v4l2_ctrl_handler_log_status+0xb7/0x600 drivers/media/v4l2-core/v4l2-ctrls-core.c:2552 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (vivid_ctrls:1636:(hdl_meta_cap)->_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 find_ref_lock drivers/media/v4l2-core/v4l2-ctrls-core.c:1648 [inline] handler_new_ref+0x7c4/0xc60 drivers/media/v4l2-core/v4l2-ctrls-core.c:1685 v4l2_ctrl_add_handler drivers/media/v4l2-core/v4l2-ctrls-core.c:2209 [inline] v4l2_ctrl_add_handler+0x22a/0x310 drivers/media/v4l2-core/v4l2-ctrls-core.c:2183 vivid_create_controls+0x2f6a/0x3910 drivers/media/test-drivers/vivid/vivid-ctrls.c:1988 vivid_create_instance drivers/media/test-drivers/vivid/vivid-core.c:1854 [inline] vivid_probe drivers/media/test-drivers/vivid/vivid-core.c:2018 [inline] vivid_probe+0x3c9a/0x9fe0 drivers/media/test-drivers/vivid/vivid-core.c:2003 platform_probe+0xff/0x1f0 drivers/base/platform.c:1404 call_driver_probe drivers/base/dd.c:578 [inline] really_probe+0x23e/0xa90 drivers/base/dd.c:656 __driver_probe_device+0x1de/0x440 drivers/base/dd.c:798 driver_probe_device+0x4c/0x1b0 drivers/base/dd.c:828 __driver_attach+0x283/0x580 drivers/base/dd.c:1214 bus_for_each_dev+0x13c/0x1d0 drivers/base/bus.c:368 bus_add_driver+0x2ed/0x640 drivers/base/bus.c:673 driver_register+0x15c/0x4b0 drivers/base/driver.c:246 vivid_init+0x45/0x80 drivers/media/test-drivers/vivid/vivid-core.c:2145 do_one_initcall+0x128/0x700 init/main.c:1245 do_initcall_level init/main.c:1307 [inline] do_initcalls init/main.c:1323 [inline] do_basic_setup init/main.c:1342 [inline] kernel_init_freeable+0x69d/0xca0 init/main.c:1555 kernel_init+0x1c/0x2b0 init/main.c:1444 ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 -> #0 (vivid_ctrls:1606:(hdl_user_gen)->_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2478/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 v4l2_ctrl_lock include/media/v4l2-ctrls.h:572 [inline] log_ctrl drivers/media/v4l2-core/v4l2-ctrls-core.c:2519 [inline] v4l2_ctrl_handler_log_status+0x274/0x600 drivers/media/v4l2-core/v4l2-ctrls-core.c:2557 v4l2_ctrl_log_status+0xef/0x130 drivers/media/v4l2-core/v4l2-ctrls-api.c:1206 vidioc_log_status+0x60/0xe0 drivers/media/test-drivers/vivid/vivid-core.c:426 v4l_log_status+0x9e/0x120 drivers/media/v4l2-core/v4l2-ioctl.c:2562 __video_do_ioctl+0xaf9/0xf00 drivers/media/v4l2-core/v4l2-ioctl.c:3049 video_usercopy+0x4c2/0x1660 drivers/media/v4l2-core/v4l2-ioctl.c:3390 v4l2_ioctl+0x1c0/0x260 drivers/media/v4l2-core/v4l2-dev.c:364 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:904 [inline] __se_sys_ioctl fs/ioctl.c:890 [inline] __x64_sys_ioctl+0x193/0x220 fs/ioctl.c:890 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x260 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(vivid_ctrls:1636:(hdl_meta_cap)->_lock); lock(vivid_ctrls:1606:(hdl_user_gen)->_lock); lock(vivid_ctrls:1636:(hdl_meta_cap)->_lock); lock(vivid_ctrls:1606:(hdl_user_gen)->_lock); *** DEADLOCK *** 2 locks held by syz-executor124/5078: #0: ffff888027145aa8 (&dev->mutex#3){+.+.}-{3:3}, at: __video_do_ioctl+0x4a8/0xf00 drivers/media/v4l2-core/v4l2-ioctl.c:3017 #1: ffff888027144a30 (vivid_ctrls:1636:(hdl_meta_cap)->_lock){+.+.}-{3:3}, at: v4l2_ctrl_handler_log_status+0xb7/0x600 drivers/media/v4l2-core/v4l2-ctrls-core.c:2552 stack backtrace: CPU: 1 PID: 5078 Comm: syz-executor124 Not tainted 6.9.0-rc5-syzkaller-00007-g4d2008430ce8 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:114 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2478/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 v4l2_ctrl_lock include/media/v4l2-ctrls.h:572 [inline] log_ctrl drivers/media/v4l2-core/v4l2-ctrls-core.c:2519 [inline] v4l2_ctrl_handler_log_status+0x274/0x600 drivers/media/v4l2-core/v4l2-ctrls-core.c:2557 v4l2_ctrl_log_status+0xef/0x130 drivers/media/v4l2-core/v4l2-ctrls-api.c:1206 vidioc_log_status+0x60/0xe0 drivers/media/test-drivers/vivid/vivid-core.c:426 v4l_log_status+0x9e/0x120 drivers/media/v4l2-core/v4l2-ioctl.c:2562 __video_do_ioctl+0xaf9/0xf00 drivers/media/v4l2-core/v4l2-ioctl.c:3049 video_usercopy+0x4c2/0x1660 drivers/media/v4l2-core/v4l2-ioctl.c:3390 v4l2_ioctl+0x1c0/0x260 drivers/media/v4l2-core/v4l2-dev.c:364 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:904 [inline] __se_sys_ioctl fs/ioctl.c:890 [inline] __x64_sys_ioctl+0x193/0x220 fs/ioctl.c:890 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x260 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f0fb33a32a9 Code: 48 83 c4 28 c3 e8 37 17 00 00 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fff702f2328 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007fff702f24f8 RCX: 00007f0fb33a32a9 RDX: 0000000000000000 RSI: 0000000000005646 RDI: 0000000000000003 RBP: 00007f0fb3416610 R08: 0000000000000000 R09: 00007fff702f24f8 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001 R13: 00007fff702f24e8 R14: 0000000000000001 R15: 0000000000000001 true vivid-007: Integer 32 Bits: 0 vivid-007: Integer 64 Bits: 0 vivid-007: Menu: Menu Item 3 vivid-007: String: vivid-007: Bitmask: 0x80002000 vivid-007: Integer Menu: 5 vivid-007: U32 1 Element Array: [1] 24 vivid-007: U16 8x16 Matrix: [8][16] 24 vivid-007: U8 2x3x4x5 Array: [2][3][4][5] 24 vivid-007: Area: unknown type 262 vivid-007: Read-Only Integer 32 Bits: 0 vivid-007: U32 Dynamic Array: [100] 50 vivid-007: U8 Pixel Array: [640][368] 128 vivid-007: S32 2 Element Array: [2] 2 vivid-007: S64 5 Element Array: [5] 4 vivid-007: Wrap Sequence Number: false vivid-007: Wrap Timestamp: None vivid-007: Percentage of Dropped Buffers: 0 vivid-007: Generate PTS: true vivid-007: Generate SCR: true tpg source WxH: 640x3