====================================================== WARNING: possible circular locking dependency detected 5.16.0-rc1-next-20211118-syzkaller #0 Not tainted ------------------------------------------------------ usb-storage/20504 is trying to acquire lock: ffff88801d759168 (hcd->address0_mutex){+.+.}-{3:3}, at: usb_reset_and_verify_device+0x3ee/0xee0 drivers/usb/core/hub.c:5923 but task is already holding lock: ffff88801d7e35c0 (&port_dev->status_lock){+.+.}-{3:3}, at: usb_lock_port drivers/usb/core/hub.c:3086 [inline] ffff88801d7e35c0 (&port_dev->status_lock){+.+.}-{3:3}, at: usb_reset_device+0x4b4/0x9a0 drivers/usb/core/hub.c:6107 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&port_dev->status_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:607 [inline] __mutex_lock+0x12f/0x12f0 kernel/locking/mutex.c:740 usb_lock_port drivers/usb/core/hub.c:3086 [inline] hub_port_connect drivers/usb/core/hub.c:5279 [inline] hub_port_connect_change drivers/usb/core/hub.c:5493 [inline] port_event drivers/usb/core/hub.c:5639 [inline] hub_event+0x21c1/0x4450 drivers/usb/core/hub.c:5721 process_one_work+0x9b2/0x1690 kernel/workqueue.c:2298 worker_thread+0x658/0x11f0 kernel/workqueue.c:2445 kthread+0x405/0x4f0 kernel/kthread.c:327 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 -> #0 (hcd->address0_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3063 [inline] check_prevs_add kernel/locking/lockdep.c:3186 [inline] validate_chain kernel/locking/lockdep.c:3801 [inline] __lock_acquire+0x2a07/0x54a0 kernel/locking/lockdep.c:5027 lock_acquire kernel/locking/lockdep.c:5637 [inline] lock_acquire+0x1ab/0x510 kernel/locking/lockdep.c:5602 __mutex_lock_common kernel/locking/mutex.c:607 [inline] __mutex_lock+0x12f/0x12f0 kernel/locking/mutex.c:740 usb_reset_and_verify_device+0x3ee/0xee0 drivers/usb/core/hub.c:5923 usb_reset_device+0x4bd/0x9a0 drivers/usb/core/hub.c:6108 usb_stor_port_reset drivers/usb/storage/transport.c:1443 [inline] usb_stor_port_reset+0x19a/0x1f0 drivers/usb/storage/transport.c:1425 usb_stor_invoke_transport+0x6ac/0x16e0 drivers/usb/storage/transport.c:919 usb_stor_control_thread+0x5e5/0xaa0 drivers/usb/storage/usb.c:380 kthread+0x405/0x4f0 kernel/kthread.c:327 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&port_dev->status_lock); lock(hcd->address0_mutex); lock(&port_dev->status_lock); lock(hcd->address0_mutex); *** DEADLOCK *** 3 locks held by usb-storage/20504: #0: ffff88815e5eb220 (&dev->mutex){....}-{3:3}, at: device_trylock include/linux/device.h:770 [inline] #0: ffff88815e5eb220 (&dev->mutex){....}-{3:3}, at: usb_lock_device_for_reset+0x13e/0x2d0 drivers/usb/core/usb.c:872 #1: ffff88807dba8e60 (&us_interface_key[i]){+.+.}-{3:3}, at: usb_stor_pre_reset+0x35/0x40 drivers/usb/storage/usb.c:230 #2: ffff88801d7e35c0 (&port_dev->status_lock){+.+.}-{3:3}, at: usb_lock_port drivers/usb/core/hub.c:3086 [inline] #2: ffff88801d7e35c0 (&port_dev->status_lock){+.+.}-{3:3}, at: usb_reset_device+0x4b4/0x9a0 drivers/usb/core/hub.c:6107 stack backtrace: CPU: 1 PID: 20504 Comm: usb-storage Not tainted 5.16.0-rc1-next-20211118-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2143 check_prev_add kernel/locking/lockdep.c:3063 [inline] check_prevs_add kernel/locking/lockdep.c:3186 [inline] validate_chain kernel/locking/lockdep.c:3801 [inline] __lock_acquire+0x2a07/0x54a0 kernel/locking/lockdep.c:5027 lock_acquire kernel/locking/lockdep.c:5637 [inline] lock_acquire+0x1ab/0x510 kernel/locking/lockdep.c:5602 __mutex_lock_common kernel/locking/mutex.c:607 [inline] __mutex_lock+0x12f/0x12f0 kernel/locking/mutex.c:740 usb_reset_and_verify_device+0x3ee/0xee0 drivers/usb/core/hub.c:5923 usb_reset_device+0x4bd/0x9a0 drivers/usb/core/hub.c:6108 usb_stor_port_reset drivers/usb/storage/transport.c:1443 [inline] usb_stor_port_reset+0x19a/0x1f0 drivers/usb/storage/transport.c:1425 usb_stor_invoke_transport+0x6ac/0x16e0 drivers/usb/storage/transport.c:919 usb_stor_control_thread+0x5e5/0xaa0 drivers/usb/storage/usb.c:380 kthread+0x405/0x4f0 kernel/kthread.c:327 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 usb 2-1: reset high-speed USB device number 86 using dummy_hcd usb 2-1: Using ep0 maxpacket: 16 usb 2-1: device descriptor read/all, error -71 usb 2-1: reset high-speed USB device number 86 using dummy_hcd usb 2-1: Using ep0 maxpacket: 32 usb 2-1: device firmware changed