====================================================== WARNING: possible circular locking dependency detected 5.15.159-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.0/7669 is trying to acquire lock: ffff88805691cbc0 (&sb->s_type->i_mutex_key#38){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] ffff88805691cbc0 (&sb->s_type->i_mutex_key#38){+.+.}-{3:3}, at: vfs_rename+0x814/0x10f0 fs/namei.c:4797 but task is already holding lock: ffff88805e354520 (&type->i_mutex_dir_key#20/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] ffff88805e354520 (&type->i_mutex_dir_key#20/2){+.+.}-{3:3}, at: vfs_rename+0x7a2/0x10f0 fs/namei.c:4795 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&type->i_mutex_dir_key#20/2){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667 inode_lock_nested include/linux/fs.h:824 [inline] xattr_rmdir fs/reiserfs/xattr.c:106 [inline] delete_one_xattr+0x102/0x2f0 fs/reiserfs/xattr.c:338 reiserfs_for_each_xattr+0x9b2/0xb40 fs/reiserfs/xattr.c:311 reiserfs_delete_xattrs+0x1b/0x80 fs/reiserfs/xattr.c:364 reiserfs_evict_inode+0x20c/0x460 fs/reiserfs/inode.c:53 evict+0x2a4/0x620 fs/inode.c:587 d_delete_notify include/linux/fsnotify.h:261 [inline] vfs_rmdir+0x33c/0x460 fs/namei.c:4162 do_rmdir+0x368/0x670 fs/namei.c:4210 __do_sys_unlinkat fs/namei.c:4390 [inline] __se_sys_unlinkat fs/namei.c:4384 [inline] __x64_sys_unlinkat+0xdc/0xf0 fs/namei.c:4384 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (&type->i_mutex_dir_key#20/3){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667 inode_lock_nested include/linux/fs.h:824 [inline] open_xa_root fs/reiserfs/xattr.c:127 [inline] open_xa_dir+0x132/0x610 fs/reiserfs/xattr.c:152 xattr_lookup+0x24/0x280 fs/reiserfs/xattr.c:395 reiserfs_xattr_get+0xf7/0x9d0 fs/reiserfs/xattr.c:684 __vfs_getxattr+0x3e0/0x410 fs/xattr.c:401 cap_inode_need_killpriv+0x41/0x60 security/commoncap.c:301 security_inode_need_killpriv+0x5d/0x90 security/security.c:1423 dentry_needs_remove_privs fs/inode.c:1925 [inline] file_remove_privs+0x243/0x610 fs/inode.c:1966 __generic_file_write_iter+0x166/0x4f0 mm/filemap.c:3858 generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3944 call_write_iter include/linux/fs.h:2172 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0xacf/0xe50 fs/read_write.c:594 ksys_pwrite64 fs/read_write.c:701 [inline] __do_sys_pwrite64 fs/read_write.c:711 [inline] __se_sys_pwrite64 fs/read_write.c:708 [inline] __x64_sys_pwrite64+0x1a9/0x230 fs/read_write.c:708 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&sb->s_type->i_mutex_key#38){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:789 [inline] vfs_rename+0x814/0x10f0 fs/namei.c:4797 do_renameat2+0xe0f/0x1700 fs/namei.c:4985 __do_sys_renameat2 fs/namei.c:5018 [inline] __se_sys_renameat2 fs/namei.c:5015 [inline] __x64_sys_renameat2+0xce/0xe0 fs/namei.c:5015 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: &sb->s_type->i_mutex_key#38 --> &type->i_mutex_dir_key#20/3 --> &type->i_mutex_dir_key#20/2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&type->i_mutex_dir_key#20/2); lock(&type->i_mutex_dir_key#20/3); lock(&type->i_mutex_dir_key#20/2); lock(&sb->s_type->i_mutex_key#38); *** DEADLOCK *** 5 locks held by syz-executor.0/7669: #0: ffff88801f068460 (sb_writers#31){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377 #1: ffff88801f068748 (&type->s_vfs_rename_key#3){+.+.}-{3:3}, at: lock_rename fs/namei.c:3016 [inline] #1: ffff88801f068748 (&type->s_vfs_rename_key#3){+.+.}-{3:3}, at: do_renameat2+0x5b7/0x1700 fs/namei.c:4924 #2: ffff88805e3537e0 (&type->i_mutex_dir_key#20/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3017 [inline] #2: ffff88805e3537e0 (&type->i_mutex_dir_key#20/1){+.+.}-{3:3}, at: do_renameat2+0x644/0x1700 fs/namei.c:4924 #3: ffff88805691be80 (&type->i_mutex_dir_key#20/5){+.+.}-{3:3}, at: do_renameat2+0x67e/0x1700 fs/namei.c:4924 #4: ffff88805e354520 (&type->i_mutex_dir_key#20/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] #4: ffff88805e354520 (&type->i_mutex_dir_key#20/2){+.+.}-{3:3}, at: vfs_rename+0x7a2/0x10f0 fs/namei.c:4795 stack backtrace: CPU: 0 PID: 7669 Comm: syz-executor.0 Not tainted 5.15.159-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:789 [inline] vfs_rename+0x814/0x10f0 fs/namei.c:4797 do_renameat2+0xe0f/0x1700 fs/namei.c:4985 __do_sys_renameat2 fs/namei.c:5018 [inline] __se_sys_renameat2 fs/namei.c:5015 [inline] __x64_sys_renameat2+0xce/0xe0 fs/namei.c:5015 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7f2c575c9ee9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f2c55b3d0c8 EFLAGS: 00000246 ORIG_RAX: 000000000000013c RAX: ffffffffffffffda RBX: 00007f2c576f8f80 RCX: 00007f2c575c9ee9 RDX: 0000000000000009 RSI: 0000000020000100 RDI: 0000000000000005 RBP: 00007f2c5761649e R08: 0000000000000002 R09: 0000000000000000 R10: 0000000020000580 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f2c576f8f80 R15: 00007ffc49d2b8c8