====================================================== WARNING: possible circular locking dependency detected 5.2.0-next-20190708 #33 Not tainted ------------------------------------------------------ syz-executor795/9141 is trying to acquire lock: 000000002b57d3ab (&rp->fetch_lock){+.+.}, at: mon_bin_vma_fault+0x73/0x2d0 drivers/usb/mon/mon_bin.c:1237 but task is already holding lock: 0000000098497b51 (&mm->mmap_sem#2){++++}, at: __mm_populate+0x270/0x380 mm/gup.c:1258 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&mm->mmap_sem#2){++++}: __might_fault mm/memory.c:4517 [inline] __might_fault+0x15e/0x1e0 mm/memory.c:4502 _copy_to_user+0x30/0x160 lib/usercopy.c:25 copy_to_user include/linux/uaccess.h:152 [inline] mon_bin_read+0x329/0x640 drivers/usb/mon/mon_bin.c:825 do_loop_readv_writev fs/read_write.c:714 [inline] do_loop_readv_writev fs/read_write.c:701 [inline] do_iter_read+0x4a4/0x660 fs/read_write.c:935 vfs_readv+0xf0/0x160 fs/read_write.c:997 do_preadv+0x1c4/0x280 fs/read_write.c:1089 __do_sys_preadv fs/read_write.c:1139 [inline] __se_sys_preadv fs/read_write.c:1134 [inline] __x64_sys_preadv+0x9a/0xf0 fs/read_write.c:1134 do_syscall_64+0xfd/0x6a0 arch/x86/entry/common.c:296 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #0 (&rp->fetch_lock){+.+.}: check_prev_add kernel/locking/lockdep.c:2405 [inline] check_prevs_add kernel/locking/lockdep.c:2507 [inline] validate_chain kernel/locking/lockdep.c:2897 [inline] __lock_acquire+0x25a9/0x4c30 kernel/locking/lockdep.c:3880 lock_acquire+0x190/0x410 kernel/locking/lockdep.c:4413 __mutex_lock_common kernel/locking/mutex.c:926 [inline] __mutex_lock+0xf7/0x1340 kernel/locking/mutex.c:1073 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:1088 mon_bin_vma_fault+0x73/0x2d0 drivers/usb/mon/mon_bin.c:1237 __do_fault+0x111/0x540 mm/memory.c:3158 do_cow_fault mm/memory.c:3584 [inline] do_fault mm/memory.c:3687 [inline] handle_pte_fault mm/memory.c:3916 [inline] __handle_mm_fault+0xd41/0x3f20 mm/memory.c:4040 handle_mm_fault+0x1b5/0x6b0 mm/memory.c:4077 faultin_page mm/gup.c:651 [inline] __get_user_pages+0x7d4/0x1b30 mm/gup.c:854 populate_vma_page_range+0x20d/0x2a0 mm/gup.c:1230 __mm_populate+0x204/0x380 mm/gup.c:1278 mm_populate include/linux/mm.h:2383 [inline] vm_mmap_pgoff+0x213/0x230 mm/util.c:396 ksys_mmap_pgoff+0x4aa/0x630 mm/mmap.c:1615 __do_sys_mmap arch/x86/kernel/sys_x86_64.c:100 [inline] __se_sys_mmap arch/x86/kernel/sys_x86_64.c:91 [inline] __x64_sys_mmap+0xe9/0x1b0 arch/x86/kernel/sys_x86_64.c:91 do_syscall_64+0xfd/0x6a0 arch/x86/entry/common.c:296 entry_SYSCALL_64_after_hwframe+0x49/0xbe other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&mm->mmap_sem#2); lock(&rp->fetch_lock); lock(&mm->mmap_sem#2); lock(&rp->fetch_lock); *** DEADLOCK *** 1 lock held by syz-executor795/9141: #0: 0000000098497b51 (&mm->mmap_sem#2){++++}, at: __mm_populate+0x270/0x380 mm/gup.c:1258 stack backtrace: CPU: 0 PID: 9141 Comm: syz-executor795 Not tainted 5.2.0-next-20190708 #33 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x172/0x1f0 lib/dump_stack.c:113 print_circular_bug.cold+0x163/0x172 kernel/locking/lockdep.c:1617 check_noncircular+0x345/0x3e0 kernel/locking/lockdep.c:1741 check_prev_add kernel/locking/lockdep.c:2405 [inline] check_prevs_add kernel/locking/lockdep.c:2507 [inline] validate_chain kernel/locking/lockdep.c:2897 [inline] __lock_acquire+0x25a9/0x4c30 kernel/locking/lockdep.c:3880 lock_acquire+0x190/0x410 kernel/locking/lockdep.c:4413 __mutex_lock_common kernel/locking/mutex.c:926 [inline] __mutex_lock+0xf7/0x1340 kernel/locking/mutex.c:1073 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:1088 mon_bin_vma_fault+0x73/0x2d0 drivers/usb/mon/mon_bin.c:1237 __do_fault+0x111/0x540 mm/memory.c:3158 do_cow_fault mm/memory.c:3584 [inline] do_fault mm/memory.c:3687 [inline] handle_pte_fault mm/memory.c:3916 [inline] __handle_mm_fault+0xd41/0x3f20 mm/memory.c:4040 handle_mm_fault+0x1b5/0x6b0 mm/memory.c:4077 faultin_page mm/gup.c:651 [inline] __get_user_pages+0x7d4/0x1b30 mm/gup.c:854 populate_vma_page_range+0x20d/0x2a0 mm/gup.c:1230 __mm_populate+0x204/0x380 mm/gup.c:1278 mm_populate include/linux/mm.h:2383 [inline] vm_mmap_pgoff+0x213/0x230 mm/util.c:396 ksys_mmap_pgoff+0x4aa/0x630 mm/mmap.c:1615 __do_sys_mmap arch/x86/kernel/sys_x86_64.c:100 [inline] __se_sys_mmap arch/x86/kernel/sys_x86_64.c:91 [inline] __x64_sys_mmap+0xe9/0x1b0 arch/x86/kernel/sys_x86_64.c:91 do_syscall_64+0xfd/0x6a0 arch/x86/entry/common.c:296 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x4497f9 Code: e8 ec b9 02 00 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 ab d6 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007f37e61edcd8 EFLAGS: 00000246 ORIG_RAX: 0000000000000009 RAX: ffffffffffffffda RBX: 00000000006dac38 RCX: 00000000004497f9 RDX: 0000000000000002 RSI: 0000000000400000 RDI: 0000000020a05000 RBP: 00000000006dac30 R08: 0000000000000005 R09: 0000000000000000 R10: 0000000000008012 R11: 0000000000000246 R12: 00000000006dac3c R13: 00007ffcd13a161f R14: 00007f37e61ee9c0 R15: 20c49ba5e353f7cf