====================================================== WARNING: possible circular locking dependency detected 5.15.162-syzkaller #0 Not tainted ------------------------------------------------------ syz.1.557/5670 is trying to acquire lock: ffff888063d4aaa0 (&type->i_mutex_dir_key#15/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] ffff888063d4aaa0 (&type->i_mutex_dir_key#15/2){+.+.}-{3:3}, at: xattr_rmdir fs/reiserfs/xattr.c:106 [inline] ffff888063d4aaa0 (&type->i_mutex_dir_key#15/2){+.+.}-{3:3}, at: delete_one_xattr+0x102/0x2f0 fs/reiserfs/xattr.c:338 but task is already holding lock: ffff888063e37380 (&type->i_mutex_dir_key#15/3){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] ffff888063e37380 (&type->i_mutex_dir_key#15/3){+.+.}-{3:3}, at: reiserfs_for_each_xattr+0x9a4/0xb40 fs/reiserfs/xattr.c:309 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&type->i_mutex_dir_key#15/3){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667 inode_lock_nested include/linux/fs.h:824 [inline] open_xa_root fs/reiserfs/xattr.c:127 [inline] open_xa_dir+0x132/0x610 fs/reiserfs/xattr.c:152 xattr_lookup+0x24/0x280 fs/reiserfs/xattr.c:395 reiserfs_xattr_get+0xf7/0x9d0 fs/reiserfs/xattr.c:684 __vfs_getxattr+0x3e0/0x410 fs/xattr.c:401 cap_inode_need_killpriv+0x41/0x60 security/commoncap.c:301 security_inode_need_killpriv+0x5d/0x90 security/security.c:1423 dentry_needs_remove_privs fs/inode.c:1925 [inline] file_remove_privs+0x243/0x610 fs/inode.c:1966 __generic_file_write_iter+0x166/0x4f0 mm/filemap.c:3858 generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3944 call_write_iter include/linux/fs.h:2172 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0xacf/0xe50 fs/read_write.c:594 ksys_write+0x1a2/0x2c0 fs/read_write.c:647 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (&sb->s_type->i_mutex_key#34){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:789 [inline] vfs_rename+0x814/0x10f0 fs/namei.c:4797 ovl_do_rename+0x1b4/0x290 fs/overlayfs/overlayfs.h:234 ovl_create_over_whiteout fs/overlayfs/dir.c:534 [inline] ovl_create_or_link+0x1174/0x1470 fs/overlayfs/dir.c:625 ovl_create_object+0x232/0x300 fs/overlayfs/dir.c:659 vfs_mkdir+0x3b6/0x590 fs/namei.c:4065 do_mkdirat+0x260/0x520 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4103 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&type->i_mutex_dir_key#15/2){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667 inode_lock_nested include/linux/fs.h:824 [inline] xattr_rmdir fs/reiserfs/xattr.c:106 [inline] delete_one_xattr+0x102/0x2f0 fs/reiserfs/xattr.c:338 reiserfs_for_each_xattr+0x9b2/0xb40 fs/reiserfs/xattr.c:311 reiserfs_delete_xattrs+0x1b/0x80 fs/reiserfs/xattr.c:364 reiserfs_evict_inode+0x20c/0x460 fs/reiserfs/inode.c:53 evict+0x2a4/0x620 fs/inode.c:587 __dentry_kill+0x436/0x650 fs/dcache.c:582 dentry_kill+0xbb/0x290 dput+0xd8/0x1a0 fs/dcache.c:889 ovl_create_or_link+0x107d/0x1470 fs/overlayfs/dir.c:625 ovl_create_object+0x232/0x300 fs/overlayfs/dir.c:659 vfs_mkdir+0x3b6/0x590 fs/namei.c:4065 do_mkdirat+0x260/0x520 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4103 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: &type->i_mutex_dir_key#15/2 --> &sb->s_type->i_mutex_key#34 --> &type->i_mutex_dir_key#15/3 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&type->i_mutex_dir_key#15/3); lock(&sb->s_type->i_mutex_key#34); lock(&type->i_mutex_dir_key#15/3); lock(&type->i_mutex_dir_key#15/2); *** DEADLOCK *** 7 locks held by syz.1.557/5670: #0: ffff888077234460 (sb_writers#14){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377 #1: ffff888074f53be0 (&ovl_i_mutex_dir_key[depth]/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] #1: ffff888074f53be0 (&ovl_i_mutex_dir_key[depth]/1){+.+.}-{3:3}, at: filename_create+0x25c/0x530 fs/namei.c:3835 #2: ffff888079672460 (sb_writers#26){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377 #3: ffff888079672748 (&type->s_vfs_rename_key#3){+.+.}-{3:3}, at: lock_rename+0x4f/0x100 fs/namei.c:3016 #4: ffff888063d482e0 (&type->i_mutex_dir_key#15/1){+.+.}-{3:3}, at: lock_rename+0xc0/0x100 fs/namei.c:3017 #5: ffff888063ec16c0 (&type->i_mutex_dir_key#15/5){+.+.}-{3:3}, at: lock_rename+0xef/0x100 #6: ffff888063e37380 (&type->i_mutex_dir_key#15/3){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] #6: ffff888063e37380 (&type->i_mutex_dir_key#15/3){+.+.}-{3:3}, at: reiserfs_for_each_xattr+0x9a4/0xb40 fs/reiserfs/xattr.c:309 stack backtrace: CPU: 0 PID: 5670 Comm: syz.1.557 Not tainted 5.15.162-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667 inode_lock_nested include/linux/fs.h:824 [inline] xattr_rmdir fs/reiserfs/xattr.c:106 [inline] delete_one_xattr+0x102/0x2f0 fs/reiserfs/xattr.c:338 reiserfs_for_each_xattr+0x9b2/0xb40 fs/reiserfs/xattr.c:311 reiserfs_delete_xattrs+0x1b/0x80 fs/reiserfs/xattr.c:364 reiserfs_evict_inode+0x20c/0x460 fs/reiserfs/inode.c:53 evict+0x2a4/0x620 fs/inode.c:587 __dentry_kill+0x436/0x650 fs/dcache.c:582 dentry_kill+0xbb/0x290 dput+0xd8/0x1a0 fs/dcache.c:889 ovl_create_or_link+0x107d/0x1470 fs/overlayfs/dir.c:625 ovl_create_object+0x232/0x300 fs/overlayfs/dir.c:659 vfs_mkdir+0x3b6/0x590 fs/namei.c:4065 do_mkdirat+0x260/0x520 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4103 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7ff64e022bd9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ff64ca82048 EFLAGS: 00000246 ORIG_RAX: 0000000000000102 RAX: ffffffffffffffda RBX: 00007ff64e1b1038 RCX: 00007ff64e022bd9 RDX: 0000000000000000 RSI: 0000000020000100 RDI: ffffffffffffff9c RBP: 00007ff64e091e60 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000006e R14: 00007ff64e1b1038 R15: 00007ffc51501018